Skip to content

A reactive notebook for Python — run reproducible experiments, query with SQL, execute as a script, deploy as an app, and version with git. Stored as pure Python. All in a modern, AI-native editor.

refactor: type memoization helpers without any or casts (#11352)

Shahmir Varqhaed33ad0d9a76
diff --git a/frontend/src/utils/once.ts b/frontend/src/utils/once.ts
index af325626fc..d518726b00 100644
--- a/frontend/src/utils/once.ts
+++ b/frontend/src/utils/once.ts
@@ -2,36 +2,36 @@
import { arrayShallowEquals } from "./arrays";
-// oxlint-disable-next-line typescript/no-explicit-any
-export function once<T extends (...args: any[]) => any>(fn: T): T {
- let result: ReturnType<T>;
+export function once<F extends (...args: never[]) => unknown>(fn: F): F;
+export function once<Args extends unknown[], Result, This>(
+ fn: (this: This, ...args: Args) => Result,
+): (this: This, ...args: Args) => Result {
+ let result: Result;
let called = false;
- return function (
- this: ThisParameterType<T>,
- ...args: Parameters<T>
- ): ReturnType<T> {
+ return function (this: This, ...args: Args): Result {
if (!called) {
called = true;
- result = fn.apply(this, args) as ReturnType<T>;
+ result = fn.apply(this, args);
}
return result;
- } as T;
+ };
}
-// oxlint-disable-next-line typescript/no-explicit-any
-export function memoizeLastValue<T extends (...args: any[]) => any>(fn: T): T {
- let result: ReturnType<T>;
- let lastArgs: Parameters<T> | undefined;
+export function memoizeLastValue<F extends (...args: never[]) => unknown>(
+ fn: F,
+): F;
+export function memoizeLastValue<Args extends unknown[], Result, This>(
+ fn: (this: This, ...args: Args) => Result,
+): (this: This, ...args: Args) => Result {
+ let result: Result;
+ let lastArgs: Args | undefined;
let lastError: unknown;
let hasError = false;
- return function (
- this: ThisParameterType<T>,
- ...args: Parameters<T>
- ): ReturnType<T> {
+ return function (this: This, ...args: Args): Result {
if (lastArgs === undefined || !arrayShallowEquals(args, lastArgs)) {
try {
- result = fn.apply(this, args) as ReturnType<T>;
+ result = fn.apply(this, args);
hasError = false;
lastError = undefined;
} catch (error) {
@@ -45,5 +45,5 @@ export function memoizeLastValue<T extends (...args: any[]) => any>(fn: T): T {
throw lastError;
}
return result;
- } as T;
+ };
}