Skip to content

A reactive notebook for Python — run reproducible experiments, query with SQL, execute as a script, deploy as an app, and version with git. Stored as pure Python. All in a modern, AI-native editor.

Lighten shadows (#7682)

Akshay Agrawalef00ec6402bc
diff --git a/frontend/src/components/editor/chrome/wrapper/footer.tsx b/frontend/src/components/editor/chrome/wrapper/footer.tsx
index c94437e533..565bb4c541 100644
--- a/frontend/src/components/editor/chrome/wrapper/footer.tsx
+++ b/frontend/src/components/editor/chrome/wrapper/footer.tsx
@@ -44,7 +44,7 @@ export const Footer: React.FC = () => {
});
return (
- <footer className="h-10 py-2 bg-background flex items-center text-muted-foreground text-md pl-2 pr-1 border-t border-border select-none no-print text-sm shadow-[0_0_4px_1px_rgba(0,0,0,0.1)] z-50 print:hidden hide-on-fullscreen overflow-x-auto overflow-y-hidden scrollbar-thin">
+ <footer className="h-10 py-2 bg-background flex items-center text-muted-foreground text-md pl-2 pr-1 border-t border-border select-none no-print text-sm z-50 print:hidden hide-on-fullscreen overflow-x-auto overflow-y-hidden scrollbar-thin">
<IfCapability capability="terminal">
<div className="flex items-center">
<div className="flex">
diff --git a/frontend/src/components/editor/renderers/cell-array.tsx b/frontend/src/components/editor/renderers/cell-array.tsx
index 24841d27f3..33cd86aa05 100644
--- a/frontend/src/components/editor/renderers/cell-array.tsx
+++ b/frontend/src/components/editor/renderers/cell-array.tsx
@@ -256,7 +256,7 @@ const AddCellButtons: React.FC<{
const buttonClass = cn(
"mb-0 rounded-none sm:px-4 md:px-5 lg:px-8 tracking-wide no-wrap whitespace-nowrap",
- "hover:bg-accent hover:text-accent-foreground font-semibold uppercase text-xs",
+ "font-semibold opacity-70 hover:opacity-90 uppercase text-xs",
);
const renderBody = () => {
@@ -344,10 +344,10 @@ const AddCellButtons: React.FC<{
<div className="flex justify-center mt-4 pt-6 pb-32 group gap-4 w-full print:hidden">
<div
className={cn(
- "shadow-sm border border-border rounded transition-all duration-200 overflow-hidden divide-x divide-border flex",
- !isAiButtonOpen && "w-fit",
+ "border border-border rounded transition-all duration-200 overflow-hidden divide-x divide-border flex",
+ !isAiButtonOpen && "w-fit shadow-sm-solid-shade",
isAiButtonOpen &&
- "w-full max-w-4xl shadow-lg shadow-(color:--blue-3)",
+ "w-full max-w-4xl shadow-md-solid-shade shadow-(color:--blue-3)",
className,
// Always show the AI input when it's open
isAiButtonOpen && "opacity-100",
diff --git a/frontend/src/css/app/Cell.css b/frontend/src/css/app/Cell.css
index 542b42522f..1de19c109d 100644
--- a/frontend/src/css/app/Cell.css
+++ b/frontend/src/css/app/Cell.css
@@ -14,12 +14,12 @@
width: 100%;
border: 1px solid var(--gray-4);
- @apply divide-y divide-(--gray-5) shadow-sm-solid shadow-shade;
+ @apply divide-y divide-(--gray-5);
&:focus-visible {
/* focus-visible outlines the entire cell body in black, but the cell's
- * body is an irregular shape because of pseudo-elements that extend
- * its hit-box / hover area. */
+ * body is an irregular shape because of pseudo-elements that extend
+ * its hit-box / hover area. */
outline: none;
}
@@ -110,27 +110,8 @@
border-bottom-right-radius: 9px;
}
- &:hover {
- @apply shadow-md-solid shadow-shade;
- }
-
&:focus-within {
- border: 1px solid var(--gray-5);
-
- /* a sharp box shadow with a slight blur to outline the element */
- @apply shadow-lg-solid shadow-shade;
-
- /* a little bit of motion
- *
- * Note: we use left/top instead of transform because transform creates a new
- * stacking context and makes completion tooltip appear below surrounding
- * cells/outputs. See
- *
- * https://stackoverflow.com/questions/20851452/z-index-is-canceled-by-setting-transformrotate,
- * https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_Positioning/Understanding_z_index/The_stacking_context
- * */
- left: -1px;
- top: -1px;
+ @apply shadow-md-solid shadow-shade;
}
.cm {
@@ -164,12 +145,6 @@
&.disabled.has-error,
&.disabled:hover,
&.disabled.has-error:hover {
- @apply shadow-sm-solid shadow-shade;
-
- &:focus-within {
- @apply shadow-lg-solid shadow-shade;
- }
-
.output-area,
.cm-gutters,
.cm {
@@ -179,20 +154,13 @@
}
/* Error styles for Cell, less precedence than needs run */
-
- &.has-error,
+ &.has-error:not(.needs-run),
&.error-outline {
- outline: 1px solid var(--red-4);
- @apply shadow-md-solid shadow-[var(--red-8)];
- }
-
- &.has-error:hover {
- @apply shadow-lg-solid shadow-[var(--red-8)];
+ border: 1px solid var(--red-4);
}
- &.has-error:focus-within,
- &.has-error:focus-within:hover {
- @apply shadow-xl-solid shadow-[var(--red-8)];
+ &.has-error:not(.needs-run):focus-within {
+ @apply shadow-md-solid shadow-error/10;
}
&.error-outline,
@@ -205,20 +173,14 @@
&.needs-run {
/* TODO(akshayka): Can give this an outline to make more visible. */
- outline: none;
- @apply divide-stale shadow-md-solid shadow-stale;
-
- &:hover {
- @apply shadow-lg-solid shadow-stale;
- }
+ border-color: var(--stale);
+ @apply divide-stale shadow-sm-solid shadow-stale;
- &:focus-within:hover,
&:focus-within {
- @apply shadow-xl-solid shadow-stale;
+ @apply divide-stale shadow-md-solid shadow-stale;
}
&:focus-within .cm-editor {
- box-shadow: none;
border: 1px solid transparent;
}
@@ -276,17 +238,15 @@
&.borderless {
border-color: transparent;
- box-shadow: none;
& > * {
border-bottom: none;
}
/* Apply the original styles */
-
- &:hover {
+ &:hover,
+ &:focus {
border: 1px solid var(--gray-4);
- @apply shadow-sm-solid shadow-shade;
}
}
@@ -317,17 +277,14 @@
&.borderless {
border-color: transparent;
- box-shadow: none;
& > * {
border-bottom: none;
}
/* Apply the original styles */
-
&:hover {
border: 1px solid var(--gray-4);
- @apply shadow-sm-solid shadow-shade;
}
}
}
diff --git a/frontend/src/css/globals.css b/frontend/src/css/globals.css
index ed649b9470..729cd3ffbd 100644
--- a/frontend/src/css/globals.css
+++ b/frontend/src/css/globals.css
@@ -182,4 +182,10 @@
/* biome-ignore format: definition needs to be oneline or breaks variants */
--shadow-2xl-solid: 10px 12px 0px 0px var(--base-shadow-darker), 0 0px 8px 0px hsl(0deg 0% 90% / 50%);
+
+ /* Solid shadows with lighter shade color */
+ /* biome-ignore format: definition needs to be oneline or breaks variants */
+ --shadow-sm-solid-shade: 2px 2px 0px 0px var(--base-shadow), 0px 0px 2px 0px hsl(0deg 0% 50% / 20%);
+ /* biome-ignore format: definition needs to be oneline or breaks variants */
+ --shadow-md-solid-shade: 4px 4px 0px 0px var(--base-shadow), 0 0px 2px 0px hsl(0deg 0% 60% / 50%);
}