A reactive notebook for Python — run reproducible experiments, query with SQL, execute as a script, deploy as an app, and version with git. Stored as pure Python. All in a modern, AI-native editor.
Python artificial-intelligencedagdata-sciencedata-visualizationdataflowdeveloper-toolsmachine-learningnotebookspipelinepythonreactivesqlweb-app
fix: turn off auto install for micropip (#7680)
Myles Scolnickfce046d19d07
diff --git a/marimo/_pyodide/pyodide_session.py b/marimo/_pyodide/pyodide_session.pyindex a2802ed071..dc99dbbf7c 100644--- a/marimo/_pyodide/pyodide_session.py+++ b/marimo/_pyodide/pyodide_session.py@@ -35,9 +35,6 @@ from marimo._runtime.commands import (from marimo._runtime.context.kernel_context import initialize_kernel_contextfrom marimo._runtime.input_override import input_overridefrom marimo._runtime.marimo_pdb import MarimoPdb-from marimo._runtime.packages.pypi_package_manager import (- MicropipPackageManager,-)from marimo._runtime.runtime import Kernelfrom marimo._runtime.utils.set_ui_element_request_manager import (SetUIElementRequestManager,@@ -217,25 +214,10 @@ class PyodideSession:except Exception as e:LOGGER.warning("Error parsing script metadata: %s", e)- try:- import pyodide.code # type: ignore-- # Get imports from code- imports = pyodide.code.find_imports(code) # type: ignore- if not isinstance(imports, list):- return []-- # Pyodide find_imports is aggressive and grabs nested imports- # so we filter them out- module_names: set[str] = {mod.split(".")[0] for mod in imports}- # Convert module names to package names- package_manager = MicropipPackageManager()- return [- package_manager.module_to_package(mod) for mod in module_names- ]- except Exception as e:- LOGGER.warning("Error finding packages: %s", e)- return []+ # We don't return "unknown" packages from the imports, since+ # this is used downstream to pre-install packages while loading the notebook+ # without user consent.+ return []T = TypeVar("T")diff --git a/marimo/_runtime/packages/pypi_package_manager.py b/marimo/_runtime/packages/pypi_package_manager.pyindex 0f015919bb..c166131878 100644--- a/marimo/_runtime/packages/pypi_package_manager.py+++ b/marimo/_runtime/packages/pypi_package_manager.py@@ -97,7 +97,9 @@ class MicropipPackageManager(PypiPackageManager):docs_url = "https://micropip.pyodide.org/"def should_auto_install(self) -> bool:- return True+ # We don't auto-install packages with micropip without the user's consent,+ # since it can install unwanted packages.+ return Falsedef is_manager_installed(self) -> bool:return is_pyodide()diff --git a/tests/_pyodide/test_pyodide_session.py b/tests/_pyodide/test_pyodide_session.pyindex dfc0585304..1859168e22 100644--- a/tests/_pyodide/test_pyodide_session.py+++ b/tests/_pyodide/test_pyodide_session.py@@ -193,7 +193,8 @@ async def test_pyodide_session_find_packages(pyodide_session: PyodideSession,mock_pyodide: MagicMock,) -> None:- # Test finding packages in code+ # We don't use `pyodide.code.find_imports`+ # because this returns imports not in the lockfile (and potentially not trusted).code = dedent("""import numpy as np@@ -204,11 +205,8 @@ async def test_pyodide_session_find_packages()packages = pyodide_session.find_packages(code)- # sklearn gets converted to scikit-learn- assert sorted(packages) == sorted(- ["numpy", "pandas", "scikit-learn", "matplotlib"]- )- mock_pyodide.code.find_imports.assert_called_once_with(code)+ assert sorted(packages) == sorted([])+ mock_pyodide.code.find_imports.assert_not_called()async def test_pyodide_session_find_packages_with_script_metadata(diff --git a/tests/_runtime/test_manage_script_metadata.py b/tests/_runtime/test_manage_script_metadata.pyindex ba8791e8f6..c0a8798508 100644--- a/tests/_runtime/test_manage_script_metadata.py+++ b/tests/_runtime/test_manage_script_metadata.py@@ -336,38 +336,26 @@ async def test_missing_packages_hook(),}+ def reset_package_manager() -> MicropipPackageManager:+ k.packages_callbacks.package_manager = create_package_manager(+ "micropip"+ )+ package_manager = k.packages_callbacks.package_manager+ assert isinstance(package_manager, MicropipPackageManager)+ return package_manager+with (patch("marimo._runtime.runtime.broadcast_notification", mock_broadcast),patch("micropip.install", new_callable=AsyncMock),):- # Case 1: Auto-install enabledrunner = cast(cell_runner.Runner, MockRunner())- k.packages_callbacks.package_manager = create_package_manager(- "micropip"- )- package_manager = k.packages_callbacks.package_manager- assert isinstance(package_manager, MicropipPackageManager)- k.packages_callbacks.missing_packages_hook(runner)- # Should create install request- assert len(control_requests) == 1- request = control_requests[0]- assert isinstance(request, InstallPackagesCommand)- assert request.manager == package_manager.name- assert request.versions == {- "numpy": "",- "ibis-framework[duckdb]": "",- "grouped-one": "",- "grouped-two": "",- }- assert len(broadcast_messages) == 0-- # Case 2: Auto-install disabled+ # Case 1: Auto-install disabled+ package_manager = reset_package_manager()control_requests.clear()broadcast_messages.clear()- package_manager.should_auto_install = lambda: False # type: ignorek.packages_callbacks.missing_packages_hook(runner)# Should broadcast alert instead of installing@@ -383,7 +371,8 @@ async def test_missing_packages_hook(]assert alert.isolated == is_python_isolated()- # Case 3: Multiple missing modules+ # Case 2: Multiple missing modules+ package_manager = reset_package_manager()control_requests.clear()broadcast_messages.clear()k.module_registry.missing_modules = lambda: {@@ -391,43 +380,22 @@ async def test_missing_packages_hook("pandas","scipy",} # type: ignore- package_manager.should_auto_install = lambda: True # type: ignorek.packages_callbacks.missing_packages_hook(runner)# Should create install request with all missing packages- assert len(control_requests) == 1- request = control_requests[0]- assert isinstance(request, InstallPackagesCommand)- assert request.manager == package_manager.name- assert request.versions == {- "grouped-one": "",- "grouped-two": "",- "ibis-framework[duckdb]": "",- "numpy": "",- "pandas": "",- "scipy": "",- }-- # Case 4: Already attempted packages should be filtered- control_requests.clear()- broadcast_messages.clear()- package_manager.attempted_to_install = (- lambda package: package == "numpy"- ) # type: ignore- k.packages_callbacks.missing_packages_hook(runner)-- # Should only include packages not yet attempted- assert len(control_requests) == 1- request = control_requests[0]- assert isinstance(request, InstallPackagesCommand)- assert request.manager == package_manager.name- assert request.versions == {- "grouped-one": "",- "grouped-two": "",- "ibis-framework[duckdb]": "",- "pandas": "",- "scipy": "",- }+ assert len(control_requests) == 0+ assert len(broadcast_messages) == 1+ alert = broadcast_messages[0]+ assert isinstance(alert, MissingPackageAlertNotification)+ assert alert.packages == [+ "grouped-one",+ "grouped-two",+ "ibis-framework[duckdb]",+ "numpy",+ "pandas",+ "scipy",+ ]+ assert alert.isolated == is_python_isolated()def test_missing_packages_hook_pip(