A reactive notebook for Python — run reproducible experiments, query with SQL, execute as a script, deploy as an app, and version with git. Stored as pure Python. All in a modern, AI-native editor.
Python artificial-intelligencedagdata-sciencedata-visualizationdataflowdeveloper-toolsmachine-learningnotebookspipelinepythonreactivesqlweb-app
fix: do not mutate the test environment during tests (#9305)
Akshay Agrawalffd048c2a8f2
diff --git a/tests/_code_mode/test_context.py b/tests/_code_mode/test_context.pyindex c8d0a9584c..f414ab04ee 100644--- a/tests/_code_mode/test_context.py+++ b/tests/_code_mode/test_context.py@@ -753,18 +753,35 @@ class TestPackages:async def test_list_errors_after_add(self, k: Kernel) -> None:"""list() raises after add() has been called in the same batch."""with _ctx(k) as ctx:- async with ctx as nb:- nb.packages.add("pandas")- with pytest.raises(RuntimeError):- nb.packages.list()+ pm = k.packages_callbacks.package_manager+ assert pm is not None++ # Mock install: queued ops still run on context exit and would+ # otherwise invoke `uv add pandas` against the test venv.+ with patch.object(+ pm, "install", new_callable=AsyncMock, return_value=True+ ):+ async with ctx as nb:+ nb.packages.add("pandas")+ with pytest.raises(RuntimeError):+ nb.packages.list()async def test_list_errors_after_remove(self, k: Kernel) -> None:"""list() raises after remove() has been called in the same batch."""with _ctx(k) as ctx:- async with ctx as nb:- nb.packages.remove("pandas")- with pytest.raises(RuntimeError):- nb.packages.list()+ pm = k.packages_callbacks.package_manager+ assert pm is not None++ # Mock uninstall: queued ops still run on context exit and would+ # otherwise invoke `uv remove pandas` against the test venv,+ # triggering a `uv sync` that wipes every test-group package.+ with patch.object(+ pm, "uninstall", new_callable=AsyncMock, return_value=True+ ):+ async with ctx as nb:+ nb.packages.remove("pandas")+ with pytest.raises(RuntimeError):+ nb.packages.list()async def test_add_and_remove_in_same_batch(self, k: Kernel) -> None:"""add and remove can coexist in the same batch, executed in order."""diff --git a/tests/conftest.py b/tests/conftest.pyindex 9b13f522ea..ee1cc4809e 100644--- a/tests/conftest.py+++ b/tests/conftest.py@@ -86,6 +86,94 @@ def pytest_collection_modifyitems(item.add_marker(pytest.mark.skip(reason=reason))[email protected](scope="session")+def _venv_canary_path() -> Path | None:+ """Resolve an on-disk file whose existence signals the test venv is intact.++ We use `hypothesis`: it's in the `test` dependency group but not in+ `[project.dependencies]`, so if a test calls through to the real+ `UvPackageManager.install`/`uninstall` (which shells out to+ `uv add`/`uv remove` → `uv sync`), the sync resolves against+ `[project.dependencies]` only and deletes every test-group package+ from `.venv`. Watching `hypothesis/__init__.py` catches that+ mutation with a single stat call.+ """+ import importlib.util++ spec = importlib.util.find_spec("hypothesis")+ if spec is None or spec.origin is None:+ return None+ path = Path(spec.origin)+ return path if path.exists() else None++[email protected](autouse=True)+def _assert_venv_not_wiped(+ _venv_canary_path: Path | None, request: pytest.FixtureRequest+) -> Generator[None, None, None]:+ """Fail fast if a test mutates the shared test venv.++ The historical failure this guards against: an unmocked call to+ `UvPackageManager.install`/`uninstall` (e.g. via+ `ctx.packages.add`/`remove` in code-mode tests) runs+ `uv add`/`uv remove` against the project's `pyproject.toml`,+ then `uv sync` resolves only `[project.dependencies]` and deletes+ every `[dependency-groups].test` package — pytest, hypothesis,+ numpy, matplotlib, execnet, the `.venv/bin/pytest` shim — from the+ venv. Subsequent tests cascade into obscure+ `ModuleNotFoundError`/`FileNotFoundError` failures.++ Checking the canary before and after each test pinpoints the exact+ offender: see `tests/_code_mode/test_context.py::TestPackages` for+ the required mocking pattern.++ Under pytest-xdist, other workers run concurrently; the post-check+ can fire on a worker whose current test did not cause the mutation.+ We soften the post-check message in that case and recommend+ rerunning with `-p no:xdist` to identify the culprit.+ """+ import os++ under_xdist = "PYTEST_XDIST_WORKER" in os.environ++ if _venv_canary_path is None:+ # Could not establish a canary (e.g. hypothesis not installed on+ # disk); nothing to protect.+ yield+ return++ if not _venv_canary_path.exists():+ pytest.fail(+ f"Test venv was mutated before {request.node.nodeid!r}: "+ f"canary {_venv_canary_path} is missing. A previous test "+ f"invoked the real package manager (likely via "+ f"ctx.packages.add/remove without mocking pm.install/"+ f"pm.uninstall). See tests/_code_mode/test_context.py::"+ f"TestPackages for the required pattern."+ )+ yield+ if not _venv_canary_path.exists():+ if under_xdist:+ pytest.fail(+ f"Test venv was mutated during or concurrent with "+ f"{request.node.nodeid!r}: canary {_venv_canary_path} "+ f"no longer exists. Under xdist the mutator may be a "+ f"different worker's test. Rerun with `-p no:xdist` "+ f"to identify the culprit. See "+ f"tests/_code_mode/test_context.py::TestPackages for "+ f"the required mocking pattern."+ )+ else:+ pytest.fail(+ f"Test {request.node.nodeid!r} mutated the shared venv: "+ f"canary {_venv_canary_path} no longer exists. This test "+ f"(or a fixture it uses) invoked the real package manager. "+ f"Mock pm.install/pm.uninstall — see "+ f"tests/_code_mode/test_context.py::TestPackages for the "+ f"required pattern."+ )++@pytest.fixture(scope="session")def _fake_main_file(tmp_path_factory: pytest.TempPathFactory) -> Path:"""A benign empty .py file to assign as __main__.__file__ in tests.