The personal finance app for everyone
Allow transfers based on transactions in different currencies (#903)
Jakub Kottnauer3cae528dfde6
diff --git a/app/models/account/transfer.rb b/app/models/account/transfer.rbindex 9a3aeb4c..83ef7e00 100644--- a/app/models/account/transfer.rb+++ b/app/models/account/transfer.rb@@ -1,7 +1,8 @@class Account::Transfer < ApplicationRecordhas_many :transactions, dependent: :nullify- validate :transaction_count, :from_different_accounts, :net_zero_flows, :all_transactions_marked+ validate :net_zero_flows, if: :single_currency_transfer?+ validate :transaction_count, :from_different_accounts, :all_transactions_markeddef inflow_transactiontransactions.find { |t| t.inflow? }@@ -32,6 +33,10 @@ class Account::Transfer < ApplicationRecordprivate+ def single_currency_transfer?+ transactions.map(&:currency).uniq.size == 1+ end+def transaction_countunless transactions.size == 2errors.add :transactions, "must have exactly 2 transactions"diff --git a/test/models/account/transfer_test.rb b/test/models/account/transfer_test.rbindex d176dacf..7eb280d8 100644--- a/test/models/account/transfer_test.rb+++ b/test/models/account/transfer_test.rb@@ -39,11 +39,18 @@ class Account::TransferTest < ActiveSupport::TestCaseendend- test "transfer transactions must net to zero" do+ test "single-currency transfer transactions must net to zero" do@outflow.update! amount: 105assert_raises ActiveRecord::RecordInvalid doAccount::Transfer.create! transactions: [ @inflow, @outflow ]endend++ test "multi-currency transfer transactions do not have to net to zero" do+ @outflow.update! amount: 105, currency: "EUR"+ transfer = Account::Transfer.create! transactions: [ @inflow, @outflow ]++ assert transfer.valid?+ endend