The personal finance app for everyone
Only update account balance if changed (#1676)
Zach Gollwitzer43dd16e3fb06
diff --git a/app/models/account.rb b/app/models/account.rbindex 19d883ca..b23a8e15 100644--- a/app/models/account.rb+++ b/app/models/account.rb@@ -135,9 +135,11 @@ class Account < ApplicationRecordenddef update_with_sync!(attributes)+ should_update_balance = attributes[:balance] && attributes[:balance].to_d != balance+transaction doupdate!(attributes)- update_balance!(attributes[:balance]) if attributes[:balance]+ update_balance!(attributes[:balance]) if should_update_balanceendsync_laterdiff --git a/test/interfaces/accountable_resource_interface_test.rb b/test/interfaces/accountable_resource_interface_test.rbindex d44baf7e..913854a3 100644--- a/test/interfaces/accountable_resource_interface_test.rb+++ b/test/interfaces/accountable_resource_interface_test.rb@@ -61,11 +61,11 @@ module AccountableResourceInterfaceTestassert_equal "#{@account.accountable_name.humanize} account created", flash[:notice]end- test "updates account balance by creating new valuation" do+ test "updates account balance by creating new valuation if balance has changed" doassert_difference [ "Account::Entry.count", "Account::Valuation.count" ], 1 dopatch account_url(@account), params: {account: {- balance: 10000+ balance: 12000}}end@@ -81,7 +81,7 @@ module AccountableResourceInterfaceTestassert_no_difference [ "Account::Entry.count", "Account::Valuation.count" ] dopatch account_url(@account), params: {account: {- balance: 10000+ balance: 12000}}end