Skip to content

armgit / maybe

Public Imported from GitHub
0

The personal finance app for everyone

Remove retry logic from security upsert

Zach Gollwitzer5d798fe0a043
diff --git a/app/models/security/provided.rb b/app/models/security/provided.rb
index d3f59b65..351e3a3f 100644
--- a/app/models/security/provided.rb
+++ b/app/models/security/provided.rb
@@ -64,20 +64,7 @@ module Security::Provided
end
valid_prices.each_slice(100) do |batch|
- retries ||= 0
-
- begin
- Security::Price.upsert_all(batch, unique_by: %i[security_id date currency])
- rescue => e
- if retries < 3
- retries += 1
- sleep(1)
- Rails.logger.warn("Retrying upsert of #{batch.size} prices for security_id=#{id} ticker=#{ticker} retry=#{retries} error=#{e.message}")
- retry
- else
- raise e
- end
- end
+ Security::Price.upsert_all(batch, unique_by: %i[security_id date currency])
end
end