The personal finance app for everyone
Fix signage on transaction imports (#1236)
Zach Gollwitzer73d61fc99098
diff --git a/app/models/import/row.rb b/app/models/import/row.rbindex a4e7a473..8d434925 100644--- a/app/models/import/row.rb+++ b/app/models/import/row.rb@@ -24,9 +24,9 @@ class Import::Row < ApplicationRecorddef signed_amountif import.type == "TradeImport"- price.to_d * apply_signage_convention(qty.to_d)+ price.to_d * apply_trade_signage_convention(qty.to_d)else- apply_signage_convention(amount.to_d)+ apply_transaction_signage_convention(amount.to_d)endend@@ -38,10 +38,16 @@ class Import::Row < ApplicationRecordendprivate- def apply_signage_convention(value)+ # In the Maybe system, positive quantities == "inflows"+ def apply_trade_signage_convention(value)value * (import.signage_convention == "inflows_positive" ? 1 : -1)end+ # In the Maybe system, positive amounts == "outflows", so we must reverse signage+ def apply_transaction_signage_convention(value)+ value * (import.signage_convention == "inflows_positive" ? -1 : 1)+ end+def required_columnsimport.required_column_keys.each do |required_key|errors.add(required_key, "is required") if self[required_key].blank?