Skip to content

armgit / maybe

Public Imported from GitHub
0

The personal finance app for everyone

Minor improvements to categories & changelog pages (#1274)

Arsen Shkrumelyak77fc5caecf69
diff --git a/app/models/provider/github.rb b/app/models/provider/github.rb
index 3d5601de..5aa8526a 100644
--- a/app/models/provider/github.rb
+++ b/app/models/provider/github.rb
@@ -47,6 +47,8 @@ class Provider::Github
if release
{
avatar: release.author.avatar_url,
+ # this is the username, it would be nice to get the full name
+ username: release.author.login,
name: release.name,
published_at: release.published_at,
body: Octokit.markdown(release.body, mode: "gfm", context: repo)
diff --git a/app/views/categories/_badge.html.erb b/app/views/categories/_badge.html.erb
index 2c04d43e..a9752262 100644
--- a/app/views/categories/_badge.html.erb
+++ b/app/views/categories/_badge.html.erb
@@ -2,9 +2,10 @@
<% category ||= null_category %>
<div>
- <span class="flex items-center gap-1 text-sm font-medium rounded-full px-1.5 py-1 border border-alpha-black-25"
+ <span class="flex items-center gap-1 text-sm font-medium rounded-full px-1.5 py-1 border"
style="
background-color: color-mix(in srgb, <%= category.color %> 5%, white);
+ border-color: color-mix(in srgb, <%= category.color %> 30%, white);
color: <%= category.color %>;">
<%= category.name %>
</span>
diff --git a/app/views/pages/changelog.html.erb b/app/views/pages/changelog.html.erb
index 911dcdf0..99d9a9c9 100644
--- a/app/views/pages/changelog.html.erb
+++ b/app/views/pages/changelog.html.erb
@@ -12,7 +12,7 @@
<%= image_tag @release_notes[:avatar], class: "rounded-full w-full h-full object-cover" %>
</div>
<div>
- <div class="text-gray-900 font-medium text-sm"><%= @release_notes[:name] %></div>
+ <a class="text-gray-900 font-medium text-sm" href="https://github.com/<%= @release_notes[:username] %>"><%= "@#{@release_notes[:username]}" %></a>
<div class="text-gray-500 text-sm"><%= @release_notes[:published_at].strftime("%B %d, %Y") %></div>
</div>
</div>