The personal finance app for everyone
Temp fix for missing accountables on self hosted instances (#1071)
Zach Gollwitzerc0908f454ac8
diff --git a/app/models/account.rb b/app/models/account.rbindex e71390d6..0efa8542 100644--- a/app/models/account.rb+++ b/app/models/account.rb@@ -28,8 +28,6 @@ class Account < ApplicationRecorddelegated_type :accountable, types: Accountable::TYPES, dependent: :destroy- delegate :value, :series, to: :accountable-class << selfdef by_group(period: Period.all, currency: Money.default_currency.iso_code)grouped_accounts = { assets: ValueGroup.new("Assets", currency), liabilities: ValueGroup.new("Liabilities", currency) }@@ -75,6 +73,31 @@ class Account < ApplicationRecordendend+ # Start of temporary fix for #1068+ # ==========================================================================++ # TODO: Both `series` and `value` methods are a temporary fix for #1068, which appears to be a data corruption issue.+ # Every account should have an accountable no matter what, but some self hosted instances seem to have missing accountables.+ # When this is fixed, we can add this back to `delegate :value, :series, to: :accountable`+ def series(period: Period.all, currency: self.currency)+ if accountable.present?+ accountable.series(period: period, currency: currency)+ else+ TimeSeries.new([])+ end+ end++ def value+ if accountable.present?+ accountable.value+ else+ balance_money+ end+ end++ # ==========================================================================+ # End of temporary fix for #1068+def alertlatest_sync = syncs.latest[ latest_sync&.error, *latest_sync&.warnings ].compact.first