Skip to content

armgit / maybe

Public Imported from GitHub
0

The personal finance app for everyone

Fix mobile settings nav styles

Zach Gollwitzerd266b6a35e62
diff --git a/app/javascript/application.js b/app/javascript/application.js
index c107c9ac..12751637 100644
--- a/app/javascript/application.js
+++ b/app/javascript/application.js
@@ -5,11 +5,3 @@ import "controllers";
Turbo.StreamActions.redirect = function () {
Turbo.visit(this.target);
};
-
-if (typeof console !== "undefined") {
- console.debug = console.log;
- window.onerror = (msg, url, line) => {
- console.log(`Error: ${msg}\nURL: ${url}\nLine: ${line}`);
- return false;
- };
-}
diff --git a/app/views/layouts/settings.html.erb b/app/views/layouts/settings.html.erb
index e4e68784..7a6aec97 100644
--- a/app/views/layouts/settings.html.erb
+++ b/app/views/layouts/settings.html.erb
@@ -1,5 +1,5 @@
<%= render "layouts/shared/htmldoc" do %>
- <div class="md:flex h-full bg-surface">
+ <div class="flex flex-col lg:flex-row h-full bg-surface">
<div class="p-4 w-full md:w-96 shrink-0 md:h-full md:overflow-y-auto">
<%= render "settings/settings_nav" %>
</div>
diff --git a/app/views/layouts/shared/_htmldoc.html.erb b/app/views/layouts/shared/_htmldoc.html.erb
index efb89615..b36a81ce 100644
--- a/app/views/layouts/shared/_htmldoc.html.erb
+++ b/app/views/layouts/shared/_htmldoc.html.erb
@@ -5,7 +5,7 @@
<%= yield :head %>
</head>
- <body class="h-screen overflow-hidden lg:overflow-auto antialiased h-screen-safe ">
+ <body class="h-full overflow-hidden lg:overflow-auto antialiased">
<div class="fixed z-50 top-6 md:top-4 left-1/2 -translate-x-1/2 w-full md:w-80 px-4 md:px-0 mx-auto md:mx-0 md:right-auto mt-safe">
<div id="notification-tray" class="space-y-1 w-full">
<%= render_flash_notifications %>
diff --git a/app/views/settings/_settings_nav.html.erb b/app/views/settings/_settings_nav.html.erb
index d7548731..621c0882 100644
--- a/app/views/settings/_settings_nav.html.erb
+++ b/app/views/settings/_settings_nav.html.erb
@@ -1,17 +1,17 @@
<div class="space-y-4">
- <div class="flex items-center gap-2 p-1.5">
+ <div class="hidden lg:flex items-center gap-2 p-1.5">
<%= render LinkComponent.new(
text: "Back",
icon: "chevron-left",
href: previous_path,
variant: "ghost",
- class: "hidden md:inline-flex"
) %>
<%= link_to previous_path, class: "hidden md:block uppercase bg-surface-inset-hover rounded-sm px-1 py-0.5 text-xs text-secondary shadow-sm ml-1 pointer-events-none", data: { controller: "hotkey", hotkey: "Escape" } do %>
<kbd>esc</kbd>
<% end %>
</div>
+
<nav class="space-y-4 hidden md:block">
<section class="space-y-2">
<div class="flex items-center gap-2 px-3">
@@ -93,9 +93,17 @@
<% end %>
</section>
</nav>
- <nav class="space-y-4 overflow-y-auto md:hidden" id="mobile-settings-nav">
+ <nav class="space-y-4 overflow-y-auto md:hidden" id="mobile-settings-nav">
<ul class="flex space-y-1">
+ <li>
+ <%= render LinkComponent.new(
+ text: "Back",
+ icon: "chevron-left",
+ href: previous_path,
+ variant: "ghost",
+ ) %>
+ </li>
<li>
<%= render "settings/settings_nav_item", name: t(".profile_label"), path: settings_profile_path, icon: "circle-user" %>