Skip to content

armgit / maybe

Public Imported from GitHub
0

The personal finance app for everyone

New Design System + Codebase Refresh (#1823)

Zach Gollwitzerd75be2282bfe
diff --git a/.cursor/rules/project-conventions.mdc b/.cursor/rules/project-conventions.mdc
index eb139262..ddc5cdc7 100644
--- a/.cursor/rules/project-conventions.mdc
+++ b/.cursor/rules/project-conventions.mdc
@@ -43,7 +43,8 @@ This codebase adopts a "skinny controller, fat models" convention. Furthermore,
- Organize large pieces of business logic into Rails concerns and POROs (Plain ole' Ruby Objects)
- While a Rails concern _may_ offer shared functionality (i.e. "duck types"), it can also be a "one-off" concern that is only included in one place for better organization and readability.
-- When possible, models should answer questions about themselves—for example, we might have a method, `account.series` that returns a time-series of the account's most recent balances. We prefer this over something more service-like such as `AccountSeries.new(account).call`.
+- When concerns are used for code organization, they should be organized around the "traits" of a model; not for simply moving code to another spot in the codebase.
+- When possible, models should answer questions about themselves—for example, we might have a method, `account.balance_series` that returns a time-series of the account's most recent balances. We prefer this over something more service-like such as `AccountSeries.new(account).call`.
### Convention 3: Prefer server-side solutions over client-side solutions
diff --git a/app/assets/images/logomark-color.svg b/app/assets/images/logomark-color.svg
new file mode 100644
index 00000000..2c1bf71d
--- /dev/null
+++ b/app/assets/images/logomark-color.svg
@@ -0,0 +1,12 @@
+<svg xmlns="http://www.w3.org/2000/svg" width="36" height="36" viewBox="0 0 36 36" fill="none">
+ <path d="M8.39804 24.0315H4.09584C3.07641 24.0315 2.25 24.8609 2.25 25.8841C2.25 26.9072 3.07641 27.7367 4.09584 27.7367H8.39804C9.41747 27.7367 10.2439 26.9072 10.2439 25.8841C10.2439 24.8609 9.41747 24.0315 8.39804 24.0315Z" fill="#F23E94"/>
+ <path d="M27.6403 27.7359H31.9425C32.9619 27.7359 33.7883 26.9065 33.7883 25.8833C33.7883 24.8601 32.9619 24.0307 31.9425 24.0307H27.6403C26.6209 24.0307 25.7945 24.8601 25.7945 25.8833C25.7945 26.9065 26.6209 27.7359 27.6403 27.7359Z" fill="#F23E94"/>
+ <path d="M19.7588 24.0189H16.2567C15.2373 24.0189 14.4109 24.8483 14.4109 25.8715C14.4109 26.8947 15.2373 27.7241 16.2567 27.7241H19.7588C20.7783 27.7241 21.6047 26.8947 21.6047 25.8715C21.6047 24.8483 20.7783 24.0189 19.7588 24.0189Z" fill="#F23E94"/>
+ <path d="M25.9683 22.4047H30.1112C31.1306 22.4047 31.957 21.5753 31.957 20.5521C31.957 19.529 31.1306 18.6995 30.1112 18.6995H25.9683C24.9489 18.6995 24.1225 19.529 24.1225 20.5521C24.1225 21.5753 24.9489 22.4047 25.9683 22.4047Z" fill="#6927DA"/>
+ <path d="M9.99971 18.6993H5.85685C4.83742 18.6993 4.01101 19.5288 4.01101 20.5519C4.01101 21.5751 4.83742 22.4045 5.85685 22.4045H9.99971C11.0191 22.4045 11.8455 21.5751 11.8455 20.5519C11.8455 19.5288 11.0191 18.6993 9.99971 18.6993Z" fill="#6927DA"/>
+ <path d="M21.0888 18.6875H14.924C13.9045 18.6875 13.0781 19.517 13.0781 20.5401C13.0781 21.5633 13.9045 22.3927 14.924 22.3927H21.0888C22.1082 22.3927 22.9346 21.5633 22.9346 20.5401C22.9346 19.517 22.1082 18.6875 21.0888 18.6875Z" fill="#6927DA"/>
+ <path d="M15.5578 13.2072H7.69136C6.67193 13.2072 5.84552 14.0366 5.84552 15.0598C5.84552 16.0829 6.67193 16.9123 7.69136 16.9123H15.5578C16.5772 16.9123 17.4036 16.0829 17.4036 15.0598C17.4036 14.0366 16.5772 13.2072 15.5578 13.2072Z" fill="#1570EF"/>
+ <path d="M20.9094 16.9116H28.2735C29.2929 16.9116 30.1193 16.0821 30.1193 15.059C30.1193 14.0358 29.2929 13.2064 28.2735 13.2064L20.9094 13.2064C19.89 13.2064 19.0636 14.0358 19.0636 15.059C19.0636 16.0821 19.89 16.9116 20.9094 16.9116Z" fill="#1570EF"/>
+ <path d="M26.5036 7.875H22.3515C21.3321 7.875 20.5057 8.70443 20.5057 9.72759C20.5057 10.7507 21.3321 11.5802 22.3515 11.5802H26.5036C27.523 11.5802 28.3494 10.7507 28.3494 9.72759C28.3494 8.70443 27.523 7.875 26.5036 7.875Z" fill="#22CCEE"/>
+ <path d="M13.6077 7.875H9.45557C8.43614 7.875 7.60973 8.70443 7.60973 9.72759C7.60973 10.7507 8.43614 11.5802 9.45557 11.5802H13.6077C14.6271 11.5802 15.4535 10.7507 15.4535 9.72759C15.4535 8.70443 14.6271 7.875 13.6077 7.875Z" fill="#22CCEE"/>
+</svg>
\ No newline at end of file
diff --git a/app/assets/tailwind/application.css b/app/assets/tailwind/application.css
index 9153362f..ecb797a1 100644
--- a/app/assets/tailwind/application.css
+++ b/app/assets/tailwind/application.css
@@ -8,7 +8,7 @@
@plugin "@tailwindcss/typography";
@plugin "@tailwindcss/forms";
-@utility combobox {
+.combobox {
.hw-combobox__main__wrapper,
.hw-combobox__input {
@apply w-full;
@@ -40,6 +40,35 @@
--hw-handle-offset-right: 0px;
}
+/* Typography */
+.prose {
+ @apply max-w-none;
+
+ h2 {
+ @apply text-xl font-medium;
+ }
+
+ h3 {
+ @apply text-lg font-medium;
+ }
+
+ li {
+ @apply m-0;
+ }
+
+ details {
+ @apply mb-4 rounded-xl mt-3.5;
+ }
+
+ summary {
+ @apply flex items-center gap-1;
+ }
+
+ video {
+ @apply m-0 rounded-b-xl;
+ }
+}
+
.prose--github-release-notes {
.octicon {
@apply inline-block overflow-visible align-text-bottom fill-current;
diff --git a/app/assets/tailwind/maybe-design-system.css b/app/assets/tailwind/maybe-design-system.css
index eaaa1cb2..3f252db6 100644
--- a/app/assets/tailwind/maybe-design-system.css
+++ b/app/assets/tailwind/maybe-design-system.css
@@ -256,23 +256,43 @@
}
@utility bg-surface {
- @apply bg-gray-50 hover:bg-gray-100;
+ @apply bg-gray-50;
+}
+
+@utility bg-surface-hover {
+ @apply bg-gray-100;
}
@utility bg-surface-inset {
- @apply bg-gray-100 hover:bg-gray-200;
+ @apply bg-gray-100;
+}
+
+@utility bg-surface-inset-hover {
+ @apply bg-gray-200;
}
@utility bg-container {
- @apply bg-white hover:bg-gray-50;
+ @apply bg-white;
+}
+
+@utility bg-container-hover {
+ @apply bg-gray-50;
}
@utility bg-container-inset {
- @apply bg-gray-50 hover:bg-gray-100;
+ @apply bg-gray-50;
+}
+
+@utility bg-container-inset-hover {
+ @apply bg-gray-100;
}
@utility bg-inverse {
- @apply bg-gray-800 hover:bg-gray-700;
+ @apply bg-gray-800;
+}
+
+@utility bg-inverse-hover {
+ @apply bg-gray-700;
}
@utility bg-overlay {
@@ -291,7 +311,19 @@
@apply border-alpha-black-100;
}
+@utility border-subdued {
+ @apply border-alpha-black-50;
+}
+
@layer base {
+ form>button {
+ @apply cursor-pointer;
+ }
+
+ hr {
+ @apply text-gray-200;
+ }
+
details>summary::-webkit-details-marker {
@apply hidden;
}
@@ -337,7 +369,7 @@
}
.btn--ghost {
- @apply border border-transparent text-gray-900 hover:bg-gray-50;
+ @apply border border-transparent text-gray-900 hover:bg-gray-100;
}
.btn--destructive {
@@ -412,35 +444,6 @@
@apply peer-checked:bg-green-600 peer-checked:after:translate-x-4;
}
- /* Typography */
- .prose {
- @apply max-w-none;
-
- h2 {
- @apply text-xl font-medium;
- }
-
- h3 {
- @apply text-lg font-medium;
- }
-
- li {
- @apply m-0;
- }
-
- details {
- @apply mb-4 rounded-xl mt-3.5;
- }
-
- summary {
- @apply flex items-center gap-1;
- }
-
- video {
- @apply m-0 rounded-b-xl;
- }
- }
-
/* Tooltips */
.tooltip {
@apply hidden absolute;
diff --git a/app/controllers/account/holdings_controller.rb b/app/controllers/account/holdings_controller.rb
index 27ebcd9a..bfda09fb 100644
--- a/app/controllers/account/holdings_controller.rb
+++ b/app/controllers/account/holdings_controller.rb
@@ -1,6 +1,4 @@
class Account::HoldingsController < ApplicationController
- layout :with_sidebar
-
before_action :set_holding, only: %i[show destroy]
def index
diff --git a/app/controllers/accountable_sparklines_controller.rb b/app/controllers/accountable_sparklines_controller.rb
new file mode 100644
index 00000000..17892479
--- /dev/null
+++ b/app/controllers/accountable_sparklines_controller.rb
@@ -0,0 +1,25 @@
+class AccountableSparklinesController < ApplicationController
+ def show
+ @accountable = Accountable.from_type(params[:accountable_type]&.classify)
+
+ @series = Rails.cache.fetch(cache_key) do
+ family.accounts.active
+ .where(accountable_type: @accountable.name)
+ .balance_series(
+ currency: family.currency,
+ favorable_direction: @accountable.favorable_direction
+ )
+ end
+
+ render layout: false
+ end
+
+ private
+ def family
+ Current.family
+ end
+
+ def cache_key
+ family.build_cache_key("#{@accountable.name}_sparkline")
+ end
+end
diff --git a/app/controllers/accounts_controller.rb b/app/controllers/accounts_controller.rb
index 3c0d25e7..df2b4d3c 100644
--- a/app/controllers/accounts_controller.rb
+++ b/app/controllers/accounts_controller.rb
@@ -1,26 +1,11 @@
class AccountsController < ApplicationController
- layout :with_sidebar
-
- before_action :set_account, only: %i[sync]
+ before_action :set_account, only: %i[sync chart sparkline]
def index
- @manual_accounts = Current.family.accounts.manual.alphabetically
- @plaid_items = Current.family.plaid_items.ordered
- end
+ @manual_accounts = family.accounts.manual.alphabetically
+ @plaid_items = family.plaid_items.ordered
- def summary
- @period = Period.from_param(params[:period])
- snapshot = Current.family.snapshot(@period)
- @net_worth_series = snapshot[:net_worth_series]
- @asset_series = snapshot[:asset_series]
- @liability_series = snapshot[:liability_series]
- @accounts = Current.family.accounts.active
- @account_groups = @accounts.by_group(period: @period, currency: Current.family.currency)
- end
-
- def list
- @period = Period.from_param(params[:period])
- render layout: false
+ render layout: "settings"
end
def sync
@@ -32,20 +17,27 @@ class AccountsController < ApplicationController
end
def chart
- @account = Current.family.accounts.find(params[:id])
render layout: "application"
end
+ def sparkline
+ render layout: false
+ end
+
def sync_all
- unless Current.family.syncing?
- Current.family.sync_later
+ unless family.syncing?
+ family.sync_later
end
redirect_to accounts_path
end
private
+ def family
+ Current.family
+ end
+
def set_account
- @account = Current.family.accounts.find(params[:id])
+ @account = family.accounts.find(params[:id])
end
end
diff --git a/app/controllers/application_controller.rb b/app/controllers/application_controller.rb
index 7c9e98ca..2951cbfd 100644
--- a/app/controllers/application_controller.rb
+++ b/app/controllers/application_controller.rb
@@ -22,12 +22,6 @@ class ApplicationController < ActionController::Base
subscribed_at.present? && subscribed_at <= Time.current && subscribed_at > 1.hour.ago
end
- def with_sidebar
- return "turbo_rails/frame" if turbo_frame_request?
-
- "with_sidebar"
- end
-
def detect_os
user_agent = request.user_agent
@os = case user_agent
diff --git a/app/controllers/budget_categories_controller.rb b/app/controllers/budget_categories_controller.rb
index ef83da7d..dcd96262 100644
--- a/app/controllers/budget_categories_controller.rb
+++ b/app/controllers/budget_categories_controller.rb
@@ -7,7 +7,7 @@ class BudgetCategoriesController < ApplicationController
end
def show
- @recent_transactions = @budget.entries
+ @recent_transactions = @budget.transactions
if params[:id] == BudgetCategory.uncategorized.id
@budget_category = @budget.uncategorized_budget_category
@@ -42,6 +42,7 @@ class BudgetCategoriesController < ApplicationController
end
def set_budget
- @budget = Current.family.budgets.find(params[:budget_id])
+ start_date = Budget.param_to_date(params[:budget_month_year])
+ @budget = Current.family.budgets.find_by(start_date: start_date)
end
end
diff --git a/app/controllers/budgets_controller.rb b/app/controllers/budgets_controller.rb
index 4ea71169..992dec44 100644
--- a/app/controllers/budgets_controller.rb
+++ b/app/controllers/budgets_controller.rb
@@ -6,10 +6,6 @@ class BudgetsController < ApplicationController
end
def show
- @next_budget = @budget.next_budget
- @previous_budget = @budget.previous_budget
- @latest_budget = Budget.find_or_bootstrap(Current.family)
- render layout: with_sidebar
end
def edit
@@ -21,12 +17,6 @@ class BudgetsController < ApplicationController
redirect_to budget_budget_categories_path(@budget)
end
- def create
- start_date = Date.parse(budget_create_params[:start_date])
- @budget = Budget.find_or_bootstrap(Current.family, date: start_date)
- redirect_to budget_path(@budget)
- end
-
def picker
render partial: "budgets/picker", locals: {
family: Current.family,
@@ -44,12 +34,13 @@ class BudgetsController < ApplicationController
end
def set_budget
- @budget = Current.family.budgets.find(params[:id])
- @budget.sync_budget_categories
+ start_date = Budget.param_to_date(params[:month_year])
+ @budget = Budget.find_or_bootstrap(Current.family, start_date: start_date)
+ raise ActiveRecord::RecordNotFound unless @budget
end
def redirect_to_current_month_budget
- current_budget = Budget.find_or_bootstrap(Current.family)
+ current_budget = Budget.find_or_bootstrap(Current.family, start_date: Date.current)
redirect_to budget_path(current_budget)
end
end
diff --git a/app/controllers/categories_controller.rb b/app/controllers/categories_controller.rb
index a9d3d105..04ffb0e5 100644
--- a/app/controllers/categories_controller.rb
+++ b/app/controllers/categories_controller.rb
@@ -1,12 +1,12 @@
class CategoriesController < ApplicationController
- layout :with_sidebar
-
before_action :set_category, only: %i[edit update destroy]
before_action :set_categories, only: %i[update edit]
before_action :set_transaction, only: :create
def index
@categories = Current.family.categories.alphabetically
+
+ render layout: "settings"
end
def new
diff --git a/app/controllers/category/deletions_controller.rb b/app/controllers/category/deletions_controller.rb
index 57f8ee5f..e11777ab 100644
--- a/app/controllers/category/deletions_controller.rb
+++ b/app/controllers/category/deletions_controller.rb
@@ -1,6 +1,4 @@
class Category::DeletionsController < ApplicationController
- layout :with_sidebar
-
before_action :set_category
before_action :set_replacement_category, only: :create
diff --git a/app/controllers/concerns/accountable_resource.rb b/app/controllers/concerns/accountable_resource.rb
index 2a02edb4..16467e36 100644
--- a/app/controllers/concerns/accountable_resource.rb
+++ b/app/controllers/concerns/accountable_resource.rb
@@ -4,7 +4,6 @@ module AccountableResource
included do
include ScrollFocusable
- layout :with_sidebar
before_action :set_account, only: [ :show, :edit, :update, :destroy ]
before_action :set_link_token, only: :new
end
diff --git a/app/controllers/concerns/auto_sync.rb b/app/controllers/concerns/auto_sync.rb
index fa279034..d9e616e4 100644
--- a/app/controllers/concerns/auto_sync.rb
+++ b/app/controllers/concerns/auto_sync.rb
@@ -13,9 +13,7 @@ module AutoSync
def family_needs_auto_sync?
return false unless Current.family.present?
- return false unless Current.family.accounts.any?
- Current.family.last_synced_at.blank? ||
- Current.family.last_synced_at.to_date < Date.current
+ (Current.family.last_synced_at&.to_date || 1.day.ago) < Date.current
end
end
diff --git a/app/controllers/concerns/entryable_resource.rb b/app/controllers/concerns/entryable_resource.rb
index e3b7365f..58519725 100644
--- a/app/controllers/concerns/entryable_resource.rb
+++ b/app/controllers/concerns/entryable_resource.rb
@@ -2,7 +2,6 @@ module EntryableResource
extend ActiveSupport::Concern
included do
- layout :with_sidebar
before_action :set_entry, only: %i[show update destroy]
end
diff --git a/app/controllers/help/articles_controller.rb b/app/controllers/help/articles_controller.rb
deleted file mode 100644
index e5b19ff3..00000000
--- a/app/controllers/help/articles_controller.rb
+++ /dev/null
@@ -1,11 +0,0 @@
-class Help::ArticlesController < ApplicationController
- layout :with_sidebar
-
- def show
- @article = Help::Article.find(params[:id])
-
- unless @article
- head :not_found
- end
- end
-end
diff --git a/app/controllers/imports_controller.rb b/app/controllers/imports_controller.rb
index caee3328..3fb704fe 100644
--- a/app/controllers/imports_controller.rb
+++ b/app/controllers/imports_controller.rb
@@ -10,7 +10,7 @@ class ImportsController < ApplicationController
def index
@imports = Current.family.imports
- render layout: with_sidebar
+ render layout: "settings"
end
def new
diff --git a/app/controllers/merchants_controller.rb b/app/controllers/merchants_controller.rb
index 252c5de6..cbcf1cdb 100644
--- a/app/controllers/merchants_controller.rb
+++ b/app/controllers/merchants_controller.rb
@@ -1,10 +1,10 @@
class MerchantsController < ApplicationController
- layout :with_sidebar
-
before_action :set_merchant, only: %i[edit update destroy]
def index
@merchants = Current.family.merchants.alphabetically
+
+ render layout: "settings"
end
def new
diff --git a/app/controllers/mfa_controller.rb b/app/controllers/mfa_controller.rb
index f46fbb56..ec3071e5 100644
--- a/app/controllers/mfa_controller.rb
+++ b/app/controllers/mfa_controller.rb
@@ -47,7 +47,7 @@ class MfaController < ApplicationController
if action_name.in?(%w[verify verify_code])
"auth"
else
- "with_sidebar"
+ "settings"
end
end
end
diff --git a/app/controllers/onboardings_controller.rb b/app/controllers/onboardings_controller.rb
index bf1ecae2..36948f92 100644
--- a/app/controllers/onboardings_controller.rb
+++ b/app/controllers/onboardings_controller.rb
@@ -1,5 +1,4 @@
class OnboardingsController < ApplicationController
- layout "application"
before_action :set_user
before_action :load_invitation
diff --git a/app/controllers/pages_controller.rb b/app/controllers/pages_controller.rb
index e372a8d6..61d39322 100644
--- a/app/controllers/pages_controller.rb
+++ b/app/controllers/pages_controller.rb
@@ -1,40 +1,20 @@
class PagesController < ApplicationController
skip_before_action :authenticate_user!, only: %i[early_access]
- layout :with_sidebar, except: %i[early_access]
def dashboard
- @period = Period.from_param(params[:period])
- snapshot = Current.family.snapshot(@period)
- @net_worth_series = snapshot[:net_worth_series]
- @asset_series = snapshot[:asset_series]
- @liability_series = snapshot[:liability_series]
-
- snapshot_transactions = Current.family.snapshot_transactions
- @income_series = snapshot_transactions[:income_series]
- @spending_series = snapshot_transactions[:spending_series]
- @savings_rate_series = snapshot_transactions[:savings_rate_series]
-
- snapshot_account_transactions = Current.family.snapshot_account_transactions
- @top_spenders = snapshot_account_transactions[:top_spenders]
- @top_earners = snapshot_account_transactions[:top_earners]
- @top_savers = snapshot_account_transactions[:top_savers]
-
- @accounts = Current.family.accounts.active
- @account_groups = @accounts.by_group(period: @period, currency: Current.family.currency)
- @transaction_entries = Current.family.entries.incomes_and_expenses.limit(6).reverse_chronological
-
- # TODO: Placeholders for trendlines
- placeholder_series_data = 10.times.map do |i|
- { date: Date.current - i.days, value: Money.new(0, Current.family.currency) }
- end
- @investing_series = TimeSeries.new(placeholder_series_data)
+ @period = Period.from_key(params[:period], fallback: true)
+ @balance_sheet = Current.family.balance_sheet
+ @accounts = Current.family.accounts.active.with_attached_logo
end
def changelog
@release_notes = Provider::Github.new.fetch_latest_release_notes
+
+ render layout: "settings"
end
def feedback
+ render layout: "settings"
end
def early_access
diff --git a/app/controllers/settings/billings_controller.rb b/app/controllers/settings/billings_controller.rb
index 2eb6c49b..7bb8c200 100644
--- a/app/controllers/settings/billings_controller.rb
+++ b/app/controllers/settings/billings_controller.rb
@@ -1,4 +1,6 @@
-class Settings::BillingsController < SettingsController
+class Settings::BillingsController < ApplicationController
+ layout "settings"
+
def show
@user = Current.user
end
diff --git a/app/controllers/settings/hostings_controller.rb b/app/controllers/settings/hostings_controller.rb
index aae6513c..fa88d23c 100644
--- a/app/controllers/settings/hostings_controller.rb
+++ b/app/controllers/settings/hostings_controller.rb
@@ -1,4 +1,6 @@
-class Settings::HostingsController < SettingsController
+class Settings::HostingsController < ApplicationController
+ layout "settings"
+
before_action :raise_if_not_self_hosted
def show
diff --git a/app/controllers/settings/preferences_controller.rb b/app/controllers/settings/preferences_controller.rb
index 4f4fc1f8..83f9e2e4 100644
--- a/app/controllers/settings/preferences_controller.rb
+++ b/app/controllers/settings/preferences_controller.rb
@@ -1,4 +1,6 @@
-class Settings::PreferencesController < SettingsController
+class Settings::PreferencesController < ApplicationController
+ layout "settings"
+
def show
@user = Current.user
end
diff --git a/app/controllers/settings/profiles_controller.rb b/app/controllers/settings/profiles_controller.rb
index 443ba16b..d62eecd6 100644
--- a/app/controllers/settings/profiles_controller.rb
+++ b/app/controllers/settings/profiles_controller.rb
@@ -1,4 +1,6 @@
-class Settings::ProfilesController < SettingsController
+class Settings::ProfilesController < ApplicationController
+ layout "settings"
+
def show
@user = Current.user
@users = Current.family.users.order(:created_at)
diff --git a/app/controllers/settings/securities_controller.rb b/app/controllers/settings/securities_controller.rb
index 7f19d7ca..9f8eac1c 100644
--- a/app/controllers/settings/securities_controller.rb
+++ b/app/controllers/settings/securities_controller.rb
@@ -1,4 +1,6 @@
-class Settings::SecuritiesController < SettingsController
+class Settings::SecuritiesController < ApplicationController
+ layout "settings"
+
def show
end
end
diff --git a/app/controllers/settings_controller.rb b/app/controllers/settings_controller.rb
deleted file mode 100644
index e0fcac5e..00000000
--- a/app/controllers/settings_controller.rb
+++ /dev/null
@@ -1,3 +0,0 @@
-class SettingsController < ApplicationController
- layout :with_sidebar
-end
diff --git a/app/controllers/tag/deletions_controller.rb b/app/controllers/tag/deletions_controller.rb
index a5b14f7c..5ec31a3d 100644
--- a/app/controllers/tag/deletions_controller.rb
+++ b/app/controllers/tag/deletions_controller.rb
@@ -1,6 +1,4 @@
class Tag::DeletionsController < ApplicationController
- layout :with_sidebar
-
before_action :set_tag
before_action :set_replacement_tag, only: :create
diff --git a/app/controllers/tags_controller.rb b/app/controllers/tags_controller.rb
index 2b81e7cd..0794e1e7 100644
--- a/app/controllers/tags_controller.rb
+++ b/app/controllers/tags_controller.rb
@@ -1,10 +1,10 @@
class TagsController < ApplicationController
- layout :with_sidebar
-
before_action :set_tag, only: %i[edit update destroy]
def index
@tags = Current.family.tags.alphabetically
+
+ render layout: "settings"
end
def new
diff --git a/app/controllers/transactions_controller.rb b/app/controllers/transactions_controller.rb
index eb82f376..a1e254c4 100644
--- a/app/controllers/transactions_controller.rb
+++ b/app/controllers/transactions_controller.rb
@@ -1,34 +1,26 @@
class TransactionsController < ApplicationController
include ScrollFocusable
- layout :with_sidebar
-
before_action :store_params!, only: :index
def index
@q = search_params
- search_query = Current.family.transactions.search(@q).active
-
- set_focused_record(search_query, params[:focused_record_id], default_per_page: 50)
-
- @pagy, @transaction_entries = pagy(
- search_query.reverse_chronological.preload(
- :account,
- entryable: [
- :category, :merchant, :tags,
- :transfer_as_inflow,
- transfer_as_outflow: {
- inflow_transaction: { entry: :account },
- outflow_transaction: { entry: :account }
- }
- ]
- ),
+ transactions_query = Current.family.transactions.active.search(@q)
+
+ set_focused_record(transactions_query, params[:focused_record_id], default_per_page: 50)
+
+ @pagy, @transactions = pagy(
+ transactions_query.includes(
+ { entry: :account },
+ :category, :merchant, :tags,
+ transfer_as_outflow: { inflow_transaction: { entry: :account } },
+ transfer_as_inflow: { outflow_transaction: { entry: :account } }
+ ).reverse_chronological,
limit: params[:per_page].presence || default_params[:per_page],
params: ->(params) { params.except(:focused_record_id) }
)
- @transfers = @transaction_entries.map { |entry| entry.entryable.transfer_as_outflow }.compact
- @totals = search_query.stats(Current.family.currency)
+ @totals = Current.family.income_statement.totals(transactions_scope: transactions_query)
end
def clear_filter
diff --git a/app/controllers/transfers_controller.rb b/app/controllers/transfers_controller.rb
index b66054c2..a1a7e27c 100644
--- a/app/controllers/transfers_controller.rb
+++ b/app/controllers/transfers_controller.rb
@@ -1,6 +1,4 @@
class TransfersController < ApplicationController
- layout :with_sidebar
-
before_action :set_transfer, only: %i[destroy show update]
def new
diff --git a/app/controllers/users_controller.rb b/app/controllers/users_controller.rb
index 5bb4f45f..d8d0de8a 100644
--- a/app/controllers/users_controller.rb
+++ b/app/controllers/users_controller.rb
@@ -19,7 +19,10 @@ class UsersController < ApplicationController
@user.update!(user_params.except(:redirect_to, :delete_profile_image))
@user.profile_image.purge if should_purge_profile_image?
- handle_redirect(t(".success"))
+ respond_to do |format|
+ format.html { handle_redirect(t(".success")) }
+ format.json { head :ok }
+ end
end
end
@@ -57,7 +60,7 @@ class UsersController < ApplicationController
def user_params
params.require(:user).permit(
- :first_name, :last_name, :email, :profile_image, :redirect_to, :delete_profile_image, :onboarded_at,
+ :first_name, :last_name, :email, :profile_image, :redirect_to, :delete_profile_image, :onboarded_at, :show_sidebar,
family_attributes: [ :name, :currency, :country, :locale, :date_format, :timezone, :id, :data_enrichment_enabled ]
)
end
diff --git a/app/helpers/account/entries_helper.rb b/app/helpers/account/entries_helper.rb
index b3268fdd..3350a328 100644
--- a/app/helpers/account/entries_helper.rb
+++ b/app/helpers/account/entries_helper.rb
@@ -1,22 +1,13 @@
module Account::EntriesHelper
- def permitted_entryable_partial_path(entry, relative_partial_path)
- "account/entries/entryables/#{permitted_entryable_key(entry)}/#{relative_partial_path}"
- end
-
- def transfer_entries(entries)
- transfers = entries.select { |e| e.transfer_id.present? }
- transfers.map(&:transfer).uniq
- end
-
- def entries_by_date(entries, transfers: [], selectable: true, totals: false)
+ def entries_by_date(entries, totals: false)
entries.group_by(&:date).map do |date, grouped_entries|
content = capture do
- yield [ grouped_entries, transfers.select { |t| t.outflow_transaction.entry.date == date } ]
+ yield grouped_entries
end
next if content.blank?
- render partial: "account/entries/entry_group", locals: { date:, entries: grouped_entries, content:, selectable:, totals: }
+ render partial: "account/entries/entry_group", locals: { date:, entries: grouped_entries, content:, totals: }
end.compact.join.html_safe
end
@@ -28,11 +19,4 @@ module Account::EntriesHelper
entry.display_name
].join(" • ")
end
-
- private
-
- def permitted_entryable_key(entry)
- permitted_entryable_paths = %w[transaction valuation trade]
- entry.entryable_name_short.presence_in(permitted_entryable_paths)
- end
end
diff --git a/app/helpers/account/holdings_helper.rb b/app/helpers/account/holdings_helper.rb
deleted file mode 100644
index c9ed7e03..00000000
--- a/app/helpers/account/holdings_helper.rb
+++ /dev/null
@@ -1,13 +0,0 @@
-module Account::HoldingsHelper
- def brokerage_cash_holding(account)
- currency = Money::Currency.new(account.currency)
-
- account.holdings.build \
- date: Date.current,
- qty: account.cash_balance,
- price: 1,
- amount: account.cash_balance,
- currency: currency.iso_code,
- security: Security.new(ticker: currency.iso_code, name: currency.name)
- end
-end
diff --git a/app/helpers/accounts_helper.rb b/app/helpers/accounts_helper.rb
index 356798e5..eedb86c3 100644
--- a/app/helpers/accounts_helper.rb
+++ b/app/helpers/accounts_helper.rb
@@ -1,87 +1,6 @@
module AccountsHelper
- def period_label(period)
- return "since account creation" if period.date_range.begin.nil?
- start_date, end_date = period.date_range.first, period.date_range.last
-
- return "Starting from #{start_date.strftime('%b %d, %Y')}" if end_date.nil?
- return "Ending at #{end_date.strftime('%b %d, %Y')}" if start_date.nil?
-
- days_apart = (end_date - start_date).to_i
-
- # Handle specific cases
- if start_date == Date.current.beginning_of_week && end_date == Date.current
- return "Current Week to Date (CWD)"
- elsif start_date == Date.current.beginning_of_month && end_date == Date.current
- return "Current Month to Date (MTD)"
- elsif start_date == Date.current.beginning_of_quarter && end_date == Date.current
- return "Current Quarter to Date (CQD)"
- elsif start_date == Date.current.beginning_of_year && end_date == Date.current
- return "Current Year to Date (YTD)"
- end
-
- # Default cases
- case days_apart
- when 1
- "vs. yesterday"
- when 7
- "vs. last week"
- when 30, 31
- "vs. last month"
- when 90
- "vs. last 3 months"
- when 365, 366
- "vs. last year"
- else
- "from #{start_date.strftime('%b %d, %Y')} to #{end_date.strftime('%b %d, %Y')}"
- end
- end
-
def summary_card(title:, &block)
content = capture(&block)
render "accounts/summary_card", title: title, content: content
end
-
- def to_accountable_title(accountable)
- accountable.model_name.human
- end
-
- def accountable_text_class(accountable_type)
- class_mapping(accountable_type)[:text]
- end
-
- def accountable_fill_class(accountable_type)
- class_mapping(accountable_type)[:fill]
- end
-
- def accountable_bg_class(accountable_type)
- class_mapping(accountable_type)[:bg]
- end
-
- def accountable_bg_transparent_class(accountable_type)
- class_mapping(accountable_type)[:bg_transparent]
- end
-
- def accountable_color(accountable_type)
- class_mapping(accountable_type)[:hex]
- end
-
- def account_groups(period: nil)
- assets, liabilities = Current.family.accounts.active.by_group(currency: Current.family.currency, period: period || Period.last_30_days).values_at(:assets, :liabilities)
- [ assets.children.sort_by(&:name), liabilities.children.sort_by(&:name) ].flatten
- end
-
- private
-
- def class_mapping(accountable_type)
- {
- "CreditCard" => { text: "text-red-500", bg: "bg-red-500", bg_transparent: "bg-red-500/10", fill: "fill-red-500", hex: "#F13636" },
- "Loan" => { text: "text-fuchsia-500", bg: "bg-fuchsia-500", bg_transparent: "bg-fuchsia-500/10", fill: "fill-fuchsia-500", hex: "#D444F1" },
- "OtherLiability" => { text: "text-secondary", bg: "bg-gray-500", bg_transparent: "bg-gray-500/10", fill: "fill-gray-500", hex: "#737373" },
- "Depository" => { text: "text-violet-500", bg: "bg-violet-500", bg_transparent: "bg-violet-500/10", fill: "fill-violet-500", hex: "#875BF7" },
- "Investment" => { text: "text-blue-600", bg: "bg-blue-600", bg_transparent: "bg-blue-600/10", fill: "fill-blue-600", hex: "#1570EF" },
- "OtherAsset" => { text: "text-green-500", bg: "bg-green-500", bg_transparent: "bg-green-500/10", fill: "fill-green-500", hex: "#12B76A" },
- "Property" => { text: "text-cyan-500", bg: "bg-cyan-500", bg_transparent: "bg-cyan-500/10", fill: "fill-cyan-500", hex: "#06AED4" },
- "Vehicle" => { text: "text-pink-500", bg: "bg-pink-500", bg_transparent: "bg-pink-500/10", fill: "fill-pink-500", hex: "#F23E94" }
- }.fetch(accountable_type, { text: "text-secondary", bg: "bg-gray-500", bg_transparent: "bg-gray-500/10", fill: "fill-gray-500", hex: "#737373" })
- end
end
diff --git a/app/helpers/application_helper.rb b/app/helpers/application_helper.rb
index 424ed539..e8d898cc 100644
--- a/app/helpers/application_helper.rb
+++ b/app/helpers/application_helper.rb
@@ -72,18 +72,8 @@ module ApplicationHelper
render partial: "shared/disclosure", locals: { title: title, content: content, open: default_open }
end
- def sidebar_link_to(name, path, options = {})
- is_current = current_page?(path) || (request.path.start_with?(path) && path != "/")
-
- classes = [
- "flex items-center gap-2 px-3 py-2 rounded-xl border text-sm font-medium text-secondary",
- (is_current ? "bg-white text-primary shadow-xs border-alpha-black-50" : "hover:bg-gray-100 border-transparent")
- ].compact.join(" ")
-
- link_to path, **options.merge(class: classes), aria: { current: ("page" if current_page?(path)) } do
- concat(lucide_icon(options[:icon], class: "w-5 h-5")) if options[:icon]
- concat(name)
- end
+ def page_active?(path)
+ current_page?(path) || (request.path.start_with?(path) && path != "/")
end
def mixed_hex_styles(hex)
@@ -105,24 +95,6 @@ module ApplicationHelper
uri.relative? ? uri.path : root_path
end
- def trend_styles(trend)
- fallback = { bg_class: "bg-gray-500/5", text_class: "text-secondary", symbol: "", icon: "minus" }
- return fallback if trend.nil? || trend.direction.flat?
-
- bg_class, text_class, symbol, icon = case trend.direction
- when "up"
- trend.favorable_direction.down? ? [ "bg-red-500/5", "text-red-500", "+", "arrow-up" ] : [ "bg-green-500/5", "text-green-500", "+", "arrow-up" ]
- when "down"
- trend.favorable_direction.down? ? [ "bg-green-500/5", "text-green-500", "-", "arrow-down" ] : [ "bg-red-500/5", "text-red-500", "-", "arrow-down" ]
- when "flat"
- [ "bg-gray-500/5", "text-secondary", "", "minus" ]
- else
- raise ArgumentError, "Invalid trend direction: #{trend.direction}"
- end
-
- { bg_class: bg_class, text_class: text_class, symbol: symbol, icon: icon }
- end
-
# Wrapper around I18n.l to support custom date formats
def format_date(object, format = :default, options = {})
date = object.to_date
@@ -139,17 +111,7 @@ module ApplicationHelper
def format_money(number_or_money, options = {})
return nil unless number_or_money
- money = Money.new(number_or_money)
- options.reverse_merge!(money.format_options(I18n.locale))
- number_to_currency(money.amount, options)
- end
-
- def format_money_without_symbol(number_or_money, options = {})
- return nil unless number_or_money
-
- money = Money.new(number_or_money)
- options.reverse_merge!(money.format_options(I18n.locale))
- ActiveSupport::NumberHelper.number_to_delimited(money.amount.round(options[:precision] || 0), { delimiter: options[:delimiter], separator: options[:separator] })
+ Money.new(number_or_money).format(options)
end
def totals_by_currency(collection:, money_method:, separator: " | ", negate: false)
@@ -168,7 +130,6 @@ module ApplicationHelper
end
private
-
def calculate_total(item, money_method, negate)
items = item.reject { |i| i.respond_to?(:entryable) && i.entryable.transfer? }
total = items.sum(&money_method)
diff --git a/app/helpers/email_confirmations_helper.rb b/app/helpers/email_confirmations_helper.rb
deleted file mode 100644
index c5f58449..00000000
--- a/app/helpers/email_confirmations_helper.rb
+++ /dev/null
@@ -1,2 +0,0 @@
-module EmailConfirmationsHelper
-end
diff --git a/app/helpers/forms_helper.rb b/app/helpers/forms_helper.rb
index 39fa0740..22861eb0 100644
--- a/app/helpers/forms_helper.rb
+++ b/app/helpers/forms_helper.rb
@@ -18,18 +18,9 @@ module FormsHelper
end
def period_select(form:, selected:, classes: "border border-tertiary shadow-xs rounded-lg text-sm pr-7 cursor-pointer text-primary focus:outline-hidden focus:ring-0")
- periods_for_select = [
- %w[CWD current_week], # Current Week to Date
- %w[7D last_7_days],
- %w[MTD current_month], # Month to Date
- %w[1M last_30_days],
- %w[CQD current_quarter], # Quarter to Date
- %w[3M last_90_days],
- %w[YTD current_year], # Year to Date
- %w[1Y last_365_days]
- ]
-
- form.select(:period, periods_for_select, { selected: selected }, class: classes, data: { "auto-submit-form-target": "auto" })
+ periods_for_select = Period.all.map { |period| [ period.label_short, period.key ] }
+
+ form.select(:period, periods_for_select, { selected: selected.key }, class: classes, data: { "auto-submit-form-target": "auto" })
end
diff --git a/app/helpers/impersonation_sessions_helper.rb b/app/helpers/impersonation_sessions_helper.rb
deleted file mode 100644
index f955b896..00000000
--- a/app/helpers/impersonation_sessions_helper.rb
+++ /dev/null
@@ -1,2 +0,0 @@
-module ImpersonationSessionsHelper
-end
diff --git a/app/helpers/invitations_helper.rb b/app/helpers/invitations_helper.rb
deleted file mode 100644
index 1483b9ee..00000000
--- a/app/helpers/invitations_helper.rb
+++ /dev/null
@@ -1,2 +0,0 @@
-module InvitationsHelper
-end
diff --git a/app/helpers/pages_helper.rb b/app/helpers/pages_helper.rb
deleted file mode 100644
index 2c057fd0..00000000
--- a/app/helpers/pages_helper.rb
+++ /dev/null
@@ -1,2 +0,0 @@
-module PagesHelper
-end
diff --git a/app/helpers/properties_helper.rb b/app/helpers/properties_helper.rb
deleted file mode 100644
index e9841903..00000000
--- a/app/helpers/properties_helper.rb
+++ /dev/null
@@ -1,2 +0,0 @@
-module PropertiesHelper
-end
diff --git a/app/helpers/securities_helper.rb b/app/helpers/securities_helper.rb
deleted file mode 100644
index 05762cb3..00000000
--- a/app/helpers/securities_helper.rb
+++ /dev/null
@@ -1,2 +0,0 @@
-module SecuritiesHelper
-end
diff --git a/app/helpers/settings/billing_helper.rb b/app/helpers/settings/billing_helper.rb
deleted file mode 100644
index 8de033a5..00000000
--- a/app/helpers/settings/billing_helper.rb
+++ /dev/null
@@ -1,2 +0,0 @@
-module Settings::BillingHelper
-end
diff --git a/app/helpers/settings/hosting_helper.rb b/app/helpers/settings/hosting_helper.rb
deleted file mode 100644
index b92b592b..00000000
--- a/app/helpers/settings/hosting_helper.rb
+++ /dev/null
@@ -1,2 +0,0 @@
-module Settings::HostingHelper
-end
diff --git a/app/helpers/settings_helper.rb b/app/helpers/settings_helper.rb
index 66488eff..0eaecd85 100644
--- a/app/helpers/settings_helper.rb
+++ b/app/helpers/settings_helper.rb
@@ -1,17 +1,17 @@
module SettingsHelper
SETTINGS_ORDER = [
- { name: I18n.t("settings.nav.profile_label"), path: :settings_profile_path },
- { name: I18n.t("settings.nav.preferences_label"), path: :settings_preferences_path },
- { name: I18n.t("settings.nav.self_hosting_label"), path: :settings_hosting_path, condition: :self_hosted? },
- { name: I18n.t("settings.nav.security_label"), path: :settings_security_path },
- { name: I18n.t("settings.nav.billing_label"), path: :settings_billing_path },
- { name: I18n.t("settings.nav.accounts_label"), path: :accounts_path },
- { name: I18n.t("settings.nav.imports_label"), path: :imports_path },
- { name: I18n.t("settings.nav.tags_label"), path: :tags_path },
- { name: I18n.t("settings.nav.categories_label"), path: :categories_path },
- { name: I18n.t("settings.nav.merchants_label"), path: :merchants_path },
- { name: I18n.t("settings.nav.whats_new_label"), path: :changelog_path },
- { name: I18n.t("settings.nav.feedback_label"), path: :feedback_path }
+ { name: I18n.t("settings.settings_nav.profile_label"), path: :settings_profile_path },
+ { name: I18n.t("settings.settings_nav.preferences_label"), path: :settings_preferences_path },
+ { name: I18n.t("settings.settings_nav.security_label"), path: :settings_security_path },
+ { name: I18n.t("settings.settings_nav.self_hosting_label"), path: :settings_hosting_path, condition: :self_hosted? },
+ { name: I18n.t("settings.settings_nav.billing_label"), path: :settings_billing_path },
+ { name: I18n.t("settings.settings_nav.accounts_label"), path: :accounts_path },
+ { name: I18n.t("settings.settings_nav.imports_label"), path: :imports_path },
+ { name: I18n.t("settings.settings_nav.tags_label"), path: :tags_path },
+ { name: I18n.t("settings.settings_nav.categories_label"), path: :categories_path },
+ { name: I18n.t("settings.settings_nav.merchants_label"), path: :merchants_path },
+ { name: I18n.t("settings.settings_nav.whats_new_label"), path: :changelog_path },
+ { name: I18n.t("settings.settings_nav.feedback_label"), path: :feedback_path }
]
def adjacent_setting(current_path, offset)
@@ -24,7 +24,7 @@ module SettingsHelper
adjacent = visible_settings[adjacent_index]
- render partial: "settings/nav_link_large", locals: {
+ render partial: "settings/settings_nav_link_large", locals: {
path: send(adjacent[:path]),
direction: offset > 0 ? "next" : "previous",
title: adjacent[:name]
diff --git a/app/helpers/subscription_helper.rb b/app/helpers/subscription_helper.rb
deleted file mode 100644
index bac8d5a9..00000000
--- a/app/helpers/subscription_helper.rb
+++ /dev/null
@@ -1,2 +0,0 @@
-module SubscriptionHelper
-end
diff --git a/app/helpers/tags_helper.rb b/app/helpers/tags_helper.rb
deleted file mode 100644
index 4a796243..00000000
--- a/app/helpers/tags_helper.rb
+++ /dev/null
@@ -1,7 +0,0 @@
-module TagsHelper
- def null_tag
- Tag.new \
- name: "Uncategorized",
- color: Tag::UNCATEGORIZED_COLOR
- end
-end
diff --git a/app/helpers/value_groups_helper.rb b/app/helpers/value_groups_helper.rb
deleted file mode 100644
index 5362ed0c..00000000
--- a/app/helpers/value_groups_helper.rb
+++ /dev/null
@@ -1,13 +0,0 @@
-module ValueGroupsHelper
- def value_group_pie_data(value_group)
- value_group.children.filter { |c| c.sum > 0 }.map do |child|
- {
- label: to_accountable_title(Accountable.from_type(child.name)),
- percent_of_total: child.percent_of_total.round(1).to_f,
- formatted_value: format_money(child.sum, precision: 0),
- bg_color: accountable_bg_class(child.name),
- fill_color: accountable_fill_class(child.name)
- }
- end.to_json
- end
-end
diff --git a/app/helpers/vehicles_helper.rb b/app/helpers/vehicles_helper.rb
deleted file mode 100644
index f8e7abd9..00000000
--- a/app/helpers/vehicles_helper.rb
+++ /dev/null
@@ -1,2 +0,0 @@
-module VehiclesHelper
-end
diff --git a/app/helpers/webhooks_helper.rb b/app/helpers/webhooks_helper.rb
deleted file mode 100644
index 3fa66567..00000000
--- a/app/helpers/webhooks_helper.rb
+++ /dev/null
@@ -1,2 +0,0 @@
-module WebhooksHelper
-end
diff --git a/app/javascript/controllers/bulk_select_controller.js b/app/javascript/controllers/bulk_select_controller.js
index 22b0a59a..a1e40157 100644
--- a/app/javascript/controllers/bulk_select_controller.js
+++ b/app/javascript/controllers/bulk_select_controller.js
@@ -146,7 +146,9 @@ export default class extends Controller {
_updateGroups() {
this.groupTargets.forEach((group) => {
- const rows = this.rowTargets.filter((row) => group.contains(row));
+ const rows = this.rowTargets.filter(
+ (row) => group.contains(row) && !row.disabled,
+ );
const groupSelected =
rows.length > 0 &&
rows.every((row) => this.selectedIdsValue.includes(row.dataset.id));
diff --git a/app/javascript/controllers/pie_chart_controller.js b/app/javascript/controllers/pie_chart_controller.js
deleted file mode 100644
index 96cdc56f..00000000
--- a/app/javascript/controllers/pie_chart_controller.js
+++ /dev/null
@@ -1,154 +0,0 @@
-import { Controller } from "@hotwired/stimulus";
-import * as d3 from "d3";
-
-// Connects to data-controller="pie-chart"
-export default class extends Controller {
- static values = {
- data: Array,
- total: String,
- label: String,
- };
-
- #d3SvgMemo = null;
- #d3GroupMemo = null;
- #d3ContentMemo = null;
- #d3ViewboxWidth = 200;
- #d3ViewboxHeight = 200;
-
- connect() {
- this.#draw();
- document.addEventListener("turbo:load", this.#redraw);
- }
-
- disconnect() {
- this.#teardown();
- document.removeEventListener("turbo:load", this.#redraw);
- }
-
- #redraw = () => {
- this.#teardown();
- this.#draw();
- };
-
- #teardown() {
- this.#d3SvgMemo = null;
- this.#d3GroupMemo = null;
- this.#d3ContentMemo = null;
- this.#d3Container.selectAll("*").remove();
- }
-
- #draw() {
- this.#d3Container.attr("class", "relative");
- this.#d3Content.html(this.#contentSummaryTemplate());
-
- const pie = d3
- .pie()
- .value((d) => d.percent_of_total)
- .padAngle(0.06);
-
- const arc = d3
- .arc()
- .innerRadius(this.#radius - 8)
- .outerRadius(this.#radius)
- .cornerRadius(2);
-
- const arcs = this.#d3Group
- .selectAll("arc")
- .data(pie(this.dataValue))
- .enter()
- .append("g")
- .attr("class", "arc");
-
- const paths = arcs
- .append("path")
- .attr("class", (d) => d.data.fill_color)
- .attr("d", arc);
-
- paths
- .on("mouseover", (event) => {
- this.#d3Svg.selectAll(".arc path").attr("class", "fill-gray-200");
- d3.select(event.target).attr("class", (d) => d.data.fill_color);
- this.#d3ContentMemo.html(
- this.#contentDetailTemplate(d3.select(event.target).datum().data),
- );
- })
- .on("mouseout", () => {
- this.#d3Svg
- .selectAll(".arc path")
- .attr("class", (d) => d.data.fill_color);
- this.#d3ContentMemo.html(this.#contentSummaryTemplate());
- });
- }
-
- #contentSummaryTemplate() {
- return `<span class="text-xl text-gray-900 font-medium">${this.totalValue}</span> <span class="text-xs">${this.labelValue}</span>`;
- }
-
- #contentDetailTemplate(datum) {
- return `
- <span class="text-xl text-gray-900 font-medium">${datum.formatted_value}</span>
- <div class="flex flex-row text-xs gap-2 items-center">
- <div class="w-[10px] h-[10px] rounded-full ${datum.bg_color}"></div>
- <span>${datum.label}</span>
- <span>${datum.percent_of_total}%</span>
- </div>
- `;
- }
-
- get #radius() {
- return Math.min(this.#d3ViewboxWidth, this.#d3ViewboxHeight) / 2;
- }
-
- get #d3Container() {
- return d3.select(this.element);
- }
-
- get #d3Svg() {
- if (!this.#d3SvgMemo) {
- this.#d3SvgMemo = this.#createMainSvg();
- }
- return this.#d3SvgMemo;
- }
-
- get #d3Group() {
- if (!this.#d3GroupMemo) {
- this.#d3GroupMemo = this.#createMainGroup();
- }
-
- return this.#d3GroupMemo;
- }
-
- get #d3Content() {
- if (!this.#d3ContentMemo) {
- this.#d3ContentMemo = this.#createContent();
- }
- return this.#d3ContentMemo;
- }
-
- #createMainSvg() {
- return this.#d3Container
- .append("svg")
- .attr("width", "100%")
- .attr("class", "relative aspect-1")
- .attr("viewBox", [0, 0, this.#d3ViewboxWidth, this.#d3ViewboxHeight]);
- }
-
- #createMainGroup() {
- return this.#d3Svg
- .append("g")
- .attr(
- "transform",
- `translate(${this.#d3ViewboxWidth / 2},${this.#d3ViewboxHeight / 2})`,
- );
- }
-
- #createContent() {
- this.#d3ContentMemo = this.#d3Container
- .append("div")
- .attr(
- "class",
- "absolute inset-0 w-full text-center flex flex-col items-center justify-center",
- );
- return this.#d3ContentMemo;
- }
-}
diff --git a/app/javascript/controllers/sidebar_controller.js b/app/javascript/controllers/sidebar_controller.js
new file mode 100644
index 00000000..7ed40418
--- /dev/null
+++ b/app/javascript/controllers/sidebar_controller.js
@@ -0,0 +1,28 @@
+import { Controller } from "@hotwired/stimulus";
+
+// Connects to data-controller="sidebar"
+export default class extends Controller {
+ static values = { userId: String };
+ static targets = ["panel", "content"];
+
+ toggle() {
+ this.panelTarget.classList.toggle("w-0");
+ this.panelTarget.classList.toggle("opacity-0");
+ this.panelTarget.classList.toggle("w-[260px]");
+ this.panelTarget.classList.toggle("opacity-100");
+ this.contentTarget.classList.toggle("max-w-4xl");
+ this.contentTarget.classList.toggle("max-w-5xl");
+
+ fetch(`/users/${this.userIdValue}`, {
+ method: "PATCH",
+ headers: {
+ "Content-Type": "application/x-www-form-urlencoded",
+ "X-CSRF-Token": document.querySelector('[name="csrf-token"]').content,
+ Accept: "application/json",
+ },
+ body: new URLSearchParams({
+ "user[show_sidebar]": !this.panelTarget.classList.contains("w-0"),
+ }).toString(),
+ });
+ }
+}
diff --git a/app/javascript/controllers/tabs_controller.js b/app/javascript/controllers/tabs_controller.js
index 7fb3e0c5..1e1cd614 100644
--- a/app/javascript/controllers/tabs_controller.js
+++ b/app/javascript/controllers/tabs_controller.js
@@ -2,12 +2,16 @@ import { Controller } from "@hotwired/stimulus";
// Connects to data-controller="tabs"
export default class extends Controller {
- static classes = ["active"];
+ static classes = ["active", "inactive"];
static targets = ["btn", "tab"];
- static values = { defaultTab: String };
+ static values = { defaultTab: String, localStorageKey: String };
connect() {
- this.updateClasses(this.defaultTabValue);
+ const selectedTab = this.hasLocalStorageKeyValue
+ ? this.getStoredTab() || this.defaultTabValue
+ : this.defaultTabValue;
+
+ this.updateClasses(selectedTab);
document.addEventListener("turbo:load", this.onTurboLoad);
}
@@ -18,23 +22,46 @@ export default class extends Controller {
select(event) {
const element = event.target.closest("[data-id]");
if (element) {
- this.updateClasses(element.dataset.id);
+ const selectedId = element.dataset.id;
+ this.updateClasses(selectedId);
+ if (this.hasLocalStorageKeyValue) {
+ this.storeTab(selectedId);
+ }
}
}
onTurboLoad = () => {
- this.updateClasses(this.defaultTabValue);
+ const selectedTab = this.hasLocalStorageKeyValue
+ ? this.getStoredTab() || this.defaultTabValue
+ : this.defaultTabValue;
+
+ this.updateClasses(selectedTab);
};
+ getStoredTab() {
+ const tabs = JSON.parse(localStorage.getItem("tabs") || "{}");
+ return tabs[this.localStorageKeyValue];
+ }
+
+ storeTab(selectedId) {
+ const tabs = JSON.parse(localStorage.getItem("tabs") || "{}");
+ tabs[this.localStorageKeyValue] = selectedId;
+ localStorage.setItem("tabs", JSON.stringify(tabs));
+ }
+
updateClasses = (selectedId) => {
- this.btnTargets.forEach((btn) =>
- btn.classList.remove(...this.activeClasses),
- );
+ this.btnTargets.forEach((btn) => {
+ btn.classList.remove(...this.activeClasses);
+ btn.classList.remove(...this.inactiveClasses);
+ });
+
this.tabTargets.forEach((tab) => tab.classList.add("hidden"));
this.btnTargets.forEach((btn) => {
if (btn.dataset.id === selectedId) {
btn.classList.add(...this.activeClasses);
+ } else {
+ btn.classList.add(...this.inactiveClasses);
}
});
diff --git a/app/javascript/controllers/time_series_chart_controller.js b/app/javascript/controllers/time_series_chart_controller.js
index 4ae37bfa..d3cc05cc 100644
--- a/app/javascript/controllers/time_series_chart_controller.js
+++ b/app/javascript/controllers/time_series_chart_controller.js
@@ -7,7 +7,6 @@ export default class extends Controller {
strokeWidth: { type: Number, default: 2 },
useLabels: { type: Boolean, default: true },
useTooltip: { type: Boolean, default: true },
- usePercentSign: Boolean,
};
_d3SvgMemo = null;
@@ -16,15 +15,18 @@ export default class extends Controller {
_d3InitialContainerWidth = 0;
_d3InitialContainerHeight = 0;
_normalDataPoints = [];
+ _resizeObserver = null;
connect() {
this._install();
document.addEventListener("turbo:load", this._reinstall);
+ this._setupResizeObserver();
}
disconnect() {
this._teardown();
document.removeEventListener("turbo:load", this._reinstall);
+ this._resizeObserver?.disconnect();
}
_reinstall = () => {
@@ -49,10 +51,9 @@ export default class extends Controller {
_normalizeDataPoints() {
this._normalDataPoints = (this.dataValue.values || []).map((d) => ({
- ...d,
date: new Date(`${d.date}T00:00:00Z`),
- value: d.value.amount ? +d.value.amount : +d.value,
- currency: d.value.currency,
+ date_formatted: d.date_formatted,
+ trend: d.trend,
}));
}
@@ -138,13 +139,13 @@ export default class extends Controller {
.append("stop")
.attr("class", "start-color")
.attr("offset", "0%")
- .attr("stop-color", this._trendColor);
+ .attr("stop-color", this.dataValue.trend.color);
gradient
.append("stop")
.attr("class", "middle-color")
.attr("offset", "100%")
- .attr("stop-color", this._trendColor);
+ .attr("stop-color", this.dataValue.trend.color);
gradient
.append("stop")
@@ -182,7 +183,7 @@ export default class extends Controller {
this._normalDataPoints[this._normalDataPoints.length - 1].date,
])
.tickSize(0)
- .tickFormat(d3.utcFormat("%d %b %Y")),
+ .tickFormat(d3.utcFormat("%b %d, %Y")),
)
.select(".domain")
.remove();
@@ -212,7 +213,7 @@ export default class extends Controller {
.attr("x2", 0)
.attr(
"y1",
- this._d3YScale(d3.max(this._normalDataPoints, (d) => d.value)),
+ this._d3YScale(d3.max(this._normalDataPoints, this._getDatumValue)),
)
.attr("y2", this._d3ContainerHeight);
@@ -240,7 +241,7 @@ export default class extends Controller {
.area()
.x((d) => this._d3XScale(d.date))
.y0(this._d3ContainerHeight)
- .y1((d) => this._d3YScale(d.value)),
+ .y1((d) => this._d3YScale(this._getDatumValue(d))),
);
// Apply the gradient + clip path
@@ -320,7 +321,7 @@ export default class extends Controller {
.append("circle")
.attr("class", "data-point-circle")
.attr("cx", this._d3XScale(d.date))
- .attr("cy", this._d3YScale(d.value))
+ .attr("cy", this._d3YScale(this._getDatumValue(d)))
.attr("r", 8)
.attr("fill", this._trendColor)
.attr("fill-opacity", "0.1")
@@ -331,7 +332,7 @@ export default class extends Controller {
.append("circle")
.attr("class", "data-point-circle")
.attr("cx", this._d3XScale(d.date))
- .attr("cy", this._d3YScale(d.value))
+ .attr("cy", this._d3YScale(this._getDatumValue(d)))
.attr("r", 3)
.attr("fill", this._trendColor)
.attr("pointer-events", "none");
@@ -361,7 +362,7 @@ export default class extends Controller {
_tooltipTemplate(datum) {
return `
<div style="margin-bottom: 4px; color: var(--color-gray-500);">
- ${d3.utcFormat("%b %d, %Y")(datum.date)}
+ ${datum.date_formatted}
</div>
<div style="display: flex; align-items: center; gap: 16px;">
@@ -371,24 +372,20 @@ export default class extends Controller {
cx="5"
cy="5"
r="4"
- stroke="${this._tooltipTrendColor(datum)}"
+ stroke="${datum.trend.color}"
fill="transparent"
stroke-width="1"></circle>
</svg>
- ${this._tooltipValue(datum)}${this.usePercentSignValue ? "%" : ""}
+ ${this._extractFormattedValue(datum.trend.current)}
</div>
${
- this.usePercentSignValue ||
- datum.trend.value === 0 ||
- datum.trend.value.amount === 0
- ? `
- <span style="width: 80px;"></span>
- `
+ datum.trend.value === 0
+ ? `<span style="width: 80px;"></span>`
: `
- <span style="color: ${this._tooltipTrendColor(datum)};">
- ${this._tooltipChange(datum)} (${datum.trend.percent}%)
+ <span style="color: ${datum.trend.color};">
+ ${this._extractFormattedValue(datum.trend.value)} (${datum.trend.percent_formatted})
</span>
`
}
@@ -396,55 +393,23 @@ export default class extends Controller {
`;
}
- _tooltipTrendColor(datum) {
- return {
- up:
- datum.trend.favorable_direction === "up"
- ? "var(--color-success)"
- : "var(--color-destructive)",
- down:
- datum.trend.favorable_direction === "down"
- ? "var(--color-success)"
- : "var(--color-destructive)",
- flat: "var(--color-gray-500)",
- }[datum.trend.direction];
- }
+ _getDatumValue = (datum) => {
+ return this._extractNumericValue(datum.trend.current);
+ };
- _tooltipValue(datum) {
- if (datum.currency) {
- return this._currencyValue(datum);
+ _extractNumericValue = (numeric) => {
+ if (typeof numeric === "object" && "amount" in numeric) {
+ return Number(numeric.amount);
}
- return datum.value;
- }
+ return Number(numeric);
+ };
- _tooltipChange(datum) {
- if (datum.currency) {
- return this._currencyChange(datum);
+ _extractFormattedValue = (numeric) => {
+ if (typeof numeric === "object" && "formatted" in numeric) {
+ return numeric.formatted;
}
- return this._decimalChange(datum);
- }
-
- _currencyValue(datum) {
- return Intl.NumberFormat(undefined, {
- style: "currency",
- currency: datum.currency,
- }).format(datum.value);
- }
-
- _currencyChange(datum) {
- return Intl.NumberFormat(undefined, {
- style: "currency",
- currency: datum.currency,
- signDisplay: "always",
- }).format(datum.trend.value.amount);
- }
-
- _decimalChange(datum) {
- return Intl.NumberFormat(undefined, {
- style: "decimal",
- signDisplay: "always",
- }).format(datum.trend.value);
- }
+ return numeric;
+ };
_createMainSvg() {
return this._d3Container
@@ -503,28 +468,14 @@ export default class extends Controller {
}
get _trendColor() {
- if (this._trendDirection === "flat") {
- return "var(--color-gray-500)";
- }
- if (this._trendDirection === this._favorableDirection) {
- return "var(--color-green-500)";
- }
- return "var(--color-destructive)";
- }
-
- get _trendDirection() {
- return this.dataValue.trend.direction;
- }
-
- get _favorableDirection() {
- return this.dataValue.trend.favorable_direction;
+ return this.dataValue.trend.color;
}
get _d3Line() {
return d3
.line()
.x((d) => this._d3XScale(d.date))
- .y((d) => this._d3YScale(d.value));
+ .y((d) => this._d3YScale(this._getDatumValue(d)));
}
get _d3XScale() {
@@ -536,8 +487,8 @@ export default class extends Controller {
get _d3YScale() {
const reductionPercent = this.useLabelsValue ? 0.3 : 0.05;
- const dataMin = d3.min(this._normalDataPoints, (d) => d.value);
- const dataMax = d3.max(this._normalDataPoints, (d) => d.value);
+ const dataMin = d3.min(this._normalDataPoints, this._getDatumValue);
+ const dataMax = d3.max(this._normalDataPoints, this._getDatumValue);
const padding = (dataMax - dataMin) * reductionPercent;
return d3
@@ -545,4 +496,11 @@ export default class extends Controller {
.rangeRound([this._d3ContainerHeight, 0])
.domain([dataMin - padding, dataMax + padding]);
}
+
+ _setupResizeObserver() {
+ this._resizeObserver = new ResizeObserver(() => {
+ this._reinstall();
+ });
+ this._resizeObserver.observe(this.element);
+ }
}
diff --git a/app/models/account.rb b/app/models/account.rb
index 7b86a88e..75752077 100644
--- a/app/models/account.rb
+++ b/app/models/account.rb
@@ -1,5 +1,5 @@
class Account < ApplicationRecord
- include Syncable, Monetizable, Issuable
+ include Syncable, Monetizable, Issuable, Chartable
validates :name, :balance, :currency, presence: true
@@ -20,7 +20,7 @@ class Account < ApplicationRecord
enum :classification, { asset: "asset", liability: "liability" }, validate: { allow_nil: true }
- scope :active, -> { where(is_active: true, scheduled_for_deletion: false) }
+ scope :active, -> { where(is_active: true) }
scope :assets, -> { where(classification: "asset") }
scope :liabilities, -> { where(classification: "liability") }
scope :alphabetically, -> { order(:name) }
@@ -32,34 +32,7 @@ class Account < ApplicationRecord
accepts_nested_attributes_for :accountable, update_only: true
- def institution_domain
- return nil unless plaid_account&.plaid_item&.institution_url.present?
- URI.parse(plaid_account.plaid_item.institution_url).host.gsub(/^www\./, "")
- end
-
class << self
- def by_group(period: Period.all, currency: Money.default_currency.iso_code)
- grouped_accounts = { assets: ValueGroup.new("Assets", currency), liabilities: ValueGroup.new("Liabilities", currency) }
-
- Accountable.by_classification.each do |classification, types|
- types.each do |type|
- accounts = self.where(accountable_type: type)
- if accounts.any?
- group = grouped_accounts[classification.to_sym].add_child_group(type, currency)
- accounts.each do |account|
- group.add_value_node(
- account,
- account.balance_money.exchange_to(currency, fallback_rate: 0),
- account.series(period: period, currency: currency)
- )
- end
- end
- end
- end
-
- grouped_accounts
- end
-
def create_and_sync(attributes)
attributes[:accountable_attributes] ||= {} # Ensure accountable is created, even if empty
account = new(attributes.merge(cash_balance: attributes[:balance]))
@@ -89,8 +62,13 @@ class Account < ApplicationRecord
end
end
+ def institution_domain
+ return nil unless plaid_account&.plaid_item&.institution_url.present?
+ URI.parse(plaid_account.plaid_item.institution_url).host.gsub(/^www\./, "")
+ end
+
def destroy_later
- update!(scheduled_for_deletion: true)
+ update!(scheduled_for_deletion: true, is_active: false)
DestroyJob.perform_later(self)
end
@@ -106,18 +84,6 @@ class Account < ApplicationRecord
accountable.post_sync
end
- def series(period: Period.last_30_days, currency: nil)
- balance_series = balances.in_period(period).where(currency: currency || self.currency)
-
- if balance_series.empty? && period.date_range.end == Date.current
- TimeSeries.new([ { date: Date.current, value: balance_money.exchange_to(currency || self.currency) } ])
- else
- TimeSeries.from_collection(balance_series, :balance_money, favorable_direction: asset? ? "up" : "down")
- end
- rescue Money::ConversionError
- TimeSeries.new([])
- end
-
def original_balance
balance_amount = balances.chronological.first&.balance || balance
Money.new(balance_amount, currency)
@@ -127,10 +93,6 @@ class Account < ApplicationRecord
holdings.where(currency: currency, date: holdings.maximum(:date)).order(amount: :desc)
end
- def favorable_direction
- classification == "asset" ? "up" : "down"
- end
-
def enrich_data
DataEnricher.new(self).run
end
@@ -161,63 +123,11 @@ class Account < ApplicationRecord
end
end
- def transfer_match_candidates
- Account::Entry.select([
- "inflow_candidates.entryable_id as inflow_transaction_id",
- "outflow_candidates.entryable_id as outflow_transaction_id",
- "ABS(inflow_candidates.date - outflow_candidates.date) as date_diff"
- ]).from("account_entries inflow_candidates")
- .joins("
- JOIN account_entries outflow_candidates ON (
- inflow_candidates.amount < 0 AND
- outflow_candidates.amount > 0 AND
- inflow_candidates.amount = -outflow_candidates.amount AND
- inflow_candidates.currency = outflow_candidates.currency AND
- inflow_candidates.account_id <> outflow_candidates.account_id AND
- inflow_candidates.date BETWEEN outflow_candidates.date - 4 AND outflow_candidates.date + 4
- )
- ").joins("
- LEFT JOIN transfers existing_transfers ON (
- existing_transfers.inflow_transaction_id = inflow_candidates.entryable_id OR
- existing_transfers.outflow_transaction_id = outflow_candidates.entryable_id
- )
- ")
- .joins("LEFT JOIN rejected_transfers ON (
- rejected_transfers.inflow_transaction_id = inflow_candidates.entryable_id AND
- rejected_transfers.outflow_transaction_id = outflow_candidates.entryable_id
- )")
- .joins("JOIN accounts inflow_accounts ON inflow_accounts.id = inflow_candidates.account_id")
- .joins("JOIN accounts outflow_accounts ON outflow_accounts.id = outflow_candidates.account_id")
- .where("inflow_accounts.family_id = ? AND outflow_accounts.family_id = ?", self.family_id, self.family_id)
- .where("inflow_accounts.is_active = true AND inflow_accounts.scheduled_for_deletion = false")
- .where("outflow_accounts.is_active = true AND outflow_accounts.scheduled_for_deletion = false")
- .where("inflow_candidates.entryable_type = 'Account::Transaction' AND outflow_candidates.entryable_type = 'Account::Transaction'")
- .where(existing_transfers: { id: nil })
- .order("date_diff ASC") # Closest matches first
- end
+ def sparkline_series
+ cache_key = family.build_cache_key("#{id}_sparkline")
- def auto_match_transfers!
- # Exclude already matched transfers
- candidates_scope = transfer_match_candidates.where(rejected_transfers: { id: nil })
-
- # Track which transactions we've already matched to avoid duplicates
- used_transaction_ids = Set.new
-
- candidates = []
-
- Transfer.transaction do
- candidates_scope.each do |match|
- next if used_transaction_ids.include?(match.inflow_transaction_id) ||
- used_transaction_ids.include?(match.outflow_transaction_id)
-
- Transfer.create!(
- inflow_transaction_id: match.inflow_transaction_id,
- outflow_transaction_id: match.outflow_transaction_id,
- )
-
- used_transaction_ids << match.inflow_transaction_id
- used_transaction_ids << match.outflow_transaction_id
- end
+ Rails.cache.fetch(cache_key) do
+ balance_series
end
end
end
diff --git a/app/models/account/balance.rb b/app/models/account/balance.rb
index cd361269..5d4e3710 100644
--- a/app/models/account/balance.rb
+++ b/app/models/account/balance.rb
@@ -4,6 +4,6 @@ class Account::Balance < ApplicationRecord
belongs_to :account
validates :account, :date, :balance, presence: true
monetize :balance
- scope :in_period, ->(period) { period.date_range.nil? ? all : where(date: period.date_range) }
+ scope :in_period, ->(period) { period.nil? ? all : where(date: period.date_range) }
scope :chronological, -> { order(:date) }
end
diff --git a/app/models/account/balance_trend_calculator.rb b/app/models/account/balance_trend_calculator.rb
index a2e89e1d..a9bfeb30 100644
--- a/app/models/account/balance_trend_calculator.rb
+++ b/app/models/account/balance_trend_calculator.rb
@@ -80,7 +80,7 @@ class Account::BalanceTrendCalculator
return BalanceTrend.new(trend: nil) unless intraday_balance.present?
BalanceTrend.new(
- trend: TimeSeries::Trend.new(
+ trend: Trend.new(
current: Money.new(intraday_balance, entry.currency),
previous: Money.new(prior_balance, entry.currency),
favorable_direction: entry.account.favorable_direction
diff --git a/app/models/account/chartable.rb b/app/models/account/chartable.rb
new file mode 100644
index 00000000..aba8415c
--- /dev/null
+++ b/app/models/account/chartable.rb
@@ -0,0 +1,102 @@
+module Account::Chartable
+ extend ActiveSupport::Concern
+
+ class_methods do
+ def balance_series(currency:, period: Period.last_30_days, favorable_direction: "up")
+ balances = Account::Balance.find_by_sql([
+ balance_series_query,
+ {
+ start_date: period.start_date,
+ end_date: period.end_date,
+ interval: period.interval,
+ target_currency: currency
+ }
+ ])
+
+ balances = gapfill_balances(balances)
+
+ values = [ nil, *balances ].each_cons(2).map do |prev, curr|
+ Series::Value.new(
+ date: curr.date,
+ date_formatted: I18n.l(curr.date, format: :long),
+ trend: Trend.new(
+ current: Money.new(curr.balance, currency),
+ previous: prev.nil? ? nil : Money.new(prev.balance, currency),
+ favorable_direction: favorable_direction
+ )
+ )
+ end
+
+ Series.new(
+ start_date: period.start_date,
+ end_date: period.end_date,
+ interval: period.interval,
+ trend: Trend.new(
+ current: Money.new(balances.last&.balance || 0, currency),
+ previous: Money.new(balances.first&.balance || 0, currency),
+ favorable_direction: favorable_direction
+ ),
+ values: values
+ )
+ end
+
+ private
+ def balance_series_query
+ <<~SQL
+ WITH dates as (
+ SELECT generate_series(DATE :start_date, DATE :end_date, :interval::interval)::date as date
+ UNION DISTINCT
+ SELECT CURRENT_DATE -- Ensures we always end on current date, regardless of interval
+ )
+ SELECT
+ d.date,
+ SUM(CASE WHEN accounts.classification = 'asset' THEN ab.balance ELSE -ab.balance END * COALESCE(er.rate, 1)) as balance,
+ COUNT(CASE WHEN accounts.currency <> :target_currency AND er.rate IS NULL THEN 1 END) as missing_rates
+ FROM dates d
+ LEFT JOIN accounts ON accounts.id IN (#{all.select(:id).to_sql})
+ LEFT JOIN account_balances ab ON (
+ ab.date = d.date AND
+ ab.currency = accounts.currency AND
+ ab.account_id = accounts.id
+ )
+ LEFT JOIN exchange_rates er ON (
+ er.date = ab.date AND
+ er.from_currency = accounts.currency AND
+ er.to_currency = :target_currency
+ )
+ GROUP BY d.date
+ ORDER BY d.date
+ SQL
+ end
+
+ def gapfill_balances(balances)
+ gapfilled = []
+
+ prev_balance = nil
+
+ [ nil, *balances ].each_cons(2).each_with_index do |(prev, curr), index|
+ if index == 0 && curr.balance.nil?
+ curr.balance = 0 # Ensure all series start with a non-nil balance
+ elsif curr.balance.nil?
+ curr.balance = prev.balance
+ end
+
+ gapfilled << curr
+ end
+
+ gapfilled
+ end
+ end
+
+ def favorable_direction
+ classification == "asset" ? "up" : "down"
+ end
+
+ def balance_series(period: Period.last_30_days)
+ self.class.where(id: self.id).balance_series(
+ currency: currency,
+ period: period,
+ favorable_direction: favorable_direction
+ )
+ end
+end
diff --git a/app/models/account/entry.rb b/app/models/account/entry.rb
index 8ec0175b..b53db19b 100644
--- a/app/models/account/entry.rb
+++ b/app/models/account/entry.rb
@@ -1,8 +1,6 @@
class Account::Entry < ApplicationRecord
include Monetizable
- Stats = Struct.new(:currency, :count, :income_total, :expense_total, keyword_init: true)
-
monetize :amount
belongs_to :account
@@ -16,6 +14,10 @@ class Account::Entry < ApplicationRecord
validates :date, uniqueness: { scope: [ :account_id, :entryable_type ] }, if: -> { account_valuation? }
validates :date, comparison: { greater_than: -> { min_supported_date } }
+ scope :active, -> {
+ joins(:account).where(accounts: { is_active: true })
+ }
+
scope :chronological, -> {
order(
date: :asc,
@@ -24,10 +26,6 @@ class Account::Entry < ApplicationRecord
)
}
- scope :active, -> {
- joins(:account).where(accounts: { is_active: true, scheduled_for_deletion: false })
- }
-
scope :reverse_chronological, -> {
order(
date: :desc,
@@ -36,35 +34,6 @@ class Account::Entry < ApplicationRecord
)
}
- # All non-transfer entries, rejected transfers, and the outflow of a loan payment transfer are incomes/expenses
- scope :incomes_and_expenses, -> {
- joins("INNER JOIN account_transactions ON account_transactions.id = account_entries.entryable_id AND account_entries.entryable_type = 'Account::Transaction'")
- .joins("LEFT JOIN transfers ON transfers.inflow_transaction_id = account_transactions.id OR transfers.outflow_transaction_id = account_transactions.id")
- .joins("LEFT JOIN account_transactions inflow_txns ON inflow_txns.id = transfers.inflow_transaction_id")
- .joins("LEFT JOIN account_entries inflow_entries ON inflow_entries.entryable_id = inflow_txns.id AND inflow_entries.entryable_type = 'Account::Transaction'")
- .joins("LEFT JOIN accounts inflow_accounts ON inflow_accounts.id = inflow_entries.account_id")
- .where("transfers.id IS NULL OR transfers.status = 'rejected' OR (account_entries.amount > 0 AND inflow_accounts.accountable_type = 'Loan')")
- }
-
- scope :incomes, -> {
- incomes_and_expenses.where("account_entries.amount <= 0")
- }
-
- scope :expenses, -> {
- incomes_and_expenses.where("account_entries.amount > 0")
- }
-
- scope :with_converted_amount, ->(currency) {
- # Join with exchange rates to convert the amount to the given currency
- # If no rate is available, exclude the transaction from the results
- select(
- "account_entries.*",
- "account_entries.amount * COALESCE(er.rate, 1) AS converted_amount"
- )
- .joins(sanitize_sql_array([ "LEFT JOIN exchange_rates er ON account_entries.date = er.date AND account_entries.currency = er.from_currency AND er.to_currency = ?", currency ]))
- .where("er.rate IS NOT NULL OR account_entries.currency = ?", currency)
- }
-
def sync_account_later
sync_start_date = [ date_previously_was, date ].compact.min unless destroyed?
account.sync_later(start_date: sync_start_date)
@@ -82,23 +51,6 @@ class Account::Entry < ApplicationRecord
enriched_name.presence || name
end
- def transfer_match_candidates
- candidates_scope = account.transfer_match_candidates
-
- candidates_scope = if amount.negative?
- candidates_scope.where("inflow_candidates.entryable_id = ?", entryable_id)
- else
- candidates_scope.where("outflow_candidates.entryable_id = ?", entryable_id)
- end
-
- candidates_scope.map do |pm|
- Transfer.new(
- inflow_transaction_id: pm.inflow_transaction_id,
- outflow_transaction_id: pm.outflow_transaction_id,
- )
- end
- end
-
class << self
def search(params)
Account::EntrySearch.new(params).build_query(all)
@@ -109,35 +61,6 @@ class Account::Entry < ApplicationRecord
30.years.ago.to_date
end
- def daily_totals(entries, currency, period: Period.last_30_days)
- # Sum spending and income for each day in the period with the given currency
- select(
- "gs.date",
- "COALESCE(SUM(converted_amount) FILTER (WHERE converted_amount > 0), 0) AS spending",
- "COALESCE(SUM(-converted_amount) FILTER (WHERE converted_amount < 0), 0) AS income"
- )
- .from(entries.with_converted_amount(currency), :e)
- .joins(sanitize_sql([ "RIGHT JOIN generate_series(?, ?, interval '1 day') AS gs(date) ON e.date = gs.date", period.date_range.first, period.date_range.last ]))
- .group("gs.date")
- end
-
- def daily_rolling_totals(entries, currency, period: Period.last_30_days)
- # Extend the period to include the rolling window
- period_with_rolling = period.extend_backward(period.date_range.count.days)
-
- # Aggregate the rolling sum of spending and income based on daily totals
- rolling_totals = from(daily_totals(entries, currency, period: period_with_rolling))
- .select(
- "*",
- sanitize_sql_array([ "SUM(spending) OVER (ORDER BY date RANGE BETWEEN INTERVAL ? PRECEDING AND CURRENT ROW) as rolling_spend", "#{period.date_range.count} days" ]),
- sanitize_sql_array([ "SUM(income) OVER (ORDER BY date RANGE BETWEEN INTERVAL ? PRECEDING AND CURRENT ROW) as rolling_income", "#{period.date_range.count} days" ])
- )
- .order(:date)
-
- # Trim the results to the original period
- select("*").from(rolling_totals).where("date >= ?", period.date_range.first)
- end
-
def bulk_update!(bulk_update_params)
bulk_attributes = {
date: bulk_update_params[:date],
@@ -159,25 +82,5 @@ class Account::Entry < ApplicationRecord
all.size
end
-
- def stats(currency = "USD")
- result = all
- .incomes_and_expenses
- .joins(sanitize_sql_array([ "LEFT JOIN exchange_rates er ON account_entries.date = er.date AND account_entries.currency = er.from_currency AND er.to_currency = ?", currency ]))
- .select(
- "COUNT(*) AS count",
- "SUM(CASE WHEN account_entries.amount < 0 THEN (account_entries.amount * COALESCE(er.rate, 1)) ELSE 0 END) AS income_total",
- "SUM(CASE WHEN account_entries.amount > 0 THEN (account_entries.amount * COALESCE(er.rate, 1)) ELSE 0 END) AS expense_total"
- )
- .to_a
- .first
-
- Stats.new(
- currency: currency,
- count: result.count,
- income_total: result.income_total ? result.income_total * -1 : 0,
- expense_total: result.expense_total || 0
- )
- end
end
end
diff --git a/app/models/account/entry_search.rb b/app/models/account/entry_search.rb
index 962cb5c0..b6617037 100644
--- a/app/models/account/entry_search.rb
+++ b/app/models/account/entry_search.rb
@@ -12,29 +12,44 @@ class Account::EntrySearch
attribute :end_date, :string
class << self
- def from_entryable_search(entryable_search)
- new(entryable_search.attributes.slice(*attribute_names))
+ def apply_search_filter(scope, search)
+ return scope if search.blank?
+
+ query = scope
+ query = query.where("account_entries.name ILIKE :search OR account_entries.enriched_name ILIKE :search",
+ search: "%#{ActiveRecord::Base.sanitize_sql_like(search)}%"
+ )
+ query
end
- end
- def build_query(scope)
- query = scope
+ def apply_date_filters(scope, start_date, end_date)
+ return scope if start_date.blank? && end_date.blank?
- query = query.where("account_entries.name ILIKE :search OR account_entries.enriched_name ILIKE :search",
- search: "%#{ActiveRecord::Base.sanitize_sql_like(search)}%"
- ) if search.present?
- query = query.where("account_entries.date >= ?", start_date) if start_date.present?
- query = query.where("account_entries.date <= ?", end_date) if end_date.present?
+ query = scope
+ query = query.where("account_entries.date >= ?", start_date) if start_date.present?
+ query = query.where("account_entries.date <= ?", end_date) if end_date.present?
+ query
+ end
+
+ def apply_type_filter(scope, types)
+ return scope if types.blank?
+
+ query = scope
- if types.present?
if types.include?("income") && !types.include?("expense")
query = query.where("account_entries.amount < 0")
elsif types.include?("expense") && !types.include?("income")
query = query.where("account_entries.amount >= 0")
end
+
+ query
end
- if amount.present? && amount_operator.present?
+ def apply_amount_filter(scope, amount, amount_operator)
+ return scope if amount.blank? || amount_operator.blank?
+
+ query = scope
+
case amount_operator
when "equal"
query = query.where("ABS(ABS(account_entries.amount) - ?) <= 0.01", amount.to_f.abs)
@@ -43,15 +58,27 @@ class Account::EntrySearch
when "greater"
query = query.where("ABS(account_entries.amount) > ?", amount.to_f.abs)
end
- end
- if accounts.present? || account_ids.present?
- query = query.joins(:account)
+ query
end
- query = query.where(accounts: { name: accounts }) if accounts.present?
- query = query.where(accounts: { id: account_ids }) if account_ids.present?
+ def apply_accounts_filter(scope, accounts, account_ids)
+ return scope if accounts.blank? && account_ids.blank?
+ query = scope
+ query = query.where(accounts: { name: accounts }) if accounts.present?
+ query = query.where(accounts: { id: account_ids }) if account_ids.present?
+ query
+ end
+ end
+
+ def build_query(scope)
+ query = scope.joins(:account)
+ query = self.class.apply_search_filter(query, search)
+ query = self.class.apply_date_filters(query, start_date, end_date)
+ query = self.class.apply_type_filter(query, types)
+ query = self.class.apply_amount_filter(query, amount, amount_operator)
+ query = self.class.apply_accounts_filter(query, accounts, account_ids)
query
end
end
diff --git a/app/models/account/entryable.rb b/app/models/account/entryable.rb
index 79a47849..91df5521 100644
--- a/app/models/account/entryable.rb
+++ b/app/models/account/entryable.rb
@@ -9,5 +9,21 @@ module Account::Entryable
included do
has_one :entry, as: :entryable, touch: true
+
+ scope :with_entry, -> { joins(:entry) }
+
+ scope :active, -> { with_entry.merge(Account::Entry.active) }
+
+ scope :in_period, ->(period) {
+ with_entry.where(account_entries: { date: period.start_date..period.end_date })
+ }
+
+ scope :reverse_chronological, -> {
+ with_entry.merge(Account::Entry.reverse_chronological)
+ }
+
+ scope :chronological, -> {
+ with_entry.merge(Account::Entry.chronological)
+ }
end
end
diff --git a/app/models/account/holding.rb b/app/models/account/holding.rb
index 3b6ce472..eb6e35ef 100644
--- a/app/models/account/holding.rb
+++ b/app/models/account/holding.rb
@@ -53,13 +53,12 @@ class Account::Holding < ApplicationRecord
end
private
-
def calculate_trend
return nil unless amount_money
start_amount = qty * avg_cost
- TimeSeries::Trend.new \
+ Trend.new \
current: amount_money,
previous: start_amount
end
diff --git a/app/models/account/syncer.rb b/app/models/account/syncer.rb
index e8bf7a40..8aeb0ba0 100644
--- a/app/models/account/syncer.rb
+++ b/app/models/account/syncer.rb
@@ -5,7 +5,7 @@ class Account::Syncer
end
def run
- account.auto_match_transfers!
+ account.family.auto_match_transfers!
holdings = sync_holdings
balances = sync_balances(holdings)
diff --git a/app/models/account/trade.rb b/app/models/account/trade.rb
index 7d4976ba..a683b2ca 100644
--- a/app/models/account/trade.rb
+++ b/app/models/account/trade.rb
@@ -16,6 +16,6 @@ class Account::Trade < ApplicationRecord
current_value = current_price * qty.abs
cost_basis = price_money * qty.abs
- TimeSeries::Trend.new(current: current_value, previous: cost_basis)
+ Trend.new(current: current_value, previous: cost_basis)
end
end
diff --git a/app/models/account/transaction.rb b/app/models/account/transaction.rb
index a3a91bf9..a500ef74 100644
--- a/app/models/account/transaction.rb
+++ b/app/models/account/transaction.rb
@@ -1,33 +1,17 @@
class Account::Transaction < ApplicationRecord
- include Account::Entryable
+ include Account::Entryable, Transferable
belongs_to :category, optional: true
belongs_to :merchant, optional: true
+
has_many :taggings, as: :taggable, dependent: :destroy
has_many :tags, through: :taggings
- has_one :transfer_as_inflow, class_name: "Transfer", foreign_key: "inflow_transaction_id", dependent: :destroy
- has_one :transfer_as_outflow, class_name: "Transfer", foreign_key: "outflow_transaction_id", dependent: :destroy
-
- # We keep track of rejected transfers to avoid auto-matching them again
- has_one :rejected_transfer_as_inflow, class_name: "RejectedTransfer", foreign_key: "inflow_transaction_id", dependent: :destroy
- has_one :rejected_transfer_as_outflow, class_name: "RejectedTransfer", foreign_key: "outflow_transaction_id", dependent: :destroy
-
accepts_nested_attributes_for :taggings, allow_destroy: true
- scope :active, -> { where(excluded: false) }
-
class << self
def search(params)
Account::TransactionSearch.new(params).build_query(all)
end
end
-
- def transfer
- transfer_as_inflow || transfer_as_outflow
- end
-
- def transfer?
- transfer.present?
- end
end
diff --git a/app/models/account/transaction/transferable.rb b/app/models/account/transaction/transferable.rb
new file mode 100644
index 00000000..de0b70cb
--- /dev/null
+++ b/app/models/account/transaction/transferable.rb
@@ -0,0 +1,40 @@
+module Account::Transaction::Transferable
+ extend ActiveSupport::Concern
+
+ included do
+ has_one :transfer_as_inflow, class_name: "Transfer", foreign_key: "inflow_transaction_id", dependent: :destroy
+ has_one :transfer_as_outflow, class_name: "Transfer", foreign_key: "outflow_transaction_id", dependent: :destroy
+
+ # We keep track of rejected transfers to avoid auto-matching them again
+ has_one :rejected_transfer_as_inflow, class_name: "RejectedTransfer", foreign_key: "inflow_transaction_id", dependent: :destroy
+ has_one :rejected_transfer_as_outflow, class_name: "RejectedTransfer", foreign_key: "outflow_transaction_id", dependent: :destroy
+ end
+
+ def transfer
+ transfer_as_inflow || transfer_as_outflow
+ end
+
+ def transfer?
+ transfer.present?
+ end
+
+ def transfer_match_candidates
+ candidates_scope = if self.entry.amount.negative?
+ family_matches_scope.where("inflow_candidates.entryable_id = ?", self.id)
+ else
+ family_matches_scope.where("outflow_candidates.entryable_id = ?", self.id)
+ end
+
+ candidates_scope.map do |match|
+ Transfer.new(
+ inflow_transaction_id: match.inflow_transaction_id,
+ outflow_transaction_id: match.outflow_transaction_id,
+ )
+ end
+ end
+
+ private
+ def family_matches_scope
+ self.entry.account.family.transfer_match_candidates
+ end
+end
diff --git a/app/models/account/transaction_search.rb b/app/models/account/transaction_search.rb
index 12884302..3cf927e8 100644
--- a/app/models/account/transaction_search.rb
+++ b/app/models/account/transaction_search.rb
@@ -16,7 +16,7 @@ class Account::TransactionSearch
# Returns array of Account::Entry objects to stay consistent with partials, which only deal with Account::Entry
def build_query(scope)
- query = scope
+ query = scope.joins(entry: :account)
if types.present? && types.exclude?("transfer")
query = query.joins("LEFT JOIN transfers ON transfers.inflow_transaction_id = account_entries.id OR transfers.outflow_transaction_id = account_entries.id")
@@ -40,8 +40,13 @@ class Account::TransactionSearch
query = query.joins(:tags).where(tags: { name: tags }) if tags.present?
- entries_scope = Account::Entry.account_transactions.where(entryable_id: query.select(:id))
+ # Apply common entry search filters
+ query = Account::EntrySearch.apply_search_filter(query, search)
+ query = Account::EntrySearch.apply_date_filters(query, start_date, end_date)
+ query = Account::EntrySearch.apply_type_filter(query, types)
+ query = Account::EntrySearch.apply_amount_filter(query, amount, amount_operator)
+ query = Account::EntrySearch.apply_accounts_filter(query, accounts, account_ids)
- Account::EntrySearch.from_entryable_search(self).build_query(entries_scope)
+ query
end
end
diff --git a/app/models/balance_sheet.rb b/app/models/balance_sheet.rb
new file mode 100644
index 00000000..f6b07f16
--- /dev/null
+++ b/app/models/balance_sheet.rb
@@ -0,0 +1,95 @@
+class BalanceSheet
+ include Monetizable
+
+ monetize :total_assets, :total_liabilities, :net_worth
+
+ attr_reader :family
+
+ def initialize(family)
+ @family = family
+ end
+
+ def total_assets
+ totals_query.filter { |t| t.classification == "asset" }.sum(&:converted_balance)
+ end
+
+ def total_liabilities
+ totals_query.filter { |t| t.classification == "liability" }.sum(&:converted_balance)
+ end
+
+ def net_worth
+ total_assets - total_liabilities
+ end
+
+ def classification_groups
+ [
+ ClassificationGroup.new(
+ key: "asset",
+ display_name: "Assets",
+ icon: "blocks",
+ account_groups: account_groups("asset")
+ ),
+ ClassificationGroup.new(
+ key: "liability",
+ display_name: "Debts",
+ icon: "scale",
+ account_groups: account_groups("liability")
+ )
+ ]
+ end
+
+ def account_groups(classification = nil)
+ classification_accounts = classification ? totals_query.filter { |t| t.classification == classification } : totals_query
+ classification_total = classification_accounts.sum(&:converted_balance)
+ account_groups = classification_accounts.group_by(&:accountable_type).transform_keys { |k| Accountable.from_type(k) }
+
+ account_groups.map do |accountable, accounts|
+ group_total = accounts.sum(&:converted_balance)
+
+ AccountGroup.new(
+ key: accountable.model_name.param_key,
+ name: accountable.display_name,
+ classification: accountable.classification,
+ total: group_total,
+ total_money: Money.new(group_total, currency),
+ weight: classification_total.zero? ? 0 : group_total / classification_total.to_d * 100,
+ missing_rates?: accounts.any? { |a| a.missing_rates? },
+ color: accountable.color,
+ accounts: accounts.map do |account|
+ account.define_singleton_method(:weight) do
+ classification_total.zero? ? 0 : account.converted_balance / classification_total.to_d * 100
+ end
+ account
+ end.sort_by(&:weight).reverse
+ )
+ end.sort_by(&:weight).reverse
+ end
+
+ def net_worth_series(period: Period.last_30_days)
+ active_accounts.balance_series(currency: currency, period: period, favorable_direction: "up")
+ end
+
+ def currency
+ family.currency
+ end
+
+ private
+ ClassificationGroup = Struct.new(:key, :display_name, :icon, :account_groups, keyword_init: true)
+ AccountGroup = Struct.new(:key, :name, :accountable_type, :classification, :total, :total_money, :weight, :accounts, :color, :missing_rates?, keyword_init: true)
+
+ def active_accounts
+ family.accounts.active.with_attached_logo
+ end
+
+ def totals_query
+ @totals_query ||= active_accounts
+ .joins(ActiveRecord::Base.sanitize_sql_array([ "LEFT JOIN exchange_rates ON exchange_rates.date = CURRENT_DATE AND accounts.currency = exchange_rates.from_currency AND exchange_rates.to_currency = ?", currency ]))
+ .select(
+ "accounts.*",
+ "SUM(accounts.balance * COALESCE(exchange_rates.rate, 1)) as converted_balance",
+ ActiveRecord::Base.sanitize_sql_array([ "COUNT(CASE WHEN accounts.currency <> ? AND exchange_rates.rate IS NULL THEN 1 END) as missing_rates", currency ])
+ )
+ .group(:classification, :accountable_type, :id)
+ .to_a
+ end
+end
diff --git a/app/models/budget.rb b/app/models/budget.rb
index 134258ca..0dfb16e8 100644
--- a/app/models/budget.rb
+++ b/app/models/budget.rb
@@ -1,9 +1,11 @@
class Budget < ApplicationRecord
include Monetizable
+ PARAM_DATE_FORMAT = "%b-%Y"
+
belongs_to :family
- has_many :budget_categories, dependent: :destroy
+ has_many :budget_categories, -> { includes(:category) }, dependent: :destroy
validates :start_date, :end_date, presence: true
validates :start_date, :end_date, uniqueness: { scope: :family_id }
@@ -13,16 +15,28 @@ class Budget < ApplicationRecord
:estimated_spending, :estimated_income, :actual_income, :remaining_expected_income
class << self
- def for_date(date)
- find_by(start_date: date.beginning_of_month, end_date: date.end_of_month)
+ def date_to_param(date)
+ date.strftime(PARAM_DATE_FORMAT).downcase
+ end
+
+ def param_to_date(param)
+ Date.strptime(param, PARAM_DATE_FORMAT).beginning_of_month
+ end
+
+ def budget_date_valid?(date, family:)
+ beginning_of_month = date.beginning_of_month
+
+ beginning_of_month >= oldest_valid_budget_date(family) && beginning_of_month <= Date.current.end_of_month
end
- def find_or_bootstrap(family, date: Date.current)
+ def find_or_bootstrap(family, start_date:)
+ return nil unless budget_date_valid?(start_date, family: family)
+
Budget.transaction do
budget = Budget.find_or_create_by!(
family: family,
- start_date: date.beginning_of_month,
- end_date: date.end_of_month
+ start_date: start_date.beginning_of_month,
+ end_date: start_date.end_of_month
) do |b|
b.currency = family.currency
end
@@ -32,17 +46,38 @@ class Budget < ApplicationRecord
budget
end
end
+
+ private
+ def oldest_valid_budget_date(family)
+ @oldest_valid_budget_date ||= family.oldest_entry_date.beginning_of_month
+ end
+ end
+
+ def period
+ Period.new(start_date: start_date, end_date: end_date)
+ end
+
+ def to_param
+ self.class.date_to_param(start_date)
end
def sync_budget_categories
- family.categories.expenses.each do |category|
- budget_categories.find_or_create_by(
- category: category,
- ) do |bc|
- bc.budgeted_spending = 0
- bc.currency = family.currency
- end
+ current_category_ids = family.categories.expenses.pluck(:id).to_set
+ existing_budget_category_ids = budget_categories.pluck(:category_id).to_set
+ categories_to_add = current_category_ids - existing_budget_category_ids
+ categories_to_remove = existing_budget_category_ids - current_category_ids
+
+ # Create missing categories
+ categories_to_add.each do |category_id|
+ budget_categories.create!(
+ category_id: category_id,
+ budgeted_spending: 0,
+ currency: family.currency
+ )
end
+
+ # Remove old categories
+ budget_categories.where(category_id: categories_to_remove).destroy_all if categories_to_remove.any?
end
def uncategorized_budget_category
@@ -52,8 +87,8 @@ class Budget < ApplicationRecord
end
end
- def entries
- family.entries.incomes_and_expenses.where(date: start_date..end_date)
+ def transactions
+ family.transactions.active.in_period(period)
end
def name
@@ -64,28 +99,32 @@ class Budget < ApplicationRecord
budgeted_spending.present?
end
- def income_categories_with_totals
- family.income_categories_with_totals(date: start_date)
+ def income_category_totals
+ income_totals.category_totals.reject { |ct| ct.category.subcategory? }.sort_by(&:weight).reverse
end
- def expense_categories_with_totals
- family.expense_categories_with_totals(date: start_date)
+ def expense_category_totals
+ expense_totals.category_totals.reject { |ct| ct.category.subcategory? }.sort_by(&:weight).reverse
end
def current?
start_date == Date.today.beginning_of_month && end_date == Date.today.end_of_month
end
- def previous_budget
- prev_month_end_date = end_date - 1.month
- return nil if prev_month_end_date < family.oldest_entry_date
- family.budgets.find_or_bootstrap(family, date: prev_month_end_date)
+ def previous_budget_param
+ previous_date = start_date - 1.month
+ return nil unless self.class.budget_date_valid?(previous_date, family: family)
+
+ self.class.date_to_param(previous_date)
end
- def next_budget
+ def next_budget_param
return nil if current?
- next_start_date = start_date + 1.month
- family.budgets.find_or_bootstrap(family, date: next_start_date)
+
+ next_date = start_date + 1.month
+ return nil unless self.class.budget_date_valid?(next_date, family: family)
+
+ self.class.date_to_param(next_date)
end
def to_donut_segments_json
@@ -94,8 +133,8 @@ class Budget < ApplicationRecord
# Continuous gray segment for empty budgets
return [ { color: "#F0F0F0", amount: 1, id: unused_segment_id } ] unless allocations_valid?
- segments = budget_categories.includes(:category).map do |bc|
- { color: bc.category.color, amount: bc.actual_spending, id: bc.id }
+ segments = budget_categories.map do |bc|
+ { color: bc.category.color, amount: budget_category_actual_spending(bc), id: bc.id }
end
if available_to_spend.positive?
@@ -109,11 +148,23 @@ class Budget < ApplicationRecord
# Actuals: How much user has spent on each budget category
# =============================================================================
def estimated_spending
- family.budgeting_stats.avg_monthly_expenses&.abs
+ income_statement.median_expense(interval: "month")
end
def actual_spending
- expense_categories_with_totals.total_money.amount
+ expense_totals.total
+ end
+
+ def budget_category_actual_spending(budget_category)
+ expense_totals.category_totals.find { |ct| ct.category.id == budget_category.category.id }&.total || 0
+ end
+
+ def category_median_monthly_expense(category)
+ income_statement.median_expense(category: category)
+ end
+
+ def category_avg_monthly_expense(category)
+ income_statement.avg_expense(category: category)
end
def available_to_spend
@@ -157,11 +208,11 @@ class Budget < ApplicationRecord
# Income: How much user earned relative to what they expected to earn
# =============================================================================
def estimated_income
- family.budgeting_stats.avg_monthly_income&.abs
+ family.income_statement.median_income(interval: "month")
end
def actual_income
- family.entries.incomes.where(date: start_date..end_date).sum(:amount).abs
+ family.income_statement.income_totals(period: self.period).total
end
def actual_income_percent
@@ -179,4 +230,17 @@ class Budget < ApplicationRecord
remaining_expected_income.abs / expected_income.to_f * 100
end
+
+ private
+ def income_statement
+ @income_statement ||= family.income_statement
+ end
+
+ def expense_totals
+ @expense_totals ||= income_statement.expense_totals(period: period)
+ end
+
+ def income_totals
+ @income_totals ||= family.income_statement.income_totals(period: period)
+ end
end
diff --git a/app/models/budget_category.rb b/app/models/budget_category.rb
index 5109198d..e909a7e8 100644
--- a/app/models/budget_category.rb
+++ b/app/models/budget_category.rb
@@ -6,7 +6,7 @@ class BudgetCategory < ApplicationRecord
validates :budget_id, uniqueness: { scope: :category_id }
- monetize :budgeted_spending, :actual_spending, :available_to_spend
+ monetize :budgeted_spending, :available_to_spend, :avg_monthly_expense, :median_monthly_expense, :actual_spending
class Group
attr_reader :budget_category, :budget_subcategories
@@ -45,12 +45,24 @@ class BudgetCategory < ApplicationRecord
super || budget.family.categories.uncategorized
end
- def subcategory?
- category.parent_id.present?
+ def name
+ category.name
end
def actual_spending
- category.month_total(date: budget.start_date)
+ budget.budget_category_actual_spending(self)
+ end
+
+ def avg_monthly_expense
+ budget.category_avg_monthly_expense(category)
+ end
+
+ def median_monthly_expense
+ budget.category_median_monthly_expense(category)
+ end
+
+ def subcategory?
+ category.parent_id.present?
end
def available_to_spend
diff --git a/app/models/budgeting_stats.rb b/app/models/budgeting_stats.rb
deleted file mode 100644
index fdda0dff..00000000
--- a/app/models/budgeting_stats.rb
+++ /dev/null
@@ -1,29 +0,0 @@
-class BudgetingStats
- attr_reader :family
-
- def initialize(family)
- @family = family
- end
-
- def avg_monthly_income
- income_expense_totals_query(Account::Entry.incomes)
- end
-
- def avg_monthly_expenses
- income_expense_totals_query(Account::Entry.expenses)
- end
-
- private
- def income_expense_totals_query(type_scope)
- monthly_totals = family.entries
- .merge(type_scope)
- .select("SUM(account_entries.amount) as total")
- .group(Arel.sql("date_trunc('month', account_entries.date)"))
-
- result = Family.select("AVG(mt.total)")
- .from(monthly_totals, :mt)
- .pick("AVG(mt.total)")
-
- result&.round(2)
- end
-end
diff --git a/app/models/category.rb b/app/models/category.rb
index 4837c9cf..15e8e0bc 100644
--- a/app/models/category.rb
+++ b/app/models/category.rb
@@ -108,30 +108,6 @@ class Category < ApplicationRecord
parent.present?
end
- def avg_monthly_total
- family.category_stats.avg_monthly_total_for(self)
- end
-
- def median_monthly_total
- family.category_stats.median_monthly_total_for(self)
- end
-
- def month_total(date: Date.current)
- family.category_stats.month_total_for(self, date: date)
- end
-
- def avg_monthly_total_money
- Money.new(avg_monthly_total, family.currency)
- end
-
- def median_monthly_total_money
- Money.new(median_monthly_total, family.currency)
- end
-
- def month_total_money(date: Date.current)
- Money.new(month_total(date: date), family.currency)
- end
-
private
def category_level_limit
if (subcategory? && parent.subcategory?) || (parent? && subcategory?)
@@ -144,4 +120,8 @@ class Category < ApplicationRecord
errors.add(:parent, "must have the same classification as its parent")
end
end
+
+ def monetizable_currency
+ family.currency
+ end
end
diff --git a/app/models/category_stats.rb b/app/models/category_stats.rb
deleted file mode 100644
index 631b95ee..00000000
--- a/app/models/category_stats.rb
+++ /dev/null
@@ -1,179 +0,0 @@
-class CategoryStats
- attr_reader :family
-
- def initialize(family)
- @family = family
- end
-
- def avg_monthly_total_for(category)
- statistics_data[category.id]&.avg || 0
- end
-
- def median_monthly_total_for(category)
- statistics_data[category.id]&.median || 0
- end
-
- def month_total_for(category, date: Date.current)
- monthly_totals = totals_data[category.id]
-
- category_total = monthly_totals&.find { |mt| mt.month == date.month && mt.year == date.year }
-
- category_total&.amount || 0
- end
-
- def month_category_totals(date: Date.current)
- by_classification = Hash.new { |h, k| h[k] = {} }
-
- totals_data.each_with_object(by_classification) do |(category_id, totals), result|
- totals.each do |t|
- next unless t.month == date.month && t.year == date.year
- result[t.classification][category_id] ||= { amount: 0, subcategory: t.subcategory? }
- result[t.classification][category_id][:amount] += t.amount.abs
- end
- end
-
- # Calculate percentages for each group
- category_totals = []
-
- [ "income", "expense" ].each do |classification|
- totals = by_classification[classification]
-
- # Only include non-subcategory amounts in the total for percentage calculations
- total_amount = totals.sum do |_, data|
- data[:subcategory] ? 0 : data[:amount]
- end
-
- next if total_amount.zero?
-
- totals.each do |category_id, data|
- percentage = (data[:amount].to_f / total_amount * 100).round(1)
-
- category_totals << CategoryTotal.new(
- category_id: category_id,
- amount: data[:amount],
- percentage: percentage,
- classification: classification,
- currency: family.currency,
- subcategory?: data[:subcategory]
- )
- end
- end
-
- # Calculate totals based on non-subcategory amounts only
- total_income = category_totals
- .select { |ct| ct.classification == "income" && !ct.subcategory? }
- .sum(&:amount)
-
- total_expense = category_totals
- .select { |ct| ct.classification == "expense" && !ct.subcategory? }
- .sum(&:amount)
-
- CategoryTotals.new(
- total_income: total_income,
- total_expense: total_expense,
- category_totals: category_totals
- )
- end
-
- private
- Totals = Struct.new(:month, :year, :amount, :classification, :currency, :subcategory?, keyword_init: true)
- Stats = Struct.new(:avg, :median, :currency, keyword_init: true)
- CategoryTotals = Struct.new(:total_income, :total_expense, :category_totals, keyword_init: true)
- CategoryTotal = Struct.new(:category_id, :amount, :percentage, :classification, :currency, :subcategory?, keyword_init: true)
-
- def statistics_data
- @statistics_data ||= begin
- stats = totals_data.each_with_object({ nil => Stats.new(avg: 0, median: 0) }) do |(category_id, totals), hash|
- next if totals.empty?
-
- amounts = totals.map(&:amount)
- hash[category_id] = Stats.new(
- avg: (amounts.sum.to_f / amounts.size).round,
- median: calculate_median(amounts),
- currency: family.currency
- )
- end
- end
- end
-
- def totals_data
- @totals_data ||= begin
- totals = monthly_totals_query.each_with_object({ nil => [] }) do |row, hash|
- hash[row.category_id] ||= []
- existing_total = hash[row.category_id].find { |t| t.month == row.date.month && t.year == row.date.year }
-
- if existing_total
- existing_total.amount += row.total.to_i
- else
- hash[row.category_id] << Totals.new(
- month: row.date.month,
- year: row.date.year,
- amount: row.total.to_i,
- classification: row.classification,
- currency: family.currency,
- subcategory?: row.parent_category_id.present?
- )
- end
-
- # If category is a parent, its total includes its own transactions + sum(child category transactions)
- if row.parent_category_id
- hash[row.parent_category_id] ||= []
-
- existing_parent_total = hash[row.parent_category_id].find { |t| t.month == row.date.month && t.year == row.date.year }
-
- if existing_parent_total
- existing_parent_total.amount += row.total.to_i
- else
- hash[row.parent_category_id] << Totals.new(
- month: row.date.month,
- year: row.date.year,
- amount: row.total.to_i,
- classification: row.classification,
- currency: family.currency,
- subcategory?: false
- )
- end
- end
- end
-
- # Ensure we have a default empty array for nil category, which represents "Uncategorized"
- totals[nil] ||= []
- totals
- end
- end
-
- def monthly_totals_query
- income_expense_classification = Arel.sql("
- CASE WHEN categories.id IS NULL THEN
- CASE WHEN account_entries.amount < 0 THEN 'income' ELSE 'expense' END
- ELSE categories.classification
- END
- ")
-
- family.entries
- .incomes_and_expenses
- .select(
- "categories.id as category_id",
- "categories.parent_id as parent_category_id",
- income_expense_classification,
- "date_trunc('month', account_entries.date) as date",
- "SUM(account_entries.amount) as total"
- )
- .joins("LEFT JOIN categories ON categories.id = account_transactions.category_id")
- .group(Arel.sql("categories.id, categories.parent_id, #{income_expense_classification}, date_trunc('month', account_entries.date)"))
- .order(Arel.sql("date_trunc('month', account_entries.date) DESC"))
- end
-
-
- def calculate_median(numbers)
- return 0 if numbers.empty?
-
- sorted = numbers.sort
- mid = sorted.size / 2
- if sorted.size.odd?
- sorted[mid]
- else
- ((sorted[mid-1] + sorted[mid]) / 2.0).round
- end
- end
-end
diff --git a/app/models/concerns/accountable.rb b/app/models/concerns/accountable.rb
index 73e5ef69..c3e2b783 100644
--- a/app/models/concerns/accountable.rb
+++ b/app/models/concerns/accountable.rb
@@ -1,23 +1,50 @@
module Accountable
extend ActiveSupport::Concern
- ASSET_TYPES = %w[Depository Investment Crypto Property Vehicle OtherAsset]
- LIABILITY_TYPES = %w[CreditCard Loan OtherLiability]
- TYPES = ASSET_TYPES + LIABILITY_TYPES
+ TYPES = %w[Depository Investment Crypto Property Vehicle OtherAsset CreditCard Loan OtherLiability]
def self.from_type(type)
return nil unless TYPES.include?(type)
type.constantize
end
- def self.by_classification
- { assets: ASSET_TYPES, liabilities: LIABILITY_TYPES }
- end
-
included do
has_one :account, as: :accountable, touch: true
end
+ class_methods do
+ def classification
+ raise NotImplementedError, "Accountable must implement #classification"
+ end
+
+ def icon
+ raise NotImplementedError, "Accountable must implement #icon"
+ end
+
+ def color
+ raise NotImplementedError, "Accountable must implement #color"
+ end
+
+ def favorable_direction
+ classification == "asset" ? "up" : "down"
+ end
+
+ def display_name
+ self.name.pluralize.titleize
+ end
+
+ def balance_money(family)
+ family.accounts
+ .active
+ .joins(sanitize_sql_array([
+ "LEFT JOIN exchange_rates ON exchange_rates.date = :current_date AND accounts.currency = exchange_rates.from_currency AND exchange_rates.to_currency = :family_currency",
+ { current_date: Date.current.to_s, family_currency: family.currency }
+ ]))
+ .where(accountable_type: self.name)
+ .sum("accounts.balance * COALESCE(exchange_rates.rate, 1)")
+ end
+ end
+
def post_sync
broadcast_replace_to(
account,
@@ -26,4 +53,20 @@ module Accountable
locals: { account: account }
)
end
+
+ def display_name
+ self.class.display_name
+ end
+
+ def icon
+ self.class.icon
+ end
+
+ def color
+ self.class.color
+ end
+
+ def classification
+ self.class.classification
+ end
end
diff --git a/app/models/concerns/monetizable.rb b/app/models/concerns/monetizable.rb
index 8179271b..e80fcb5f 100644
--- a/app/models/concerns/monetizable.rb
+++ b/app/models/concerns/monetizable.rb
@@ -4,11 +4,19 @@ module Monetizable
class_methods do
def monetize(*fields)
fields.each do |field|
- define_method("#{field}_money") do
- value = self.send(field)
- value.nil? ? nil : Money.new(value, currency || Money.default_currency)
+ define_method("#{field}_money") do |**args|
+ value = self.send(field, **args)
+
+ return nil if value.nil? || monetizable_currency.nil?
+
+ Money.new(value, monetizable_currency)
end
end
end
end
+
+ private
+ def monetizable_currency
+ currency
+ end
end
diff --git a/app/models/credit_card.rb b/app/models/credit_card.rb
index dc269516..fa621546 100644
--- a/app/models/credit_card.rb
+++ b/app/models/credit_card.rb
@@ -1,6 +1,20 @@
class CreditCard < ApplicationRecord
include Accountable
+ class << self
+ def color
+ "#F13636"
+ end
+
+ def icon
+ "credit-card"
+ end
+
+ def classification
+ "liability"
+ end
+ end
+
def available_credit_money
available_credit ? Money.new(available_credit, account.currency) : nil
end
@@ -12,12 +26,4 @@ class CreditCard < ApplicationRecord
def annual_fee_money
annual_fee ? Money.new(annual_fee, account.currency) : nil
end
-
- def color
- "#F13636"
- end
-
- def icon
- "credit-card"
- end
end
diff --git a/app/models/crypto.rb b/app/models/crypto.rb
index 1aba075e..7724a953 100644
--- a/app/models/crypto.rb
+++ b/app/models/crypto.rb
@@ -1,11 +1,21 @@
class Crypto < ApplicationRecord
include Accountable
- def color
- "#737373"
- end
+ class << self
+ def color
+ "#737373"
+ end
+
+ def classification
+ "asset"
+ end
+
+ def icon
+ "bitcoin"
+ end
- def icon
- "bitcoin"
+ def display_name
+ "Crypto"
+ end
end
end
diff --git a/app/models/demo/generator.rb b/app/models/demo/generator.rb
index 283ae35b..bc5036eb 100644
--- a/app/models/demo/generator.rb
+++ b/app/models/demo/generator.rb
@@ -61,6 +61,34 @@ class Demo::Generator
puts "Demo data loaded successfully!"
end
+ def generate_multi_currency_data!
+ puts "Clearing existing data..."
+
+ destroy_everything!
+
+ puts "Data cleared"
+
+ create_family_and_user!("Demo Family 1", "[email protected]", currency: "EUR")
+
+ family = Family.find_by(name: "Demo Family 1")
+
+ puts "Users reset"
+
+ usd_checking = family.accounts.create!(name: "USD Checking", currency: "USD", balance: 10000, accountable: Depository.new)
+ eur_checking = family.accounts.create!(name: "EUR Checking", currency: "EUR", balance: 4900, accountable: Depository.new)
+
+ puts "Accounts created"
+
+ create_transaction!(account: usd_checking, amount: -11000, currency: "USD", name: "USD income Transaction")
+ create_transaction!(account: usd_checking, amount: 1000, currency: "USD", name: "USD expense Transaction")
+ create_transaction!(account: eur_checking, amount: -5000, currency: "EUR", name: "EUR income Transaction")
+ create_transaction!(account: eur_checking, amount: 100, currency: "EUR", name: "EUR expense Transaction")
+
+ puts "Transactions created"
+
+ puts "Demo data loaded successfully!"
+ end
+
private
def destroy_everything!
Family.destroy_all
@@ -71,13 +99,14 @@ class Demo::Generator
Security::Price.destroy_all
end
- def create_family_and_user!(family_name, user_email, data_enrichment_enabled: false)
+ def create_family_and_user!(family_name, user_email, data_enrichment_enabled: false, currency: "USD")
base_uuid = "d99e3c6e-d513-4452-8f24-dc263f8528c0"
id = Digest::UUID.uuid_v5(base_uuid, family_name)
family = Family.create!(
id: id,
name: family_name,
+ currency: currency,
stripe_subscription_status: "active",
data_enrichment_enabled: data_enrichment_enabled,
locale: "en",
@@ -161,19 +190,21 @@ class Demo::Generator
balance: 15000,
currency: "USD"
- 200.times do
+ # First create income transactions to ensure positive balance
+ 50.times do
create_transaction! \
account: checking,
- name: "Expense",
- amount: Faker::Number.positive(from: 100, to: 1000)
+ amount: Faker::Number.negative(from: -2000, to: -500),
+ name: "Income",
+ category: family.categories.find_by(name: "Income")
end
- 50.times do
+ # Then create expenses that won't exceed the income
+ 200.times do
create_transaction! \
account: checking,
- amount: Faker::Number.negative(from: -2000),
- name: "Income",
- category: family.categories.find_by(name: "Income")
+ name: "Expense",
+ amount: Faker::Number.positive(from: 8, to: 500)
end
end
@@ -185,14 +216,23 @@ class Demo::Generator
currency: "USD",
subtype: "savings"
+ # Create larger income deposits first
100.times do
create_transaction! \
account: savings,
- amount: Faker::Number.negative(from: -2000),
+ amount: Faker::Number.negative(from: -3000, to: -1000),
tags: [ family.tags.find_by(name: "Emergency Fund") ],
category: family.categories.find_by(name: "Income"),
name: "Income"
end
+
+ # Add some smaller withdrawals that won't exceed the deposits
+ 50.times do
+ create_transaction! \
+ account: savings,
+ amount: Faker::Number.positive(from: 100, to: 1000),
+ name: "Savings Withdrawal"
+ end
end
def create_transfer_transactions!(family)
@@ -304,39 +344,50 @@ class Demo::Generator
create_valuation!(house, 2.years.ago.to_date, 540000)
create_valuation!(house, 1.years.ago.to_date, 550000)
- family.accounts.create! \
+ mortgage = family.accounts.create! \
accountable: Loan.new,
name: "Mortgage",
balance: 495000,
currency: "USD"
+
+ create_valuation!(mortgage, 3.years.ago.to_date, 495000)
+ create_valuation!(mortgage, 2.years.ago.to_date, 490000)
+ create_valuation!(mortgage, 1.years.ago.to_date, 485000)
end
def create_car_and_loan!(family)
- family.accounts.create! \
+ vehicle = family.accounts.create! \
accountable: Vehicle.new,
name: "Honda Accord",
balance: 18000,
currency: "USD"
- family.accounts.create! \
+ create_valuation!(vehicle, 1.year.ago.to_date, 18000)
+
+ loan = family.accounts.create! \
accountable: Loan.new,
name: "Car Loan",
balance: 8000,
currency: "USD"
+
+ create_valuation!(loan, 1.year.ago.to_date, 8000)
end
def create_other_accounts!(family)
- family.accounts.create! \
+ other_asset = family.accounts.create! \
accountable: OtherAsset.new,
name: "Other Asset",
balance: 10000,
currency: "USD"
- family.accounts.create! \
+ other_liability = family.accounts.create! \
accountable: OtherLiability.new,
name: "Other Liability",
balance: 5000,
currency: "USD"
+
+ create_valuation!(other_asset, 1.year.ago.to_date, 10000)
+ create_valuation!(other_liability, 1.year.ago.to_date, 5000)
end
def create_transaction!(attributes = {})
diff --git a/app/models/depository.rb b/app/models/depository.rb
index 3b818f43..0e03547c 100644
--- a/app/models/depository.rb
+++ b/app/models/depository.rb
@@ -6,11 +6,21 @@ class Depository < ApplicationRecord
[ "Savings", "savings" ]
].freeze
- def color
- "#875BF7"
- end
+ class << self
+ def display_name
+ "Cash"
+ end
+
+ def color
+ "#875BF7"
+ end
+
+ def classification
+ "asset"
+ end
- def icon
- "landmark"
+ def icon
+ "landmark"
+ end
end
end
diff --git a/app/models/family.rb b/app/models/family.rb
index 4f001119..ff2c8b07 100644
--- a/app/models/family.rb
+++ b/app/models/family.rb
@@ -1,5 +1,5 @@
class Family < ApplicationRecord
- include Plaidable, Syncable
+ include Providable, Plaidable, Syncable, AutoTransferMatchable
DATE_FORMATS = [
[ "MM-DD-YYYY", "%m-%d-%Y" ],
@@ -13,26 +13,37 @@ class Family < ApplicationRecord
[ "YYYY.MM.DD", "%Y.%m.%d" ]
].freeze
- include Providable
-
has_many :users, dependent: :destroy
- has_many :invitations, dependent: :destroy
- has_many :tags, dependent: :destroy
has_many :accounts, dependent: :destroy
+ has_many :plaid_items, dependent: :destroy
+ has_many :invitations, dependent: :destroy
+
has_many :imports, dependent: :destroy
- has_many :transactions, through: :accounts
+ has_many :issues, through: :accounts
+
has_many :entries, through: :accounts
+ has_many :transactions, through: :accounts
+ has_many :trades, through: :accounts
+ has_many :holdings, through: :accounts
+
+ has_many :tags, dependent: :destroy
has_many :categories, dependent: :destroy
has_many :merchants, dependent: :destroy
- has_many :issues, through: :accounts
- has_many :holdings, through: :accounts
- has_many :plaid_items, dependent: :destroy
+
has_many :budgets, dependent: :destroy
has_many :budget_categories, through: :budgets
validates :locale, inclusion: { in: I18n.available_locales.map(&:to_s) }
validates :date_format, inclusion: { in: DATE_FORMATS.map(&:last) }
+ def balance_sheet
+ @balance_sheet ||= BalanceSheet.new(self)
+ end
+
+ def income_statement
+ @income_statement ||= IncomeStatement.new(self)
+ end
+
def sync_data(start_date: nil)
update!(last_synced_at: Time.current)
@@ -81,120 +92,6 @@ class Family < ApplicationRecord
).link_token
end
- def income_categories_with_totals(date: Date.current)
- categories_with_stats(classification: "income", date: date)
- end
-
- def expense_categories_with_totals(date: Date.current)
- categories_with_stats(classification: "expense", date: date)
- end
-
- def category_stats
- CategoryStats.new(self)
- end
-
- def budgeting_stats
- BudgetingStats.new(self)
- end
-
- def snapshot(period = Period.all)
- query = accounts.active.joins(:balances)
- .where("account_balances.currency = ?", self.currency)
- .select(
- "account_balances.currency",
- "account_balances.date",
- "SUM(CASE WHEN accounts.classification = 'liability' THEN account_balances.balance ELSE 0 END) AS liabilities",
- "SUM(CASE WHEN accounts.classification = 'asset' THEN account_balances.balance ELSE 0 END) AS assets",
- "SUM(CASE WHEN accounts.classification = 'asset' THEN account_balances.balance WHEN accounts.classification = 'liability' THEN -account_balances.balance ELSE 0 END) AS net_worth",
- )
- .group("account_balances.date, account_balances.currency")
- .order("account_balances.date")
-
- query = query.where("account_balances.date >= ?", period.date_range.begin) if period.date_range.begin
- query = query.where("account_balances.date <= ?", period.date_range.end) if period.date_range.end
- result = query.to_a
-
- {
- asset_series: TimeSeries.new(result.map { |r| { date: r.date, value: Money.new(r.assets, r.currency) } }),
- liability_series: TimeSeries.new(result.map { |r| { date: r.date, value: Money.new(r.liabilities, r.currency) } }, favorable_direction: "down"),
- net_worth_series: TimeSeries.new(result.map { |r| { date: r.date, value: Money.new(r.net_worth, r.currency) } })
- }
- end
-
- def snapshot_account_transactions
- period = Period.last_30_days
- results = accounts.active
- .joins(:entries)
- .joins("LEFT JOIN transfers ON (transfers.inflow_transaction_id = account_entries.entryable_id OR transfers.outflow_transaction_id = account_entries.entryable_id)")
- .select(
- "accounts.*",
- "COALESCE(SUM(account_entries.amount) FILTER (WHERE account_entries.amount > 0), 0) AS spending",
- "COALESCE(SUM(-account_entries.amount) FILTER (WHERE account_entries.amount < 0), 0) AS income"
- )
- .where("account_entries.date >= ?", period.date_range.begin)
- .where("account_entries.date <= ?", period.date_range.end)
- .where("account_entries.entryable_type = 'Account::Transaction'")
- .where("transfers.id IS NULL")
- .group("accounts.id")
- .having("SUM(ABS(account_entries.amount)) > 0")
- .to_a
-
- results.each do |r|
- r.define_singleton_method(:savings_rate) do
- (income - spending) / income
- end
- end
-
- {
- top_spenders: results.sort_by(&:spending).select { |a| a.spending > 0 }.reverse,
- top_earners: results.sort_by(&:income).select { |a| a.income > 0 }.reverse,
- top_savers: results.sort_by { |a| a.savings_rate }.reverse
- }
- end
-
- def snapshot_transactions
- candidate_entries = entries.account_transactions.incomes_and_expenses
- rolling_totals = Account::Entry.daily_rolling_totals(candidate_entries, self.currency, period: Period.last_30_days)
-
- spending = []
- income = []
- savings = []
- rolling_totals.each do |r|
- spending << {
- date: r.date,
- value: Money.new(r.rolling_spend, self.currency)
- }
-
- income << {
- date: r.date,
- value: Money.new(r.rolling_income, self.currency)
- }
-
- savings << {
- date: r.date,
- value: r.rolling_income != 0 ? ((r.rolling_income - r.rolling_spend) / r.rolling_income) : 0.to_d
- }
- end
-
- {
- income_series: TimeSeries.new(income, favorable_direction: "up"),
- spending_series: TimeSeries.new(spending, favorable_direction: "down"),
- savings_rate_series: TimeSeries.new(savings, favorable_direction: "up")
- }
- end
-
- def net_worth
- assets - liabilities
- end
-
- def assets
- Money.new(accounts.active.assets.map { |account| account.balance_money.exchange_to(currency, fallback_rate: 0) }.sum, currency)
- end
-
- def liabilities
- Money.new(accounts.active.liabilities.map { |account| account.balance_money.exchange_to(currency, fallback_rate: 0) }.sum, currency)
- end
-
def synth_usage
self.class.synth_provider&.usage
end
@@ -223,36 +120,13 @@ class Family < ApplicationRecord
accounts.active.count
end
- private
- CategoriesWithTotals = Struct.new(:total_money, :category_totals, keyword_init: true)
- CategoryWithStats = Struct.new(:category, :amount_money, :percentage, keyword_init: true)
-
- def categories_with_stats(classification:, date: Date.current)
- totals = category_stats.month_category_totals(date: date)
-
- classified_totals = totals.category_totals.select { |t| t.classification == classification }
-
- if classification == "income"
- total = totals.total_income
- categories_scope = categories.incomes
- else
- total = totals.total_expense
- categories_scope = categories.expenses
- end
-
- categories_with_uncategorized = categories_scope + [ categories_scope.uncategorized ]
-
- CategoriesWithTotals.new(
- total_money: Money.new(total, currency),
- category_totals: categories_with_uncategorized.map do |category|
- ct = classified_totals.find { |ct| ct.category_id == category&.id }
-
- CategoryWithStats.new(
- category: category,
- amount_money: Money.new(ct&.amount || 0, currency),
- percentage: ct&.percentage || 0
- )
- end
- )
- end
+ # Cache key that is invalidated when any of the family's entries are updated (which affect rollups and other calculations)
+ def build_cache_key(key)
+ [
+ "family",
+ id,
+ key,
+ entries.maximum(:updated_at)
+ ].compact.join("_")
+ end
end
diff --git a/app/models/family/auto_transfer_matchable.rb b/app/models/family/auto_transfer_matchable.rb
new file mode 100644
index 00000000..32fe94b4
--- /dev/null
+++ b/app/models/family/auto_transfer_matchable.rb
@@ -0,0 +1,61 @@
+module Family::AutoTransferMatchable
+ def transfer_match_candidates
+ Account::Entry.select([
+ "inflow_candidates.entryable_id as inflow_transaction_id",
+ "outflow_candidates.entryable_id as outflow_transaction_id",
+ "ABS(inflow_candidates.date - outflow_candidates.date) as date_diff"
+ ]).from("account_entries inflow_candidates")
+ .joins("
+ JOIN account_entries outflow_candidates ON (
+ inflow_candidates.amount < 0 AND
+ outflow_candidates.amount > 0 AND
+ inflow_candidates.amount = -outflow_candidates.amount AND
+ inflow_candidates.currency = outflow_candidates.currency AND
+ inflow_candidates.account_id <> outflow_candidates.account_id AND
+ inflow_candidates.date BETWEEN outflow_candidates.date - 4 AND outflow_candidates.date + 4
+ )
+ ").joins("
+ LEFT JOIN transfers existing_transfers ON (
+ existing_transfers.inflow_transaction_id = inflow_candidates.entryable_id OR
+ existing_transfers.outflow_transaction_id = outflow_candidates.entryable_id
+ )
+ ")
+ .joins("LEFT JOIN rejected_transfers ON (
+ rejected_transfers.inflow_transaction_id = inflow_candidates.entryable_id AND
+ rejected_transfers.outflow_transaction_id = outflow_candidates.entryable_id
+ )")
+ .joins("JOIN accounts inflow_accounts ON inflow_accounts.id = inflow_candidates.account_id")
+ .joins("JOIN accounts outflow_accounts ON outflow_accounts.id = outflow_candidates.account_id")
+ .where("inflow_accounts.family_id = ? AND outflow_accounts.family_id = ?", self.id, self.id)
+ .where("inflow_accounts.is_active = true")
+ .where("outflow_accounts.is_active = true")
+ .where("inflow_candidates.entryable_type = 'Account::Transaction' AND outflow_candidates.entryable_type = 'Account::Transaction'")
+ .where(existing_transfers: { id: nil })
+ .order("date_diff ASC") # Closest matches first
+ end
+
+ def auto_match_transfers!
+ # Exclude already matched transfers
+ candidates_scope = transfer_match_candidates.where(rejected_transfers: { id: nil })
+
+ # Track which transactions we've already matched to avoid duplicates
+ used_transaction_ids = Set.new
+
+ candidates = []
+
+ Transfer.transaction do
+ candidates_scope.each do |match|
+ next if used_transaction_ids.include?(match.inflow_transaction_id) ||
+ used_transaction_ids.include?(match.outflow_transaction_id)
+
+ Transfer.create!(
+ inflow_transaction_id: match.inflow_transaction_id,
+ outflow_transaction_id: match.outflow_transaction_id,
+ )
+
+ used_transaction_ids << match.inflow_transaction_id
+ used_transaction_ids << match.outflow_transaction_id
+ end
+ end
+ end
+end
diff --git a/app/models/income_statement.rb b/app/models/income_statement.rb
new file mode 100644
index 00000000..52ad030c
--- /dev/null
+++ b/app/models/income_statement.rb
@@ -0,0 +1,118 @@
+class IncomeStatement
+ include Monetizable
+
+ monetize :median_expense, :median_income
+
+ attr_reader :family
+
+ def initialize(family)
+ @family = family
+ end
+
+ def totals(transactions_scope: nil)
+ transactions_scope ||= family.transactions.active
+
+ result = totals_query(transactions_scope: transactions_scope)
+
+ total_income = result.select { |t| t.classification == "income" }.sum(&:total)
+ total_expense = result.select { |t| t.classification == "expense" }.sum(&:total)
+
+ ScopeTotals.new(
+ transactions_count: transactions_scope.count,
+ income_money: Money.new(total_income, family.currency),
+ expense_money: Money.new(total_expense, family.currency),
+ missing_exchange_rates?: result.any?(&:missing_exchange_rates?)
+ )
+ end
+
+ def expense_totals(period: Period.current_month)
+ build_period_total(classification: "expense", period: period)
+ end
+
+ def income_totals(period: Period.current_month)
+ build_period_total(classification: "income", period: period)
+ end
+
+ def median_expense(interval: "month", category: nil)
+ if category.present?
+ category_stats(interval: interval).find { |stat| stat.classification == "expense" && stat.category_id == category.id }&.median || 0
+ else
+ family_stats(interval: interval).find { |stat| stat.classification == "expense" }&.median || 0
+ end
+ end
+
+ def avg_expense(interval: "month", category: nil)
+ if category.present?
+ category_stats(interval: interval).find { |stat| stat.classification == "expense" && stat.category_id == category.id }&.avg || 0
+ else
+ family_stats(interval: interval).find { |stat| stat.classification == "expense" }&.avg || 0
+ end
+ end
+
+ def median_income(interval: "month")
+ family_stats(interval: interval).find { |stat| stat.classification == "income" }&.median || 0
+ end
+
+ private
+ ScopeTotals = Data.define(:transactions_count, :income_money, :expense_money, :missing_exchange_rates?)
+ PeriodTotal = Data.define(:classification, :total, :currency, :missing_exchange_rates?, :category_totals)
+ CategoryTotal = Data.define(:category, :total, :currency, :weight)
+
+ def categories
+ @categories ||= family.categories.all.to_a
+ end
+
+ def build_period_total(classification:, period:)
+ totals = totals_query(transactions_scope: family.transactions.active.in_period(period)).select { |t| t.classification == classification }
+ classification_total = totals.sum(&:total)
+
+ category_totals = totals.map do |ct|
+ # If parent category is nil, it's a top-level category. This means we need to
+ # sum itself + SUM(children) to get the overall category total
+ children_totals = if ct.parent_category_id.nil? && ct.category_id.present?
+ totals.select { |t| t.parent_category_id == ct.category_id }.sum(&:total)
+ else
+ 0
+ end
+
+ category_total = ct.total + children_totals
+
+ weight = (category_total.zero? ? 0 : category_total.to_f / classification_total) * 100
+
+ CategoryTotal.new(
+ category: categories.find { |c| c.id == ct.category_id } || family.categories.uncategorized,
+ total: category_total,
+ currency: family.currency,
+ weight: weight,
+ )
+ end
+
+ PeriodTotal.new(
+ classification: classification,
+ total: category_totals.reject { |ct| ct.category.subcategory? }.sum(&:total),
+ currency: family.currency,
+ missing_exchange_rates?: totals.any?(&:missing_exchange_rates?),
+ category_totals: category_totals
+ )
+ end
+
+ def family_stats(interval: "month")
+ @family_stats ||= {}
+ @family_stats[interval] ||= FamilyStats.new(family, interval:).call
+ end
+
+ def category_stats(interval: "month")
+ @category_stats ||= {}
+ @category_stats[interval] ||= CategoryStats.new(family, interval:).call
+ end
+
+ def totals_query(transactions_scope:)
+ @totals_query_cache ||= {}
+ cache_key = Digest::MD5.hexdigest(transactions_scope.to_sql)
+ @totals_query_cache[cache_key] ||= Totals.new(family, transactions_scope: transactions_scope).call
+ end
+
+ def monetizable_currency
+ family.currency
+ end
+end
diff --git a/app/models/income_statement/base_query.rb b/app/models/income_statement/base_query.rb
new file mode 100644
index 00000000..baa09659
--- /dev/null
+++ b/app/models/income_statement/base_query.rb
@@ -0,0 +1,42 @@
+module IncomeStatement::BaseQuery
+ private
+ def base_query_sql(family:, interval:, transactions_scope:)
+ sql = <<~SQL
+ SELECT
+ c.id as category_id,
+ c.parent_id as parent_category_id,
+ date_trunc(:interval, ae.date) as date,
+ CASE WHEN ae.amount < 0 THEN 'income' ELSE 'expense' END as classification,
+ SUM(ae.amount * COALESCE(er.rate, 1)) as total,
+ BOOL_OR(ae.currency <> :target_currency AND er.rate IS NULL) as missing_exchange_rates
+ FROM (#{transactions_scope.to_sql}) at
+ JOIN account_entries ae ON ae.entryable_id = at.id AND ae.entryable_type = 'Account::Transaction'
+ LEFT JOIN categories c ON c.id = at.category_id
+ LEFT JOIN (
+ SELECT t.*, t.id as transfer_id, a.accountable_type
+ FROM transfers t
+ JOIN account_entries ae ON ae.entryable_id = t.inflow_transaction_id
+ AND ae.entryable_type = 'Account::Transaction'
+ JOIN accounts a ON a.id = ae.account_id
+ ) transfer_info ON (
+ transfer_info.inflow_transaction_id = at.id OR
+ transfer_info.outflow_transaction_id = at.id
+ )
+ LEFT JOIN exchange_rates er ON (
+ er.date = ae.date AND
+ er.from_currency = ae.currency AND
+ er.to_currency = :target_currency
+ )
+ WHERE (
+ transfer_info.transfer_id IS NULL OR
+ (ae.amount < 0 AND transfer_info.accountable_type = 'Loan')
+ )
+ GROUP BY 1, 2, 3, 4
+ SQL
+
+ ActiveRecord::Base.sanitize_sql_array([
+ sql,
+ { target_currency: family.currency, interval: interval }
+ ])
+ end
+end
diff --git a/app/models/income_statement/category_stats.rb b/app/models/income_statement/category_stats.rb
new file mode 100644
index 00000000..9f971d99
--- /dev/null
+++ b/app/models/income_statement/category_stats.rb
@@ -0,0 +1,41 @@
+class IncomeStatement::CategoryStats
+ include IncomeStatement::BaseQuery
+
+ def initialize(family, interval: "month")
+ @family = family
+ @interval = interval
+ end
+
+ def call
+ ActiveRecord::Base.connection.select_all(query_sql).map do |row|
+ StatRow.new(
+ category_id: row["category_id"],
+ classification: row["classification"],
+ median: row["median"],
+ avg: row["avg"],
+ missing_exchange_rates?: row["missing_exchange_rates"]
+ )
+ end
+ end
+
+ private
+ StatRow = Data.define(:category_id, :classification, :median, :avg, :missing_exchange_rates?)
+
+ def query_sql
+ base_sql = base_query_sql(family: @family, interval: @interval, transactions_scope: @family.transactions.active)
+
+ <<~SQL
+ WITH base_totals AS (
+ #{base_sql}
+ )
+ SELECT
+ category_id,
+ classification,
+ ABS(PERCENTILE_CONT(0.5) WITHIN GROUP (ORDER BY total)) as median,
+ ABS(AVG(total)) as avg,
+ BOOL_OR(missing_exchange_rates) as missing_exchange_rates
+ FROM base_totals
+ GROUP BY category_id, classification;
+ SQL
+ end
+end
diff --git a/app/models/income_statement/family_stats.rb b/app/models/income_statement/family_stats.rb
new file mode 100644
index 00000000..2edece2e
--- /dev/null
+++ b/app/models/income_statement/family_stats.rb
@@ -0,0 +1,47 @@
+class IncomeStatement::FamilyStats
+ include IncomeStatement::BaseQuery
+
+ def initialize(family, interval: "month")
+ @family = family
+ @interval = interval
+ end
+
+ def call
+ ActiveRecord::Base.connection.select_all(query_sql).map do |row|
+ StatRow.new(
+ classification: row["classification"],
+ median: row["median"],
+ avg: row["avg"],
+ missing_exchange_rates?: row["missing_exchange_rates"]
+ )
+ end
+ end
+
+ private
+ StatRow = Data.define(:classification, :median, :avg, :missing_exchange_rates?)
+
+ def query_sql
+ base_sql = base_query_sql(family: @family, interval: @interval, transactions_scope: @family.transactions.active)
+
+ <<~SQL
+ WITH base_totals AS (
+ #{base_sql}
+ ), aggregated_totals AS (
+ SELECT
+ date,
+ classification,
+ SUM(total) as total,
+ BOOL_OR(missing_exchange_rates) as missing_exchange_rates
+ FROM base_totals
+ GROUP BY date, classification
+ )
+ SELECT
+ classification,
+ ABS(PERCENTILE_CONT(0.5) WITHIN GROUP (ORDER BY total)) as median,
+ ABS(AVG(total)) as avg,
+ BOOL_OR(missing_exchange_rates) as missing_exchange_rates
+ FROM aggregated_totals
+ GROUP BY classification;
+ SQL
+ end
+end
diff --git a/app/models/income_statement/totals.rb b/app/models/income_statement/totals.rb
new file mode 100644
index 00000000..acf2017b
--- /dev/null
+++ b/app/models/income_statement/totals.rb
@@ -0,0 +1,41 @@
+class IncomeStatement::Totals
+ include IncomeStatement::BaseQuery
+
+ def initialize(family, transactions_scope:)
+ @family = family
+ @transactions_scope = transactions_scope
+ end
+
+ def call
+ ActiveRecord::Base.connection.select_all(query_sql).map do |row|
+ TotalsRow.new(
+ parent_category_id: row["parent_category_id"],
+ category_id: row["category_id"],
+ classification: row["classification"],
+ total: row["total"],
+ missing_exchange_rates?: row["missing_exchange_rates"]
+ )
+ end
+ end
+
+ private
+ TotalsRow = Data.define(:parent_category_id, :category_id, :classification, :total, :missing_exchange_rates?)
+
+ def query_sql
+ base_sql = base_query_sql(family: @family, interval: "day", transactions_scope: @transactions_scope)
+
+ <<~SQL
+ WITH base_totals AS (
+ #{base_sql}
+ )
+ SELECT
+ parent_category_id,
+ category_id,
+ classification,
+ ABS(SUM(total)) as total,
+ BOOL_OR(missing_exchange_rates) as missing_exchange_rates
+ FROM base_totals
+ GROUP BY 1, 2, 3;
+ SQL
+ end
+end
diff --git a/app/models/investment.rb b/app/models/investment.rb
index 76e7a57c..1dabae3e 100644
--- a/app/models/investment.rb
+++ b/app/models/investment.rb
@@ -16,11 +16,17 @@ class Investment < ApplicationRecord
[ "Angel", "angel" ]
].freeze
- def color
- "#1570EF"
- end
+ class << self
+ def color
+ "#1570EF"
+ end
+
+ def classification
+ "asset"
+ end
- def icon
- "line-chart"
+ def icon
+ "line-chart"
+ end
end
end
diff --git a/app/models/loan.rb b/app/models/loan.rb
index 41bd4d7b..14b4d084 100644
--- a/app/models/loan.rb
+++ b/app/models/loan.rb
@@ -17,11 +17,17 @@ class Loan < ApplicationRecord
Money.new(payment.round, account.currency)
end
- def color
- "#D444F1"
- end
+ class << self
+ def color
+ "#D444F1"
+ end
- def icon
- "hand-coins"
+ def icon
+ "hand-coins"
+ end
+
+ def classification
+ "liability"
+ end
end
end
diff --git a/app/models/other_asset.rb b/app/models/other_asset.rb
index 68d3915e..ad4d5c7c 100644
--- a/app/models/other_asset.rb
+++ b/app/models/other_asset.rb
@@ -1,11 +1,17 @@
class OtherAsset < ApplicationRecord
include Accountable
- def color
- "#12B76A"
- end
+ class << self
+ def color
+ "#12B76A"
+ end
+
+ def icon
+ "plus"
+ end
- def icon
- "plus"
+ def classification
+ "asset"
+ end
end
end
diff --git a/app/models/other_liability.rb b/app/models/other_liability.rb
index 18e44171..03ef07ba 100644
--- a/app/models/other_liability.rb
+++ b/app/models/other_liability.rb
@@ -1,11 +1,17 @@
class OtherLiability < ApplicationRecord
include Accountable
- def color
- "#737373"
- end
+ class << self
+ def color
+ "#737373"
+ end
+
+ def icon
+ "minus"
+ end
- def icon
- "minus"
+ def classification
+ "liability"
+ end
end
end
diff --git a/app/models/period.rb b/app/models/period.rb
index c1d28e99..65825058 100644
--- a/app/models/period.rb
+++ b/app/models/period.rb
@@ -1,46 +1,167 @@
class Period
- attr_reader :name, :date_range
+ include ActiveModel::Validations, Comparable
+
+ attr_reader :start_date, :end_date
+
+ validates :start_date, :end_date, presence: true
+ validate :must_be_valid_date_range
+
+ PERIODS = {
+ "last_day" => {
+ date_range: [ 1.day.ago.to_date, Date.current ],
+ label_short: "1D",
+ label: "Last Day",
+ comparison_label: "vs. yesterday"
+ },
+ "current_week" => {
+ date_range: [ Date.current.beginning_of_week, Date.current ],
+ label_short: "WTD",
+ label: "Current Week",
+ comparison_label: "vs. start of week"
+ },
+ "last_7_days" => {
+ date_range: [ 7.days.ago.to_date, Date.current ],
+ label_short: "7D",
+ label: "Last 7 Days",
+ comparison_label: "vs. last week"
+ },
+ "current_month" => {
+ date_range: [ Date.current.beginning_of_month, Date.current ],
+ label_short: "MTD",
+ label: "Current Month",
+ comparison_label: "vs. start of month"
+ },
+ "last_30_days" => {
+ date_range: [ 30.days.ago.to_date, Date.current ],
+ label_short: "30D",
+ label: "Last 30 Days",
+ comparison_label: "vs. last month"
+ },
+ "last_90_days" => {
+ date_range: [ 90.days.ago.to_date, Date.current ],
+ label_short: "90D",
+ label: "Last 90 Days",
+ comparison_label: "vs. last quarter"
+ },
+ "current_year" => {
+ date_range: [ Date.current.beginning_of_year, Date.current ],
+ label_short: "YTD",
+ label: "Current Year",
+ comparison_label: "vs. start of year"
+ },
+ "last_365_days" => {
+ date_range: [ 365.days.ago.to_date, Date.current ],
+ label_short: "365D",
+ label: "Last 365 Days",
+ comparison_label: "vs. 1 year ago"
+ },
+ "last_5_years" => {
+ date_range: [ 5.years.ago.to_date, Date.current ],
+ label_short: "5Y",
+ label: "Last 5 Years",
+ comparison_label: "vs. 5 years ago"
+ }
+ }
class << self
- def from_param(param)
- find_by_name(param) || self.last_30_days
+ def default
+ from_key("last_30_days")
end
- def find_by_name(name)
- INDEX[name]
+ def from_key(key, fallback: false)
+ if PERIODS[key].present?
+ start_date, end_date = PERIODS[key].fetch(:date_range)
+ new(start_date: start_date, end_date: end_date)
+ else
+ return default if fallback
+ raise ArgumentError, "Invalid period key: #{key}"
+ end
end
- def names
- INDEX.keys.sort
+ def all
+ PERIODS.map { |key, period| from_key(key) }
end
end
- def initialize(name: "custom", date_range:)
- @name = name
- @date_range = date_range
+ PERIODS.each do |key, period|
+ define_singleton_method(key) do
+ start_date, end_date = period.fetch(:date_range)
+ new(start_date: start_date, end_date: end_date)
+ end
+ end
+
+ def initialize(start_date:, end_date:, date_format: "%b %d, %Y")
+ @start_date = start_date
+ @end_date = end_date
+ @date_format = date_format
+ validate!
+ end
+
+ def <=>(other)
+ [ start_date, end_date ] <=> [ other.start_date, other.end_date ]
+ end
+
+ def date_range
+ start_date..end_date
+ end
+
+ def days
+ (end_date - start_date).to_i + 1
+ end
+
+ def within?(other)
+ start_date >= other.start_date && end_date <= other.end_date
end
- def extend_backward(duration)
- Period.new(name: name + "_extended", date_range: (date_range.first - duration)..date_range.last)
+ def interval
+ if days > 90
+ "1 month"
+ else
+ "1 day"
+ end
end
- BUILTIN = [
- new(name: "all", date_range: nil..Date.current),
- new(name: "current_week", date_range: Date.current.beginning_of_week..Date.current),
- new(name: "last_7_days", date_range: 7.days.ago.to_date..Date.current),
- new(name: "current_month", date_range: Date.current.beginning_of_month..Date.current),
- new(name: "last_30_days", date_range: 30.days.ago.to_date..Date.current),
- new(name: "current_quarter", date_range: Date.current.beginning_of_quarter..Date.current),
- new(name: "last_90_days", date_range: 90.days.ago.to_date..Date.current),
- new(name: "current_year", date_range: Date.current.beginning_of_year..Date.current),
- new(name: "last_365_days", date_range: 365.days.ago.to_date..Date.current)
- ]
+ def key
+ PERIODS.find { |_, period| period.fetch(:date_range) == [ start_date, end_date ] }&.first
+ end
- INDEX = BUILTIN.index_by(&:name)
+ def label
+ if known?
+ PERIODS[key].fetch(:label)
+ else
+ "Custom Period"
+ end
+ end
- BUILTIN.each do |period|
- define_singleton_method(period.name) do
- period
+ def label_short
+ if known?
+ PERIODS[key].fetch(:label_short)
+ else
+ "CP"
end
end
+
+ def comparison_label
+ if known?
+ PERIODS[key].fetch(:comparison_label)
+ else
+ "#{start_date.strftime(@date_format)} to #{end_date.strftime(@date_format)}"
+ end
+ end
+
+ private
+ def known?
+ key.present?
+ end
+
+ def must_be_valid_date_range
+ return if start_date.nil? || end_date.nil?
+ unless start_date.is_a?(Date) && end_date.is_a?(Date)
+ errors.add(:start_date, "must be a valid date")
+ errors.add(:end_date, "must be a valid date")
+ return
+ end
+
+ errors.add(:start_date, "must be before end date") if start_date > end_date
+ end
end
diff --git a/app/models/plaid_account.rb b/app/models/plaid_account.rb
index 1fdf40ee..186105ce 100644
--- a/app/models/plaid_account.rb
+++ b/app/models/plaid_account.rb
@@ -115,12 +115,6 @@ class PlaidAccount < ApplicationRecord
plaid_item.family
end
- def transfer?(plaid_txn)
- transfer_categories = [ "TRANSFER_IN", "TRANSFER_OUT", "LOAN_PAYMENTS" ]
-
- transfer_categories.include?(plaid_txn.personal_finance_category.primary)
- end
-
def create_initial_loan_balance(loan_data)
if loan_data.origination_principal_amount.present? && loan_data.origination_date.present?
account.entries.find_or_create_by!(plaid_id: loan_data.account_id) do |e|
diff --git a/app/models/property.rb b/app/models/property.rb
index ec1d530f..b30a1071 100644
--- a/app/models/property.rb
+++ b/app/models/property.rb
@@ -16,6 +16,20 @@ class Property < ApplicationRecord
attribute :area_unit, :string, default: "sqft"
+ class << self
+ def icon
+ "home"
+ end
+
+ def color
+ "#06AED4"
+ end
+
+ def classification
+ "asset"
+ end
+ end
+
def area
Measurement.new(area_value, area_unit) if area_value.present?
end
@@ -25,15 +39,7 @@ class Property < ApplicationRecord
end
def trend
- TimeSeries::Trend.new(current: account.balance_money, previous: first_valuation_amount)
- end
-
- def color
- "#06AED4"
- end
-
- def icon
- "home"
+ Trend.new(current: account.balance_money, previous: first_valuation_amount)
end
private
diff --git a/app/models/series.rb b/app/models/series.rb
new file mode 100644
index 00000000..0447ebc4
--- /dev/null
+++ b/app/models/series.rb
@@ -0,0 +1,57 @@
+class Series
+ attr_reader :start_date, :end_date, :interval, :trend, :values
+
+ Value = Struct.new(
+ :date,
+ :date_formatted,
+ :trend,
+ keyword_init: true
+ )
+
+ class << self
+ def from_raw_values(values, interval: "1 day")
+ raise ArgumentError, "Must be an array of at least 2 values" unless values.size >= 2
+ raise ArgumentError, "Must have date and value properties" unless values.all? { |value| value.has_key?(:date) && value.has_key?(:value) }
+
+ ordered = values.sort_by { |value| value[:date] }
+ start_date = ordered.first[:date]
+ end_date = ordered.last[:date]
+
+ new(
+ start_date: start_date,
+ end_date: end_date,
+ interval: interval,
+ trend: Trend.new(
+ current: ordered.last[:value],
+ previous: ordered.first[:value]
+ ),
+ values: [ nil, *ordered ].each_cons(2).map do |prev_value, curr_value|
+ Value.new(
+ date: curr_value[:date],
+ date_formatted: I18n.l(curr_value[:date], format: :long),
+ trend: Trend.new(
+ current: curr_value[:value],
+ previous: prev_value&.[](:value)
+ )
+ )
+ end
+ )
+ end
+ end
+
+ def initialize(start_date:, end_date:, interval:, trend:, values:)
+ @start_date = start_date
+ @end_date = end_date
+ @interval = interval
+ @trend = trend
+ @values = values
+ end
+
+ def current
+ values.last.trend.current
+ end
+
+ def any?
+ values.any?
+ end
+end
diff --git a/app/models/time_series.rb b/app/models/time_series.rb
deleted file mode 100644
index f9ef3ffb..00000000
--- a/app/models/time_series.rb
+++ /dev/null
@@ -1,65 +0,0 @@
-class TimeSeries
- DIRECTIONS = %w[up down].freeze
-
- attr_reader :values, :favorable_direction
-
- def self.from_collection(collection, value_method, favorable_direction: "up")
- collection.map do |obj|
- {
- date: obj.date,
- value: obj.public_send(value_method),
- original: obj
- }
- end.then { |data| new(data, favorable_direction: favorable_direction) }
- end
-
- def initialize(data, favorable_direction: "up")
- @favorable_direction = (favorable_direction.presence_in(DIRECTIONS) || "up").inquiry
- @values = initialize_values data.sort_by { |d| d[:date] }
- end
-
- def first
- values.first
- end
-
- def last
- values.last
- end
-
- def on(date)
- values.find { |v| v.date == date }
- end
-
- def trend
- TimeSeries::Trend.new \
- current: last&.value,
- previous: first&.value,
- series: self
- end
-
- def empty?
- values.empty?
- end
-
- def has_current_day_value?
- values.any? { |v| v.date == Date.current }
- end
-
- # `as_json` returns the data shape used by D3 charts
- def as_json
- {
- values: values.map(&:as_json),
- trend: trend.as_json,
- favorable_direction: favorable_direction
- }.as_json
- end
-
- private
- def initialize_values(data)
- [ nil, *data ].each_cons(2).map do |previous, current|
- TimeSeries::Value.new **current,
- previous_value: previous.try(:[], :value),
- series: self
- end
- end
-end
diff --git a/app/models/time_series/trend.rb b/app/models/time_series/trend.rb
deleted file mode 100644
index c6638cbe..00000000
--- a/app/models/time_series/trend.rb
+++ /dev/null
@@ -1,131 +0,0 @@
-class TimeSeries::Trend
- include ActiveModel::Validations
-
- attr_reader :current, :previous, :favorable_direction
-
- validate :values_must_be_of_same_type, :values_must_be_of_known_type
-
- def initialize(current:, previous:, series: nil, favorable_direction: nil)
- @current = current
- @previous = previous
- @series = series
- @favorable_direction = get_favorable_direction(favorable_direction)
-
- validate!
- end
-
- def direction
- if previous.nil? || current == previous
- "flat"
- elsif current && current > previous
- "up"
- else
- "down"
- end.inquiry
- end
-
- def color
- case direction
- when "up"
- favorable_direction.down? ? red_hex : green_hex
- when "down"
- favorable_direction.down? ? green_hex : red_hex
- else
- gray_hex
- end
- end
-
- def icon
- if direction.flat?
- "minus"
- elsif direction.up?
- "arrow-up"
- else
- "arrow-down"
- end
- end
-
- def value
- if previous.nil?
- current.is_a?(Money) ? Money.new(0, current.currency) : 0
- else
- current - previous
- end
- end
-
- def percent
- if previous.nil? || (previous.zero? && current.zero?)
- 0.0
- elsif previous.zero?
- Float::INFINITY
- else
- change = (current_amount - previous_amount)
- base = previous_amount.to_f
-
- (change / base * 100).round(1).to_f
- end
- end
-
- def as_json
- {
- favorable_direction: favorable_direction,
- direction: direction,
- value: value,
- percent: percent
- }.as_json
- end
-
- private
-
- attr_reader :series
-
- def red_hex
- "#F13636" # red-500
- end
-
- def green_hex
- "#10A861" # green-600
- end
-
- def gray_hex
- "#737373" # gray-500
- end
-
- def values_must_be_of_same_type
- unless current.class == previous.class || [ previous, current ].any?(&:nil?)
- errors.add :current, :must_be_of_the_same_type_as_previous
- errors.add :previous, :must_be_of_the_same_type_as_current
- end
- end
-
- def values_must_be_of_known_type
- unless current.is_a?(Money) || current.is_a?(Numeric) || current.nil?
- errors.add :current, :must_be_of_type_money_numeric_or_nil
- end
-
- unless previous.is_a?(Money) || previous.is_a?(Numeric) || previous.nil?
- errors.add :previous, :must_be_of_type_money_numeric_or_nil
- end
- end
-
- def current_amount
- extract_numeric current
- end
-
- def previous_amount
- extract_numeric previous
- end
-
- def extract_numeric(obj)
- if obj.is_a? Money
- obj.amount
- else
- obj
- end
- end
-
- def get_favorable_direction(favorable_direction)
- direction = favorable_direction.presence || series&.favorable_direction
- (direction.presence_in(TimeSeries::DIRECTIONS) || "up").inquiry
- end
-end
diff --git a/app/models/time_series/value.rb b/app/models/time_series/value.rb
deleted file mode 100644
index 390343e1..00000000
--- a/app/models/time_series/value.rb
+++ /dev/null
@@ -1,46 +0,0 @@
-class TimeSeries::Value
- include Comparable
- include ActiveModel::Validations
-
- attr_reader :value, :date, :original, :trend
-
- validates :date, presence: true
- validate :value_must_be_of_known_type
-
- def initialize(date:, value:, original: nil, series: nil, previous_value: nil)
- @date, @value, @original, @series = date, value, original, series
- @trend = create_trend previous_value
-
- validate!
- end
-
- def <=>(other)
- result = date <=> other.date
- result = value <=> other.value if result == 0
- result
- end
-
- def as_json
- {
- date: date.iso8601,
- value: value.as_json,
- trend: trend.as_json
- }
- end
-
- private
- attr_reader :series
-
- def create_trend(previous_value)
- TimeSeries::Trend.new \
- current: value,
- previous: previous_value,
- series: series
- end
-
- def value_must_be_of_known_type
- unless value.is_a?(Money) || value.is_a?(Numeric)
- errors.add :value, :must_be_a_money_or_numeric
- end
- end
-end
diff --git a/app/models/trend.rb b/app/models/trend.rb
new file mode 100644
index 00000000..33e2014d
--- /dev/null
+++ b/app/models/trend.rb
@@ -0,0 +1,94 @@
+class Trend
+ include ActiveModel::Validations
+
+ DIRECTIONS = %w[up down].freeze
+
+ attr_reader :current, :previous, :favorable_direction
+
+ validates :current, presence: true
+
+ def initialize(current:, previous:, favorable_direction: nil)
+ @current = current
+ @previous = previous || 0
+ @favorable_direction = (favorable_direction.presence_in(DIRECTIONS) || "up").inquiry
+
+ validate!
+ end
+
+ def direction
+ if current == previous
+ "flat"
+ elsif current > previous
+ "up"
+ else
+ "down"
+ end.inquiry
+ end
+
+ def color
+ case direction
+ when "up"
+ favorable_direction.down? ? red_hex : green_hex
+ when "down"
+ favorable_direction.down? ? green_hex : red_hex
+ else
+ gray_hex
+ end
+ end
+
+ def icon
+ if direction.flat?
+ "minus"
+ elsif direction.up?
+ "arrow-up"
+ else
+ "arrow-down"
+ end
+ end
+
+ def value
+ current - previous
+ end
+
+ def percent
+ return 0.0 if previous.zero? && current.zero?
+ return Float::INFINITY if previous.zero?
+
+ change = (current - previous).to_f
+
+ (change / previous.to_f * 100).round(1)
+ end
+
+ def percent_formatted
+ if percent.finite?
+ "#{percent.round(1)}%"
+ else
+ percent > 0 ? "+∞" : "-∞"
+ end
+ end
+
+ def as_json
+ {
+ value: value,
+ percent: percent,
+ percent_formatted: percent_formatted,
+ current: current,
+ previous: previous,
+ color: color,
+ icon: icon
+ }
+ end
+
+ private
+ def red_hex
+ "var(--color-destructive)"
+ end
+
+ def green_hex
+ "var(--color-success)"
+ end
+
+ def gray_hex
+ "var(--color-gray)"
+ end
+end
diff --git a/app/models/value_group.rb b/app/models/value_group.rb
deleted file mode 100644
index 275884b9..00000000
--- a/app/models/value_group.rb
+++ /dev/null
@@ -1,104 +0,0 @@
- class ValueGroup
- attr_accessor :parent, :original
- attr_reader :name, :children, :value, :currency
-
- def initialize(name, currency = Money.default_currency)
- @name = name
- @currency = Money::Currency.new(currency)
- @children = []
- end
-
- def sum
- return value if is_value_node?
- return Money.new(0, currency) if children.empty? && value.nil?
- children.sum(&:sum)
- end
-
- def avg
- return value if is_value_node?
- return Money.new(0, currency) if children.empty? && value.nil?
- leaf_values = value_nodes.map(&:value)
- leaf_values.compact.sum / leaf_values.compact.size
- end
-
- def series
- return @series if is_value_node?
-
- summed_by_date = children.each_with_object(Hash.new(0)) do |child, acc|
- child.series.values.each do |series_value|
- acc[series_value.date] += series_value.value
- end
- end
-
- first_child = children.first
-
- summed_series = summed_by_date.map { |date, value| { date: date, value: value } }
-
- TimeSeries.new(summed_series, favorable_direction: first_child&.series&.favorable_direction || "up")
- end
-
- def series=(series)
- raise "Cannot set series on a non-leaf node" unless is_value_node?
-
- _series = series || TimeSeries.new([])
-
- raise "Series must be an instance of TimeSeries" unless _series.is_a?(TimeSeries)
- raise "Series must contain money values in the node's currency" unless _series.values.all? { |v| v.value.currency == currency }
- @series = _series
- end
-
- def value_nodes
- return [ self ] unless value.nil?
- children.flat_map { |child| child.value_nodes }
- end
-
- def empty?
- value_nodes.empty?
- end
-
- def percent_of_total
- return 100 if parent.nil? || parent.sum.zero?
-
- ((sum / parent.sum) * 100).round(1)
- end
-
- def add_child_group(name, currency = Money.default_currency)
- raise "Cannot add subgroup to node with a value" if is_value_node?
- child = self.class.new(name, currency)
- child.parent = self
- @children << child
- child
- end
-
- def add_value_node(original, value, series = nil)
- raise "Cannot add value node to a non-leaf node" unless can_add_value_node?
- child = self.class.new(original.name)
- child.original = original
- child.value = value
- child.series = series
- child.parent = self
- @children << child
- child
- end
-
- def value=(value)
- raise "Cannot set value on a non-leaf node" unless is_leaf_node?
- raise "Value must be an instance of Money" unless value.is_a?(Money)
- @value = value
- @currency = value.currency
- end
-
- def is_leaf_node?
- children.empty?
- end
-
- def is_value_node?
- value.present?
- end
-
- private
- def can_add_value_node?
- return false if is_value_node?
- children.empty? || children.all?(&:is_value_node?)
- end
- end
diff --git a/app/models/vehicle.rb b/app/models/vehicle.rb
index 70f20457..6ba19540 100644
--- a/app/models/vehicle.rb
+++ b/app/models/vehicle.rb
@@ -12,15 +12,21 @@ class Vehicle < ApplicationRecord
end
def trend
- TimeSeries::Trend.new(current: account.balance_money, previous: first_valuation_amount)
+ Trend.new(current: account.balance_money, previous: first_valuation_amount)
end
- def color
- "#F23E94"
- end
+ class << self
+ def color
+ "#F23E94"
+ end
- def icon
- "car-front"
+ def icon
+ "car-front"
+ end
+
+ def classification
+ "asset"
+ end
end
private
diff --git a/app/views/account/entries/_entry.html.erb b/app/views/account/entries/_entry.html.erb
index 0007f2c6..4bdf42ae 100644
--- a/app/views/account/entries/_entry.html.erb
+++ b/app/views/account/entries/_entry.html.erb
@@ -1,5 +1,4 @@
-<%# locals: (entry:, selectable: true, balance_trend: nil) %>
+<%# locals: (entry:, balance_trend: nil, view_ctx: "global") %>
-<%= turbo_frame_tag dom_id(entry) do %>
- <%= render partial: entry.entryable.to_partial_path, locals: { entry:, selectable:, balance_trend: } %>
-<% end %>
+<%= render partial: entry.entryable.to_partial_path,
+ locals: { entry: entry, balance_trend: balance_trend, view_ctx: view_ctx } %>
diff --git a/app/views/account/entries/_entry_group.html.erb b/app/views/account/entries/_entry_group.html.erb
index beec5893..7a08bcf7 100644
--- a/app/views/account/entries/_entry_group.html.erb
+++ b/app/views/account/entries/_entry_group.html.erb
@@ -1,13 +1,12 @@
-<%# locals: (date:, entries:, content:, selectable:, totals: false) %>
+<%# locals: (date:, entries:, content:, totals: false) %>
+
<div id="entry-group-<%= date %>" class="bg-gray-25 rounded-xl p-1 w-full" data-bulk-select-target="group">
<div class="py-2 px-4 flex items-center justify-between font-medium text-xs text-secondary">
<div class="flex pl-0.5 items-center gap-4">
- <% if selectable %>
<%= check_box_tag "#{date}_entries_selection",
class: ["checkbox checkbox--light", "hidden": entries.size == 0],
id: "selection_entry_#{date}",
data: { action: "bulk-select#toggleGroupSelection" } %>
- <% end %>
<p class="uppercase space-x-1.5">
<%= tag.span I18n.l(date, format: :long) %>
@@ -22,7 +21,7 @@
</div>
<% end %>
</div>
- <div class="bg-white shadow-xs rounded-md border border-alpha-black-25 divide-y divide-alpha-black-50">
+ <div class="bg-white shadow-border-xs rounded-md divide-y divide-alpha-black-50">
<%= content %>
</div>
</div>
diff --git a/app/views/account/entries/_loading.html.erb b/app/views/account/entries/_loading.html.erb
index 7436f568..e5496bb7 100644
--- a/app/views/account/entries/_loading.html.erb
+++ b/app/views/account/entries/_loading.html.erb
@@ -1,4 +1,4 @@
-<div class="bg-white space-y-4 p-5 border border-alpha-black-25 rounded-xl shadow-xs">
+<div class="bg-white space-y-4 p-5 shadow-border-xs rounded-xl">
<div class="p-5 flex justify-center items-center">
<%= tag.p t(".loading"), class: "text-secondary animate-pulse text-sm" %>
</div>
diff --git a/app/views/account/holdings/_cash.html.erb b/app/views/account/holdings/_cash.html.erb
index 0619df7f..235b5128 100644
--- a/app/views/account/holdings/_cash.html.erb
+++ b/app/views/account/holdings/_cash.html.erb
@@ -14,7 +14,7 @@
<div class="col-span-2 flex justify-end items-center gap-2">
<% cash_weight = account.balance.zero? ? 0 : account.cash_balance / account.balance * 100 %>
- <%= render "shared/progress_circle", progress: cash_weight, text_class: "text-blue-500" %>
+ <%= render "shared/progress_circle", progress: cash_weight %>
<%= tag.p number_to_percentage(cash_weight, precision: 1) %>
</div>
diff --git a/app/views/account/holdings/_holding.html.erb b/app/views/account/holdings/_holding.html.erb
index e07fcaac..e0aca801 100644
--- a/app/views/account/holdings/_holding.html.erb
+++ b/app/views/account/holdings/_holding.html.erb
@@ -18,7 +18,7 @@
<div class="col-span-2 flex justify-end items-center gap-2">
<% if holding.weight %>
- <%= render "shared/progress_circle", progress: holding.weight, text_class: "text-blue-500" %>
+ <%= render "shared/progress_circle", progress: holding.weight %>
<%= tag.p number_to_percentage(holding.weight, precision: 1) %>
<% else %>
<%= tag.p "--", class: "text-secondary mb-5" %>
diff --git a/app/views/account/holdings/index.html.erb b/app/views/account/holdings/index.html.erb
index 3c52da53..a4dfeb4d 100644
--- a/app/views/account/holdings/index.html.erb
+++ b/app/views/account/holdings/index.html.erb
@@ -1,5 +1,5 @@
<%= turbo_frame_tag dom_id(@account, "holdings") do %>
- <div class="bg-white space-y-4 p-5 border border-alpha-black-25 rounded-xl shadow-xs">
+ <div class="bg-white space-y-4 p-5 rounded-xl shadow-border-xs">
<div class="flex items-center justify-between">
<%= tag.h2 t(".holdings"), class: "font-medium text-lg" %>
<%= link_to new_account_trade_path(account_id: @account.id),
@@ -20,7 +20,7 @@
<%= tag.p t(".return"), class: "col-span-2 justify-self-end" %>
</div>
- <div class="rounded-lg bg-white border-alpha-black-25 shadow-xs">
+ <div class="rounded-lg bg-white shadow-border-xs">
<% if @account.current_holdings.any? %>
<%= render "account/holdings/cash", account: @account %>
<%= render "account/holdings/ruler" %>
diff --git a/app/views/account/trades/_selection_bar.html.erb b/app/views/account/trades/_selection_bar.html.erb
deleted file mode 100644
index 78d69c45..00000000
--- a/app/views/account/trades/_selection_bar.html.erb
+++ /dev/null
@@ -1,15 +0,0 @@
-<div class="fixed bottom-6 z-10 flex items-center justify-between rounded-xl bg-gray-900 px-4 text-sm text-white w-[420px] py-1.5">
- <div class="flex items-center gap-2">
- <%= check_box_tag "entry_selection", 1, true, class: "checkbox checkbox--dark", data: { action: "bulk-select#deselectAll" } %>
-
- <p data-bulk-select-target="selectionBarText"></p>
- </div>
-
- <div class="flex items-center gap-1 text-secondary">
- <%= form_with url: bulk_delete_account_transactions_path, data: { turbo_confirm: true, turbo_frame: "_top" } do %>
- <button type="button" data-bulk-select-scope-param="bulk_delete" data-action="bulk-select#submitBulkRequest" class="p-1.5 group hover:bg-gray-700 flex items-center justify-center rounded-md" title="Delete">
- <%= lucide_icon "trash-2", class: "w-5 group-hover:text-white" %>
- </button>
- <% end %>
- </div>
-</div>
diff --git a/app/views/account/trades/_trade.html.erb b/app/views/account/trades/_trade.html.erb
index 0f0f54af..3397dfa7 100644
--- a/app/views/account/trades/_trade.html.erb
+++ b/app/views/account/trades/_trade.html.erb
@@ -1,52 +1,50 @@
-<%# locals: (entry:, selectable: true, balance_trend: nil) %>
+<%# locals: (entry:, balance_trend: nil, **) %>
-<% trade, account = entry.account_trade, entry.account %>
+<% trade = entry.entryable %>
-<div class="grid grid-cols-12 items-center <%= entry.excluded ? "text-subdued bg-gray-25" : "text-primary" %> text-sm font-medium p-4">
- <div class="col-span-6 flex items-center gap-4">
- <% if selectable %>
- <%= check_box_tag dom_id(entry, "selection"),
+<%= turbo_frame_tag dom_id(entry) do %>
+ <%= turbo_frame_tag dom_id(trade) do %>
+ <div class="grid grid-cols-12 items-center <%= entry.excluded ? "text-gray-400 bg-gray-25" : "text-primary" %> text-sm font-medium p-4">
+ <div class="col-span-6 flex items-center gap-4">
+ <%= check_box_tag dom_id(entry, "selection"),
class: "checkbox checkbox--light",
data: { id: entry.id, "bulk-select-target": "row", action: "bulk-select#toggleRowSelection" } %>
- <% end %>
- <div class="max-w-full">
- <%= tag.div class: ["flex items-center gap-2"] do %>
- <div class="flex h-8 w-8 shrink-0 items-center justify-center rounded-full bg-gray-600/5 text-gray-600">
- <%= entry.display_name.first.upcase %>
- </div>
+ <div class="max-w-full">
+ <%= tag.div class: ["flex items-center gap-2"] do %>
+ <div class="flex h-8 w-8 shrink-0 items-center justify-center rounded-full bg-gray-600/5 text-gray-600">
+ <%= entry.display_name.first.upcase %>
+ </div>
- <div class="truncate">
- <% if entry.new_record? %>
- <%= content_tag :p, entry.display_name %>
- <% else %>
- <%= link_to entry.display_name,
+ <div class="truncate">
+ <%= link_to entry.display_name,
account_entry_path(entry),
data: { turbo_frame: "drawer", turbo_prefetch: false },
class: "hover:underline hover:text-gray-800" %>
+ </div>
<% end %>
</div>
- <% end %>
- </div>
- </div>
+ </div>
- <div class="col-span-2 flex items-center">
- <%= render "categories/badge", category: trade_category %>
- </div>
+ <div class="col-span-2 flex items-center">
+ <%= render "categories/badge", category: trade_category %>
+ </div>
- <div class="col-span-2 justify-self-end font-medium text-sm">
- <%= content_tag :p,
+ <div class="col-span-2 justify-self-end font-medium text-sm">
+ <%= content_tag :p,
format_money(-entry.amount_money),
class: ["text-green-600": entry.amount.negative?] %>
- </div>
+ </div>
- <div class="col-span-2 justify-self-end">
- <% if balance_trend&.trend %>
- <div class="flex items-center gap-2">
- <%= tag.p format_money(balance_trend.trend.current), class: "font-medium text-sm text-primary" %>
+ <div class="col-span-2 justify-self-end">
+ <% if balance_trend&.trend %>
+ <div class="flex items-center gap-2">
+ <%= tag.p format_money(balance_trend.trend.current), class: "font-medium text-sm text-primary" %>
+ </div>
+ <% else %>
+ <%= tag.p "--", class: "font-medium text-sm text-gray-400" %>
+ <% end %>
</div>
- <% else %>
- <%= tag.p "--", class: "font-medium text-sm text-subdued" %>
- <% end %>
- </div>
-</div>
+ </div>
+ <% end %>
+<% end %>
diff --git a/app/views/account/trades/index.html.erb b/app/views/account/trades/index.html.erb
deleted file mode 100644
index 4427aba1..00000000
--- a/app/views/account/trades/index.html.erb
+++ /dev/null
@@ -1,42 +0,0 @@
-<%= turbo_frame_tag dom_id(@account, "trades") do %>
- <div id="trades" data-controller="bulk-select" data-bulk-select-resource-value="<%= t(".trade") %>" class="bg-white space-y-4 p-5 border border-alpha-black-25 rounded-xl shadow-xs">
- <div class="flex justify-between items-center">
- <h3 class="font-medium text-lg"><%= t(".trades") %></h3>
- <%= link_to new_account_trade_path(@account),
- id: dom_id(@account, "new_trade"),
- class: "flex gap-1 font-medium items-center bg-gray-50 text-primary p-2 rounded-lg",
- data: { turbo_frame: :modal } do %>
- <%= lucide_icon("plus", class: "w-5 h-5 text-primary") %>
- <span class="text-sm"><%= t(".new") %></span>
- <% end %>
- </div>
-
- <div class="bg-gray-25 rounded-xl grid grid-cols-12 items-center uppercase text-xs font-medium text-secondary px-5 py-3">
- <div class="pl-0.5 col-span-6 flex items-center gap-4">
- <%= check_box_tag "selection_entry",
- class: "checkbox checkbox--light",
- data: { action: "bulk-select#togglePageSelection" } %>
- <%= tag.p t(".trade") %>
- </div>
-
- <%= tag.p t(".type"), class: "col-span-3 justify-self-end" %>
- <%= tag.p t(".amount"), class: "col-span-3 justify-self-end" %>
- </div>
-
- <div>
- <div id="transaction-selection-bar" data-bulk-select-target="selectionBar" class="flex justify-center hidden">
- <%= render "selection_bar" %>
- </div>
-
- <% if @entries.empty? %>
- <p class="text-secondary py-4"><%= t(".no_trades") %></p>
- <% else %>
- <div class="space-y-6">
- <%= entries_by_date(@entries) do |entries, _transfers| %>
- <%= render partial: "account/trades/trade", collection: entries, as: :entry %>
- <% end %>
- </div>
- <% end %>
- </div>
- </div>
-<% end %>
diff --git a/app/views/account/transactions/_transaction.html.erb b/app/views/account/transactions/_transaction.html.erb
index 77eb0134..8d589733 100644
--- a/app/views/account/transactions/_transaction.html.erb
+++ b/app/views/account/transactions/_transaction.html.erb
@@ -1,75 +1,98 @@
-<%# locals: (entry:, selectable: true, balance_trend: nil) %>
+<%# locals: (entry:, balance_trend: nil, view_ctx: "global") %>
-<div class="grid grid-cols-12 items-center text-primary text-sm font-medium p-4 <%= @focused_record == entry ? "border border-gray-900 rounded-lg" : "" %>">
- <div class="pr-10 flex items-center gap-4 <%= balance_trend ? "col-span-6" : "col-span-8" %>">
- <% if selectable %>
- <%= check_box_tag dom_id(entry, "selection"),
- disabled: entry.entryable.transfer?,
- class: "checkbox checkbox--light",
- data: { id: entry.id, "bulk-select-target": "row", action: "bulk-select#toggleRowSelection" } %>
- <% end %>
+<% transaction = entry.entryable %>
- <div class="max-w-full">
- <%= content_tag :div, class: ["flex items-center gap-2"] do %>
- <% if entry.entryable.merchant&.icon_url %>
- <%= image_tag entry.entryable.merchant.icon_url, class: "w-6 h-6 rounded-full", loading: "lazy" %>
- <% else %>
- <%= render "shared/circle_logo", name: entry.display_name, size: "sm" %>
- <% end %>
+<%= turbo_frame_tag dom_id(entry) do %>
+ <%= turbo_frame_tag dom_id(transaction) do %>
+ <div class="grid grid-cols-12 items-center text-primary text-sm font-medium p-4
+ <%= @focused_record == entry || @focused_record == transaction ?
+ "border border-gray-900 rounded-lg" : "" %>">
- <div class="truncate">
- <div class="space-y-0.5">
- <div class="flex items-center gap-1">
- <% if entry.new_record? %>
- <%= content_tag :p, entry.display_name %>
- <% else %>
- <%= link_to entry.entryable.transfer? ? entry.entryable.transfer.name : entry.display_name,
- entry.entryable.transfer? ? transfer_path(entry.entryable.transfer) : account_entry_path(entry),
- data: { turbo_frame: "drawer", turbo_prefetch: false },
- class: "hover:underline hover:text-gray-800" %>
- <% end %>
+ <div class="pr-10 flex items-center gap-4
+ <%= balance_trend ? "col-span-6" : "col-span-8" %>">
+ <%= check_box_tag dom_id(entry, "selection"),
+ disabled: transaction.transfer?,
+ class: "checkbox checkbox--light",
+ data: {
+ id: entry.id,
+ "bulk-select-target": "row",
+ action: "bulk-select#toggleRowSelection"
+ } %>
- <% if entry.excluded %>
- <span title="One-time <%= entry.amount.negative? ? "income" : "expense" %> (excluded from averages)">
- <%= lucide_icon "asterisk", class: "w-4 h-4 shrink-0 text-orange-500" %>
- </span>
- <% end %>
+ <div class="max-w-full">
+ <%= content_tag :div, class: ["flex items-center gap-2"] do %>
+ <% if transaction.merchant&.icon_url %>
+ <%= image_tag transaction.merchant.icon_url,
+ class: "w-6 h-6 rounded-full",
+ loading: "lazy" %>
+ <% else %>
+ <%= render "shared/circle_logo",
+ name: entry.display_name,
+ size: "sm" %>
+ <% end %>
- <% if entry.entryable.transfer? %>
- <%= render "account/transactions/transfer_match", entry: entry %>
- <% end %>
- </div>
+ <div class="truncate">
+ <div class="space-y-0.5">
+ <div class="flex items-center gap-1">
+ <%= link_to(
+ transaction.transfer? ? transaction.transfer.name : entry.display_name,
+ transaction.transfer? ? transfer_path(transaction.transfer) : account_entry_path(entry),
+ data: {
+ turbo_frame: "drawer",
+ turbo_prefetch: false
+ },
+ class: "hover:underline hover:text-gray-800"
+ ) %>
+
+ <% if entry.excluded %>
+ <span title="One-time <%= entry.amount.negative? ? "income" : "expense" %> (excluded from averages)">
+ <%= lucide_icon "asterisk", class: "w-4 h-4 shrink-0 text-orange-500" %>
+ </span>
+ <% end %>
+
+ <% if transaction.transfer? %>
+ <%= render "account/transactions/transfer_match", transaction: transaction %>
+ <% end %>
+ </div>
- <div class="text-secondary text-xs font-normal">
- <% if entry.entryable.transfer? %>
- <%= render "transfers/account_links", transfer: entry.entryable.transfer, is_inflow: entry.entryable.transfer_as_inflow.present? %>
- <% else %>
- <%= link_to entry.account.name, account_path(entry.account, tab: "transactions", focused_record_id: entry.id), data: { turbo_frame: "_top" }, class: "hover:underline" %>
- <% end %>
+ <div class="text-secondary text-xs font-normal">
+ <% if transaction.transfer? %>
+ <%= render "transfers/account_links",
+ transfer: transaction.transfer,
+ is_inflow: transaction.transfer_as_inflow.present? %>
+ <% else %>
+ <%= link_to entry.account.name,
+ account_path(entry.account, tab: "transactions", focused_record_id: entry.id),
+ data: { turbo_frame: "_top" },
+ class: "hover:underline" %>
+ <% end %>
+ </div>
+ </div>
</div>
- </div>
+ <% end %>
</div>
- <% end %>
- </div>
- </div>
+ </div>
- <div class="flex items-center gap-1 col-span-2">
- <%= render "account/transactions/transaction_category", entry: entry %>
- </div>
+ <div class="flex items-center gap-1 col-span-2">
+ <%= render "account/transactions/transaction_category", transaction: transaction %>
+ </div>
- <div class="col-span-2 ml-auto">
- <%= content_tag :p,
- format_money(-entry.amount_money),
- class: ["text-green-600": entry.amount.negative?] %>
- </div>
+ <div class="col-span-2 ml-auto">
+ <%= content_tag :p,
+ transaction.transfer? && view_ctx == "global" ? "+/- #{format_money(entry.amount_money.abs)}" : format_money(-entry.amount_money),
+ class: ["text-green-600": entry.amount.negative?] %>
+ </div>
- <% if balance_trend %>
- <div class="col-span-2 justify-self-end">
- <% if balance_trend.trend %>
- <%= tag.p format_money(balance_trend.trend.current), class: "font-medium text-sm text-primary" %>
- <% else %>
- <%= tag.p "--", class: "font-medium text-sm text-subdued" %>
+ <% if balance_trend %>
+ <div class="col-span-2 justify-self-end">
+ <% if balance_trend.trend %>
+ <%= tag.p format_money(balance_trend.trend.current),
+ class: "font-medium text-sm text-primary" %>
+ <% else %>
+ <%= tag.p "--", class: "font-medium text-sm text-gray-400" %>
+ <% end %>
+ </div>
<% end %>
</div>
<% end %>
-</div>
+<% end %>
diff --git a/app/views/account/transactions/_transaction_category.html.erb b/app/views/account/transactions/_transaction_category.html.erb
index 5489d310..933a80fe 100644
--- a/app/views/account/transactions/_transaction_category.html.erb
+++ b/app/views/account/transactions/_transaction_category.html.erb
@@ -1,9 +1,9 @@
-<%# locals: (entry:) %>
+<%# locals: (transaction:) %>
-<div id="<%= dom_id(entry, "category_menu") %>">
- <% if entry.account_transaction.transfer&.categorizable? || entry.account_transaction.transfer.nil? %>
- <%= render "categories/menu", transaction: entry.account_transaction %>
+<div id="<%= dom_id(transaction, "category_menu") %>">
+ <% if transaction.transfer&.categorizable? || transaction.transfer.nil? %>
+ <%= render "categories/menu", transaction: transaction %>
<% else %>
- <%= render "categories/badge", category: entry.account_transaction.transfer&.payment? ? payment_category : transfer_category %>
+ <%= render "categories/badge", category: transaction.transfer&.payment? ? payment_category : transfer_category %>
<% end %>
</div>
diff --git a/app/views/account/transactions/_transfer_match.html.erb b/app/views/account/transactions/_transfer_match.html.erb
index 18665a45..a406e7f4 100644
--- a/app/views/account/transactions/_transfer_match.html.erb
+++ b/app/views/account/transactions/_transfer_match.html.erb
@@ -1,26 +1,26 @@
-<%# locals: (entry:) %>
+<%# locals: (transaction:) %>
-<div id="<%= dom_id(entry, "transfer_match") %>" class="flex items-center gap-1">
- <% if entry.account_transaction.transfer.confirmed? %>
- <span title="<%= entry.account_transaction.transfer.payment? ? "Payment" : "Transfer" %> is confirmed">
+<div id="<%= dom_id(transaction, "transfer_match") %>" class="flex items-center gap-1">
+ <% if transaction.transfer.confirmed? %>
+ <span title="<%= transaction.transfer.payment? ? "Payment" : "Transfer" %> is confirmed">
<%= lucide_icon "link-2", class: "w-4 h-4 text-indigo-600" %>
</span>
- <% elsif entry.account_transaction.transfer.pending? %>
+ <% elsif transaction.transfer.pending? %>
<span class="inline-flex items-center rounded-full bg-indigo-50 px-2 py-0.5 text-xs font-medium text-indigo-700">
Auto-matched
</span>
- <%= button_to transfer_path(entry.account_transaction.transfer, transfer: { status: "confirmed" }),
+ <%= button_to transfer_path(transaction.transfer, transfer: { status: "confirmed" }),
method: :patch,
- class: "text-secondary hover:text-gray-800 flex items-center justify-center",
+ class: "text-secondary hover:text-gray-800 flex items-center justify-center cursor-pointer",
title: "Confirm match" do %>
<%= lucide_icon "check", class: "w-4 h-4 text-indigo-400 hover:text-indigo-600" %>
<% end %>
- <%= button_to transfer_path(entry.account_transaction.transfer, transfer: { status: "rejected" }),
+ <%= button_to transfer_path(transaction.transfer, transfer: { status: "rejected" }),
method: :patch,
data: { turbo: false },
- class: "text-secondary hover:text-gray-800 flex items-center justify-center",
+ class: "text-secondary hover:text-gray-800 flex items-center justify-center cursor-pointer",
title: "Reject match" do %>
<%= lucide_icon "x", class: "w-4 h-4 text-subdued hover:text-gray-600" %>
<% end %>
diff --git a/app/views/account/transactions/bulk_edit.html.erb b/app/views/account/transactions/bulk_edit.html.erb
index 7f462acf..6e7d03e3 100644
--- a/app/views/account/transactions/bulk_edit.html.erb
+++ b/app/views/account/transactions/bulk_edit.html.erb
@@ -1,7 +1,7 @@
<%= turbo_frame_tag "bulk_transaction_edit_drawer" do %>
<dialog data-controller="modal"
data-action="click->modal#clickOutside"
- class="bg-white border border-alpha-black-25 rounded-2xl max-h-[calc(100vh-32px)] max-w-[480px] w-full shadow-xs h-full mt-4 mr-4 ml-auto">
+ class="bg-white shadow-border-xs rounded-2xl max-h-[calc(100vh-32px)] max-w-[480px] w-full mt-4 mr-4 ml-auto">
<%= styled_form_with url: bulk_update_account_transactions_path, scope: "bulk_update", class: "h-full", data: { turbo_frame: "_top" } do |form| %>
<div class="flex h-full flex-col justify-between p-4">
<div>
diff --git a/app/views/account/transactions/index.html.erb b/app/views/account/transactions/index.html.erb
deleted file mode 100644
index 9ae47a15..00000000
--- a/app/views/account/transactions/index.html.erb
+++ /dev/null
@@ -1,32 +0,0 @@
-<%= turbo_frame_tag dom_id(@account, "transactions") do %>
- <div class="bg-white space-y-4 p-5 border border-alpha-black-25 rounded-xl shadow-xs">
- <div class="flex justify-between items-center">
- <h3 class="font-medium text-lg"><%= t(".transactions") %></h3>
- <%= link_to new_account_transaction_path(account_id: @account),
- class: "flex gap-1 font-medium items-center bg-gray-50 text-primary p-2 rounded-lg",
- data: { turbo_frame: :modal } do %>
- <%= lucide_icon("plus", class: "w-5 h-5 text-primary") %>
- <span class="text-sm"><%= t(".new") %></span>
- <% end %>
- </div>
-
- <div id="transactions" data-controller="bulk-select" data-bulk-select-resource-value="<%= t(".transaction") %>">
- <div id="transaction-selection-bar" data-bulk-select-target="selectionBar" class="flex justify-center hidden">
- <%= render "selection_bar" %>
- </div>
-
- <% if @entries.empty? %>
- <p class="text-secondary py-4"><%= t(".no_transactions") %></p>
- <% else %>
- <div class="space-y-6">
- <%= entries_by_date(@entries) do |entries, _transfers| %>
- <%= render entries %>
- <% end %>
- </div>
- <div class="pt-4">
- <%= render "pagination", pagy: @pagy %>
- </div>
- <% end %>
- </div>
- </div>
-<% end %>
diff --git a/app/views/account/valuations/_valuation.html.erb b/app/views/account/valuations/_valuation.html.erb
index f321db74..39e4e0d1 100644
--- a/app/views/account/valuations/_valuation.html.erb
+++ b/app/views/account/valuations/_valuation.html.erb
@@ -1,43 +1,43 @@
-<%# locals: (entry:, selectable: true, balance_trend: nil) %>
+<%# locals: (entry:, balance_trend: nil, **) %>
+
+<% valuation = entry.entryable %>
<% color = balance_trend&.trend&.color || "#D444F1" %>
<% icon = balance_trend&.trend&.icon || "plus" %>
-<div class="p-4 grid grid-cols-12 items-center text-primary text-sm font-medium">
- <div class="col-span-8 flex items-center gap-4">
- <% if selectable %>
- <%= check_box_tag dom_id(entry, "selection"),
+<%= turbo_frame_tag dom_id(entry) do %>
+ <%= turbo_frame_tag dom_id(valuation) do %>
+ <div class="p-4 grid grid-cols-12 items-center text-primary text-sm font-medium">
+ <div class="col-span-8 flex items-center gap-4">
+ <%= check_box_tag dom_id(entry, "selection"),
class: "checkbox checkbox--light",
data: { id: entry.id, "bulk-select-target": "row", action: "bulk-select#toggleRowSelection" } %>
- <% end %>
- <div class="flex items-center gap-3">
- <%= tag.div class: "w-6 h-6 rounded-full p-1.5 flex items-center justify-center", style: mixed_hex_styles(color) do %>
- <%= lucide_icon icon, class: "w-4 h-4 shrink-0" %>
- <% end %>
+ <div class="flex items-center gap-3">
+ <%= tag.div class: "w-6 h-6 rounded-full p-1.5 flex items-center justify-center", style: mixed_hex_styles(color) do %>
+ <%= lucide_icon icon, class: "w-4 h-4 shrink-0" %>
+ <% end %>
- <div class="truncate text-primary">
- <% if entry.new_record? %>
- <%= content_tag :p, entry.display_name %>
- <% else %>
- <%= link_to entry.display_name,
+ <div class="truncate text-primary">
+ <%= link_to entry.display_name,
account_entry_path(entry),
data: { turbo_frame: "drawer", turbo_prefetch: false },
class: "hover:underline hover:text-gray-800" %>
- <% end %>
+ </div>
+ </div>
</div>
- </div>
- </div>
- <div class="col-span-2 justify-self-end font-medium text-sm">
- <% if balance_trend&.trend %>
- <%= tag.span format_money(balance_trend.trend.value), style: "color: #{balance_trend.trend.color}" %>
- <% else %>
- <%= tag.span "--", class: "text-subdued" %>
- <% end %>
- </div>
+ <div class="col-span-2 justify-self-end font-medium text-sm">
+ <% if balance_trend&.trend %>
+ <%= tag.span format_money(balance_trend.trend.value), style: "color: #{balance_trend.trend.color}" %>
+ <% else %>
+ <%= tag.span "--", class: "text-gray-400" %>
+ <% end %>
+ </div>
- <div class="col-span-2 justify-self-end">
- <%= tag.p format_money(entry.amount_money), class: "font-medium text-sm text-primary" %>
- </div>
-</div>
+ <div class="col-span-2 justify-self-end">
+ <%= tag.p format_money(entry.amount_money), class: "font-medium text-sm text-primary" %>
+ </div>
+ </div>
+ <% end %>
+<% end %>
diff --git a/app/views/account/valuations/edit.html.erb b/app/views/account/valuations/edit.html.erb
deleted file mode 100644
index 1e94f516..00000000
--- a/app/views/account/valuations/edit.html.erb
+++ /dev/null
@@ -1,3 +0,0 @@
-<%= turbo_frame_tag dom_id(@entry) do %>
- <%= render "account/valuations/form", entry: @entry %>
-<% end %>
diff --git a/app/views/account/valuations/index.html.erb b/app/views/account/valuations/index.html.erb
index e962209d..0d859559 100644
--- a/app/views/account/valuations/index.html.erb
+++ b/app/views/account/valuations/index.html.erb
@@ -1,5 +1,5 @@
<%= turbo_frame_tag dom_id(@account, "valuations") do %>
- <div class="bg-white space-y-4 p-5 border border-alpha-black-25 rounded-xl shadow-xs">
+ <div class="bg-white space-y-4 p-5 shadow-border-xs rounded-xl">
<div class="flex items-center justify-between">
<%= tag.h2 t(".valuations"), class: "font-medium text-lg" %>
<%= link_to new_account_valuation_path(@account),
@@ -18,7 +18,7 @@
<%= tag.div class: "col-span-1" %>
</div>
- <div class="rounded-lg bg-white border-alpha-black-25 shadow-xs">
+ <div class="rounded-lg bg-white shadow-border-xs">
<%= turbo_frame_tag dom_id(@account.entries.account_valuations.new) %>
<% if @entries.any? %>
diff --git a/app/views/accountable_sparklines/show.html.erb b/app/views/accountable_sparklines/show.html.erb
new file mode 100644
index 00000000..b5a479a8
--- /dev/null
+++ b/app/views/accountable_sparklines/show.html.erb
@@ -0,0 +1,11 @@
+<%= turbo_frame_tag "#{@accountable.model_name.param_key}_sparkline" do %>
+ <div class="flex items-center justify-end gap-1">
+ <div class="w-8 h-3">
+ <%= render "shared/sparkline", id: dom_id(@accountable, :sparkline_chart), series: @series %>
+ </div>
+
+ <%= tag.p @series.trend.percent_formatted,
+ style: "color: #{@series.trend.color}",
+ class: "text-right text-xs font-medium text-primary" %>
+ </div>
+<% end %>
diff --git a/app/views/accounts/_account_list.html.erb b/app/views/accounts/_account_list.html.erb
deleted file mode 100644
index dcd88418..00000000
--- a/app/views/accounts/_account_list.html.erb
+++ /dev/null
@@ -1,61 +0,0 @@
-<%# locals: (group:) -%>
-<% type = Accountable.from_type(group.name) %>
-<% if group && group.children.any? %>
- <% group_trend = group.series.trend %>
-
- <details
- class="mb-1 text-sm group"
- data-controller="account-collapse"
- data-account-collapse-type-value="<%= type %>">
- <summary class="flex gap-4 px-3 py-2 items-center w-full rounded-[10px] font-medium
- hover:bg-gray-100 cursor-pointer">
- <%= lucide_icon("chevron-down",
- class: "hidden group-open:block text-secondary w-5 h-5") %>
- <%= lucide_icon("chevron-right",
- class: "group-open:hidden text-secondary w-5 h-5") %>
-
- <div class="text-left"><%= type.model_name.human %></div>
-
- <div class="ml-auto flex flex-col items-end">
- <p class="text-right"><%= format_money group.sum %></p>
-
- <div class="flex items-center gap-1">
- <div class="h-3 w-8">
- <%= render "shared/sparkline", series: group.series, id: "#{group.name}_sparkline" %>
- </div>
-
- <span class="text-xs" style="color: <%= group_trend.color %>"><%= group_trend.value.positive? ? "+" : "" %><%= group_trend.percent.infinite? ? "∞" : number_to_percentage(group_trend.percent, precision: 0) %></span>
- </div>
- </div>
- </summary>
- <% group.children.sort_by(&:name).each do |account_value_node| %>
- <% account = account_value_node.original %>
- <% account_trend = account_value_node.series.trend %>
- <%= link_to account, class: "flex items-center w-full gap-3 px-3 py-2 mb-1 hover:bg-gray-100 rounded-[10px]" do %>
- <%= render "accounts/logo", account: account, size: "sm" %>
- <div class="overflow-hidden">
- <p class="font-medium truncate"><%= account_value_node.name %></p>
- <% if account.subtype %>
- <p class="text-xs text-secondary"><%= account.subtype&.humanize %></p>
- <% end %>
- </div>
- <div class="flex flex-col items-end font-medium text-right ml-auto">
- <p><%= format_money account.balance_money %></p>
- <div class="flex items-center gap-1">
- <div class="h-3 w-8">
- <%= render "shared/sparkline", series: account_value_node.series, id: dom_id(account, :list_sparkline) %>
- </div>
-
- <span class="text-xs" style="color: <%= account_trend.color %>">
- <%= account_trend.value.positive? ? "+" : "" %><%= account_trend.percent.infinite? ? "∞" : number_to_percentage(account_trend.percent, precision: 0) %>
- </span>
- </div>
- </div>
- <% end %>
- <% end %>
- <%= link_to new_polymorphic_path(type, step: "method_select"), class: "flex items-center min-h-10 gap-4 px-3 py-2 mb-1 text-secondary text-sm font-medium rounded-[10px] hover:bg-gray-100", data: { turbo_frame: "modal" } do %>
- <%= lucide_icon("plus", class: "w-5 h-5") %>
- <%= t(".new_account", type: type.model_name.human.downcase) %>
- <% end %>
- </details>
-<% end %>
diff --git a/app/views/accounts/_account_sidebar_tabs.html.erb b/app/views/accounts/_account_sidebar_tabs.html.erb
new file mode 100644
index 00000000..3bf4d64e
--- /dev/null
+++ b/app/views/accounts/_account_sidebar_tabs.html.erb
@@ -0,0 +1,68 @@
+<%# locals: (family:) %>
+
+<div
+ class="space-y-3"
+ data-controller="tabs"
+ data-tabs-local-storage-key-value="account-sidebar-tabs"
+ data-tabs-active-class="bg-white shadow-sm text-primary"
+ data-tabs-inactive-class="text-secondary"
+ data-tabs-default-tab-value="assets-tab">
+ <div class="bg-surface-inset rounded-lg p-1 flex">
+ <button type="button" data-id="assets-tab" class="w-1/3 px-2 py-1 rounded-md text-sm text-secondary" data-tabs-target="btn" data-action="click->tabs#select">
+ Assets
+ </button>
+
+ <button type="button" data-id="debts-tab" class="w-1/3 px-2 py-1 rounded-md text-secondary text-sm" data-tabs-target="btn" data-action="click->tabs#select">
+ Debts
+ </button>
+
+ <button type="button" data-id="all-tab" class="w-1/3 px-2 py-1 rounded-md text-secondary text-sm" data-tabs-target="btn" data-action="click->tabs#select">
+ All
+ </button>
+ </div>
+
+ <div data-tabs-target="tab" id="assets-tab">
+ <%= link_to new_account_path(step: "method_select"),
+ class: "flex items-center gap-3 btn btn--ghost text-secondary mb-1",
+ data: { turbo_frame: "modal" } do %>
+ <%= icon("plus") %>
+ <span>New asset</span>
+ <% end %>
+
+ <div class="space-y-2">
+ <% family.balance_sheet.account_groups("asset").each do |group| %>
+ <%= render "accounts/accountable_group", account_group: group %>
+ <% end %>
+ </div>
+ </div>
+
+ <div data-tabs-target="tab" id="debts-tab" class="hidden">
+ <%= link_to new_account_path(step: "method_select"),
+ class: "flex items-center gap-3 btn btn--ghost text-secondary mb-1",
+ data: { turbo_frame: "modal" } do %>
+ <%= icon("plus") %>
+ <span>New debt</span>
+ <% end %>
+
+ <div class="space-y-2">
+ <% family.balance_sheet.account_groups("liability").each do |group| %>
+ <%= render "accounts/accountable_group", account_group: group %>
+ <% end %>
+ </div>
+ </div>
+
+ <div data-tabs-target="tab" id="all-tab" class="hidden">
+ <%= link_to new_account_path(step: "method_select"),
+ class: "flex items-center gap-3 btn btn--ghost text-secondary mb-1",
+ data: { turbo_frame: "modal" } do %>
+ <%= icon("plus") %>
+ <span>New account</span>
+ <% end %>
+
+ <div class="space-y-2">
+ <% family.balance_sheet.account_groups.each do |group| %>
+ <%= render "accounts/accountable_group", account_group: group %>
+ <% end %>
+ </div>
+ </div>
+</div>
diff --git a/app/views/accounts/_account_type.html.erb b/app/views/accounts/_account_type.html.erb
index d8b104db..4ff07990 100644
--- a/app/views/accounts/_account_type.html.erb
+++ b/app/views/accounts/_account_type.html.erb
@@ -5,5 +5,5 @@
<span style="background-color: color-mix(in srgb, <%= accountable.color %> 10%, white);" class="flex w-8 h-8 shrink-0 grow-0 items-center justify-center rounded-lg border border-alpha-black-25">
<%= lucide_icon(accountable.icon, style: "color: #{accountable.color}", class: "w-5 h-5") %>
</span>
- <%= accountable.model_name.human %>
+ <%= accountable.display_name.singularize %>
<% end %>
diff --git a/app/views/accounts/_accountable_group.html.erb b/app/views/accounts/_accountable_group.html.erb
new file mode 100644
index 00000000..c5b4e90e
--- /dev/null
+++ b/app/views/accounts/_accountable_group.html.erb
@@ -0,0 +1,49 @@
+<%# locals: (account_group:) %>
+
+<details class="group" data-controller="account-collapse" data-account-collapse-type-value="<%= account_group.key %>">
+ <summary class="px-3 py-2 flex items-center gap-3 cursor-pointer h-10 mb-1">
+ <%= lucide_icon("chevron-right", class: "group-open:rotate-90 text-secondary w-5 h-5") %>
+
+ <%= tag.p account_group.name, class: "text-sm font-medium" %>
+
+ <div class="ml-auto text-right grow">
+ <%= tag.p format_money(account_group.total_money), class: "text-sm font-medium text-primary" %>
+
+ <%= turbo_frame_tag "#{account_group.key}_sparkline", src: accountable_sparkline_path(account_group.key), loading: "lazy" do %>
+ <div class="flex items-center w-8 h-4 ml-auto">
+ <div class="w-6 h-px bg-gray-200"></div>
+ </div>
+ <% end %>
+ </div>
+ </summary>
+
+ <div class="space-y-1">
+ <% account_group.accounts.each do |account| %>
+ <%= link_to account_path(account), class: "block flex items-center gap-2 btn btn--ghost" do %>
+ <%= render "accounts/logo", account: account, size: "sm", color: account_group.color %>
+
+ <div>
+ <%= tag.p account.name, class: "text-sm font-medium mb-0.5" %>
+ <%= tag.p account.subtype&.humanize.presence || account_group.name, class: "text-sm text-secondary" %>
+ </div>
+
+ <div class="ml-auto text-right grow h-10">
+ <%= tag.p format_money(account.balance_money), class: "text-sm font-medium text-primary" %>
+
+ <%= turbo_frame_tag dom_id(account, :sparkline), src: sparkline_account_path(account), loading: "lazy" do %>
+ <div class="flex items-center w-8 h-5 ml-auto">
+ <div class="w-6 h-px bg-gray-200"></div>
+ </div>
+ <% end %>
+ </div>
+ <% end %>
+ <% end %>
+ </div>
+
+ <%= link_to new_polymorphic_path(account_group.key, step: "method_select"),
+ class: "flex items-center gap-3 btn btn--ghost text-secondary",
+ data: { turbo_frame: "modal" } do %>
+ <%= icon("plus") %>
+ <span>New <%= account_group.name.downcase.singularize %></span>
+ <% end %>
+</details>
diff --git a/app/views/accounts/_logo.html.erb b/app/views/accounts/_logo.html.erb
index 0d6b969d..e9bd7cde 100644
--- a/app/views/accounts/_logo.html.erb
+++ b/app/views/accounts/_logo.html.erb
@@ -1,4 +1,4 @@
-<%# locals: (account:, size: "md") %>
+<%# locals: (account:, size: "md", color: nil) %>
<% size_classes = {
"sm" => "w-6 h-6",
@@ -12,5 +12,5 @@
<% elsif account.logo.attached? %>
<%= image_tag account.logo, class: "rounded-full #{size_classes[size]}" %>
<% else %>
- <%= circle_logo(account.name, hex: account.accountable.color, size: size) %>
+ <%= circle_logo(account.name, hex: color || account.accountable.color, size: size) %>
<% end %>
diff --git a/app/views/accounts/chart.html.erb b/app/views/accounts/chart.html.erb
index 153924ca..f71750e9 100644
--- a/app/views/accounts/chart.html.erb
+++ b/app/views/accounts/chart.html.erb
@@ -1,5 +1,5 @@
-<% period = Period.from_param(params[:period]) %>
-<% series = @account.series(period: period) %>
+<% period = Period.from_key(params[:period], fallback: true) %>
+<% series = @account.balance_series(period: period) %>
<% trend = series.trend %>
<%= turbo_frame_tag dom_id(@account, :chart_details) do %>
@@ -13,23 +13,19 @@
<% end %>
<% end %>
- <%= tag.span period_label(period), class: "text-secondary" %>
+ <%= tag.span period.comparison_label, class: "text-secondary" %>
</div>
<div class="h-64">
- <% if series.has_current_day_value? %>
+ <% if series.any? %>
<div
id="lineChart"
class="w-full h-full"
data-controller="time-series-chart"
data-time-series-chart-data-value="<%= series.to_json %>"></div>
- <% elsif series.empty? %>
- <div class="w-full h-full flex items-center justify-center">
- <p class="text-secondary text-sm">No data available for the selected period.</p>
- </div>
<% else %>
<div class="w-full h-full flex items-center justify-center">
- <p class="text-secondary text-sm animate-pulse">Calculating latest balance data...</p>
+ <p class="text-secondary text-sm">No data available for the selected period.</p>
</div>
<% end %>
</div>
diff --git a/app/views/accounts/index.html.erb b/app/views/accounts/index.html.erb
index f0f39f12..7d2eb4f7 100644
--- a/app/views/accounts/index.html.erb
+++ b/app/views/accounts/index.html.erb
@@ -1,43 +1,35 @@
-<% content_for :sidebar do %>
- <%= render "settings/nav" %>
-<% end %>
-
-<div class="space-y-4">
- <header class="flex justify-between items-center text-primary font-medium">
- <h1 class="text-xl"><%= t(".accounts") %></h1>
- <div class="flex items-center gap-5">
- <div class="flex items-center gap-2">
- <%= button_to sync_all_accounts_path,
+<header class="flex justify-between items-center text-primary font-medium">
+ <h1 class="text-xl"><%= t(".accounts") %></h1>
+ <div class="flex items-center gap-5">
+ <div class="flex items-center gap-2">
+ <%= button_to sync_all_accounts_path,
disabled: Current.family.syncing?,
class: "btn btn--outline flex items-center gap-2",
title: t(".sync") do %>
- <%= lucide_icon "refresh-cw", class: "w-5 h-5" %>
- <span><%= t(".sync") %></span>
- <% end %>
+ <%= lucide_icon "refresh-cw", class: "w-5 h-5" %>
+ <span><%= t(".sync") %></span>
+ <% end %>
- <%= link_to new_account_path(return_to: accounts_path),
+ <%= link_to new_account_path(return_to: accounts_path),
data: { turbo_frame: "modal" },
class: "btn btn--primary flex items-center gap-1" do %>
- <%= lucide_icon("plus", class: "w-5 h-5") %>
- <p class="text-sm font-medium"><%= t(".new_account") %></p>
- <% end %>
- </div>
- </div>
- </header>
-
- <% if @manual_accounts.empty? && @plaid_items.empty? %>
- <%= render "empty" %>
- <% else %>
- <div class="space-y-2">
- <% if @plaid_items.any? %>
- <%= render @plaid_items.sort_by(&:created_at) %>
- <% end %>
-
- <% if @manual_accounts.any? %>
- <%= render "accounts/index/manual_accounts", accounts: @manual_accounts %>
+ <%= lucide_icon("plus", class: "w-5 h-5") %>
+ <p class="text-sm font-medium"><%= t(".new_account") %></p>
<% end %>
</div>
- <% end %>
+ </div>
+</header>
- <%= settings_nav_footer %>
-</div>
+<% if @manual_accounts.empty? && @plaid_items.empty? %>
+ <%= render "empty" %>
+<% else %>
+ <div class="space-y-2">
+ <% if @plaid_items.any? %>
+ <%= render @plaid_items.sort_by(&:created_at) %>
+ <% end %>
+
+ <% if @manual_accounts.any? %>
+ <%= render "accounts/index/manual_accounts", accounts: @manual_accounts %>
+ <% end %>
+ </div>
+<% end %>
diff --git a/app/views/accounts/index/_account_groups.erb b/app/views/accounts/index/_account_groups.erb
index 3137e477..a5665690 100644
--- a/app/views/accounts/index/_account_groups.erb
+++ b/app/views/accounts/index/_account_groups.erb
@@ -3,7 +3,7 @@
<% accounts.group_by(&:accountable_type).sort_by { |group, _| group }.each do |group, accounts| %>
<div class="bg-gray-25 p-1 rounded-xl">
<div class="flex items-center px-4 py-2 text-xs font-medium text-secondary">
- <p><%= to_accountable_title(Accountable.from_type(group)) %></p>
+ <p><%= Accountable.from_type(group).display_name %></p>
<span class="text-subdued mx-2">&middot;</span>
<p><%= accounts.count %></p>
<p class="ml-auto"><%= totals_by_currency(collection: accounts, money_method: :balance_money) %></p>
diff --git a/app/views/accounts/index/_manual_accounts.html.erb b/app/views/accounts/index/_manual_accounts.html.erb
index 3e113b89..9f3d34ed 100644
--- a/app/views/accounts/index/_manual_accounts.html.erb
+++ b/app/views/accounts/index/_manual_accounts.html.erb
@@ -1,6 +1,6 @@
<%# locals: (accounts:) %>
-<details open class="group bg-white p-4 border border-alpha-black-25 shadow-xs rounded-xl">
+<details open class="group bg-white p-4 shadow-border-xs rounded-xl">
<summary class="flex items-center gap-2 focus-visible:outline-hidden">
<%= lucide_icon "chevron-right", class: "group-open:transform group-open:rotate-90 text-secondary w-5" %>
diff --git a/app/views/accounts/list.html.erb b/app/views/accounts/list.html.erb
deleted file mode 100644
index 6075fd14..00000000
--- a/app/views/accounts/list.html.erb
+++ /dev/null
@@ -1,5 +0,0 @@
-<%= turbo_frame_tag "account-list" do %>
- <% account_groups(period: @period).each do |group| %>
- <%= render "accounts/account_list", group: group %>
- <% end %>
-<% end %>
diff --git a/app/views/accounts/show/_activity.html.erb b/app/views/accounts/show/_activity.html.erb
index eb593e74..e882e4c6 100644
--- a/app/views/accounts/show/_activity.html.erb
+++ b/app/views/accounts/show/_activity.html.erb
@@ -1,7 +1,7 @@
<%# locals: (account:) %>
<%= turbo_frame_tag dom_id(account, "entries") do %>
- <div class="bg-white p-5 border border-alpha-black-25 rounded-xl shadow-xs" data-controller="focus-record" data-focus-record-id-value="<%= @focused_record ? dom_id(@focused_record) : nil %>">
+ <div class="bg-white p-5 shadow-border-xs rounded-xl" data-controller="focus-record" data-focus-record-id-value="<%= @focused_record ? dom_id(@focused_record) : nil %>">
<div class="flex items-center justify-between mb-4">
<%= tag.h2 t(".title"), class: "font-medium text-lg" %>
<% unless @account.plaid_account_id.present? %>
@@ -77,16 +77,16 @@
<div class="rounded-tl-lg rounded-tr-lg bg-white border-alpha-black-25 shadow-xs">
<div class="space-y-4">
<% calculator = Account::BalanceTrendCalculator.for(@entries) %>
- <%= entries_by_date(@entries) do |entries, _transfers| %>
+ <%= entries_by_date(@entries) do |entries| %>
<% entries.each do |entry| %>
- <%= render entry, balance_trend: calculator&.trend_for(entry) %>
+ <%= render entry, balance_trend: calculator&.trend_for(entry), view_ctx: "account" %>
<% end %>
<% end %>
</div>
</div>
<div class="p-4 bg-white rounded-bl-lg rounded-br-lg">
- <%= render "pagination", pagy: @pagy %>
+ <%= render "shared/pagination", pagy: @pagy %>
</div>
</div>
<% end %>
diff --git a/app/views/accounts/show/_chart.html.erb b/app/views/accounts/show/_chart.html.erb
index c1f06dd6..2b0ee941 100644
--- a/app/views/accounts/show/_chart.html.erb
+++ b/app/views/accounts/show/_chart.html.erb
@@ -1,6 +1,6 @@
<%# locals: (account:, title: nil, tooltip: nil, **args) %>
-<% period = Period.from_param(params[:period]) %>
+<% period = Period.from_key(params[:period], fallback: true) %>
<% default_value_title = account.asset? ? t(".balance") : t(".owed") %>
<div id="<%= dom_id(account, :chart) %>" class="bg-white shadow-xs rounded-xl border border-alpha-black-25 rounded-lg space-y-2">
@@ -15,11 +15,11 @@
</div>
<%= form_with url: request.path, method: :get, data: { controller: "auto-submit-form" } do |form| %>
- <%= period_select form: form, selected: period.name %>
+ <%= period_select form: form, selected: period %>
<% end %>
</div>
- <%= turbo_frame_tag dom_id(account, :chart_details), src: chart_account_path(account, period: period.name) do %>
+ <%= turbo_frame_tag dom_id(account, :chart_details), src: chart_account_path(account, period: period.key) do %>
<%= render "accounts/chart_loader" %>
<% end %>
</div>
diff --git a/app/views/accounts/show/_template.html.erb b/app/views/accounts/show/_template.html.erb
index 7d17e80c..5bc44376 100644
--- a/app/views/accounts/show/_template.html.erb
+++ b/app/views/accounts/show/_template.html.erb
@@ -3,7 +3,7 @@
<%= turbo_stream_from account %>
<%= turbo_frame_tag dom_id(account) do %>
- <%= tag.div class: "space-y-4" do %>
+ <%= tag.div class: "space-y-4 pb-32" do %>
<% if header.present? %>
<%= header %>
<% else %>
diff --git a/app/views/accounts/sparkline.html.erb b/app/views/accounts/sparkline.html.erb
new file mode 100644
index 00000000..b4e587fb
--- /dev/null
+++ b/app/views/accounts/sparkline.html.erb
@@ -0,0 +1,11 @@
+<%= turbo_frame_tag dom_id(@account, :sparkline) do %>
+ <div class="flex items-center justify-end gap-1">
+ <div class="w-8 h-5">
+ <%= render "shared/sparkline", id: dom_id(@account, :sparkline_chart), series: @account.sparkline_series %>
+ </div>
+
+ <%= tag.p @account.sparkline_series.trend.percent_formatted,
+ style: "color: #{@account.sparkline_series.trend.color}",
+ class: "text-right text-xs font-medium text-primary" %>
+ </div>
+<% end %>
diff --git a/app/views/accounts/summary.html.erb b/app/views/accounts/summary.html.erb
deleted file mode 100644
index 098b67c6..00000000
--- a/app/views/accounts/summary.html.erb
+++ /dev/null
@@ -1,92 +0,0 @@
-<% period = Period.from_param(params[:period]) %>
-
-<div class="space-y-4">
-
- <%= render "accounts/summary/header" %>
-
- <div class="bg-white rounded-xl shadow-xs border border-tertiary flex divide-x divide-gray-200">
- <div class="w-1/2 p-4 flex items-stretch justify-between">
- <div class="space-y-2 grow">
- <%= render partial: "shared/value_heading", locals: {
- label: "Assets",
- period: period,
- value: Current.family.assets,
- trend: @asset_series.trend
- } %>
- </div>
- <div
- id="assetsChart"
- class="h-full w-2/5"
- data-controller="time-series-chart"
- data-time-series-chart-data-value="<%= @asset_series.to_json %>"
- data-time-series-chart-use-labels-value="false"></div>
- </div>
- <div class="w-1/2 p-4 flex items-stretch justify-between">
- <div class="space-y-2 grow">
- <%= render partial: "shared/value_heading", locals: {
- label: "Liabilities",
- period: period,
- size: "md",
- value: Current.family.liabilities,
- trend: @liability_series.trend
- } %>
- </div>
- <div
- id="liabilitiesChart"
- class="h-full w-2/5"
- data-controller="time-series-chart"
- data-time-series-chart-data-value="<%= @liability_series.to_json %>"
- data-time-series-chart-use-labels-value="false"></div>
- </div>
- </div>
- <div class="p-4 bg-white rounded-xl shadow-xs border border-alpha-black-25 space-y-4">
- <div class="flex justify-between items-center mb-5">
- <h2 class="text-lg font-medium text-primary">Assets</h2>
- <div class="flex items-center gap-2">
- <%= link_to new_account_path, class: "btn btn--secondary flex items-center gap-1", data: { turbo_frame: "modal" } do %>
- <%= lucide_icon("plus", class: "w-5 h-5 text-secondary") %>
- <p><%= t(".new") %></p>
- <% end %>
- <%= form_with url: summary_accounts_path, method: :get, data: { controller: "auto-submit-form" } do |form| %>
- <%= period_select form: form, selected: period.name %>
- <% end %>
- </div>
- </div>
-
- <% if @account_groups[:assets].children.any? %>
- <%= render partial: "pages/account_percentages_bar", locals: { account_groups: @account_groups[:assets].children } %>
- <%= render partial: "pages/account_percentages_table", locals: { account_groups: @account_groups[:assets].children } %>
- <% else %>
- <div class="py-20 flex flex-col items-center">
- <%= lucide_icon "blocks", class: "w-6 h-6 shrink-0 text-secondary" %>
- <p class="text-primary text-sm font-medium mb-1 mt-4"><%= t(".no_assets") %></p>
- <p class="text-secondary text-sm max-w-xs text-center"><%= t(".no_assets_description") %></p>
- </div>
- <% end %>
- </div>
- <div class="p-4 bg-white rounded-xl shadow-xs border border-alpha-black-25 space-y-4">
- <div class="flex justify-between items-center mb-5">
- <h2 class="text-lg font-medium text-primary">Liabilities</h2>
- <div class="flex items-center gap-2">
- <%= link_to new_account_path, class: "btn btn--secondary flex items-center gap-1", data: { turbo_frame: "modal" } do %>
- <%= lucide_icon("plus", class: "w-5 h-5 text-secondary") %>
- <p><%= t(".new") %></p>
- <% end %>
- <%= form_with url: summary_accounts_path, method: :get, data: { controller: "auto-submit-form" } do |form| %>
- <%= period_select form: form, selected: period.name %>
- <% end %>
- </div>
- </div>
-
- <% if @account_groups[:liabilities].children.any? %>
- <%= render partial: "pages/account_percentages_bar", locals: { account_groups: @account_groups[:liabilities].children } %>
- <%= render partial: "pages/account_percentages_table", locals: { account_groups: @account_groups[:liabilities].children } %>
- <% else %>
- <div class="py-20 flex flex-col items-center">
- <%= lucide_icon "scale", class: "w-6 h-6 shrink-0 text-secondary" %>
- <p class="text-primary text-sm font-medium mb-1 mt-4"><%= t(".no_liabilities") %></p>
- <p class="text-secondary text-sm max-w-xs text-center"><%= t(".no_liabilities_description") %></p>
- </div>
- <% end %>
- </div>
-</div>
diff --git a/app/views/accounts/summary/_header.html.erb b/app/views/accounts/summary/_header.html.erb
deleted file mode 100644
index 1cf47f07..00000000
--- a/app/views/accounts/summary/_header.html.erb
+++ /dev/null
@@ -1,21 +0,0 @@
-<header class="flex justify-between items-center text-primary font-medium">
- <h1 class="text-xl"><%= t(".accounts") %></h1>
-
- <div class="flex items-center gap-2">
- <%= contextual_menu do %>
- <div class="w-48 p-1 text-sm leading-6 text-primary bg-white shadow-lg shrink rounded-xl ring-1 ring-gray-900/5">
- <%= link_to accounts_path(return_to: summary_accounts_path),
- class: "block w-full py-2 px-3 space-x-2 text-primary hover:bg-gray-50 flex items-center rounded-lg font-normal" do %>
- <%= lucide_icon "settings", class: "w-5 h-5 text-secondary" %>
- <span class="text-black"><%= t(".manage") %></span>
- <% end %>
- </div>
-
- <% end %>
-
- <%= link_to new_account_path, class: "rounded-lg bg-gray-900 text-white flex items-center gap-1 justify-center hover:bg-gray-700 px-3 py-2", data: { turbo_frame: :modal } do %>
- <%= lucide_icon("plus", class: "w-5 h-5") %>
- <p class="text-sm font-medium"><%= t(".new") %></p>
- <% end %>
- </div>
-</header>
diff --git a/app/views/budget_categories/_budget_category.html.erb b/app/views/budget_categories/_budget_category.html.erb
index 888d6daf..2528b89e 100644
--- a/app/views/budget_categories/_budget_category.html.erb
+++ b/app/views/budget_categories/_budget_category.html.erb
@@ -32,7 +32,7 @@
<% end %>
<% else %>
<p class="text-sm text-secondary font-medium">
- <%= format_money(budget_category.category.avg_monthly_total_money, precision: 0) %> avg
+ <%= budget_category.median_monthly_expense_money.format %> avg
</p>
<% end %>
</div>
diff --git a/app/views/budget_categories/_budget_category_form.html.erb b/app/views/budget_categories/_budget_category_form.html.erb
index ee67345d..0c4561cd 100644
--- a/app/views/budget_categories/_budget_category_form.html.erb
+++ b/app/views/budget_categories/_budget_category_form.html.erb
@@ -2,13 +2,13 @@
<% currency = Money::Currency.new(budget_category.budget.currency) %>
-<div id=<%= dom_id(budget_category, :form) %> class="w-full flex gap-3">
+<div id="<%= dom_id(budget_category, :form) %>" class="w-full flex gap-3">
<div class="w-1 h-3 rounded-xl mt-1" style="background-color: <%= budget_category.category.color %>"></div>
<div class="text-sm mr-3">
<p class="text-primary font-medium mb-0.5"><%= budget_category.category.name %></p>
- <p class="text-secondary"><%= format_money(budget_category.category.avg_monthly_total_money, precision: 0) %>/m average</p>
+ <p class="text-secondary"><%= budget_category.median_monthly_expense_money.format(precision: 0) %>/m avg</p>
</div>
<div class="ml-auto">
diff --git a/app/views/budget_categories/_confirm_button.html.erb b/app/views/budget_categories/_confirm_button.html.erb
index 6b473633..6c949eae 100644
--- a/app/views/budget_categories/_confirm_button.html.erb
+++ b/app/views/budget_categories/_confirm_button.html.erb
@@ -8,4 +8,4 @@
Confirm
</span>
<% end %>
-</div>
\ No newline at end of file
+</div>
diff --git a/app/views/budget_categories/_uncategorized_budget_category_form.html.erb b/app/views/budget_categories/_uncategorized_budget_category_form.html.erb
index 70c887e3..13b303e2 100644
--- a/app/views/budget_categories/_uncategorized_budget_category_form.html.erb
+++ b/app/views/budget_categories/_uncategorized_budget_category_form.html.erb
@@ -7,7 +7,7 @@
<div class="text-sm mr-3">
<p class="text-primary font-medium mb-0.5"><%= budget_category.category.name %></p>
- <p class="text-secondary"><%= format_money(Money.new(budget_category.category.avg_monthly_total, budget_category.category.family.currency), precision: 0) %>/m average</p>
+ <p class="text-secondary"><%= budget_category.avg_monthly_expense_money.format(precision: 0) %>/m avg</p>
</div>
<div class="ml-auto">
diff --git a/app/views/budget_categories/index.html.erb b/app/views/budget_categories/index.html.erb
index db03a5a5..93d1f2a9 100644
--- a/app/views/budget_categories/index.html.erb
+++ b/app/views/budget_categories/index.html.erb
@@ -16,7 +16,7 @@
<div class="mx-auto max-w-lg">
<% if @budget.family.categories.empty? %>
- <div class="bg-white shadow-xs border border-gray-200 rounded-lg p-4">
+ <div class="bg-white shadow-border-xs rounded-lg p-4">
<%= render "budget_categories/no_categories" %>
</div>
<% else %>
diff --git a/app/views/budget_categories/show.html.erb b/app/views/budget_categories/show.html.erb
index b7f891f8..cf6bb5a8 100644
--- a/app/views/budget_categories/show.html.erb
+++ b/app/views/budget_categories/show.html.erb
@@ -4,7 +4,7 @@
<div>
<p class="text-sm text-secondary">Category</p>
<h3 class="text-2xl font-medium text-primary">
- <%= @budget_category.category.name %>
+ <%= @budget_category.name %>
</h3>
<% if @budget_category.budget.initialized? %>
@@ -80,14 +80,14 @@
<div class="flex items-center justify-between text-sm">
<dt class="text-secondary">Monthly average spending</dt>
<dd class="text-primary font-medium">
- <%= format_money @budget_category.category.avg_monthly_total_money, precision: 0 %>
+ <%= @budget_category.avg_monthly_expense_money.format %>
</dd>
</div>
<div class="flex items-center justify-between text-sm">
<dt class="text-secondary">Monthly median spending</dt>
<dd class="text-primary font-medium">
- <%= format_money @budget_category.category.median_monthly_total_money, precision: 0 %>
+ <%= @budget_category.median_monthly_expense_money.format %>
</dd>
</div>
</dl>
@@ -106,7 +106,7 @@
<div class="px-3 py-4 space-y-2">
<% if @recent_transactions.any? %>
<ul class="space-y-2 mb-4">
- <% @recent_transactions.each_with_index do |entry, index| %>
+ <% @recent_transactions.each_with_index do |transaction, index| %>
<li class="flex gap-4 text-sm space-y-1">
<div class="flex flex-col items-center gap-1.5 pt-2">
<div class="rounded-full h-1.5 w-1.5 bg-gray-300"></div>
@@ -118,12 +118,15 @@
<div class="flex justify-between w-full">
<div>
<p class="text-secondary text-xs uppercase">
- <%= entry.date.strftime("%b %d") %>
+ <%= transaction.entry.date.strftime("%b %d") %>
</p>
- <p class="text-primary"><%= entry.name %></p>
+ <%= link_to transaction.entry.name,
+ transactions_path(focused_record_id: transaction.id),
+ class: "text-primary hover:underline",
+ data: { turbo_frame: :_top } %>
</div>
<p class="text-primary font-medium">
- <%= format_money entry.amount_money %>
+ <%= format_money transaction.entry.amount_money %>
</p>
</div>
</li>
@@ -132,7 +135,7 @@
<%= link_to "View all category transactions",
transactions_path(q: {
- categories: [@budget_category.category.name],
+ categories: [@budget_category.name],
start_date: @budget.start_date,
end_date: @budget.end_date
}),
diff --git a/app/views/budget_categories/update.turbo_stream.erb b/app/views/budget_categories/update.turbo_stream.erb
index 34313156..bf44fea3 100644
--- a/app/views/budget_categories/update.turbo_stream.erb
+++ b/app/views/budget_categories/update.turbo_stream.erb
@@ -4,16 +4,15 @@
<%= turbo_stream.replace dom_id(@budget, :confirm_button), partial: "budget_categories/confirm_button", locals: { budget: @budget } %>
-
<% if @budget_category.subcategory? %>
<%# Update sibling subcategories when a subcategory changes %>
<% @budget_category.siblings.each do |sibling| %>
<%= turbo_stream.update dom_id(sibling, :form), partial: "budget_categories/budget_category_form", locals: { budget_category: sibling } %>
<% end %>
-
+
<% else %>
<%# Update all subcategories when a parent category changes %>
<% @budget_category.subcategories.each do |subcategory| %>
<%= turbo_stream.update dom_id(subcategory, :form), partial: "budget_categories/budget_category_form", locals: { budget_category: subcategory } %>
<% end %>
-<% end %>
\ No newline at end of file
+<% end %>
diff --git a/app/views/budgets/_actuals_summary.html.erb b/app/views/budgets/_actuals_summary.html.erb
index 67cac86b..40da0743 100644
--- a/app/views/budgets/_actuals_summary.html.erb
+++ b/app/views/budgets/_actuals_summary.html.erb
@@ -4,26 +4,24 @@
<div class="p-4 border-b border-gray-100">
<h3 class="text-sm text-secondary mb-2">Income</h3>
- <% income_totals = budget.income_categories_with_totals %>
- <% income_categories = income_totals.category_totals.reject { |ct| ct.amount_money.zero? }.sort_by { |ct| ct.percentage }.reverse %>
<span class="inline-block mb-2 text-xl font-medium text-primary">
- <%= format_money(income_totals.total_money) %>
+ <%= budget.actual_income_money.format %>
</span>
- <% if income_categories.any? %>
+ <% if budget.income_category_totals.any? %>
<div>
<div class="flex h-1.5 mb-3 gap-1">
- <% income_categories.each do |item| %>
- <div class="h-full rounded-xs" style="background-color: <%= item.category.color %>; width: <%= item.percentage %>%"></div>
+ <% budget.income_category_totals.each do |category_total| %>
+ <div class="h-full rounded-xs" style="background-color: <%= category_total.category.color %>; width: <%= category_total.weight %>%"></div>
<% end %>
</div>
<div class="flex flex-wrap gap-x-2.5 gap-y-1 text-xs">
- <% income_categories.each do |item| %>
+ <% budget.income_category_totals.each do |category_total| %>
<div class="flex items-center gap-1.5">
- <div class="w-2.5 h-2.5 rounded-full shrink-0" style="background-color: <%= item.category.color %>"></div>
- <span class="text-secondary"><%= item.category.name %></span>
- <span class="text-primary"><%= number_to_percentage(item.percentage, precision: 0) %></span>
+ <div class="w-2.5 h-2.5 rounded-full shrink-0" style="background-color: <%= category_total.category.color %>"></div>
+ <span class="text-secondary"><%= category_total.category.name %></span>
+ <span class="text-primary"><%= number_to_percentage(category_total.weight, precision: 0) %></span>
</div>
<% end %>
</div>
@@ -34,25 +32,22 @@
<div class="p-4">
<h3 class="text-sm text-secondary mb-2">Expenses</h3>
- <% expense_totals = budget.expense_categories_with_totals %>
- <% expense_categories = expense_totals.category_totals.reject { |ct| ct.amount_money.zero? || ct.category.subcategory? }.sort_by { |ct| ct.percentage }.reverse %>
+ <span class="inline-block mb-2 text-xl font-medium text-primary"><%= budget.actual_spending_money.format %></span>
- <span class="inline-block mb-2 text-xl font-medium text-primary"><%= format_money(expense_totals.total_money) %></span>
-
- <% if expense_categories.any? %>
+ <% if budget.expense_category_totals.any? %>
<div>
<div class="flex h-1.5 mb-3 gap-1">
- <% expense_categories.each do |item| %>
- <div class="h-full rounded-xs" style="background-color: <%= item.category.color %>; width: <%= item.percentage %>%"></div>
+ <% budget.expense_category_totals.each do |category_total| %>
+ <div class="h-full rounded-xs" style="background-color: <%= category_total.category.color %>; width: <%= category_total.weight %>%"></div>
<% end %>
</div>
<div class="flex flex-wrap gap-x-2.5 gap-y-1 text-xs">
- <% expense_categories.each do |item| %>
+ <% budget.expense_category_totals.each do |category_total| %>
<div class="flex items-center gap-1.5">
- <div class="w-2.5 h-2.5 rounded-full shrink-0" style="background-color: <%= item.category.color %>"></div>
- <span class="text-secondary"><%= item.category.name %></span>
- <span class="text-primary"><%= number_to_percentage(item.percentage, precision: 0) %></span>
+ <div class="w-2.5 h-2.5 rounded-full shrink-0" style="background-color: <%= category_total.category.color %>"></div>
+ <span class="text-secondary"><%= category_total.category.name %></span>
+ <span class="text-primary"><%= number_to_percentage(category_total.weight, precision: 0) %></span>
</div>
<% end %>
</div>
diff --git a/app/views/budgets/_budget_categories.html.erb b/app/views/budgets/_budget_categories.html.erb
index 122c8348..ea3995c5 100644
--- a/app/views/budgets/_budget_categories.html.erb
+++ b/app/views/budgets/_budget_categories.html.erb
@@ -9,7 +9,7 @@
<p class="ml-auto">Amount</p>
</div>
- <div class="bg-white py-1 shadow-xs border border-gray-100 rounded-md">
+ <div class="bg-white py-1 shadow-border-xs rounded-md">
<% if budget.family.categories.expenses.empty? %>
<div class="py-8">
<%= render "budget_categories/no_categories" %>
diff --git a/app/views/budgets/_budget_header.html.erb b/app/views/budgets/_budget_header.html.erb
index 333c59b4..55210be8 100644
--- a/app/views/budgets/_budget_header.html.erb
+++ b/app/views/budgets/_budget_header.html.erb
@@ -2,16 +2,16 @@
<div class="flex items-center gap-1 mb-4">
<div class="flex items-center gap-2">
- <% if @previous_budget %>
- <%= link_to budget_path(@previous_budget) do %>
+ <% if budget.previous_budget_param %>
+ <%= link_to budget_path(budget.previous_budget_param) do %>
<%= lucide_icon "chevron-left" %>
<% end %>
<% else %>
<%= lucide_icon "chevron-left", class: "text-subdued" %>
<% end %>
- <% if @next_budget %>
- <%= link_to budget_path(@next_budget) do %>
+ <% if budget.next_budget_param %>
+ <%= link_to budget_path(budget.next_budget_param) do %>
<%= lucide_icon "chevron-right" %>
<% end %>
<% else %>
@@ -20,13 +20,13 @@
</div>
<div data-controller="menu" data-menu-placement-value="bottom-start">
- <%= tag.button data: { menu_target: "button" }, class: "flex items-center gap-1 hover:bg-gray-50 rounded-md p-2" do %>
+ <%= tag.button data: { menu_target: "button" }, class: "flex items-center gap-1 hover:bg-alpha-black-25 cursor-pointer rounded-md p-2" do %>
<span class="text-primary font-medium"><%= @budget.name %></span>
<%= lucide_icon "chevron-down", class: "w-5 h-5 shrink-0 text-secondary" %>
<% end %>
<div data-menu-target="content" class="hidden z-10">
- <%= render "budgets/picker", family: Current.family, year: Date.current.year %>
+ <%= render "budgets/picker", family: Current.family, year: budget.start_date.year %>
</div>
</div>
@@ -34,7 +34,7 @@
<% if @budget.current? %>
<span class="border border-secondary text-primary text-sm font-medium px-3 py-2 rounded-lg">Today</span>
<% else %>
- <%= link_to "Today", budget_path(@latest_budget), class: "btn btn--outline" %>
+ <%= link_to "Today", budget_path(Budget.date_to_param(Date.current)), class: "btn btn--outline" %>
<% end %>
</div>
</div>
diff --git a/app/views/budgets/_picker.html.erb b/app/views/budgets/_picker.html.erb
index 16bc50e5..4aefbf62 100644
--- a/app/views/budgets/_picker.html.erb
+++ b/app/views/budgets/_picker.html.erb
@@ -1,9 +1,11 @@
<%# locals: (family:, year:) %>
<%= turbo_frame_tag "budget_picker" do %>
- <div class="bg-white shadow-md border border-alpha-black-25 p-3 rounded-xl space-y-4">
+ <div class="bg-white shadow-border-xs p-3 rounded-xl space-y-4">
<div class="flex items-center gap-2 justify-between">
- <% if year > family.oldest_entry_date.year %>
+ <% last_month_of_previous_year = Date.new(year - 1, 12, 1) %>
+
+ <% if Budget.budget_date_valid?(last_month_of_previous_year, family: family) %>
<%= link_to picker_budgets_path(year: year - 1), data: { turbo_frame: "budget_picker" }, class: "p-2 flex items-center justify-center hover:bg-alpha-black-25 rounded-md" do %>
<%= lucide_icon "chevron-left", class: "w-5 h-5 shrink-0 text-secondary" %>
<% end %>
@@ -17,7 +19,9 @@
<%= year %>
</span>
- <% if year < Date.current.year %>
+ <% first_month_of_next_year = Date.new(year + 1, 1, 1) %>
+
+ <% if Budget.budget_date_valid?(first_month_of_next_year, family: family) %>
<%= link_to picker_budgets_path(year: year + 1), data: { turbo_frame: "budget_picker" }, class: "p-2 flex items-center justify-center hover:bg-alpha-black-25 rounded-md" do %>
<%= lucide_icon "chevron-right", class: "w-5 h-5 shrink-0 text-secondary" %>
<% end %>
@@ -29,17 +33,12 @@
</div>
<div class="grid grid-cols-3 gap-2 text-sm text-center font-medium">
- <% Date::ABBR_MONTHNAMES.compact.each_with_index do |month_name, index| %>
- <% month_number = index + 1 %>
- <% start_date = Date.new(year, month_number) %>
- <% budget = family.budgets.for_date(start_date) %>
+ <% Date::ABBR_MONTHNAMES.compact.each do |month_name| %>
+ <% date = Date.strptime("#{month_name}-#{year}", "%b-%Y") %>
+ <% param_key = Budget.date_to_param(date) %>
- <% if budget %>
- <%= link_to month_name, budget_path(budget), data: { turbo_frame: "_top" }, class: "block px-3 py-2 text-sm text-primary hover:bg-gray-100 rounded-md" %>
- <% elsif start_date >= family.oldest_entry_date.beginning_of_month && start_date <= Date.current %>
- <%= button_to budgets_path(budget: { start_date: start_date }), data: { turbo_frame: "_top" }, class: "block w-full px-3 py-2 text-primary hover:bg-gray-100 rounded-md" do %>
- <%= month_name %>
- <% end %>
+ <% if Budget.budget_date_valid?(date, family: family) %>
+ <%= link_to month_name, budget_path(param_key), data: { turbo_frame: "_top" }, class: "block px-3 py-2 text-sm text-primary hover:bg-gray-100 rounded-md" %>
<% else %>
<span class="px-3 py-2 text-subdued rounded-md"><%= month_name %></span>
<% end %>
diff --git a/app/views/budgets/show.html.erb b/app/views/budgets/show.html.erb
index 2c98f805..ec502726 100644
--- a/app/views/budgets/show.html.erb
+++ b/app/views/budgets/show.html.erb
@@ -7,7 +7,7 @@
<div class="flex items-start gap-4">
<div class="w-[300px] space-y-4">
- <div class="h-[300px] bg-white rounded-xl shadow-xs p-8 border border-gray-100">
+ <div class="h-[300px] bg-white rounded-xl shadow-border-xs p-8">
<% if @budget.available_to_allocate.negative? %>
<%= render "budgets/over_allocation_warning", budget: @budget %>
<% else %>
@@ -38,18 +38,18 @@
) %>
</div>
- <div class="bg-white rounded-xl shadow-xs border border-gray-100">
+ <div class="bg-white rounded-xl shadow-border-xs">
<%= render selected_tab == "budgeted" ? "budgets/budgeted_summary" : "budgets/actuals_summary", budget: @budget %>
</div>
<% else %>
- <div class="bg-white rounded-xl shadow-xs border border-gray-100">
+ <div class="bg-white rounded-xl shadow-border-xs">
<%= render "budgets/actuals_summary", budget: @budget %>
</div>
<% end %>
</div>
</div>
- <div class="grow bg-white rounded-xl shadow-xs p-4 border border-gray-100">
+ <div class="grow bg-white rounded-xl shadow-border-xs p-4">
<div class="flex items-center justify-between mb-4">
<h2 class="text-lg font-medium">Categories</h2>
diff --git a/app/views/categories/_category_list_group.html.erb b/app/views/categories/_category_list_group.html.erb
index 882f0710..fa7ae241 100644
--- a/app/views/categories/_category_list_group.html.erb
+++ b/app/views/categories/_category_list_group.html.erb
@@ -7,7 +7,7 @@
<p><%= categories.count %></p>
</div>
- <div class="border border-alpha-black-25 rounded-md bg-white shadow-xs">
+ <div class="shadow-border-xs rounded-md bg-white">
<div class="overflow-hidden rounded-md">
<% Category::Group.for(categories).each_with_index do |group, idx| %>
<%= render group.category %>
diff --git a/app/views/categories/index.html.erb b/app/views/categories/index.html.erb
index d440e633..ca5121a6 100644
--- a/app/views/categories/index.html.erb
+++ b/app/views/categories/index.html.erb
@@ -1,44 +1,37 @@
-<% content_for :sidebar do %>
- <%= render "settings/nav" %>
-<% end %>
-<section class="space-y-4">
- <header class="flex items-center justify-between">
- <h1 class="text-primary text-xl font-medium"><%= t(".categories") %></h1>
+<header class="flex items-center justify-between">
+ <h1 class="text-primary text-xl font-medium"><%= t(".categories") %></h1>
- <%= link_to new_category_path, class: "btn btn--primary flex items-center gap-1 justify-center", data: { turbo_frame: :modal } do %>
- <%= lucide_icon "plus", class: "w-5 h-5" %>
- <p><%= t(".new") %></p>
- <% end %>
- </header>
+ <%= link_to new_category_path, class: "btn btn--primary flex items-center gap-1 justify-center", data: { turbo_frame: :modal } do %>
+ <%= lucide_icon "plus", class: "w-5 h-5" %>
+ <p><%= t(".new") %></p>
+ <% end %>
+</header>
- <div class="bg-white shadow-xs border border-alpha-black-25 rounded-xl p-4">
- <% if @categories.any? %>
- <div class="space-y-4">
- <% if @categories.incomes.any? %>
- <%= render "categories/category_list_group", title: t(".categories_incomes"), categories: @categories.incomes %>
- <% end %>
+<div class="bg-white shadow-border-xs rounded-xl p-4">
+ <% if @categories.any? %>
+ <div class="space-y-4">
+ <% if @categories.incomes.any? %>
+ <%= render "categories/category_list_group", title: t(".categories_incomes"), categories: @categories.incomes %>
+ <% end %>
- <% if @categories.expenses.any? %>
- <%= render "categories/category_list_group", title: t(".categories_expenses"), categories: @categories.expenses %>
- <% end %>
- </div>
- <% else %>
- <div class="flex justify-center items-center py-20">
- <div class="text-center flex flex-col items-center max-w-[500px]">
- <p class="text-sm text-secondary mb-4"><%= t(".empty") %></p>
- <div class="flex items-center gap-2">
- <%= button_to t(".bootstrap"), bootstrap_categories_path, class: "btn btn--primary" %>
+ <% if @categories.expenses.any? %>
+ <%= render "categories/category_list_group", title: t(".categories_expenses"), categories: @categories.expenses %>
+ <% end %>
+ </div>
+ <% else %>
+ <div class="flex justify-center items-center py-20">
+ <div class="text-center flex flex-col items-center max-w-[500px]">
+ <p class="text-sm text-secondary mb-4"><%= t(".empty") %></p>
+ <div class="flex items-center gap-2">
+ <%= button_to t(".bootstrap"), bootstrap_categories_path, class: "btn btn--primary" %>
- <%= link_to new_category_path, class: "btn btn--outline flex items-center gap-1", data: { turbo_frame: "modal" } do %>
- <%= lucide_icon("plus", class: "w-5 h-5") %>
- <span><%= t(".new") %></span>
- <% end %>
- </div>
+ <%= link_to new_category_path, class: "btn btn--outline flex items-center gap-1", data: { turbo_frame: "modal" } do %>
+ <%= lucide_icon("plus", class: "w-5 h-5") %>
+ <span><%= t(".new") %></span>
+ <% end %>
</div>
</div>
- <% end %>
- </div>
-
- <%= settings_nav_footer %>
-</section>
+ </div>
+ <% end %>
+</div>
diff --git a/app/views/import/cleans/show.html.erb b/app/views/import/cleans/show.html.erb
index 3325ce5b..a5b71e3f 100644
--- a/app/views/import/cleans/show.html.erb
+++ b/app/views/import/cleans/show.html.erb
@@ -43,7 +43,7 @@
<% end %>
</div>
- <div class="bg-white border border-secondary rounded-xl shadow-xs divide-y divide-alpha-black-200">
+ <div class="bg-white shadow-border-xs rounded-xl divide-y divide-alpha-black-200">
<% @rows.each do |row| %>
<%= render "import/rows/form", row: row %>
<% end %>
@@ -52,8 +52,8 @@
</div>
<div class="fixed bottom-0 left-1/2 -translate-x-1/2 w-full p-12">
- <div class="border border-tertiary rounded-lg p-3 max-w-2xl mx-auto bg-white shadow-xs">
- <%= render "application/pagination", pagy: @pagy %>
+ <div class="shadow-border-xs rounded-lg p-3 max-w-2xl mx-auto bg-white">
+ <%= render "shared/pagination", pagy: @pagy %>
</div>
</div>
</div>
diff --git a/app/views/import/confirms/_mappings.html.erb b/app/views/import/confirms/_mappings.html.erb
index 8883f9f2..2880ec6d 100644
--- a/app/views/import/confirms/_mappings.html.erb
+++ b/app/views/import/confirms/_mappings.html.erb
@@ -27,7 +27,7 @@
<p class="justify-self-end"><%= t(".rows_label") %></p>
</div>
- <div class="border border-alpha-black-25 rounded-md shadow-xs divide-y divide-alpha-black-100 text-sm">
+ <div class="shadow-border-xs rounded-md divide-y divide-alpha-black-100 text-sm">
<% mappings.sort_by(&:key).each do |mapping| %>
<div class="px-5 py-3 bg-white first:rounded-tl-xl first:rounded-tr-xl last:rounded-bl-xl last:rounded-br-xl">
<%= render partial: "import/mappings/form", locals: { mapping: mapping } %>
diff --git a/app/views/imports/_import.html.erb b/app/views/imports/_import.html.erb
index ae36869f..3ee7d68c 100644
--- a/app/views/imports/_import.html.erb
+++ b/app/views/imports/_import.html.erb
@@ -42,7 +42,7 @@
<% end %>
<% if import.complete? || import.revert_failed? %>
- <%= button_to revert_import_path(import),
+ <%= button_to revert_import_path(import),
method: :put,
class: "block w-full py-2 px-3 space-x-2 text-orange-600 hover:bg-orange-50 flex items-center rounded-lg",
data: { turbo_confirm: true } do %>
diff --git a/app/views/imports/_ready.html.erb b/app/views/imports/_ready.html.erb
index 95449039..8f4dc517 100644
--- a/app/views/imports/_ready.html.erb
+++ b/app/views/imports/_ready.html.erb
@@ -12,7 +12,7 @@
<p class="justify-self-end">count</p>
</div>
- <div class="bg-white border border-alpha-black-25 rounded-lg shadow-xs text-sm">
+ <div class="bg-white shadow-border-xs rounded-lg text-sm">
<% import.dry_run.each do |key, count| %>
<% resource = dry_run_resource(key) %>
diff --git a/app/views/imports/_table.html.erb b/app/views/imports/_table.html.erb
index b084353c..c327a530 100644
--- a/app/views/imports/_table.html.erb
+++ b/app/views/imports/_table.html.erb
@@ -1,6 +1,6 @@
<%# locals: (headers: [], rows: [], caption: nil) %>
<div class="overflow-x-auto">
- <div class="border border-secondary rounded-md shadow-xs text-sm bg-white w-full">
+ <div class="border border-secondary rounded-md shadow-border-xs text-sm bg-white w-full">
<div class="grid border-b border-b-alpha-black-200" style="grid-template-columns: repeat(<%= headers.length %>, minmax(0, 1fr))">
<% headers.each_with_index do |header, index| %>
<div class="
diff --git a/app/views/imports/index.html.erb b/app/views/imports/index.html.erb
index f5d03362..9c488e38 100644
--- a/app/views/imports/index.html.erb
+++ b/app/views/imports/index.html.erb
@@ -1,29 +1,22 @@
-<% content_for :sidebar do %>
- <%= render "settings/nav" %>
-<% end %>
+<div class="flex items-center justify-between">
+ <h1 class="text-xl font-medium text-primary"><%= t(".title") %></h1>
-<div class="space-y-4">
- <div class="flex items-center justify-between">
- <h1 class="text-xl font-medium text-primary"><%= t(".title") %></h1>
+ <%= link_to new_import_path, class: "btn btn--primary flex items-center gap-2", data: { turbo_frame: :modal } do %>
+ <%= lucide_icon("plus", class: "w-5 h-5") %>
+ <span><%= t(".new") %></span>
+ <% end %>
+</div>
- <%= link_to new_import_path, class: "btn btn--primary flex items-center gap-2", data: { turbo_frame: :modal } do %>
- <%= lucide_icon("plus", class: "w-5 h-5") %>
- <span><%= t(".new") %></span>
- <% end %>
- </div>
- <div class="bg-white shadow-xs border border-alpha-black-25 rounded-xl p-4">
- <% if @imports.empty? %>
- <%= render partial: "imports/empty" %>
- <% else %>
- <div class="rounded-xl bg-gray-25 p-1">
- <h2 class="uppercase px-4 py-2 text-secondary text-xs"><%= t(".imports") %> · <%= @imports.size %></h2>
+<div class="bg-white shadow-border-xs rounded-xl p-4">
+ <% if @imports.empty? %>
+ <%= render partial: "imports/empty" %>
+ <% else %>
+ <div class="rounded-xl bg-gray-25 p-1">
+ <h2 class="uppercase px-4 py-2 text-secondary text-xs"><%= t(".imports") %> · <%= @imports.size %></h2>
- <div class="border border-alpha-gray-100 rounded-lg bg-white shadow-xs">
- <%= render partial: "imports/import", collection: @imports.ordered %>
- </div>
+ <div class="border border-alpha-black-100 rounded-lg bg-white shadow-xs">
+ <%= render partial: "imports/import", collection: @imports.ordered %>
</div>
- <% end %>
- </div>
-
- <%= settings_nav_footer %>
+ </div>
+ <% end %>
</div>
diff --git a/app/views/imports/new.html.erb b/app/views/imports/new.html.erb
index aaf0475e..751ead07 100644
--- a/app/views/imports/new.html.erb
+++ b/app/views/imports/new.html.erb
@@ -13,7 +13,7 @@
<div class="rounded-xl bg-gray-25 p-1">
<h3 class="uppercase text-secondary text-xs font-medium px-3 py-1.5"><%= t(".sources") %></h3>
- <ul class="bg-white border border-alpha-black-25 rounded-lg shadow-xs">
+ <ul class="bg-white shadow-border-xs rounded-lg">
<li>
<% if @pending_import.present? && (params[:type].nil? || params[:type] == @pending_import.type) %>
<%= link_to import_path(@pending_import), class: "flex items-center justify-between p-4 group cursor-pointer", data: { turbo: false } do %>
diff --git a/app/views/investments/show.html.erb b/app/views/investments/show.html.erb
index 2336282e..a1e34e49 100644
--- a/app/views/investments/show.html.erb
+++ b/app/views/investments/show.html.erb
@@ -10,8 +10,8 @@
tooltip: render(
"investments/value_tooltip",
balance: @account.balance_money,
- holdings: @account.balance - @account.cash_balance,
- cash: @account.cash_balance
+ holdings: @account.balance_money - @account.cash_balance_money,
+ cash: @account.cash_balance_money
) %>
<div class="min-h-[800px]">
diff --git a/app/views/layouts/_sidebar.html.erb b/app/views/layouts/_sidebar.html.erb
deleted file mode 100644
index ea878657..00000000
--- a/app/views/layouts/_sidebar.html.erb
+++ /dev/null
@@ -1,118 +0,0 @@
-<div class="flex items-center justify-between">
- <%= link_to root_path do %>
- <%= image_tag "logo.svg", alt: "Maybe", class: "h-[22px]" %>
- <% end %>
- <div id="user-menu" data-controller="menu">
- <button data-menu-target="button">
- <div class="w-9 h-9">
- <%= render "settings/user_avatar", user: Current.user, variant: :small %>
- </div>
- </button>
- <div data-menu-target="content" class="hidden absolute w-[240px] z-10 left-[255px] top-[72px] bg-white rounded-sm shadow-xs border border-alpha-black-25">
- <div class="p-3 flex items-center gap-3">
- <div class="w-9 h-9 shrink-0">
- <%= render "settings/user_avatar", user: Current.user, variant: :small, lazy: true %>
- </div>
-
- <div class="overflow-hidden text-ellipsis">
- <span class="text-primary font-medium text-sm"><%= Current.user.display_name %></span>
- <% if Current.user.display_name != Current.user.email %>
- <span class="text-secondary text-sm"><%= Current.user.email %></span>
- <% end %>
- </div>
- </div>
- <div class="border-t border-b border-tertiary p-1">
- <%= link_to settings_profile_path(return_to: request.fullpath), class: "flex gap-2 items-center hover:bg-gray-50 rounded-lg px-3 py-2" do %>
- <%= lucide_icon("settings", class: "w-5 h-5 text-secondary shrink-0") %>
- <span class="text-primary text-sm">Settings</span>
- <% end %>
- <div class="flex justify-between items-center gap-2">
- <div class="flex items-center gap-2 rounded-lg px-3 py-2">
- <%= lucide_icon("app-window", class: "w-5 h-5 text-secondary shrink-0") %>
- <div>
- <span class="text-primary text-sm">Demo mode</span>
- <span class="text-secondary text-xs block">Coming soon...</span>
- </div>
- </div>
- <%# TODO: This will be a form toggle when implemented %>
- <div class="relative inline-block cursor-not-allowed" title="Coming soon...">
- <label class="cursor-not-allowed block bg-gray-100 w-9 h-5 rounded-full after:content-[''] after:block after:absolute after:top-0.5 after:left-0.5 after:bg-white after:w-4 after:h-4 after:rounded-full after:transition-transform after:duration-300 after:ease-in-out peer-checked:bg-green-600 peer-checked:after:translate-x-4"></label>
- </div>
- </div>
- </div>
- <div class="border-t border-b border-tertiary p-1">
- <%= link_to changelog_path, class: "flex gap-2 items-center hover:bg-gray-50 rounded-lg px-3 py-2" do %>
- <%= lucide_icon("box", class: "w-5 h-5 text-secondary shrink-0") %>
- <span class="text-primary text-sm">Changelog</span>
- <% end %>
- <%= link_to feedback_path, class: "flex gap-2 items-center hover:bg-gray-50 rounded-lg px-3 py-2" do %>
- <%= lucide_icon("megaphone", class: "w-5 h-5 text-secondary shrink-0") %>
- <span class="text-primary text-sm">Feedback</span>
- <% end %>
- <% if self_hosted? %>
- <%= link_to "https://link.maybe.co/discord", class: "flex gap-2 items-center hover:bg-gray-50 rounded-lg px-3 py-2" do %>
- <%= lucide_icon("message-square-more", class: "w-5 h-5 text-secondary shrink-0") %>
- <span class="text-primary text-sm">Contact</span>
- <% end %>
- <% else %>
- <%= link_to "mailto:[email protected]", class: "flex gap-2 items-center hover:bg-gray-50 rounded-lg px-3 py-2", onclick: "Intercom('showNewMessage'); return false;" do %>
- <%= lucide_icon("message-square-more", class: "w-5 h-5 text-secondary shrink-0") %>
- <span class="text-primary text-sm">Contact</span>
- <% end %>
- <% end %>
- </div>
- <div class="p-1">
- <%= button_to session_path(Current.session), method: :delete, class: "w-full text-red-400 flex gap-1 items-center hover:bg-gray-50 rounded-lg px-3 py-2" do %>
- <%= lucide_icon("log-out", class: "w-5 h-5 shrink-0") %>
- <span class="text-sm">Logout</span>
- <% end %>
- </div>
- </div>
- </div>
-</div>
-<nav>
- <ul class="mt-6 space-y-1">
- <li>
- <%= sidebar_link_to t(".dashboard"), root_path, icon: "layout-grid" %>
- </li>
- <li>
- <%= sidebar_link_to t(".accounts"), summary_accounts_path, icon: "layers" %>
- </li>
- <li>
- <%= sidebar_link_to t(".transactions"), transactions_path, icon: "credit-card" %>
- </li>
- <li>
- <%= sidebar_link_to t(".budgeting"), budgets_path, icon: "map" %>
- </li>
- </ul>
-</nav>
-<div class="flex flex-col mt-6">
- <div class="flex items-center justify-between px-3 py-2 mb-2">
- <div class="flex items-center gap-2 text-xs uppercase text-secondary">
- <%= link_to accounts_path, class: "text-xs uppercase text-secondary font-bold tracking-wide" do %>
- <%= t(".portfolio") %>
- <% end %>
- <span class="font-bold tracking-wide">&bull;</span>
-
- <%= form_with url: list_accounts_path, method: :get, data: { controller: Current.family.accounts.any? ? "auto-submit-form" : nil, turbo_frame: "account-list" } do |form| %>
- <%= period_select form: form, selected: "last_30_days", classes: "w-full border-none pl-2 pr-7 text-xs bg-transparent gap-1 cursor-pointer font-semibold tracking-wide focus:outline-hidden focus:ring-0" %>
- <% end %>
- </div>
- <%= link_to new_account_path, id: "sidebar-new-account", class: "block hover:bg-gray-100 font-semibold text-primary flex items-center rounded p-1", title: t(".new_account"), data: { turbo_frame: "modal" } do %>
- <%= lucide_icon("plus", class: "w-5 h-5 text-secondary") %>
- <% end %>
- </div>
-
- <%= turbo_frame_tag "account-list", target: "_top" do %>
- <% if Current.family.accounts.any? %>
- <% account_groups.each do |group| %>
- <%= render "accounts/account_list", group: group %>
- <% end %>
- <% else %>
- <%= link_to new_account_path, class: "flex items-center min-h-10 gap-4 px-3 py-2 mb-1 text-secondary text-sm font-medium rounded-[10px] hover:bg-gray-100", data: { turbo_frame: "modal" } do %>
- <%= lucide_icon("plus", class: "w-5 h-5") %>
- <%= tag.p t(".new_account") %>
- <% end %>
- <% end %>
- <% end %>
-</div>
diff --git a/app/views/layouts/application.html.erb b/app/views/layouts/application.html.erb
index 14fe57b5..ffdffa7f 100644
--- a/app/views/layouts/application.html.erb
+++ b/app/views/layouts/application.html.erb
@@ -1,57 +1,51 @@
-<!DOCTYPE html>
-<html class="font-sans text-primary h-full <%= @os %>" lang="en">
- <head>
- <title><%= content_for(:title) || "Maybe" %></title>
-
- <%= csrf_meta_tags %>
- <%= csp_meta_tag %>
-
- <%= stylesheet_link_tag "tailwind", "data-turbo-track": "reload" %>
- <%= stylesheet_link_tag "application", "data-turbo-track": "reload" %>
-
- <%= javascript_include_tag "https://cdn.plaid.com/link/v2/stable/link-initialize.js" %>
- <%= combobox_style_tag %>
-
- <%= javascript_importmap_tags %>
- <%= turbo_refreshes_with method: :morph, scroll: :preserve %>
-
- <meta name="viewport"
- content="viewport-fit=cover, width=device-width, initial-scale=1.0, minimum-scale=1.0, maximum-scale=1.0, user-scalable=no">
- <meta name="mobile-web-app-capable" content="yes">
- <meta name="apple-mobile-web-app-status-bar-style" content="black-translucent">
- <meta name="apple-mobile-web-app-title" content="Maybe">
- <meta name="msapplication-TileColor" content="#ffffff">
- <meta name="theme-color" content="#ffffff">
-
- <%= yield :head %>
- </head>
-
- <body class="h-full">
- <%= render "impersonation_sessions/super_admin_bar" if Current.true_user&.super_admin? && show_super_admin_bar? %>
- <%= render "impersonation_sessions/approval_bar" if Current.true_user&.impersonated_support_sessions&.initiated&.any? %>
-
- <div class="fixed z-50 bottom-6 left-6">
- <div id="notification-tray" class="space-y-1">
- <%= render_flash_notifications %>
-
- <% if Current.family&.syncing? %>
- <%= render "shared/syncing_notice" %>
+<%= render "layouts/shared/htmldoc" do %>
+ <div class="flex h-full bg-gray-50">
+ <nav class="flex flex-col shrink-0 w-[84px] py-4 mr-3">
+ <div class="pl-2 mb-3">
+ <%= link_to root_path, class: "block" do %>
+ <%= image_tag "logomark-color.svg", class: "w-9 h-9 mx-auto" %>
<% end %>
</div>
- </div>
- <%= family_notifications_stream %>
- <%= family_stream %>
+ <ul class="space-y-0.5">
+ <li>
+ <%= render "layouts/sidebar/nav_item", name: "Home", path: root_path, icon_key: "pie-chart" %>
+ </li>
- <%= content_for?(:content) ? yield(:content) : yield %>
+ <li>
+ <%= render "layouts/sidebar/nav_item", name: "Transactions", path: transactions_path, icon_key: "credit-card" %>
+ </li>
- <%= turbo_frame_tag "modal" %>
- <%= turbo_frame_tag "drawer" %>
+ <li>
+ <%= render "layouts/sidebar/nav_item", name: "Budgets", path: budgets_path, icon_key: "layout-grid" %>
+ </li>
+ </ul>
+
+ <div class="pl-2 mt-auto mx-auto">
+ <%= render "users/user_menu", user: Current.user %>
+ </div>
+ </nav>
+
+ <%= tag.div class: class_names("py-4 shrink-0 h-full overflow-y-auto transition-all duration-300", Current.user.show_sidebar? ? "w-[260px]" : "w-0"), data: { sidebar_target: "panel" } do %>
+ <% if content_for?(:sidebar) %>
+ <%= yield :sidebar %>
+ <% else %>
+ <div id="account-sidebar-tabs" data-turbo-permanent>
+ <%= render "accounts/account_sidebar_tabs", family: Current.family %>
+ </div>
+ <% end %>
+ <% end %>
- <%= render "shared/confirm_modal" %>
+ <%= tag.main class: class_names("px-10 py-4 grow h-full", require_upgrade? ? "relative overflow-hidden" : "overflow-y-auto") do %>
+ <% if require_upgrade? %>
+ <div class="absolute inset-0 px-10 h-full w-full z-50">
+ <%= render "shared/subscribe_modal" %>
+ </div>
+ <% end %>
- <% if self_hosted? && Current.user&.onboarded_at.present? %>
- <%= render "shared/app_version" %>
+ <%= tag.div class: class_names("mx-auto w-full h-full", Current.user.show_sidebar? ? "max-w-4xl" : "max-w-5xl"), data: { sidebar_target: "content" } do %>
+ <%= yield %>
+ <% end %>
<% end %>
- </body>
-</html>
+ </div>
+<% end %>
diff --git a/app/views/layouts/auth.html.erb b/app/views/layouts/auth.html.erb
index 5e581e92..f6fd8f2e 100644
--- a/app/views/layouts/auth.html.erb
+++ b/app/views/layouts/auth.html.erb
@@ -1,35 +1,35 @@
-<%= content_for :content do %>
- <div class="flex flex-col h-screen px-6 py-12 bg-gray-25">
- <div class="grow flex flex-col justify-center">
- <div class="sm:mx-auto sm:w-full sm:max-w-md">
- <div class="flex justify-center mb-6">
- <%= image_tag "logo-color.png", class: "w-16 mb-6" %>
- </div>
+<%= render "layouts/shared/htmldoc" do %>
+ <div class="flex flex-col h-dvh">
+ <div class="flex flex-col h-screen px-6 py-12 bg-gray-25">
+ <div class="grow flex flex-col justify-center">
+ <div class="sm:mx-auto sm:w-full sm:max-w-md">
+ <div class="flex justify-center mb-6">
+ <%= image_tag "logo-color.png", class: "w-16 mb-6" %>
+ </div>
- <div class="space-y-2">
- <h2 class="text-3xl font-medium text-primary text-center">
- <%= content_for?(:header_title) ? yield(:header_title).html_safe : t(".your_account") %>
- </h2>
+ <div class="space-y-2">
+ <h2 class="text-3xl font-medium text-primary text-center">
+ <%= content_for?(:header_title) ? yield(:header_title).html_safe : t(".your_account") %>
+ </h2>
- <% if controller_name == "sessions" %>
- <p class="text-sm text-center">
- <%= tag.span t(".no_account"), class: "text-secondary" %> <%= link_to t(".sign_up"), new_registration_path, class: "font-medium text-primary hover:underline transition" %>
- </p>
- <% elsif controller_name == "registrations" %>
- <p class="text-sm text-center text-gray-600">
- <%= t(".existing_account") %> <%= link_to t(".sign_in"), new_session_path, class: "font-medium text-primary hover:underline transition" %>
- </p>
- <% end %>
+ <% if controller_name == "sessions" %>
+ <p class="text-sm text-center">
+ <%= tag.span t(".no_account"), class: "text-secondary" %> <%= link_to t(".sign_up"), new_registration_path, class: "font-medium text-primary hover:underline transition" %>
+ </p>
+ <% elsif controller_name == "registrations" %>
+ <p class="text-sm text-center text-gray-600">
+ <%= t(".existing_account") %> <%= link_to t(".sign_in"), new_session_path, class: "font-medium text-primary hover:underline transition" %>
+ </p>
+ <% end %>
+ </div>
</div>
- </div>
- <div class="mt-8 sm:mx-auto sm:w-full sm:max-w-lg">
- <%= yield %>
+ <div class="mt-8 sm:mx-auto sm:w-full sm:max-w-lg">
+ <%= yield %>
+ </div>
</div>
- </div>
- <%= render "layouts/footer" %>
+ <%= render "layouts/shared/footer" %>
+ </div>
</div>
<% end %>
-
-<%= render template: "layouts/application" %>
diff --git a/app/views/layouts/imports.html.erb b/app/views/layouts/imports.html.erb
index 1c2e771e..4e4699c9 100644
--- a/app/views/layouts/imports.html.erb
+++ b/app/views/layouts/imports.html.erb
@@ -1,4 +1,4 @@
-<%= content_for :content do %>
+<%= render "layouts/shared/htmldoc" do %>
<div class="flex flex-col h-dvh">
<header class="flex items-center justify-between p-8">
<%= link_to content_for(:previous_path) || imports_path do %>
@@ -19,5 +19,3 @@
</main>
</div>
<% end %>
-
-<%= render template: "layouts/application" %>
diff --git a/app/views/layouts/issues.html.erb b/app/views/layouts/issues.html.erb
index 1a606279..4ae03b85 100644
--- a/app/views/layouts/issues.html.erb
+++ b/app/views/layouts/issues.html.erb
@@ -1,15 +1,15 @@
-<%= drawer do %>
- <article class="prose">
- <%= tag.h2 do %>
- <%= yield :title %>
- <% end %>
+<%= render "layouts/shared/htmldoc" do %>
+ <%= drawer do %>
+ <article class="prose">
+ <%= tag.h2 do %>
+ <%= yield :title %>
+ <% end %>
- <%= tag.h3 t(".description") %>
- <%= yield :description %>
+ <%= tag.h3 "Issue Description" %>
+ <%= yield :description %>
- <%= tag.h3 t(".action") %>
- <%= yield :action %>
- </article>
+ <%= tag.h3 "How to fix this issue" %>
+ <%= yield :action %>
+ </article>
+ <% end %>
<% end %>
-
-<%= render template: "layouts/application" %>
diff --git a/app/views/layouts/onboardings.html.erb b/app/views/layouts/onboardings.html.erb
new file mode 100644
index 00000000..cf7c394c
--- /dev/null
+++ b/app/views/layouts/onboardings.html.erb
@@ -0,0 +1,3 @@
+<%= render "layouts/shared/htmldoc" do %>
+ <%= yield %>
+<% end %>
diff --git a/app/views/layouts/settings.html.erb b/app/views/layouts/settings.html.erb
new file mode 100644
index 00000000..f8743333
--- /dev/null
+++ b/app/views/layouts/settings.html.erb
@@ -0,0 +1,25 @@
+<%= render "layouts/shared/htmldoc" do %>
+ <div class="flex h-full bg-gray-25">
+ <div class="p-4 w-[260px] shrink-0 h-full overflow-y-auto">
+ <%= render "settings/settings_nav" %>
+ </div>
+
+ <main class="py-4 px-10 grow flex h-full overflow-y-auto">
+ <div class="relative max-w-4xl mx-auto flex flex-col w-full h-full">
+ <div class="grow space-y-4 overflow-y-auto -mx-1 px-1 pb-12">
+ <% if content_for?(:page_title) %>
+ <h1 class="text-primary text-xl font-medium">
+ <%= content_for :page_title %>
+ </h1>
+ <% end %>
+
+ <%= yield %>
+ </div>
+
+ <div class="mt-4">
+ <%= settings_nav_footer %>
+ </div>
+ </div>
+ </main>
+ </div>
+<% end %>
diff --git a/app/views/layouts/shared/_fixed_content.html.erb b/app/views/layouts/shared/_fixed_content.html.erb
new file mode 100644
index 00000000..88ace0d3
--- /dev/null
+++ b/app/views/layouts/shared/_fixed_content.html.erb
@@ -0,0 +1,6 @@
+<%= turbo_frame_tag "modal" %>
+<%= turbo_frame_tag "drawer" %>
+<%= render "shared/confirm_modal" %>
+
+<%= render "impersonation_sessions/super_admin_bar" if Current.true_user&.super_admin? && show_super_admin_bar? %>
+<%= render "impersonation_sessions/approval_bar" if Current.true_user&.impersonated_support_sessions&.initiated&.any? %>
diff --git a/app/views/layouts/_footer.html.erb b/app/views/layouts/shared/_footer.html.erb
similarity index 100%
rename from app/views/layouts/_footer.html.erb
rename to app/views/layouts/shared/_footer.html.erb
diff --git a/app/views/layouts/shared/_head.html.erb b/app/views/layouts/shared/_head.html.erb
new file mode 100644
index 00000000..5eb11807
--- /dev/null
+++ b/app/views/layouts/shared/_head.html.erb
@@ -0,0 +1,26 @@
+<head>
+ <title><%= content_for(:title) || "Maybe" %></title>
+
+ <%= csrf_meta_tags %>
+ <%= csp_meta_tag %>
+
+ <%= stylesheet_link_tag "tailwind", "data-turbo-track": "reload" %>
+ <%= stylesheet_link_tag "application", "data-turbo-track": "reload" %>
+
+ <%= javascript_include_tag "https://cdn.plaid.com/link/v2/stable/link-initialize.js" %>
+ <%= combobox_style_tag %>
+
+ <%= javascript_importmap_tags %>
+ <%= turbo_refreshes_with method: :morph, scroll: :preserve %>
+
+ <meta name="viewport"
+ content="viewport-fit=cover, width=device-width, initial-scale=1.0, minimum-scale=1.0, maximum-scale=1.0, user-scalable=no">
+ <meta name="mobile-web-app-capable" content="yes">
+ <meta name="apple-mobile-web-app-status-bar-style" content="black-translucent">
+ <meta name="apple-mobile-web-app-title" content="Maybe">
+
+ <meta name="msapplication-TileColor" content="#ffffff">
+ <meta name="theme-color" content="#ffffff">
+
+ <%= yield :head %>
+</head>
diff --git a/app/views/layouts/shared/_htmldoc.html.erb b/app/views/layouts/shared/_htmldoc.html.erb
new file mode 100644
index 00000000..b53b5880
--- /dev/null
+++ b/app/views/layouts/shared/_htmldoc.html.erb
@@ -0,0 +1,35 @@
+<!DOCTYPE html>
+<html class="h-full text-primary font-sans <%= @os %>" lang="en">
+ <head>
+ <%= render "layouts/shared/head" %>
+ <%= yield :head %>
+ </head>
+
+ <body class="h-full antialiased" data-controller="sidebar" data-sidebar-user-id-value="<%= Current.user&.id %>">
+ <div class="fixed z-50 bottom-6 left-6">
+ <div id="notification-tray" class="space-y-1">
+ <%= render_flash_notifications %>
+
+ <% if Current.family&.syncing? %>
+ <%= render "shared/syncing_notice" %>
+ <% end %>
+ </div>
+ </div>
+
+ <%= family_notifications_stream %>
+ <%= family_stream %>
+
+ <% if self_hosted? && (upgrade = get_upgrade_for_notification(Current.user, Setting.upgrades_mode)) %>
+ <%= render partial: "shared/upgrade_notification", locals: { upgrade: upgrade } %>
+ <% end %>
+
+ <%= turbo_frame_tag "modal" %>
+ <%= turbo_frame_tag "drawer" %>
+ <%= render "shared/confirm_modal" %>
+
+ <%= render "impersonation_sessions/super_admin_bar" if Current.true_user&.super_admin? && show_super_admin_bar? %>
+ <%= render "impersonation_sessions/approval_bar" if Current.true_user&.impersonated_support_sessions&.initiated&.any? %>
+
+ <%= yield %>
+ </body>
+</html>
diff --git a/app/views/layouts/shared/_notifications.html.erb b/app/views/layouts/shared/_notifications.html.erb
new file mode 100644
index 00000000..29cb8c8d
--- /dev/null
+++ b/app/views/layouts/shared/_notifications.html.erb
@@ -0,0 +1,16 @@
+<div class="fixed z-50 bottom-6 left-6">
+ <div id="notification-tray" class="space-y-1">
+ <%= render_flash_notifications %>
+
+ <% if Current.family&.syncing? %>
+ <%= render "shared/syncing_notice" %>
+ <% end %>
+ </div>
+</div>
+
+<%= family_notifications_stream %>
+<%= family_stream %>
+
+<% if self_hosted? && (upgrade = get_upgrade_for_notification(Current.user, Setting.upgrades_mode)) %>
+ <%= render partial: "shared/upgrade_notification", locals: { upgrade: upgrade } %>
+<% end %>
diff --git a/app/views/layouts/sidebar/_nav_item.html.erb b/app/views/layouts/sidebar/_nav_item.html.erb
new file mode 100644
index 00000000..bfe8139f
--- /dev/null
+++ b/app/views/layouts/sidebar/_nav_item.html.erb
@@ -0,0 +1,17 @@
+<%# locals: (name:, path:, icon_key:) %>
+
+<%= link_to path, class: "space-y-1 py-1 group block" do %>
+ <div class="grow flex gap-1 items-center">
+ <%= tag.div class: class_names("w-1 h-4 rounded-tr-sm rounded-br-sm", "bg-gray-900" => page_active?(path)) %>
+
+ <%= tag.div class: class_names("w-8 h-8 flex items-center justify-center mx-auto rounded-lg", page_active?(path) ? "bg-white shadow-xs text-primary" : "group-hover:bg-gray-100 text-secondary") do %>
+ <%= icon(icon_key) %>
+ <% end %>
+ </div>
+
+ <div class="grow pl-2">
+ <%= tag.p class: class_names("text-center font-medium text-[11px]", page_active?(path) ? "text-primary" : "text-secondary") do %>
+ <%= name %>
+ <% end %>
+ </div>
+<% end %>
diff --git a/app/views/layouts/with_sidebar.html.erb b/app/views/layouts/with_sidebar.html.erb
deleted file mode 100644
index cf5fdeb3..00000000
--- a/app/views/layouts/with_sidebar.html.erb
+++ /dev/null
@@ -1,25 +0,0 @@
-<%= content_for :content do %>
- <div class="flex h-full bg-gray-25">
- <div class="p-6 pb-20 w-[368px] shrink-0 h-full overflow-y-auto">
- <% if content_for?(:sidebar) %>
- <%= yield :sidebar %>
- <% else %>
- <%= render "layouts/sidebar" %>
- <% end %>
- </div>
-
- <main class="grow px-20 py-6 h-full <%= require_upgrade? ? "relative overflow-hidden" : "overflow-y-auto" %>">
- <% if require_upgrade? %>
- <%= render "shared/subscribe_modal" %>
- <% end %>
-
- <%= yield %>
- </main>
- </div>
-
- <% if (upgrade = get_upgrade_for_notification(Current.user, Setting.upgrades_mode)) %>
- <%= render partial: "shared/upgrade_notification", locals: { upgrade: upgrade } %>
- <% end %>
-<% end %>
-
-<%= render template: "layouts/application" %>
diff --git a/app/views/layouts/wizard.html.erb b/app/views/layouts/wizard.html.erb
index f19ce346..e7fa42d8 100644
--- a/app/views/layouts/wizard.html.erb
+++ b/app/views/layouts/wizard.html.erb
@@ -1,4 +1,4 @@
-<%= content_for :content do %>
+<%= render "layouts/shared/htmldoc" do %>
<div class="flex flex-col h-dvh">
<header class="flex items-center justify-between p-8">
<%= link_to content_for(:previous_path) || root_path do %>
@@ -19,5 +19,3 @@
</main>
</div>
<% end %>
-
-<%= render template: "layouts/application" %>
diff --git a/app/views/merchants/index.html.erb b/app/views/merchants/index.html.erb
index e511013f..55b1a080 100644
--- a/app/views/merchants/index.html.erb
+++ b/app/views/merchants/index.html.erb
@@ -1,44 +1,36 @@
-<% content_for :sidebar do %>
- <%= render "settings/nav" %>
-<% end %>
+<header class="flex items-center justify-between">
+ <h1 class="text-primary text-xl font-medium"><%= t(".title") %></h1>
-<section class="space-y-4">
- <header class="flex items-center justify-between">
- <h1 class="text-primary text-xl font-medium"><%= t(".title") %></h1>
+ <%= link_to new_merchant_path, class: "btn btn--primary flex items-center gap-1 justify-center", data: { turbo_frame: :modal } do %>
+ <%= lucide_icon "plus", class: "w-5 h-5" %>
+ <p><%= t(".new") %></p>
+ <% end %>
+</header>
- <%= link_to new_merchant_path, class: "btn btn--primary flex items-center gap-1 justify-center", data: { turbo_frame: :modal } do %>
- <%= lucide_icon "plus", class: "w-5 h-5" %>
- <p><%= t(".new") %></p>
- <% end %>
- </header>
-
- <div class="bg-white shadow-xs border border-alpha-black-25 rounded-xl p-4">
- <% if @merchants.any? %>
- <div class="rounded-xl bg-gray-25 space-y-1 p-1">
- <div class="flex items-center gap-1.5 px-4 py-2 text-xs font-medium text-secondary uppercase">
- <p><%= t(".title") %></p>
- <span class="text-subdued">&middot;</span>
- <p><%= @merchants.count %></p>
- </div>
+<div class="bg-white shadow-border-xs rounded-xl p-4">
+ <% if @merchants.any? %>
+ <div class="rounded-xl bg-gray-25 space-y-1 p-1">
+ <div class="flex items-center gap-1.5 px-4 py-2 text-xs font-medium text-secondary uppercase">
+ <p><%= t(".title") %></p>
+ <span class="text-subdued">&middot;</span>
+ <p><%= @merchants.count %></p>
+ </div>
- <div class="border border-alpha-black-25 rounded-md bg-white shadow-xs">
- <div class="overflow-hidden rounded-md">
- <%= render partial: @merchants, spacer_template: "merchants/ruler" %>
- </div>
+ <div class="border border-alpha-black-25 rounded-md bg-white shadow-border-xs">
+ <div class="overflow-hidden rounded-md">
+ <%= render partial: @merchants, spacer_template: "merchants/ruler" %>
</div>
</div>
- <% else %>
- <div class="flex justify-center items-center py-20">
- <div class="text-center flex flex-col items-center max-w-[300px]">
- <p class="text-primary mb-1 font-medium text-sm"><%= t(".empty") %></p>
- <%= link_to new_merchant_path, class: "w-fit flex text-white text-sm font-medium items-center gap-1 bg-gray-900 rounded-lg p-2 pr-3", data: { turbo_frame: "modal" } do %>
- <%= lucide_icon("plus", class: "w-5 h-5") %>
- <span><%= t(".new") %></span>
- <% end %>
- </div>
+ </div>
+ <% else %>
+ <div class="flex justify-center items-center py-20">
+ <div class="text-center flex flex-col items-center max-w-[300px]">
+ <p class="text-primary mb-1 font-medium text-sm"><%= t(".empty") %></p>
+ <%= link_to new_merchant_path, class: "w-fit flex text-white text-sm font-medium items-center gap-1 bg-gray-900 rounded-lg p-2 pr-3", data: { turbo_frame: "modal" } do %>
+ <%= lucide_icon("plus", class: "w-5 h-5") %>
+ <span><%= t(".new") %></span>
+ <% end %>
</div>
- <% end %>
- </div>
-
- <%= settings_nav_footer %>
+ </div>
+ <% end %>
</div>
diff --git a/app/views/mfa/backup_codes.html.erb b/app/views/mfa/backup_codes.html.erb
index f93bba0b..b27e78d4 100644
--- a/app/views/mfa/backup_codes.html.erb
+++ b/app/views/mfa/backup_codes.html.erb
@@ -4,7 +4,7 @@
%>
<% content_for :sidebar do %>
- <%= render "settings/nav" %>
+ <%= render "settings/settings_nav" %>
<% end %>
<div class="space-y-4">
@@ -27,4 +27,3 @@
<%= settings_nav_footer %>
</div>
-
\ No newline at end of file
diff --git a/app/views/mfa/new.html.erb b/app/views/mfa/new.html.erb
index 65223d25..68bbcf54 100644
--- a/app/views/mfa/new.html.erb
+++ b/app/views/mfa/new.html.erb
@@ -4,7 +4,7 @@
%>
<% content_for :sidebar do %>
- <%= render "settings/nav" %>
+ <%= render "settings/settings_nav" %>
<% end %>
<div class="space-y-4">
diff --git a/app/views/mfa/verify.html.erb b/app/views/mfa/verify.html.erb
index a719a2ae..67476e5a 100644
--- a/app/views/mfa/verify.html.erb
+++ b/app/views/mfa/verify.html.erb
@@ -11,4 +11,4 @@
label: t(".page_title") %>
<%= form.submit t(".verify_button") %>
-<% end %>
\ No newline at end of file
+<% end %>
diff --git a/app/views/onboardings/preferences.html.erb b/app/views/onboardings/preferences.html.erb
index f567cd0b..633b9145 100644
--- a/app/views/onboardings/preferences.html.erb
+++ b/app/views/onboardings/preferences.html.erb
@@ -9,7 +9,7 @@
</div>
<div class="p-1 bg-alpha-black-25 mb-2 rounded-lg">
- <div class="bg-white p-4 rounded-lg flex gap-8 shadow-xs">
+ <div class="bg-white p-4 rounded-lg flex gap-8 shadow-border-xs">
<div class="space-y-2">
<%= tag.p t(".example"), class: "text-secondary text-sm" %>
<%= tag.p "$2,323.25", class: "text-primary font-medium text-2xl" %>
@@ -38,13 +38,15 @@
{ date: Date.current, value: 265 }
] %>
+ <% placeholder_series = Series.from_raw_values(placeholder_series_data) %>
+
<div class="flex items-center w-2/5">
<div class="h-12 w-full">
<div
id="previewChart"
class="h-full w-full"
data-controller="time-series-chart"
- data-time-series-chart-data-value="<%= TimeSeries.new(placeholder_series_data).to_json %>"
+ data-time-series-chart-data-value="<%= placeholder_series.to_json %>"
data-time-series-chart-use-labels-value="false"
data-time-series-chart-use-tooltip-value="false"></div>
</div>
@@ -84,5 +86,5 @@
</div>
</div>
- <%= render "layouts/footer" %>
+ <%= render "layouts/shared/footer" %>
</div>
diff --git a/app/views/onboardings/profile.html.erb b/app/views/onboardings/profile.html.erb
index 595fa3dd..82313e88 100644
--- a/app/views/onboardings/profile.html.erb
+++ b/app/views/onboardings/profile.html.erb
@@ -38,5 +38,5 @@
</div>
</div>
- <%= render "layouts/footer" %>
+ <%= render "layouts/shared/footer" %>
</div>
diff --git a/app/views/pages/_account_group_disclosure.erb b/app/views/pages/_account_group_disclosure.erb
deleted file mode 100644
index f3c18cba..00000000
--- a/app/views/pages/_account_group_disclosure.erb
+++ /dev/null
@@ -1,48 +0,0 @@
-<%# locals: (accountable_group:) %>
-<% text_class = accountable_text_class(accountable_group.name) %>
-<details class="open:bg-gray-25 group">
- <summary class="flex p-4 items-center w-full rounded-lg font-medium hover:bg-gray-50 text-secondary text-sm font-medium cursor-pointer">
- <%= lucide_icon("chevron-down", class: "hidden group-open:block w-5 h-5") %>
- <%= lucide_icon("chevron-right", class: "group-open:hidden w-5 h-5") %>
- <div class="ml-4 h-2.5 w-2.5 rounded-full <%= accountable_bg_class(accountable_group.name) %>"></div>
- <p class="text-primary ml-2"><%= to_accountable_title(Accountable.from_type(accountable_group.name)) %></p>
- <span class="mx-1">&middot;</span>
- <div><%= accountable_group.children.count %></div>
- <div class="ml-auto text-right flex items-center gap-10 text-sm font-medium text-primary">
- <div class="flex items-center justify-end gap-2 w-24">
- <%= render partial: "shared/progress_circle", locals: { progress: accountable_group.percent_of_total, text_class: text_class } %>
- <p><%= accountable_group.percent_of_total.round(1) %>%</p>
- </div>
- <div class="w-24">
- <p><%= format_money accountable_group.sum %></p>
- </div>
- <div class="w-40">
- <%= render partial: "shared/trend_change", locals: { trend: accountable_group.series.trend } %>
- </div>
- </div>
- </summary>
- <div class="px-4 py-3 space-y-4">
- <% accountable_group.children.map do |account_value_node| %>
- <div class="flex items-center justify-between text-sm font-medium text-primary">
- <div class="flex items-center gap-4 overflow-hidden">
- <%= render "accounts/logo", account: account_value_node.original, size: "sm" %>
- <div class="truncate">
- <p><%= account_value_node.name %></p>
- </div>
- </div>
- <div class="flex gap-10 items-center text-right">
- <div class="flex items-center justify-end gap-2 w-24">
- <%= render partial: "shared/progress_circle", locals: { progress: account_value_node.percent_of_total, text_class: text_class } %>
- <p><%= account_value_node.percent_of_total %>%</p>
- </div>
- <div class="w-24">
- <p><%= format_money account_value_node.original.balance_money %></p>
- </div>
- <div class="w-40">
- <%= render partial: "shared/trend_change", locals: { trend: account_value_node.original.series.trend } %>
- </div>
- </div>
- </div>
- <% end %>
- </div>
-</details>
diff --git a/app/views/pages/_account_percentages_bar.html.erb b/app/views/pages/_account_percentages_bar.html.erb
deleted file mode 100644
index f8e98865..00000000
--- a/app/views/pages/_account_percentages_bar.html.erb
+++ /dev/null
@@ -1,17 +0,0 @@
-<%# locals: (account_groups:) %>
-<div class="space-y-4">
- <div class="flex gap-1">
- <% account_groups.sort_by(&:percent_of_total).reverse.each do |group| %>
- <div class="h-1.5 rounded-sm w-12 <%= accountable_bg_class(group.name) %>" style="width: <%= group.percent_of_total %>%;"></div>
- <% end %>
- </div>
- <div class="flex gap-4">
- <% account_groups.sort_by(&:percent_of_total).reverse.each do |group| %>
- <div class="flex items-center gap-2 text-sm">
- <div class="h-2.5 w-2.5 rounded-full <%= accountable_bg_class(group.name) %>"></div>
- <p class="text-secondary"><%= to_accountable_title(Accountable.from_type(group.name)) %></p>
- <p class="text-black"><%= group.percent_of_total.round(1) %>%</p>
- </div>
- <% end %>
- </div>
-</div>
diff --git a/app/views/pages/_account_percentages_table.html.erb b/app/views/pages/_account_percentages_table.html.erb
deleted file mode 100644
index 60dd9aa4..00000000
--- a/app/views/pages/_account_percentages_table.html.erb
+++ /dev/null
@@ -1,20 +0,0 @@
-<%# locals: (account_groups:) %>
-<div class="bg-gray-25 p-1 rounded-xl">
- <div class="px-4 py-2 flex items-center uppercase text-xs font-medium text-secondary">
- <div>Name</div>
- <div class="ml-auto text-right flex items-center gap-10">
- <div class="w-24">
- <p>% of total</p>
- </div>
- <div class="w-24">
- <p>Value</p>
- </div>
- <div class="w-40">
- <p>Change</p>
- </div>
- </div>
- </div>
- <div class="bg-white border border-alpha-black-25 shadow-xs rounded-lg divide-y divide-alpha-black-50">
- <%= render partial: "pages/account_group_disclosure", collection: account_groups.sort_by(&:name), as: :accountable_group %>
- </div>
-</div>
diff --git a/app/views/pages/changelog.html.erb b/app/views/pages/changelog.html.erb
index 6632ac9d..650f2f65 100644
--- a/app/views/pages/changelog.html.erb
+++ b/app/views/pages/changelog.html.erb
@@ -1,30 +1,21 @@
-<% content_for :sidebar do %>
- <%= render "settings/nav" %>
-<% end %>
+<%= content_for :page_title, t(".title") %>
-<div class="space-y-4 flex flex-col h-full">
- <h1 class="text-primary text-xl font-medium mb-4"><%= t(".title") %></h1>
- <div class="bg-white shadow-xs border border-alpha-black-25 rounded-xl p-4 grow overflow-y-auto">
- <div class="flex justify-between gap-4 mb-12 last:mb-0">
- <div class="w-1/3">
- <div class="px-3 flex items-center gap-3">
- <div class="text-white shrink-0 w-9 h-9">
- <%= image_tag @release_notes[:avatar], class: "rounded-full w-full h-full object-cover" %>
- </div>
- <div>
- <a class="text-primary font-medium text-sm" href="https://github.com/<%= @release_notes[:username] %>"><%= "@#{@release_notes[:username]}" %></a>
- <div class="text-secondary text-sm"><%= @release_notes[:published_at].strftime("%B %d, %Y") %></div>
- </div>
+<div class="bg-white shadow-border-xs rounded-xl p-4 grow overflow-y-auto">
+ <div class="flex justify-between gap-4 mb-12 last:mb-0">
+ <div class="w-1/3">
+ <div class="px-3 flex items-center gap-3">
+ <div class="text-white shrink-0 w-9 h-9">
+ <%= image_tag @release_notes[:avatar], class: "rounded-full w-full h-full object-cover" %>
+ </div>
+ <div>
+ <a class="text-primary font-medium text-sm" href="https://github.com/<%= @release_notes[:username] %>"><%= "@#{@release_notes[:username]}" %></a>
+ <div class="text-secondary text-sm"><%= @release_notes[:published_at].strftime("%B %d, %Y") %></div>
</div>
- </div>
- <div class="w-2/3 text-secondary text-sm prose prose--github-release-notes">
- <h2 class="mb-5 text-xl text-primary"><%= @release_notes[:name] %></h2>
- <%= @release_notes[:body].html_safe %>
</div>
</div>
- </div>
-
- <div class="mt-auto">
- <%= settings_nav_footer %>
+ <div class="w-2/3 text-secondary text-sm prose prose--github-release-notes">
+ <h2 class="mb-5 text-xl text-primary"><%= @release_notes[:name] %></h2>
+ <%= @release_notes[:body].html_safe %>
+ </div>
</div>
</div>
diff --git a/app/views/pages/dashboard.html.erb b/app/views/pages/dashboard.html.erb
index 4e84a384..b9055b70 100644
--- a/app/views/pages/dashboard.html.erb
+++ b/app/views/pages/dashboard.html.erb
@@ -1,203 +1,28 @@
-<div class="space-y-4">
- <% if self_hosted? %>
- <% if Current.family&.synth_overage? %>
- <div class="bg-yellow-100 border border-yellow-400 text-yellow-700 px-4 py-3 rounded relative" role="alert">
- Your Synth API credit limit has been exceeded. Please visit your <a href="https://dashboard.synthfinance.com/settings" class="font-medium underline hover:text-yellow-900">Synth billing settings</a> to upgrade your plan or wait for your credits to reset.
- </div>
- <% elsif !Current.family&.synth_valid? %>
- <div class="bg-yellow-100 border border-yellow-400 text-yellow-700 px-4 py-3 rounded relative" role="alert">
- Your Synth API Key is invalid. Please visit your <a href="https://dashboard.synthfinance.com/dashboard" class="font-medium underline hover:text-yellow-900">Synth dashboard</a> and verify that your API key is correct.
- </div>
- <% end %>
- <% end %>
- <header class="flex items-center justify-between">
- <div>
- <h1 class="sr-only"><%= t(".title") %></h1>
- <p class="text-xl font-medium text-primary mb-1">
- <%= Current.user.first_name.present? ? t(".greeting", name: Current.user.first_name ) : t(".fallback_greeting") %>
- </p>
- <% unless @accounts.blank? %>
- <p class="text-secondary text-sm"><%= t(".subtitle") %></p>
- <% end %>
- </div>
+<div class="w-full space-y-6 pb-24">
+ <header class="space-y-6">
+ <nav class="flex items-center gap-2">
+ <button data-action="sidebar#toggle" class="w-9 h-9 inline-flex rounded-lg items-center justify-center hover:bg-gray-100 cursor-pointer">
+ <%= icon("panel-left", color: "gray") %>
+ </button>
+
+ <span class="text-sm text-gray-500 font-medium">Home</span>
+
+ <%= icon("chevron-right", color: "gray", size: "sm") %>
- <div class="flex items-center gap-2">
- <%= contextual_menu do %>
- <div class="w-48 p-1 text-sm leading-6 text-primary bg-white shadow-lg shrink rounded-xl ring-1 ring-gray-900/5">
- <%= contextual_menu_modal_action_item t(".import"), new_import_path, icon: "hard-drive-upload" %>
- </div>
- <% end %>
+ <span class="text-gray-900 font-medium text-sm">Dashboard</span>
+ </nav>
- <%= link_to new_account_path, class: "flex items-center gap-1 btn btn--primary", data: { turbo_frame: "modal" } do %>
- <%= lucide_icon("plus", class: "w-5 h-5") %>
- <span><%= t(".new") %></span>
- <% end %>
+ <div class="space-y-1">
+ <h1 class="text-3xl font-medium text-gray-900">Welcome back, <%= Current.user.first_name %></h1>
+ <p class="text-gray-500">Here's what's happening with your money this week</p>
</div>
</header>
- <% if @accounts.empty? %>
- <%= render "shared/no_account_empty_state" %>
- <% else %>
- <section class="flex gap-4">
- <div class="bg-white border border-alpha-black-25 shadow-xs rounded-xl w-3/4 min-h-48 flex flex-col">
- <div class="flex justify-between p-4">
- <div>
- <%= render partial: "shared/value_heading", locals: {
- label: t(".net_worth"),
- period: @period,
- value: Current.family.net_worth,
- trend: @net_worth_series.trend
- } %>
- </div>
- <%= form_with url: root_path, method: :get, class: "flex items-center gap-4", data: { controller: "auto-submit-form" } do |form| %>
- <%= period_select form: form, selected: @period.name %>
- <% end %>
- </div>
- <%= render partial: "pages/dashboard/net_worth_chart", locals: { series: @net_worth_series } %>
- </div>
- <div class="bg-white p-4 border border-alpha-black-25 shadow-xs rounded-xl w-1/4">
- <%= render partial: "pages/dashboard/allocation_chart", locals: { account_groups: @account_groups } %>
- </div>
- </section>
- <section class="grid grid-cols-2 gap-4">
- <div class="bg-white p-4 border border-alpha-black-25 shadow-xs rounded-xl">
- <div class="flex flex-col gap-4 h-full">
- <div class="flex gap-4">
- <div class="grow">
- <%= render partial: "shared/value_heading", locals: {
- label: t(".income"),
- period: Period.last_30_days,
- value: @income_series.last&.value,
- trend: @income_series.trend
- } %>
- </div>
- <div
- id="incomeChart"
- class="h-full w-2/5"
- data-controller="time-series-chart"
- data-time-series-chart-data-value="<%= @income_series.to_json %>"
- data-time-series-chart-use-labels-value="false"
- data-time-series-chart-use-tooltip-value="false"></div>
- </div>
- <div class="flex gap-1.5 mt-auto">
- <% @top_earners.first(3).each do |account| %>
- <%= link_to account, class: "border border-alpha-black-25 rounded-full p-1 pr-2 flex items-center gap-1 text-xs text-primary font-medium hover:bg-gray-25", data: { controller: "tooltip" } do %>
- <%= render "accounts/logo", account: account, size: "sm" %>
- <span>+<%= Money.new(account.income, account.currency) %></span>
- <%= render partial: "shared/text_tooltip", locals: { tooltip_text: account.name } %>
- <% end %>
- <% end %>
- <% if @top_earners.count > 3 %>
- <div class="bg-gray-25 rounded-full flex h-full aspect-1 items-center justify-center text-xs font-medium text-secondary">+<%= @top_earners.count - 3 %></div>
- <% end %>
- </div>
- </div>
- </div>
- <div class="bg-white p-4 border border-alpha-black-25 shadow-xs rounded-xl">
- <div class="flex flex-col gap-4 h-full">
- <div class="flex gap-4">
- <div class="grow">
- <%= render partial: "shared/value_heading", locals: {
- label: t(".spending"),
- period: Period.last_30_days,
- value: @spending_series.last&.value,
- trend: @spending_series.trend
- } %>
- </div>
- <div
- id="spendingChart"
- class="h-full w-2/5"
- data-controller="time-series-chart"
- data-time-series-chart-data-value="<%= @spending_series.to_json %>"
- data-time-series-chart-use-labels-value="false"
- data-time-series-chart-use-tooltip-value="false"></div>
- </div>
- <div class="mt-auto flex gap-1.5">
- <% @top_spenders.first(3).each do |account| %>
- <%= link_to account, class: "border border-alpha-black-25 rounded-full p-1 pr-2 flex items-center gap-1 text-xs text-primary font-medium hover:bg-gray-25", data: { controller: "tooltip" } do %>
- <%= render "accounts/logo", account: account, size: "sm" %>
- -<%= Money.new(account.spending, account.currency) %>
- <%= render partial: "shared/text_tooltip", locals: { tooltip_text: account.name } %>
- <% end %>
- <% end %>
- <% if @top_spenders.count > 3 %>
- <div class="bg-gray-25 rounded-full flex h-full aspect-1 items-center justify-center text-xs font-medium text-secondary">+<%= @top_spenders.count - 3 %></div>
- <% end %>
- </div>
- </div>
- </div>
- <div class="bg-white p-4 border border-alpha-black-25 shadow-xs rounded-xl">
- <div class="flex flex-col gap-4 h-full">
- <div class="flex gap-4">
- <div class="grow">
- <%= render partial: "shared/value_heading", locals: {
- label: t(".savings_rate"),
- period: Period.last_30_days,
- value: (@savings_rate_series.last&.value)*100,
- trend: @savings_rate_series.trend,
- is_percentage: true
- } %>
- </div>
- <div
- id="savingsRateChart"
- class="h-full w-2/5"
- data-controller="time-series-chart"
- data-time-series-chart-data-value="<%= @savings_rate_series.to_json %>"
- data-time-series-chart-use-labels-value="false"
- data-time-series-chart-use-tooltip-value="false"></div>
- </div>
- <div class="flex gap-1.5">
- <% @top_savers.first(3).each do |account| %>
- <% unless account.savings_rate.infinite? %>
- <%= link_to account, class: "border border-alpha-black-25 rounded-full p-1 pr-2 flex items-center gap-1 text-xs text-primary font-medium hover:bg-gray-25", data: { controller: "tooltip" } do %>
- <%= render "accounts/logo", account: account, size: "sm" %>
- <span><%= account.savings_rate > 0 ? "+" : "-" %><%= number_to_percentage(account.savings_rate.abs * 100, precision: 2) %></span>
- <%= render partial: "shared/text_tooltip", locals: { tooltip_text: account.name } %>
- <% end %>
- <% end %>
- <% end %>
- <% if @top_savers.count > 3 %>
- <div class="bg-gray-25 rounded-full flex h-full aspect-1 items-center justify-center text-xs font-medium text-secondary">+<%= @top_savers.count - 3 %></div>
- <% end %>
- </div>
- </div>
- </div>
- <div class="bg-white p-4 border border-alpha-black-25 shadow-xs rounded-xl">
- <div class="flex gap-4 h-full">
- <div class="grow">
- <%= render partial: "shared/value_heading", locals: {
- label: t(".investing"),
- period: @period,
- value: @investing_series.last.value,
- trend: @investing_series.trend
- } %>
- </div>
- <div
- id="investingChart"
- class="h-full w-2/5"
- data-controller="time-series-chart"
- data-time-series-chart-data-value="<%= @investing_series.to_json %>"
- data-time-series-chart-use-labels-value="false"></div>
- </div>
- </div>
- </section>
- <section class="w-full">
- <div class="bg-white p-4 border border-alpha-black-25 shadow-xs rounded-xl space-y-4">
- <h2 class="text-lg font-medium text-primary"><%= t(".transactions") %></h2>
- <% if @transaction_entries.empty? %>
- <div class="text-secondary flex items-center justify-center py-12">
- <p><%= t(".no_transactions") %></p>
- </div>
- <% else %>
- <div class="text-secondary p-1 space-y-1 bg-gray-25 rounded-xl">
- <%= entries_by_date(@transaction_entries, selectable: false) do |entries, _transfers| %>
- <%= render entries, selectable: false %>
- <% end %>
+ <section class="bg-white py-4 rounded-xl shadow-border-xs">
+ <%= render partial: "pages/dashboard/net_worth_chart", locals: { series: @balance_sheet.net_worth_series(period: @period), period: @period } %>
+ </section>
- <p class="py-2 text-sm text-center"><%= link_to t(".view_all"), transactions_path %></p>
- </div>
- <% end %>
- </div>
- </section>
- <% end %>
+ <section>
+ <%= render "pages/dashboard/balance_sheet", balance_sheet: @balance_sheet %>
+ </section>
</div>
diff --git a/app/views/pages/dashboard/_allocation_chart.html.erb b/app/views/pages/dashboard/_allocation_chart.html.erb
deleted file mode 100644
index 7e59d8b0..00000000
--- a/app/views/pages/dashboard/_allocation_chart.html.erb
+++ /dev/null
@@ -1,29 +0,0 @@
-<%# locals: (account_groups:) -%>
-<div data-controller="tabs" data-tabs-active-class="bg-white border-alpha-black-25 shadow-xs text-primary" data-tabs-default-tab-value="asset-tab">
- <div class="bg-gray-25 rounded-lg p-1 flex gap-1 text-sm text-secondary font-medium">
- <button data-id="asset-tab" class="w-1/2 px-2 py-1 rounded-md border border-transparent" data-tabs-target="btn" data-action="tabs#select"><%= t(".assets") %></button>
- <button data-id="liability-tab" class="w-1/2 px-2 py-1 rounded-md border border-transparent" data-tabs-target="btn" data-action="tabs#select"><%= t(".debts") %></button>
- </div>
- <div>
- <div data-tabs-target="tab" id="asset-tab" class="space-y-6">
- <div class="text-secondary flex items-center justify-center py-6">
- <div
- data-controller="pie-chart"
- class="w-full aspect-1"
- data-pie-chart-data-value="<%= value_group_pie_data(account_groups[:assets]) %>"
- data-pie-chart-total-value="<%= format_money(account_groups[:assets].sum, precision: 0) %>">
- </div>
- </div>
- </div>
- <div data-tabs-target="tab" id="liability-tab" class="space-y-6 hidden">
- <div class="text-secondary flex items-center justify-center py-6">
- <div
- data-controller="pie-chart"
- class="w-full aspect-1"
- data-pie-chart-data-value="<%= value_group_pie_data(account_groups[:liabilities]) %>"
- data-pie-chart-total-value="<%= format_money(account_groups[:liabilities].sum, precision: 0) %>">
- </div>
- </div>
- </div>
- </div>
-</div>
diff --git a/app/views/pages/dashboard/_balance_sheet.html.erb b/app/views/pages/dashboard/_balance_sheet.html.erb
new file mode 100644
index 00000000..cd0c1c7d
--- /dev/null
+++ b/app/views/pages/dashboard/_balance_sheet.html.erb
@@ -0,0 +1,103 @@
+<%# locals: (balance_sheet:) %>
+
+<div class="space-y-4">
+ <% balance_sheet.classification_groups.each do |classification_group| %>
+ <div class="bg-white shadow-border-xs rounded-xl space-y-4 p-4">
+ <h2 class="text-lg font-medium"><%= classification_group.display_name %></h2>
+
+ <% if classification_group.account_groups.any? %>
+ <div class="space-y-4">
+ <div class="flex gap-1">
+ <% classification_group.account_groups.each do |account_group| %>
+ <div class="h-1.5 rounded-sm" style="width: <%= account_group.weight %>%; background-color: <%= account_group.color %>;"></div>
+ <% end %>
+ </div>
+ <div class="flex gap-4">
+ <% classification_group.account_groups.each do |account_group| %>
+ <div class="flex items-center gap-2 text-sm">
+ <div class="h-2.5 w-2.5 rounded-full" style="background-color: <%= account_group.color %>;"></div>
+ <p class="text-secondary"><%= account_group.name %></p>
+ <p class="text-black"><%= number_to_percentage(account_group.weight, precision: 0) %></p>
+ </div>
+ <% end %>
+ </div>
+ </div>
+
+ <div class="bg-surface rounded-xl p-1 space-y-1">
+ <div class="px-4 py-2 flex items-center uppercase text-xs font-medium text-secondary">
+ <div>Name</div>
+ <div class="ml-auto text-right flex items-center gap-6">
+ <div class="w-24">
+ <p>Weight</p>
+ </div>
+ <div class="w-40">
+ <p>Value</p>
+ </div>
+ </div>
+ </div>
+
+ <div class="shadow-border-xs rounded-lg bg-white">
+ <% classification_group.account_groups.each do |account_group| %>
+ <details class="group rounded-lg open:bg-surface font-medium text-sm">
+ <summary class="cursor-pointer p-4 group-open:bg-surface bg-white rounded-lg flex items-center justify-between">
+ <div class="flex items-center gap-4">
+ <%= lucide_icon("chevron-right", class: "group-open:rotate-90 text-secondary w-5 h-5") %>
+
+ <p><%= account_group.name %></p>
+ </div>
+
+ <div class="ml-auto flex items-center text-right gap-6">
+ <div class="w-24 flex items-center justify-end gap-2">
+ <%= render partial: "shared/progress_circle", locals: { progress: account_group.weight, color: account_group.color } %>
+ <p><%= number_to_percentage(account_group.weight, precision: 0) %></p>
+ </div>
+
+ <div class="w-40">
+ <p><%= format_money(account_group.total_money) %></p>
+ </div>
+ </div>
+ </summary>
+
+ <div>
+ <% account_group.accounts.each_with_index do |account, idx| %>
+ <div class="pl-12 pr-4 py-3 flex items-center justify-between text-sm font-medium">
+ <div class="flex items-center gap-3">
+ <%= render "accounts/logo", account: account, size: "sm", color: account_group.color %>
+ <%= link_to account.name, account_path(account) %>
+ </div>
+
+ <div class="ml-auto flex items-center text-right gap-6">
+ <div class="w-24 flex items-center justify-end gap-2">
+ <%= render partial: "shared/progress_circle", locals: { progress: account.weight, color: account_group.color } %>
+ <p><%= number_to_percentage(account.weight, precision: 0) %></p>
+ </div>
+
+ <div class="w-40">
+ <p><%= format_money(account.balance_money) %></p>
+ </div>
+ </div>
+ </div>
+
+ <% if idx < account_group.accounts.size - 1 %>
+
+ <div class="pl-[84px] pr-40">
+ <div class="w-full border-subdued border-b"></div>
+ </div>
+ <% end %>
+ <% end %>
+ </div>
+ </details>
+ <% end %>
+ </div>
+ </div>
+
+ <% else %>
+ <div class="py-20 flex flex-col items-center">
+ <%= lucide_icon classification_group.icon, class: "w-6 h-6 shrink-0 text-secondary" %>
+ <p class="text-primary text-sm font-medium mb-1 mt-4">No <%= classification_group.display_name %></p>
+ <p class="text-secondary text-sm max-w-xs text-center"><%= "You have no #{classification_group.display_name}" %></p>
+ </div>
+ <% end %>
+ </div>
+ <% end %>
+</div>
diff --git a/app/views/pages/dashboard/_net_worth_chart.html.erb b/app/views/pages/dashboard/_net_worth_chart.html.erb
index 0aec643a..ebf6a98b 100644
--- a/app/views/pages/dashboard/_net_worth_chart.html.erb
+++ b/app/views/pages/dashboard/_net_worth_chart.html.erb
@@ -1,16 +1,37 @@
-<%# locals: (series:) %>
-<% if series.has_current_day_value? %>
+<%# locals: (series:, period:) %>
+
+<div class="flex justify-between p-4">
+ <div class="space-y-2">
+ <div class="space-y-2">
+ <p class="text-sm text-secondary font-medium">Net Worth</p>
+ <p class="text-primary -space-x-0.5 text-xl font-medium">
+ <%= series.current.format %>
+ </p>
+ <% if series.trend.nil? %>
+ <p class="text-sm text-secondary">Data not available for the selected period</p>
+ <% elsif series.trend.direction.flat? %>
+ <p class="text-sm text-secondary">No change vs. prior period</p>
+ <% else %>
+ <div class="flex items-center gap-2">
+ <%= render partial: "shared/trend_change", locals: { trend: series.trend } %>
+ <span class="text-sm text-secondary"><%= period.comparison_label %></span>
+ </div>
+ <% end %>
+ </div>
+ </div>
+ <%= form_with url: root_path, method: :get, class: "flex items-center gap-4", data: { controller: "auto-submit-form" } do |form| %>
+ <%= period_select form: form, selected: period %>
+ <% end %>
+</div>
+
+<% if series.any? %>
<div
id="netWorthChart"
class="w-full flex-1 min-h-52"
data-controller="time-series-chart"
data-time-series-chart-data-value="<%= series.to_json %>"></div>
-<% elsif series.empty? %>
- <div class="w-full h-full flex items-center justify-center">
- <p class="text-secondary text-sm">No data available for the selected period.</p>
- </div>
<% else %>
<div class="w-full h-full flex items-center justify-center">
- <p class="text-secondary text-sm animate-pulse">Calculating latest balance data...</p>
+ <p class="text-secondary text-sm">No data available for the selected period.</p>
</div>
<% end %>
diff --git a/app/views/shared/_no_account_empty_state.html.erb b/app/views/pages/dashboard/_no_account_empty_state.html.erb
similarity index 100%
rename from app/views/shared/_no_account_empty_state.html.erb
rename to app/views/pages/dashboard/_no_account_empty_state.html.erb
diff --git a/app/views/pages/feedback.html.erb b/app/views/pages/feedback.html.erb
index dc7f33dc..b043f930 100644
--- a/app/views/pages/feedback.html.erb
+++ b/app/views/pages/feedback.html.erb
@@ -1,35 +1,28 @@
-<% content_for :sidebar do %>
- <%= render "settings/nav" %>
-<% end %>
+<%= content_for :page_title, "Feedback" %>
-<div class="space-y-4">
- <h1 class="text-primary text-xl font-medium mb-4">Feedback</h1>
- <div class="bg-white shadow-xs border border-alpha-black-25 rounded-xl p-4">
- <h2 class="text-lg font-medium text-primary mb-1">Leave feedback</h2>
- <p class="text-sm text-secondary mb-4">Let us know if you have any specific feedback. Feel free to include links to videos or screenshots.</p>
- <div class="flex gap-2">
- <%= link_to "https://github.com/maybe-finance/maybe/discussions/categories/feature-requests", target: "_blank", rel: "noopener noreferrer", class: "w-1/3 flex flex-col items-center p-4 border border-alpha-black-25 rounded-xl hover:bg-gray-50" do %>
+<div class="bg-white shadow-border-xs rounded-xl p-4">
+ <h2 class="text-lg font-medium text-primary mb-1">Leave feedback</h2>
+ <p class="text-sm text-secondary mb-4">Let us know if you have any specific feedback. Feel free to include links to videos or screenshots.</p>
+ <div class="flex gap-2">
+ <%= link_to "https://github.com/maybe-finance/maybe/discussions/categories/feature-requests", target: "_blank", rel: "noopener noreferrer", class: "w-1/3 flex flex-col items-center p-4 border border-alpha-black-25 rounded-xl hover:bg-gray-50" do %>
+ <%= image_tag "github-icon.svg", class: "w-8 h-8 mb-2" %>
+ <span class="text-sm font-medium text-primary">Write a feature request</span>
+ <% end %>
+ <% if self_hosted? %>
+ <%= link_to "https://github.com/maybe-finance/maybe/issues/new?assignees=&labels=bug&template=bug_report.md&title=", target: "_blank", rel: "noopener noreferrer", class: "w-1/3 flex flex-col items-center p-4 border border-alpha-black-25 rounded-xl hover:bg-gray-50" do %>
<%= image_tag "github-icon.svg", class: "w-8 h-8 mb-2" %>
- <span class="text-sm font-medium text-primary">Write a feature request</span>
+ <span class="text-sm font-medium text-primary">File a bug report</span>
<% end %>
- <% if self_hosted? %>
- <%= link_to "https://github.com/maybe-finance/maybe/issues/new?assignees=&labels=bug&template=bug_report.md&title=", target: "_blank", rel: "noopener noreferrer", class: "w-1/3 flex flex-col items-center p-4 border border-alpha-black-25 rounded-xl hover:bg-gray-50" do %>
- <%= image_tag "github-icon.svg", class: "w-8 h-8 mb-2" %>
- <span class="text-sm font-medium text-primary">File a bug report</span>
- <% end %>
- <% else %>
- <%= link_to "mailto:[email protected]", class: "w-1/3 flex flex-col items-center p-4 border border-alpha-black-25 rounded-xl hover:bg-gray-50", onclick: "Intercom('showNewMessage'); return false;" do %>
- <%= lucide_icon "bug", class: "w-8 h-8 mb-2" %>
- <span class="text-sm font-medium text-primary">File a bug report</span>
- <% end %>
+ <% else %>
+ <%= link_to "mailto:[email protected]", class: "w-1/3 flex flex-col items-center p-4 border border-alpha-black-25 rounded-xl hover:bg-gray-50", onclick: "Intercom('showNewMessage'); return false;" do %>
+ <%= lucide_icon "bug", class: "w-8 h-8 mb-2" %>
+ <span class="text-sm font-medium text-primary">File a bug report</span>
<% end %>
+ <% end %>
- <%= link_to "https://link.maybe.co/discord", target: "_blank", rel: "noopener noreferrer", class: "w-1/3 flex flex-col items-center p-4 border border-alpha-black-25 rounded-xl hover:bg-gray-50" do %>
- <%= image_tag "discord-icon.svg", class: "w-8 h-8 mb-2" %>
- <span class="text-sm font-medium text-primary">Discuss Maybe with others</span>
- <% end %>
- </div>
+ <%= link_to "https://link.maybe.co/discord", target: "_blank", rel: "noopener noreferrer", class: "w-1/3 flex flex-col items-center p-4 border border-alpha-black-25 rounded-xl hover:bg-gray-50" do %>
+ <%= image_tag "discord-icon.svg", class: "w-8 h-8 mb-2" %>
+ <span class="text-sm font-medium text-primary">Discuss Maybe with others</span>
+ <% end %>
</div>
-
- <%= settings_nav_footer %>
</div>
diff --git a/app/views/plaid_items/_plaid_item.html.erb b/app/views/plaid_items/_plaid_item.html.erb
index 46f24742..ee009eef 100644
--- a/app/views/plaid_items/_plaid_item.html.erb
+++ b/app/views/plaid_items/_plaid_item.html.erb
@@ -1,7 +1,7 @@
<%# locals: (plaid_item:) %>
<%= tag.div id: dom_id(plaid_item) do %>
- <details open class="group bg-white p-4 border border-alpha-black-25 shadow-xs rounded-xl">
+ <details open class="group bg-white p-4 shadow-border-xs rounded-xl">
<summary class="flex items-center justify-between gap-2 focus-visible:outline-hidden">
<div class="flex items-center gap-2">
<%= lucide_icon "chevron-right", class: "group-open:transform group-open:rotate-90 text-secondary w-5" %>
@@ -50,15 +50,14 @@
<% if plaid_item.requires_update? %>
<% begin %>
<% link_token = plaid_item.get_update_link_token(webhooks_url: plaid_webhooks_url(plaid_item.plaid_region), redirect_url: accounts_url) %>
- <button
- data-controller="plaid"
- data-action="plaid#open"
+ <button
+ data-controller="plaid"
+ data-action="plaid#open"
data-plaid-region-value="<%= plaid_item.plaid_region %>"
data-plaid-link-token-value="<%= link_token %>"
data-plaid-is-update-value="true"
data-plaid-item-id-value="<%= plaid_item.id %>"
- class="btn btn--secondary flex items-center gap-2"
- >
+ class="btn btn--secondary flex items-center gap-2">
<%= lucide_icon "refresh-cw", class: "w-4 h-4" %>
<%= tag.span t(".update") %>
</button>
diff --git a/app/views/settings/_section.html.erb b/app/views/settings/_section.html.erb
index c9849461..0b0f58ef 100644
--- a/app/views/settings/_section.html.erb
+++ b/app/views/settings/_section.html.erb
@@ -1,5 +1,5 @@
<%# locals: (title:, subtitle: nil, content:) %>
-<section class="bg-white border border-alpha-black-25 shadow-xs rounded-xl p-4 space-y-4">
+<section class="bg-white shadow-border-xs rounded-xl p-4 space-y-4">
<div>
<h2 class="text-lg font-medium text-primary"><%= title %></h2>
<% if subtitle.present? %>
diff --git a/app/views/settings/_nav.html.erb b/app/views/settings/_settings_nav.html.erb
similarity index 56%
rename from app/views/settings/_nav.html.erb
rename to app/views/settings/_settings_nav.html.erb
index b1dc91a7..7276cbc4 100644
--- a/app/views/settings/_nav.html.erb
+++ b/app/views/settings/_settings_nav.html.erb
@@ -16,28 +16,33 @@
</div>
<ul class="space-y-1">
<li>
- <%= sidebar_link_to t(".profile_label"), settings_profile_path, icon: "circle-user" %>
+ <%= render "settings/settings_nav_item", name: t(".profile_label"), path: settings_profile_path, icon: "circle-user" %>
</li>
+
<li>
- <%= sidebar_link_to t(".preferences_label"), settings_preferences_path, icon: "bolt" %>
+ <%= render "settings/settings_nav_item", name: t(".preferences_label"), path: settings_preferences_path, icon: "bolt" %>
</li>
+
<li>
- <%= sidebar_link_to t(".security_label"), settings_security_path, icon: "shield-check" %>
+ <%= render "settings/settings_nav_item", name: t(".security_label"), path: settings_security_path, icon: "shield-check" %>
</li>
+
<% if self_hosted? %>
<li>
- <%= sidebar_link_to t(".self_hosting_label"), settings_hosting_path, icon: "database" %>
+ <%= render "settings/settings_nav_item", name: t(".self_hosting_label"), path: settings_hosting_path, icon: "database" %>
</li>
<% end %>
+
<li>
- <%= sidebar_link_to t(".billing_label"), settings_billing_path, icon: "circle-dollar-sign" %>
+ <%= render "settings/settings_nav_item", name: t(".billing_label"), path: settings_billing_path, icon: "circle-dollar-sign" %>
</li>
+
<li>
- <%= sidebar_link_to t(".accounts_label"), accounts_path, icon: "layers" %>
+ <%= render "settings/settings_nav_item", name: t(".accounts_label"), path: accounts_path, icon: "layers" %>
</li>
<li>
- <%= sidebar_link_to t(".imports_label"), imports_path, icon: "download" %>
+ <%= render "settings/settings_nav_item", name: t(".imports_label"), path: imports_path, icon: "download" %>
</li>
</ul>
</section>
@@ -49,13 +54,13 @@
</div>
<ul class="space-y-1">
<li>
- <%= sidebar_link_to t(".tags_label"), tags_path, icon: "tags" %>
+ <%= render "settings/settings_nav_item", name: t(".tags_label"), path: tags_path, icon: "tags" %>
</li>
<li>
- <%= sidebar_link_to t(".categories_label"), categories_path, icon: "shapes" %>
+ <%= render "settings/settings_nav_item", name: t(".categories_label"), path: categories_path, icon: "shapes" %>
</li>
<li>
- <%= sidebar_link_to t(".merchants_label"), merchants_path, icon: "store" %>
+ <%= render "settings/settings_nav_item", name: t(".merchants_label"), path: merchants_path, icon: "store" %>
</li>
</ul>
</section>
@@ -67,14 +72,14 @@
</div>
<ul class="space-y-1">
<li>
- <%= sidebar_link_to t(".whats_new_label"), changelog_path, icon: "box" %>
- <%= sidebar_link_to t(".feedback_label"), feedback_path, icon: "megaphone" %>
+ <%= render "settings/settings_nav_item", name: t(".whats_new_label"), path: changelog_path, icon: "box" %>
+ <%= render "settings/settings_nav_item", name: t(".feedback_label"), path: feedback_path, icon: "megaphone" %>
</li>
</ul>
</section>
<section>
- <%= button_to session_path(Current.session), method: :delete, class: "flex items-center gap-2 px-3 py-2 rounded-xl border text-sm font-medium w-full text-error hover:bg-gray-100 border-transparent" do %>
+ <%= button_to session_path(Current.session), method: :delete, class: "flex items-center gap-2 btn btn--ghost text-destructive w-full" do %>
<%= lucide_icon("log-out", class: "w-5 h-5 shrink-0") %>
<span><%= t(".logout") %></span>
<% end %>
diff --git a/app/views/settings/_settings_nav_item.html.erb b/app/views/settings/_settings_nav_item.html.erb
new file mode 100644
index 00000000..1af9fdaf
--- /dev/null
+++ b/app/views/settings/_settings_nav_item.html.erb
@@ -0,0 +1,9 @@
+<%# locals: (name:, path:, icon:) %>
+
+<%= link_to path, class: class_names(
+ "flex items-center gap-2 btn btn--ghost",
+ page_active?(path) ? "text-primary bg-white shadow-border-xs" : "text-secondary hover:bg-gray-100 border-transparent"
+), aria: { current: ("page" if page_active?(path)) } do %>
+ <%= lucide_icon(icon, class: "w-5 h-5") if icon %>
+ <%= name %>
+<% end %>
diff --git a/app/views/settings/_nav_link_large.html.erb b/app/views/settings/_settings_nav_link_large.html.erb
similarity index 100%
rename from app/views/settings/_nav_link_large.html.erb
rename to app/views/settings/_settings_nav_link_large.html.erb
diff --git a/app/views/settings/billings/show.html.erb b/app/views/settings/billings/show.html.erb
index 7b1a90b3..ddf53db0 100644
--- a/app/views/settings/billings/show.html.erb
+++ b/app/views/settings/billings/show.html.erb
@@ -1,47 +1,40 @@
-<% content_for :sidebar do %>
- <%= render "settings/nav" %>
-<% end %>
-
-<div class="space-y-4">
- <h1 class="text-primary text-xl font-medium mb-4"><%= t(".page_title") %></h1>
- <%= settings_section title: t(".subscription_title"), subtitle: t(".subscription_subtitle") do %>
- <div class="space-y-4">
- <div class="p-3 shadow-xs bg-white border border-secondary rounded-lg flex justify-between items-center">
- <div class="flex items-center gap-3">
- <div class="w-9 h-9 rounded-full bg-gray-25 flex justify-center items-center">
- <%= lucide_icon "gem", class: "w-5 h-5 text-secondary" %>
- </div>
+<%= content_for :page_title, t(".page_title") %>
- <div class="text-sm space-y-1">
- <% if @user.family.subscribed? || subscription_pending? %>
- <p class="text-primary">You are currently subscribed to <span class="font-medium">Maybe+</span></p>
- <p class="text-secondary">Manage your billing settings here.</p>
- <% else %>
- <p class="text-primary">You are currently <span class="font-medium">not subscribed</span></p>
- <p class="text-secondary">Once you subscribe to Maybe+, you’ll see your billing settings here.</p>
- <% end %>
- </div>
+<%= settings_section title: t(".subscription_title"), subtitle: t(".subscription_subtitle") do %>
+ <div class="space-y-4">
+ <div class="p-3 shadow-border-xs bg-white rounded-lg flex justify-between items-center">
+ <div class="flex items-center gap-3">
+ <div class="w-9 h-9 rounded-full bg-gray-25 flex justify-center items-center">
+ <%= lucide_icon "gem", class: "w-5 h-5 text-secondary" %>
</div>
- <% if @user.family.subscribed? || subscription_pending? %>
- <%= link_to subscription_path, class: "btn btn--secondary flex items-center gap-1" do %>
- <span>Manage</span>
- <%= lucide_icon "external-link", class: "w-5 h-5 shrink-0 text-secondary" %>
- <% end %>
- <% else %>
- <%= link_to new_subscription_path, class: "btn btn--secondary flex items-center gap-1" do %>
- <span>Subscribe</span>
- <%= lucide_icon "external-link", class: "w-5 h-5 shrink-0 text-secondary" %>
+ <div class="text-sm space-y-1">
+ <% if @user.family.subscribed? || subscription_pending? %>
+ <p class="text-primary">You are currently subscribed to <span class="font-medium">Maybe+</span></p>
+ <p class="text-secondary">Manage your billing settings here.</p>
+ <% else %>
+ <p class="text-primary">You are currently <span class="font-medium">not subscribed</span></p>
+ <p class="text-secondary">Once you subscribe to Maybe+, you'll see your billing settings here.</p>
<% end %>
- <% end %>
+ </div>
</div>
- <div class="flex items-center gap-2">
- <%= image_tag "stripe-logo.svg", class: "w-5 h-5 shrink-0" %>
- <p class="text-secondary text-sm">Managed via Stripe</p>
- </div>
+ <% if @user.family.subscribed? || subscription_pending? %>
+ <%= link_to subscription_path, class: "btn btn--secondary flex items-center gap-1" do %>
+ <span>Manage</span>
+ <%= lucide_icon "external-link", class: "w-5 h-5 shrink-0 text-secondary" %>
+ <% end %>
+ <% else %>
+ <%= link_to new_subscription_path, class: "btn btn--secondary flex items-center gap-1" do %>
+ <span>Subscribe</span>
+ <%= lucide_icon "external-link", class: "w-5 h-5 shrink-0 text-secondary" %>
+ <% end %>
+ <% end %>
</div>
- <% end %>
- <%= settings_nav_footer %>
-</div>
+ <div class="flex items-center gap-2">
+ <%= image_tag "stripe-logo.svg", class: "w-5 h-5 shrink-0" %>
+ <p class="text-secondary text-sm">Managed via Stripe</p>
+ </div>
+ </div>
+<% end %>
diff --git a/app/views/settings/hostings/show.html.erb b/app/views/settings/hostings/show.html.erb
index 4684a041..ca74914a 100644
--- a/app/views/settings/hostings/show.html.erb
+++ b/app/views/settings/hostings/show.html.erb
@@ -1,21 +1,13 @@
-<% content_for :sidebar do %>
- <%= render "settings/nav" %>
+<%= content_for :page_title, t(".title") %>
+
+<%= settings_section title: t(".general") do %>
+ <div class="space-y-6">
+ <%= render "settings/hostings/upgrade_settings" %>
+ <%= render "settings/hostings/provider_settings" %>
+ <%= render "settings/hostings/synth_settings" %>
+ </div>
<% end %>
-<div class="space-y-4 pb-32">
- <h1 class="text-primary text-xl font-medium mb-4"><%= t(".title") %></h1>
-
- <%= settings_section title: t(".general") do %>
- <div class="space-y-6">
- <%= render "settings/hostings/upgrade_settings" %>
- <%= render "settings/hostings/provider_settings" %>
- <%= render "settings/hostings/synth_settings" %>
- </div>
- <% end %>
-
- <%= settings_section title: t(".invites") do %>
- <%= render "settings/hostings/invite_code_settings" %>
- <% end %>
-
- <%= settings_nav_footer %>
-</div>
+<%= settings_section title: t(".invites") do %>
+ <%= render "settings/hostings/invite_code_settings" %>
+<% end %>
diff --git a/app/views/settings/preferences/show.html.erb b/app/views/settings/preferences/show.html.erb
index 4b0a6ea0..c51444dc 100644
--- a/app/views/settings/preferences/show.html.erb
+++ b/app/views/settings/preferences/show.html.erb
@@ -1,77 +1,70 @@
-<% content_for :sidebar do %>
- <%= render "settings/nav" %>
-<% end %>
+<%= content_for :page_title, t(".page_title") %>
-<div class="space-y-4">
- <h1 class="text-primary text-xl font-medium mb-4"><%= t(".page_title") %></h1>
- <%= settings_section title: t(".general_title"), subtitle: t(".general_subtitle") do %>
- <div>
- <%= styled_form_with model: @user, class: "space-y-4", data: { controller: "auto-submit-form" } do |form| %>
- <%= form.hidden_field :redirect_to, value: "preferences" %>
+<%= settings_section title: t(".general_title"), subtitle: t(".general_subtitle") do %>
+ <div>
+ <%= styled_form_with model: @user, class: "space-y-4", data: { controller: "auto-submit-form" } do |form| %>
+ <%= form.hidden_field :redirect_to, value: "preferences" %>
- <%= form.fields_for :family do |family_form| %>
- <%= family_form.select :currency,
+ <%= form.fields_for :family do |family_form| %>
+ <%= family_form.select :currency,
currencies_for_select.map { |currency| [ "#{currency.name} (#{currency.iso_code})", currency.iso_code ] },
{ label: t(".currency") }, disabled: true %>
- <%= family_form.select :locale,
+ <%= family_form.select :locale,
language_options,
{ label: t(".language") },
{ data: { auto_submit_form_target: "auto" } } %>
- <%= family_form.select :timezone,
+ <%= family_form.select :timezone,
timezone_options,
{ label: t(".timezone") },
{ data: { auto_submit_form_target: "auto" } } %>
- <%= family_form.select :date_format,
+ <%= family_form.select :date_format,
Family::DATE_FORMATS,
{ label: t(".date_format") },
{ data: { auto_submit_form_target: "auto" } } %>
- <%= family_form.select :country,
+ <%= family_form.select :country,
country_options,
{ label: t(".country") },
{ data: { auto_submit_form_target: "auto" } } %>
- <p class="text-xs italic pl-2 text-secondary">Please note, we are still working on translations for various languages. Please see the <%= link_to "I18n issue", "https://github.com/maybe-finance/maybe/issues/1225", target: "_blank", class: "underline" %> for more information.</p>
- <% end %>
+ <p class="text-xs italic pl-2 text-secondary">Please note, we are still working on translations for various languages. Please see the <%= link_to "I18n issue", "https://github.com/maybe-finance/maybe/issues/1225", target: "_blank", class: "underline" %> for more information.</p>
<% end %>
- </div>
- <% end %>
+ <% end %>
+ </div>
+<% end %>
- <%= settings_section title: t(".data"), subtitle: t(".data_subtitle") do %>
- <%= render "settings/preferences/data_enrichment_settings", user: @user %>
- <% end %>
+<%= settings_section title: t(".data"), subtitle: t(".data_subtitle") do %>
+ <%= render "settings/preferences/data_enrichment_settings", user: @user %>
+<% end %>
- <%= settings_section title: t(".theme_title"), subtitle: t(".theme_subtitle") do %>
- <div>
- <%= styled_form_with model: @user, class: "flex justify-between items-center" do |form| %>
- <%= form.hidden_field :redirect_to, value: "preferences" %>
- <div class="text-center">
- <%= image_tag("light-mode-preview.png", alt: "Light Theme Preview", class: "h-44 mb-4") %>
- <div class="flex justify-center items-center gap-2">
- <%= form.radio_button :theme, t(".theme_light"), checked: true %>
- <%= form.label :theme_light, t(".theme_light"), value: "light" %>
- </div>
+<%= settings_section title: t(".theme_title"), subtitle: t(".theme_subtitle") do %>
+ <div>
+ <%= styled_form_with model: @user, class: "flex justify-between items-center" do |form| %>
+ <%= form.hidden_field :redirect_to, value: "preferences" %>
+ <div class="text-center">
+ <%= image_tag("light-mode-preview.png", alt: "Light Theme Preview", class: "h-44 mb-4") %>
+ <div class="flex justify-center items-center gap-2">
+ <%= form.radio_button :theme, t(".theme_light"), checked: true %>
+ <%= form.label :theme_light, t(".theme_light"), value: "light" %>
</div>
- <div class="text-center">
- <%= image_tag("dark-mode-preview.png", alt: "Dark Theme Preview", class: "h-44 mb-4") %>
- <div class="flex justify-center items-center gap-2">
- <%= form.radio_button :theme, t(".theme_dark"), disabled: true, class: "cursor-not-allowed" %>
- <%= form.label :theme_dark, t(".theme_dark"), value: "dark" %>
- </div>
+ </div>
+ <div class="text-center">
+ <%= image_tag("dark-mode-preview.png", alt: "Dark Theme Preview", class: "h-44 mb-4") %>
+ <div class="flex justify-center items-center gap-2">
+ <%= form.radio_button :theme, t(".theme_dark"), disabled: true, class: "cursor-not-allowed" %>
+ <%= form.label :theme_dark, t(".theme_dark"), value: "dark" %>
</div>
- <div class="text-center">
- <%= image_tag("system-mode-preview.png", alt: "System Theme Preview", class: "h-44 mb-4") %>
- <div class="flex items-center gap-2 justify-center">
- <%= form.radio_button :theme, t(".theme_system"), disabled: true, class: "cursor-not-allowed" %>
- <%= form.label :theme_system, t(".theme_system"), value: "system" %>
- </div>
+ </div>
+ <div class="text-center">
+ <%= image_tag("system-mode-preview.png", alt: "System Theme Preview", class: "h-44 mb-4") %>
+ <div class="flex items-center gap-2 justify-center">
+ <%= form.radio_button :theme, t(".theme_system"), disabled: true, class: "cursor-not-allowed" %>
+ <%= form.label :theme_system, t(".theme_system"), value: "system" %>
</div>
- <% end %>
- </div>
- <% end %>
-
- <%= settings_nav_footer %>
-</div>
+ </div>
+ <% end %>
+ </div>
+<% end %>
diff --git a/app/views/settings/profiles/show.html.erb b/app/views/settings/profiles/show.html.erb
index 95c248bf..165f9b1c 100644
--- a/app/views/settings/profiles/show.html.erb
+++ b/app/views/settings/profiles/show.html.erb
@@ -1,57 +1,54 @@
-<% content_for :sidebar do %>
- <%= render "settings/nav" %>
-<% end %>
-<div class="space-y-4">
- <h1 class="text-primary text-xl font-medium mb-4"><%= t(".page_title") %></h1>
- <div class="space-y-4">
- <%= settings_section title: t(".profile_title"), subtitle: t(".profile_subtitle") do %>
- <%= styled_form_with model: @user, url: user_path(@user), class: "space-y-4" do |form| %>
- <%= render "settings/user_avatar_field", form: form, user: @user %>
+<%= content_for :page_title, t(".page_title") %>
- <div>
- <%= form.email_field :email, placeholder: t(".email"), label: t(".email") %>
- <% if @user.unconfirmed_email.present? %>
- <p class="mt-2 text-sm text-gray-600">
- You have requested to change your email to <%= @user.unconfirmed_email %>. Please go to your email and confirm for the change to take effect.
- </p>
- <% end %>
- <div class="grid grid-cols-2 gap-4 mt-4">
- <%= form.text_field :first_name, placeholder: t(".first_name"), label: t(".first_name") %>
- <%= form.text_field :last_name, placeholder: t(".last_name"), label: t(".last_name") %>
- </div>
- <div class="flex justify-end mt-4">
- <%= form.submit t(".save"), class: "bg-gray-900 hover:bg-gray-700 cursor-pointer text-white rounded-lg px-3 py-2" %>
- </div>
- </div>
+<%= settings_section title: t(".profile_title"), subtitle: t(".profile_subtitle") do %>
+ <%= styled_form_with model: @user, url: user_path(@user), class: "space-y-4" do |form| %>
+ <%= render "settings/user_avatar_field", form: form, user: @user %>
+
+ <div>
+ <%= form.email_field :email, placeholder: t(".email"), label: t(".email") %>
+ <% if @user.unconfirmed_email.present? %>
+ <p class="mt-2 text-sm text-gray-600">
+ You have requested to change your email to <%= @user.unconfirmed_email %>. Please go to your email and confirm for the change to take effect.
+ </p>
<% end %>
- <% end %>
- <%= settings_section title: t(".household_title"), subtitle: t(".household_subtitle") do %>
- <div class="space-y-4">
- <%= styled_form_with model: Current.user, class: "space-y-4", data: { controller: "auto-submit-form" } do |form| %>
- <%= form.fields_for :family do |family_fields| %>
- <%= family_fields.text_field :name,
+ <div class="grid grid-cols-2 gap-4 mt-4">
+ <%= form.text_field :first_name, placeholder: t(".first_name"), label: t(".first_name") %>
+ <%= form.text_field :last_name, placeholder: t(".last_name"), label: t(".last_name") %>
+ </div>
+ <div class="flex justify-end mt-4">
+ <%= form.submit t(".save"), class: "bg-gray-900 hover:bg-gray-700 cursor-pointer text-white rounded-lg px-3 py-2" %>
+ </div>
+ </div>
+ <% end %>
+<% end %>
+
+<%= settings_section title: t(".household_title"), subtitle: t(".household_subtitle") do %>
+ <div class="space-y-4">
+ <%= styled_form_with model: Current.user, class: "space-y-4", data: { controller: "auto-submit-form" } do |form| %>
+ <%= form.fields_for :family do |family_fields| %>
+ <%= family_fields.text_field :name,
placeholder: t(".household_form_input_placeholder"),
label: t(".household_form_label"),
disabled: !Current.user.admin?,
"data-auto-submit-form-target": "auto" %>
- <% end %>
- <% end %>
- <div class="bg-gray-25 rounded-xl p-1">
- <div class="px-4 py-2">
- <p class="uppercase text-xs text-secondary font-medium"><%= Current.family.name %> &middot; <%= Current.family.users.size %></p>
+ <% end %>
+ <% end %>
+ <div class="bg-gray-25 rounded-xl p-1">
+ <div class="px-4 py-2">
+ <p class="uppercase text-xs text-secondary font-medium"><%= Current.family.name %> &middot; <%= Current.family.users.size %></p>
+ </div>
+ <% @users.each do |user| %>
+ <div class="flex gap-2 items-center bg-white p-4 border border-alpha-black-25 rounded-lg">
+ <div class="w-9 h-9 shrink-0">
+ <%= render "settings/user_avatar", user: user %>
</div>
- <% @users.each do |user| %>
- <div class="flex gap-2 items-center bg-white p-4 border border-alpha-black-25 rounded-lg">
- <div class="w-9 h-9 shrink-0">
- <%= render "settings/user_avatar", user: user %>
- </div>
- <p class="text-primary font-medium text-sm"><%= user.display_name %></p>
- <div class="rounded-md bg-gray-100 px-1.5 py-0.5">
- <p class="uppercase text-secondary font-medium text-xs"><%= user.role %></p>
- </div>
- <% if Current.user.admin? && user != Current.user %>
- <div class="ml-auto">
- <%= button_to settings_profile_path(user_id: user),
+ <p class="text-primary font-medium text-sm"><%= user.display_name %></p>
+ <div class="rounded-md bg-gray-100 px-1.5 py-0.5">
+ <p class="uppercase text-secondary font-medium text-xs"><%= user.role %></p>
+ </div>
+ <% if Current.user.admin? && user != Current.user %>
+ <div class="ml-auto">
+ <%= button_to settings_profile_path(user_id: user),
method: :delete,
class: "text-red-500 hover:text-red-700",
data: { turbo_confirm: {
@@ -60,48 +57,48 @@
accept: t(".remove_member"),
acceptClass: "w-full bg-red-500 text-white rounded-xl text-center p-[10px] border mb-2"
}} do %>
- <%= lucide_icon "x", class: "w-5 h-5" %>
- <% end %>
- </div>
+ <%= lucide_icon "x", class: "w-5 h-5" %>
<% end %>
</div>
<% end %>
- <% if @pending_invitations.any? %>
- <% @pending_invitations.each do |invitation| %>
- <div class="flex gap-2 items-center justify-between bg-white p-4 border border-alpha-black-25 rounded-lg">
- <div class="flex gap-2 items-center">
- <div class="w-9 h-9 shrink-0">
- <div class="text-white w-full h-full bg-gray-400 rounded-full flex items-center justify-center text-lg uppercase"><%= invitation.email[0] %></div>
- </div>
- <div class="flex">
- <p class="text-primary font-medium text-sm"><%= invitation.email %></p>
- <div class="rounded-md bg-gray-100 px-1.5 py-0.5">
- <p class="uppercase text-secondary font-medium text-xs"><%= t(".pending") %></p>
- </div>
- </div>
+ </div>
+ <% end %>
+ <% if @pending_invitations.any? %>
+ <% @pending_invitations.each do |invitation| %>
+ <div class="flex gap-2 items-center justify-between bg-white p-4 border border-alpha-black-25 rounded-lg">
+ <div class="flex gap-2 items-center">
+ <div class="w-9 h-9 shrink-0">
+ <div class="text-white w-full h-full bg-gray-400 rounded-full flex items-center justify-center text-lg uppercase"><%= invitation.email[0] %></div>
+ </div>
+ <div class="flex">
+ <p class="text-primary font-medium text-sm"><%= invitation.email %></p>
+ <div class="rounded-md bg-gray-100 px-1.5 py-0.5">
+ <p class="uppercase text-secondary font-medium text-xs"><%= t(".pending") %></p>
</div>
- <div class="flex items-center gap-4">
- <% if self_hosted? %>
- <div class="flex items-center gap-2" data-controller="clipboard">
- <p class="text-secondary text-sm"><%= t(".invitation_link") %></p>
- <span data-clipboard-target="source" class="hidden"><%= accept_invitation_url(invitation.token) %></span>
- <input type="text"
+ </div>
+ </div>
+ <div class="flex items-center gap-4">
+ <% if self_hosted? %>
+ <div class="flex items-center gap-2" data-controller="clipboard">
+ <p class="text-secondary text-sm"><%= t(".invitation_link") %></p>
+ <span data-clipboard-target="source" class="hidden"><%= accept_invitation_url(invitation.token) %></span>
+ <input type="text"
readonly
autocomplete="off"
value="<%= accept_invitation_url(invitation.token) %>"
class="text-sm bg-gray-50 px-2 py-1 rounded border border-gray-200 w-72">
- <button data-action="clipboard#copy" class="text-secondary hover:text-gray-700">
- <span data-clipboard-target="iconDefault">
- <%= lucide_icon "copy", class: "w-5 h-5" %>
- </span>
- <span class="hidden" data-clipboard-target="iconSuccess">
- <%= lucide_icon "check", class: "w-5 h-5" %>
- </span>
- </button>
- </div>
- <% end %>
- <% if Current.user.admin? %>
- <%= button_to invitation_path(invitation),
+ <button data-action="clipboard#copy" class="text-secondary hover:text-gray-700">
+ <span data-clipboard-target="iconDefault">
+ <%= lucide_icon "copy", class: "w-5 h-5" %>
+ </span>
+ <span class="hidden" data-clipboard-target="iconSuccess">
+ <%= lucide_icon "check", class: "w-5 h-5" %>
+ </span>
+ </button>
+ </div>
+ <% end %>
+ <% if Current.user.admin? %>
+ <%= button_to invitation_path(invitation),
method: :delete,
class: "text-red-500 hover:text-red-700",
data: { turbo_confirm: {
@@ -110,31 +107,32 @@
accept: t(".remove_invitation"),
acceptClass: "w-full bg-red-500 text-white rounded-xl text-center p-[10px] border mb-2"
}} do %>
- <%= lucide_icon "x", class: "w-5 h-5" %>
- <% end %>
- <% end %>
- </div>
- </div>
- <% end %>
- <% end %>
- <% if Current.user.admin? %>
- <%= link_to new_invitation_path,
+ <%= lucide_icon "x", class: "w-5 h-5" %>
+ <% end %>
+ <% end %>
+ </div>
+ </div>
+ <% end %>
+ <% end %>
+ <% if Current.user.admin? %>
+ <%= link_to new_invitation_path,
class: "bg-gray-100 flex items-center justify-center gap-2 text-secondary mt-1 hover:bg-gray-200 rounded-lg px-4 py-2 w-full text-center",
data: { turbo_frame: :modal } do %>
- <%= lucide_icon("plus", class: "w-5 h-5 text-secondary") %>
- <%= t(".invite_member") %>
- <% end %>
- <% end %>
- </div>
- </div>
- <% end %>
- <%= settings_section title: t(".danger_zone_title") do %>
- <div class="flex items-center justify-between">
- <div>
- <h3 class="font-medium text-primary"><%= t(".delete_account") %></h3>
- <p class="text-secondary text-sm"><%= t(".delete_account_warning") %></p>
- </div>
- <%=
+ <%= lucide_icon("plus", class: "w-5 h-5 text-secondary") %>
+ <%= t(".invite_member") %>
+ <% end %>
+ <% end %>
+ </div>
+ </div>
+<% end %>
+
+<%= settings_section title: t(".danger_zone_title") do %>
+ <div class="flex items-center justify-between">
+ <div>
+ <h3 class="font-medium text-primary"><%= t(".delete_account") %></h3>
+ <p class="text-secondary text-sm"><%= t(".delete_account_warning") %></p>
+ </div>
+ <%=
button_to t(".delete_account"), user_path(@user), method: :delete,
class: "bg-red-500 text-white text-sm font-medium rounded-lg px-3 py-2",
data: { turbo_confirm: {
@@ -143,10 +141,6 @@
accept: t(".delete_account"),
acceptClass: "w-full bg-red-500 text-white rounded-xl text-center p-[10px] border mb-2"
}}
- %>
- </div>
- <% end %>
+ %>
</div>
-
- <%= settings_nav_footer %>
-</div>
+<% end %>
diff --git a/app/views/settings/securities/show.html.erb b/app/views/settings/securities/show.html.erb
index 423f083d..716c36b9 100644
--- a/app/views/settings/securities/show.html.erb
+++ b/app/views/settings/securities/show.html.erb
@@ -1,30 +1,26 @@
-<% content_for :sidebar do %>
- <%= render "settings/nav" %>
-<% end %>
+<%= content_for :page_title, t(".page_title") %>
-<div class="space-y-4">
- <h1 class="text-primary text-xl font-medium mb-4"><%= t(".page_title") %></h1>
- <%= settings_section title: t(".mfa_title"), subtitle: t(".mfa_description") do %>
- <div class="space-y-4">
- <div class="p-3 shadow-xs bg-white border border-secondary rounded-lg flex justify-between items-center">
- <div class="flex items-center gap-3">
- <div class="w-9 h-9 rounded-full bg-gray-25 flex justify-center items-center">
- <%= lucide_icon "shield-check", class: "w-5 h-5 text-secondary" %>
- </div>
+<%= settings_section title: t(".mfa_title"), subtitle: t(".mfa_description") do %>
+ <div class="space-y-4">
+ <div class="p-3 shadow-border-xs bg-white rounded-lg flex justify-between items-center">
+ <div class="flex items-center gap-3">
+ <div class="w-9 h-9 rounded-full bg-gray-25 flex justify-center items-center">
+ <%= lucide_icon "shield-check", class: "w-5 h-5 text-secondary" %>
+ </div>
- <div class="text-sm space-y-1">
- <% if Current.user.otp_required? %>
- <p class="text-primary">Two-factor authentication is <span class="font-medium text-green-600">enabled</span></p>
- <p class="text-secondary">Your account is protected with an additional layer of security.</p>
- <% else %>
- <p class="text-primary">Two-factor authentication is <span class="font-medium text-red-600">disabled</span></p>
- <p class="text-secondary">Enable 2FA to add an extra layer of security to your account.</p>
- <% end %>
- </div>
+ <div class="text-sm space-y-1">
+ <% if Current.user.otp_required? %>
+ <p class="text-primary">Two-factor authentication is <span class="font-medium text-green-600">enabled</span></p>
+ <p class="text-secondary">Your account is protected with an additional layer of security.</p>
+ <% else %>
+ <p class="text-primary">Two-factor authentication is <span class="font-medium text-red-600">disabled</span></p>
+ <p class="text-secondary">Enable 2FA to add an extra layer of security to your account.</p>
+ <% end %>
</div>
+ </div>
- <% if Current.user.otp_required? %>
- <%= button_to t(".disable_mfa"), disable_mfa_path,
+ <% if Current.user.otp_required? %>
+ <%= button_to t(".disable_mfa"), disable_mfa_path,
method: :delete,
class: "btn btn--secondary flex items-center gap-1",
data: { turbo_confirm: {
@@ -33,13 +29,10 @@
accept: t(".disable_mfa"),
acceptClass: "w-full bg-red-500 text-white rounded-xl text-center p-[10px] border mb-2"
} } %>
- <% else %>
- <%= link_to t(".enable_mfa"), new_mfa_path,
+ <% else %>
+ <%= link_to t(".enable_mfa"), new_mfa_path,
class: "btn btn--primary flex items-center gap-1" %>
- <% end %>
- </div>
+ <% end %>
</div>
- <% end %>
-
- <%= settings_nav_footer %>
-</div>
\ No newline at end of file
+ </div>
+<% end %>
diff --git a/app/views/shared/_app_version.html.erb b/app/views/shared/_app_version.html.erb
index eb743277..7bf79bca 100644
--- a/app/views/shared/_app_version.html.erb
+++ b/app/views/shared/_app_version.html.erb
@@ -1,6 +1,3 @@
-<div class="flex items-center py-0.5 px-0.5 gap-1 fixed bottom-2 right-2 shadow-xs border border-alpha-black-50 rounded-md bg-white">
+<div class="flex items-center py-0.5 px-0.5 gap-1 fixed right-1 top-1 shadow-xs border border-alpha-black-50 rounded-md bg-white">
<p class="text-xs text-secondary pl-2">Version: <%= Maybe.version.to_release_tag %></p>
- <%= link_to settings_hosting_path, class: "flex gap-1 items-center hover:bg-gray-50 rounded-md p-2" do %>
- <%= lucide_icon("settings", class: "w-4 h-4 text-secondary shrink-0") %>
- <% end %>
</div>
diff --git a/app/views/shared/_auth_messages.html.erb b/app/views/shared/_auth_messages.html.erb
deleted file mode 100644
index 79de7718..00000000
--- a/app/views/shared/_auth_messages.html.erb
+++ /dev/null
@@ -1,7 +0,0 @@
-<% flash.each do |type, msg| %>
- <div class="p-4 <%= type == "notice" ? "bg-blue-200" : "bg-red-200" %> rounded-lg"><%= msg %></div>
-<% end %>
-
-<% errors.each do |message| %>
- <div class="p-4 bg-red-200 rounded-lg"><%= message %></div>
-<% end %>
diff --git a/app/views/shared/_circle_logo.html.erb b/app/views/shared/_circle_logo.html.erb
index e8dd7c1f..0aba2373 100644
--- a/app/views/shared/_circle_logo.html.erb
+++ b/app/views/shared/_circle_logo.html.erb
@@ -7,7 +7,7 @@
"full" => "w-full h-full"
} %>
-<%= tag.div style: mixed_hex_styles(hex),
+<%= tag.div style: mixed_hex_styles(hex || "#1570EF"),
class: [size_classes[size], "flex shrink-0 items-center justify-center rounded-full"] do %>
<%= tag.span (name.presence&.first || "T").upcase, class: ["font-medium", size == "sm" ? "text-xs" : "text-sm"] %>
<% end %>
diff --git a/app/views/shared/_drawer.html.erb b/app/views/shared/_drawer.html.erb
index 06323f40..f92858d6 100644
--- a/app/views/shared/_drawer.html.erb
+++ b/app/views/shared/_drawer.html.erb
@@ -1,7 +1,7 @@
<%# locals: (content:, reload_on_close: false) %>
<%= turbo_frame_tag "drawer" do %>
- <dialog class="ml-auto bg-white border border-alpha-black-25 rounded-2xl max-w-[480px] w-full shadow-xs h-full mt-4 mr-4 focus-visible:outline-hidden"
+ <dialog class="ml-auto bg-white shadow-border-xs rounded-2xl max-w-[480px] h-full w-full mt-4 mr-4 focus-visible:outline-hidden"
data-controller="modal"
data-action="click->modal#clickOutside"
data-modal-reload-on-close-value="<%= reload_on_close %>">
diff --git a/app/views/shared/_line_chart.html.erb b/app/views/shared/_line_chart.html.erb
deleted file mode 100644
index 0b58aa99..00000000
--- a/app/views/shared/_line_chart.html.erb
+++ /dev/null
@@ -1,12 +0,0 @@
-<%# locals: (series:) %>
-<% if series %>
- <div
- id="lineChart"
- class="w-full h-full"
- data-controller="time-series-chart"
- data-time-series-chart-data-value="<%= series.to_json %>"></div>
-<% else %>
- <div class="w-full h-full flex items-center justify-center">
- <p class="text-secondary">No data available for the selected period.</p>
- </div>
-<% end %>
diff --git a/app/views/shared/_list_group.html.erb b/app/views/shared/_list_group.html.erb
deleted file mode 100644
index c019740f..00000000
--- a/app/views/shared/_list_group.html.erb
+++ /dev/null
@@ -1,9 +0,0 @@
-<%# locals: (header:, content:) %>
-<div class="bg-gray-25 rounded-xl p-1 w-full">
- <div class="py-2 px-4 flex items-center justify-between font-medium text-xs text-secondary">
- <%= header %>
- </div>
- <div class="bg-white shadow-xs rounded-md border border-alpha-black-25 divide-y divide-alpha-black-50">
- <%= content %>
- </div>
-</div>
diff --git a/app/views/shared/_modal.html.erb b/app/views/shared/_modal.html.erb
index 1b53cc98..067e4ca0 100644
--- a/app/views/shared/_modal.html.erb
+++ b/app/views/shared/_modal.html.erb
@@ -1,6 +1,6 @@
<%# locals: (content:, classes:) -%>
<%= turbo_frame_tag "modal" do %>
- <dialog class="m-auto bg-white border border-alpha-black-25 rounded-2xl max-w-[580px] w-min-content shadow-xs h-fit <%= classes %>" data-controller="modal" data-action="click->modal#clickOutside">
+ <dialog class="m-auto bg-white shadow-border-xs rounded-2xl max-w-[580px] w-min-content h-fit <%= classes %>" data-controller="modal" data-action="click->modal#clickOutside">
<div class="flex flex-col">
<%= content %>
</div>
diff --git a/app/views/application/_pagination.html.erb b/app/views/shared/_pagination.html.erb
similarity index 100%
rename from app/views/application/_pagination.html.erb
rename to app/views/shared/_pagination.html.erb
diff --git a/app/views/shared/_progress_circle.html.erb b/app/views/shared/_progress_circle.html.erb
index f35bda25..11322d14 100644
--- a/app/views/shared/_progress_circle.html.erb
+++ b/app/views/shared/_progress_circle.html.erb
@@ -1,4 +1,4 @@
-<%# locals: (progress:, radius: 7, stroke: 2, text_class: "text-green-500") %>
+<%# locals: (progress:, radius: 7, stroke: 2, color: nil) %>
<%
circumference = Math::PI * 2 * radius
@@ -18,7 +18,8 @@
<!-- Foreground Circle -->
<circle
- class="fill-transparent stroke-current <%= text_class %>"
+ class="fill-transparent"
+ style="stroke: <%= color || "var(--color-blue-500)" %>"
r="<%= radius %>"
cx="<%= center %>"
cy="<%= center %>"
diff --git a/app/views/shared/_subscribe_modal.html.erb b/app/views/shared/_subscribe_modal.html.erb
index a7b16082..4063a195 100644
--- a/app/views/shared/_subscribe_modal.html.erb
+++ b/app/views/shared/_subscribe_modal.html.erb
@@ -1,6 +1,6 @@
-<div data-controller="modal" data-modal-open-value="true" class="absolute inset-0 z-50 flex items-center justify-center bg-white/90" aria-labelledby="modal-title" role="dialog" aria-modal="true">
+<div data-controller="modal" data-modal-open-value="true" class="h-full flex items-center justify-center bg-white/90" aria-labelledby="modal-title" role="dialog" aria-modal="true">
<div class="w-[400px] rounded-xl relative overflow-hidden">
- <div class="bg-white shadow-xl border border-gray-200 rounded-xl relative z-10">
+ <div class="bg-white shadow-border-xs rounded-xl relative z-10">
<div class="rounded-xl" style="background-image: url('<%= asset_path("maybe-plus-background.svg") %>'); background-size: cover; background-position: center top;">
<div class="text-center rounded-xl" style="background-image: linear-gradient(to bottom, rgba(197,161,119,0.15) 0%, rgba(255,255,255,0.8) 30%, white 40%);">
<div class="p-4 pt-2 rounded-xl">
diff --git a/app/views/shared/_trend_change.html.erb b/app/views/shared/_trend_change.html.erb
index 8df76179..a3f3ef74 100644
--- a/app/views/shared/_trend_change.html.erb
+++ b/app/views/shared/_trend_change.html.erb
@@ -1,14 +1,14 @@
<%# locals: { trend: } %>
-<% styles = trend_styles(trend) %>
-
-<p class="text-sm <%= styles[:text_class] %>">
+<p class="text-sm" style="color: <%= trend.color %>">
<% if trend.direction.flat? %>
<span>No change</span>
<% else %>
- <span><%= styles[:symbol] %><%= trend.value.is_a?(Money) ? format_money(trend.value.abs) : trend.value.abs.round(2) %></span>
+ <span>
+ <%= trend.value.is_a?(Money) ? format_money(trend.value) : trend.value.round(2) %>
+ </span>
<% unless trend.percent.infinite? %>
- <span>(<%= lucide_icon(styles[:icon], class: "w-4 h-4 align-text-bottom inline") %><%= trend.percent.abs %>%)</span>
+ <span>(<%= lucide_icon(trend.icon, class: "w-4 h-4 align-text-bottom inline") %><%= trend.percent_formatted %>)</span>
<% end %>
<% end %>
</p>
diff --git a/app/views/shared/_upgrade_notification.html.erb b/app/views/shared/_upgrade_notification.html.erb
index e8bddf0b..e2391b63 100644
--- a/app/views/shared/_upgrade_notification.html.erb
+++ b/app/views/shared/_upgrade_notification.html.erb
@@ -1,5 +1,5 @@
<%# locals: (upgrade:) %>
-<div class="bg-white space-y-4 text-right fixed bottom-10 right-10 p-5 border border-secondary shadow-xs rounded-md z-50 max-w-[350px]">
+<div class="bg-white space-y-4 text-right fixed bottom-10 right-10 p-5 shadow-border-xs rounded-md z-50 max-w-[350px]">
<div>
<p><%= link_to upgrade.to_s, upgrade.url, class: "text-sm text-blue-500 underline hover:text-blue-700", target: "_blank" %></p>
<% if upgrade.complete? %>
diff --git a/app/views/shared/_value_heading.html.erb b/app/views/shared/_value_heading.html.erb
deleted file mode 100644
index 524b4754..00000000
--- a/app/views/shared/_value_heading.html.erb
+++ /dev/null
@@ -1,21 +0,0 @@
-<%# locals: (label:, period:, value:, trend:, size: "lg", is_percentage: false)%>
-<div class="space-y-2">
- <p class="text-sm text-secondary font-medium"><%= label %></p>
- <p class="text-primary -space-x-0.5">
- <% if value.is_a?(Money) %>
- <span class="<%= size == "lg" ? "text-xl" : "text-lg" %> font-medium"><%= format_money value %></span>
- <% else %>
- <span class="<%= size == "lg" ? "text-xl" : "text-lg" %> font-medium"><%= is_percentage ? number_to_percentage(value, precision: 2) : value %></span>
- <% end %>
- </p>
- <% if trend.nil? %>
- <p class="text-sm text-secondary">Data not available for the selected period</p>
- <% elsif trend.direction.flat? %>
- <p class="text-sm text-secondary">No change vs. prior period</p>
- <% else %>
- <div class="flex items-center gap-2">
- <%= render partial: "shared/trend_change", locals: { trend: trend } %>
- <span class="text-sm text-secondary"><%= period_label(period) %></span>
- </div>
- <% end %>
-</div>
diff --git a/app/views/tags/index.html.erb b/app/views/tags/index.html.erb
index ea6c66d0..2001e4d9 100644
--- a/app/views/tags/index.html.erb
+++ b/app/views/tags/index.html.erb
@@ -1,44 +1,36 @@
-<% content_for :sidebar do %>
- <%= render "settings/nav" %>
-<% end %>
+<header class="flex items-center justify-between">
+ <h1 class="text-primary text-xl font-medium"><%= t(".tags") %></h1>
-<section class="space-y-4">
- <header class="flex items-center justify-between">
- <h1 class="text-primary text-xl font-medium"><%= t(".tags") %></h1>
+ <%= link_to new_tag_path, class: "btn btn--primary flex items-center gap-1 justify-center", data: { turbo_frame: :modal } do %>
+ <%= lucide_icon "plus", class: "w-5 h-5" %>
+ <p><%= t(".new") %></p>
+ <% end %>
+</header>
- <%= link_to new_tag_path, class: "btn btn--primary flex items-center gap-1 justify-center", data: { turbo_frame: :modal } do %>
- <%= lucide_icon "plus", class: "w-5 h-5" %>
- <p><%= t(".new") %></p>
- <% end %>
- </header>
-
- <div class="bg-white shadow-xs border border-alpha-black-25 rounded-xl p-4">
- <% if @tags.any? %>
- <div class="rounded-xl bg-gray-25 space-y-1 p-1">
- <div class="flex items-center gap-1.5 px-4 py-2 text-xs font-medium text-secondary uppercase">
- <p><%= t(".tags") %></p>
- <span class="text-subdued">&middot;</span>
- <p><%= @tags.count %></p>
- </div>
+<div class="bg-white shadow-border-xs rounded-xl p-4">
+ <% if @tags.any? %>
+ <div class="rounded-xl bg-gray-25 space-y-1 p-1">
+ <div class="flex items-center gap-1.5 px-4 py-2 text-xs font-medium text-secondary uppercase">
+ <p><%= t(".tags") %></p>
+ <span class="text-subdued">&middot;</span>
+ <p><%= @tags.count %></p>
+ </div>
- <div class="border border-alpha-black-25 rounded-md bg-white shadow-xs">
- <div class="overflow-hidden rounded-md">
- <%= render partial: @tags, spacer_template: "tags/ruler" %>
- </div>
+ <div class="border border-alpha-black-25 rounded-md bg-white shadow-border-xs">
+ <div class="overflow-hidden rounded-md">
+ <%= render partial: @tags, spacer_template: "tags/ruler" %>
</div>
</div>
- <% else %>
- <div class="flex justify-center items-center py-20">
- <div class="text-center flex flex-col items-center max-w-[300px]">
- <p class="text-primary mb-1 font-medium text-sm"><%= t(".empty") %></p>
- <%= link_to new_tag_path, class: "w-fit flex text-white text-sm font-medium items-center gap-1 bg-gray-900 rounded-lg p-2 pr-3", data: { turbo_frame: "modal" } do %>
- <%= lucide_icon("plus", class: "w-5 h-5") %>
- <span><%= t(".new") %></span>
- <% end %>
- </div>
+ </div>
+ <% else %>
+ <div class="flex justify-center items-center py-20">
+ <div class="text-center flex flex-col items-center max-w-[300px]">
+ <p class="text-primary mb-1 font-medium text-sm"><%= t(".empty") %></p>
+ <%= link_to new_tag_path, class: "w-fit flex text-white text-sm font-medium items-center gap-1 bg-gray-900 rounded-lg p-2 pr-3", data: { turbo_frame: "modal" } do %>
+ <%= lucide_icon("plus", class: "w-5 h-5") %>
+ <span><%= t(".new") %></span>
+ <% end %>
</div>
- <% end %>
- </div>
-
- <%= settings_nav_footer %>
-</section>
+ </div>
+ <% end %>
+</div>
diff --git a/app/views/transactions/_summary.html.erb b/app/views/transactions/_summary.html.erb
index c0b1e4fe..19c27346 100644
--- a/app/views/transactions/_summary.html.erb
+++ b/app/views/transactions/_summary.html.erb
@@ -1,19 +1,19 @@
<%# locals: (totals:) %>
-<div class="grid grid-cols-3 bg-white rounded-xl border border-alpha-black-25 shadow-xs divide-x divide-alpha-black-100">
+<div class="grid grid-cols-3 bg-white rounded-xl shadow-border-xs divide-x divide-alpha-black-100">
<div class="p-4 space-y-2">
<p class="text-sm text-secondary">Total transactions</p>
- <p class="text-primary font-medium text-xl" id="total-transactions"><%= totals.count %></p>
+ <p class="text-primary font-medium text-xl" id="total-transactions"><%= totals.transactions_count %></p>
</div>
<div class="p-4 space-y-2">
<p class="text-sm text-secondary">Income</p>
<p class="text-primary font-medium text-xl" id="total-income">
- <%= format_money Money.new(totals.income_total, totals.currency) %>
+ <%= totals.income_money.format %>
</p>
</div>
<div class="p-4 space-y-2">
<p class="text-sm text-secondary">Expenses</p>
<p class="text-primary font-medium text-xl" id="total-expense">
- <%= format_money Money.new(totals.expense_total, totals.currency) %>
+ <%= totals.expense_money.format %>
</p>
</div>
</div>
diff --git a/app/views/transactions/index.html.erb b/app/views/transactions/index.html.erb
index 9e383f38..35c99e4a 100644
--- a/app/views/transactions/index.html.erb
+++ b/app/views/transactions/index.html.erb
@@ -1,4 +1,4 @@
-<div class="space-y-4 h-full flex flex-col overflow-y-auto" data-controller="focus-record" data-focus-record-id-value="<%= @focused_record ? dom_id(@focused_record) : nil %>">
+<div class="space-y-4 h-fit max-h-full flex flex-col" data-controller="focus-record" data-focus-record-id-value="<%= @focused_record ? dom_id(@focused_record) : nil %>">
<%= render "header" %>
<%= render "summary", totals: @totals %>
@@ -7,7 +7,7 @@
data-controller="bulk-select"
data-bulk-select-singular-label-value="<%= t(".transaction") %>"
data-bulk-select-plural-label-value="<%= t(".transactions") %>"
- class="overflow-y-auto flex flex-col bg-white rounded-xl border border-alpha-black-25 shadow-xs p-4">
+ class="overflow-y-auto flex flex-col bg-white rounded-xl shadow-border-xs p-4">
<%= render "transactions/searches/search" %>
<div id="entry-selection-bar" data-bulk-select-target="selectionBar" class="flex justify-center hidden">
@@ -28,11 +28,9 @@
<p class="col-span-2 justify-self-end">amount</p>
</div>
<div class="space-y-6">
- <%= entries_by_date(@transaction_entries, transfers: @transfers, totals: true) do |entries, transfers| %>
- <%= render partial: "transfers/transfer", collection: transfers %>
-
- <%# Render regular entries %>
- <%= render partial: "account/entries/entry", collection: entries.reject { |e| e.entryable.transfer? } %>
+ <%= entries_by_date(@transactions.map(&:entry), totals: true) do |entries| %>
+ <%# Only render the outflow side of transfers to avoid duplicate entries %>
+ <%= render partial: "account/entries/entry", collection: entries.reject { |e| e.entryable.transfer_as_inflow.present? } %>
<% end %>
</div>
</div>
@@ -41,7 +39,7 @@
<% end %>
<div class="pt-4">
- <%= render "pagination", pagy: @pagy %>
+ <%= render "shared/pagination", pagy: @pagy %>
</div>
</div>
</div>
diff --git a/app/views/transactions/searches/_menu.html.erb b/app/views/transactions/searches/_menu.html.erb
index d2ea4911..15ae8bd8 100644
--- a/app/views/transactions/searches/_menu.html.erb
+++ b/app/views/transactions/searches/_menu.html.erb
@@ -6,7 +6,7 @@
data-controller="tabs"
data-tabs-active-class="bg-gray-25 text-primary"
data-tabs-default-tab-value="<%= get_default_transaction_search_filter[:key] %>"
- class="hidden absolute flex z-10 h-80 w-[540px] top-12 right-0 border border-tertiary bg-white rounded-lg shadow-xs">
+ class="hidden absolute flex z-10 h-80 w-[540px] top-12 right-0 shadow-border-xs bg-white rounded-lg">
<div class="flex w-44 flex-col items-start p-3 text-sm font-medium text-secondary border-r border-r-alpha-black-100">
<% transaction_search_filters.each do |filter| %>
<button
diff --git a/app/views/transactions/searches/filters/_badge.html.erb b/app/views/transactions/searches/filters/_badge.html.erb
index dbd94e0a..6f9c919e 100644
--- a/app/views/transactions/searches/filters/_badge.html.erb
+++ b/app/views/transactions/searches/filters/_badge.html.erb
@@ -44,7 +44,7 @@
<%= button_to clear_filter_transactions_path(param_key: param_key, param_value: param_value, **request.query_parameters),
method: :delete,
data: { turbo: false },
- class: "flex items-center" do %>
- <%= lucide_icon "x", class: "w-4 h-4 text-secondary" %>
+ class: "flex items-center cursor-pointer" do %>
+ <%= lucide_icon "x", class: "w-4 h-4 text-secondary hover:text-primary" %>
<% end %>
</li>
diff --git a/app/views/transfers/_transfer.html.erb b/app/views/transfers/_transfer.html.erb
deleted file mode 100644
index d891d509..00000000
--- a/app/views/transfers/_transfer.html.erb
+++ /dev/null
@@ -1,82 +0,0 @@
-<%# locals: (transfer:) %>
-
-<%= turbo_frame_tag dom_id(transfer) do %>
- <div class="grid grid-cols-12 items-center text-primary text-sm font-medium p-4">
- <div class="pr-10 flex items-center gap-4 col-span-8">
- <%= check_box_tag dom_id(transfer),
- disabled: true,
- class: "checkbox checkbox--light" %>
-
- <div class="max-w-full">
- <%= content_tag :div, class: ["flex items-center gap-2"] do %>
- <%= render "shared/circle_logo", name: transfer.name, size: "sm" %>
-
- <div class="truncate">
- <div class="space-y-0.5">
-
- <div class="flex items-center gap-2">
- <%= link_to transfer.name,
- transfer_path(transfer),
- data: { turbo_frame: "drawer", turbo_prefetch: false },
- class: "hover:underline hover:text-gray-800" %>
-
- <% if transfer.status == "confirmed" %>
- <span title="<%= transfer.payment? ? "Payment" : "Transfer" %> is confirmed">
- <%= lucide_icon "link-2", class: "w-4 h-4 text-indigo-600" %>
- </span>
- <% else %>
- <span class="inline-flex items-center rounded-full bg-indigo-50 px-2 py-0.5 text-xs font-medium text-indigo-700">
- Auto-matched
- </span>
-
- <%= button_to transfer_path(transfer, transfer: { status: "confirmed" }),
- method: :patch,
- class: "text-secondary hover:text-gray-800 flex items-center justify-center",
- title: "Confirm match" do %>
- <%= lucide_icon "check", class: "w-4 h-4 text-indigo-400 hover:text-indigo-600" %>
- <% end %>
-
- <%= button_to transfer_path(transfer, transfer: { status: "rejected" }),
- method: :patch,
- data: { turbo: false },
- class: "text-secondary hover:text-gray-800 flex items-center justify-center",
- title: "Reject match" do %>
- <%= lucide_icon "x", class: "w-4 h-4 text-subdued hover:text-gray-600" %>
- <% end %>
- <% end %>
- </div>
-
- <div class="text-secondary text-xs font-normal">
- <div class="flex items-center gap-1">
- <%= link_to transfer.from_account.name, transfer.from_account, class: "hover:underline", data: { turbo_frame: "_top" } %>
- <% if transfer.payment? %>
- <%= lucide_icon "arrow-right", class: "w-4 h-4" %>
- <% else %>
- <%= lucide_icon "arrow-left-right", class: "w-4 h-4" %>
- <% end %>
- <%= link_to transfer.to_account.name, transfer.to_account, class: "hover:underline", data: { turbo_frame: "_top" } %>
- </div>
- </div>
- </div>
- </div>
- <% end %>
- </div>
- </div>
-
- <div class="flex items-center gap-1 col-span-2">
- <% if transfer.categorizable? %>
- <%= render "account/transactions/transaction_category", entry: transfer.outflow_transaction.entry %>
- <% else %>
- <%= render "categories/badge", category: transfer.payment? ? payment_category : transfer_category %>
- <% end %>
- </div>
-
- <div class="col-span-2 ml-auto">
- <p class="flex items-center gap-1">
- <span>
- +/- <%= format_money(transfer.amount_abs) %>
- </span>
- </p>
- </div>
- </div>
-<% end %>
diff --git a/app/views/transfers/show.html.erb b/app/views/transfers/show.html.erb
index 1b7e42e1..911f382b 100644
--- a/app/views/transfers/show.html.erb
+++ b/app/views/transfers/show.html.erb
@@ -39,7 +39,7 @@
<dl class="flex items-center gap-2 justify-between">
<dt class="text-secondary">Amount</dt>
- <dd class="font-medium text-red-500"><%= format_money [email protected]_abs %></dd>
+ <dd class="font-medium text-red-500"><%= format_money @transfer.outflow_transaction.entry.amount_money * -1 %></dd>
</dl>
</div>
@@ -61,7 +61,7 @@
<dl class="flex items-center gap-2 justify-between">
<dt class="text-secondary">Amount</dt>
- <dd class="font-medium text-green-500">+<%= format_money @transfer.amount_abs %></dd>
+ <dd class="font-medium text-green-500">+<%= format_money @transfer.inflow_transaction.entry.amount_money * -1 %></dd>
</dl>
</div>
</div>
diff --git a/app/views/transfers/update.turbo_stream.erb b/app/views/transfers/update.turbo_stream.erb
index 08c08b47..2b1dd499 100644
--- a/app/views/transfers/update.turbo_stream.erb
+++ b/app/views/transfers/update.turbo_stream.erb
@@ -1,19 +1,20 @@
<% unless @transfer.destroyed? %>
- <%= turbo_stream.replace @transfer %>
+ <%= turbo_stream.replace @transfer.inflow_transaction.entry %>
+ <%= turbo_stream.replace @transfer.outflow_transaction.entry %>
- <%= turbo_stream.replace "category_menu_account_entry_#{@transfer.inflow_transaction.entry.id}",
- partial: "account/transactions/transaction_category",
- locals: { entry: @transfer.inflow_transaction.entry } %>
+ <%= turbo_stream.replace dom_id(@transfer.inflow_transaction, "category_menu"),
+ partial: "account/transactions/transaction_category",
+ locals: { transaction: @transfer.inflow_transaction } %>
- <%= turbo_stream.replace "category_menu_account_entry_#{@transfer.outflow_transaction.entry.id}",
- partial: "account/transactions/transaction_category",
- locals: { entry: @transfer.outflow_transaction.entry } %>
+ <%= turbo_stream.replace dom_id(@transfer.outflow_transaction, "category_menu"),
+ partial: "account/transactions/transaction_category",
+ locals: { transaction: @transfer.outflow_transaction } %>
- <%= turbo_stream.replace "transfer_match_account_entry_#{@transfer.inflow_transaction.entry.id}",
- partial: "account/transactions/transfer_match",
- locals: { entry: @transfer.inflow_transaction.entry } %>
+ <%= turbo_stream.replace dom_id(@transfer.inflow_transaction, "transfer_match"),
+ partial: "account/transactions/transfer_match",
+ locals: { transaction: @transfer.inflow_transaction } %>
- <%= turbo_stream.replace "transfer_match_account_entry_#{@transfer.outflow_transaction.entry.id}",
- partial: "account/transactions/transfer_match",
- locals: { entry: @transfer.outflow_transaction.entry } %>
+ <%= turbo_stream.replace dom_id(@transfer.outflow_transaction, "transfer_match"),
+ partial: "account/transactions/transfer_match",
+ locals: { transaction: @transfer.outflow_transaction } %>
<% end %>
diff --git a/app/views/users/_user_menu.html.erb b/app/views/users/_user_menu.html.erb
new file mode 100644
index 00000000..c8997be2
--- /dev/null
+++ b/app/views/users/_user_menu.html.erb
@@ -0,0 +1,70 @@
+<%# locals: (user:) %>
+
+<div id="user-menu" data-controller="menu" data-menu-placement-value="right-start" data-menu-offset-value="16">
+ <button data-menu-target="button">
+ <div class="w-9 h-9 cursor-pointer">
+ <%= render "settings/user_avatar", user: user, variant: :small %>
+ </div>
+ </button>
+
+ <div data-menu-target="content" class="hidden absolute w-[276px] z-10 divide-y divide-alpha-black-100 bg-white rounded-xl shadow-border-sm">
+ <div class="px-4 py-3 flex items-center gap-3">
+ <div class="w-9 h-9 shrink-0">
+ <%= render "settings/user_avatar", user: user, variant: :small, lazy: true %>
+ </div>
+
+ <div class="overflow-hidden text-ellipsis text-sm">
+ <p class="font-medium"><%= user.display_name %></p>
+ <% if user.display_name != user.email %>
+ <p class="text-secondary"><%= user.email %></p>
+ <% end %>
+ </div>
+ </div>
+
+ <% if self_hosted? %>
+ <div class="p-3">
+ <p class="text-sm">
+ <span class="font-medium text-primary">Version:</span>
+ <%= link_to Maybe.version.to_release_tag, "https://github.com/maybe-finance/maybe/releases/tag/#{Maybe.version.to_release_tag}", target: "_blank", class: "hover:underline" %>
+ (<%= link_to Maybe.commit_sha.first(7), "https://github.com/maybe-finance/maybe/commit/#{Maybe.commit_sha}", target: "_blank", class: "hover:underline" %>)
+ </p>
+ </div>
+ <% end %>
+
+ <div class="p-1">
+ <%= link_to settings_profile_path(return_to: request.fullpath), class: "btn btn--ghost flex gap-2 items-center" do %>
+ <%= lucide_icon("settings", class: "w-5 h-5 text-secondary shrink-0") %>
+ <span class="text-primary text-sm">Settings</span>
+ <% end %>
+
+ <%= link_to changelog_path, class: "btn btn--ghost flex gap-2 items-center" do %>
+ <%= lucide_icon("box", class: "w-5 h-5 text-secondary shrink-0") %>
+ <span class="text-primary text-sm">Changelog</span>
+ <% end %>
+
+ <%= link_to feedback_path, class: "btn btn--ghost flex gap-2 items-center" do %>
+ <%= lucide_icon("megaphone", class: "w-5 h-5 text-secondary shrink-0") %>
+ <span class="text-primary text-sm">Feedback</span>
+ <% end %>
+
+ <% if self_hosted? %>
+ <%= link_to "https://link.maybe.co/discord", class: "btn btn--ghost flex gap-2 items-center" do %>
+ <%= lucide_icon("message-square-more", class: "w-5 h-5 text-secondary shrink-0") %>
+ <span class="text-primary text-sm">Contact</span>
+ <% end %>
+ <% else %>
+ <%= link_to "mailto:[email protected]", class: "btn btn--ghost flex gap-2 items-center", onclick: "Intercom('showNewMessage'); return false;" do %>
+ <%= lucide_icon("message-square-more", class: "w-5 h-5 text-secondary shrink-0") %>
+ <span class="text-primary text-sm">Contact</span>
+ <% end %>
+ <% end %>
+ </div>
+
+ <div class="p-1">
+ <%= button_to session_path(Current.session), method: :delete, class: "btn btn--ghost text-destructive w-full flex gap-2 items-center" do %>
+ <%= lucide_icon("log-out", class: "w-5 h-5 shrink-0") %>
+ <span class="text-sm">Logout</span>
+ <% end %>
+ </div>
+ </div>
+</div>
diff --git a/config/locales/models/import/en.yml b/config/locales/models/import/en.yml
index 713ad905..36a90151 100644
--- a/config/locales/models/import/en.yml
+++ b/config/locales/models/import/en.yml
@@ -1,13 +1,13 @@
---
en:
activerecord:
+ attributes:
+ import:
+ currency: Currency
+ number_format: Number Format
errors:
models:
import:
attributes:
raw_file_str:
invalid_csv_format: is not a valid CSV format
- attributes:
- import:
- currency: Currency
- number_format: Number Format
diff --git a/config/locales/models/time_series/trend/en.yml b/config/locales/models/trend/en.yml
similarity index 94%
rename from config/locales/models/time_series/trend/en.yml
rename to config/locales/models/trend/en.yml
index 5f02353f..cf57f6ed 100644
--- a/config/locales/models/time_series/trend/en.yml
+++ b/config/locales/models/trend/en.yml
@@ -3,7 +3,7 @@ en:
activemodel:
errors:
models:
- time_series/trend:
+ trend:
attributes:
current:
must_be_of_the_same_type_as_previous: must be of the same type as previous
diff --git a/config/locales/views/account/trades/en.yml b/config/locales/views/account/trades/en.yml
index 01fd53fa..5aa3f857 100644
--- a/config/locales/views/account/trades/en.yml
+++ b/config/locales/views/account/trades/en.yml
@@ -21,13 +21,6 @@ en:
sell: Sell
symbol_label: Symbol
total_return_label: Unrealized gain/loss
- index:
- amount: Amount
- new: New transaction
- no_trades: No transactions for this account yet.
- trade: transaction
- trades: Transactions
- type: Type
new:
title: New transaction
show:
diff --git a/config/locales/views/account/transactions/en.yml b/config/locales/views/account/transactions/en.yml
index 659c5779..397c7bb5 100644
--- a/config/locales/views/account/transactions/en.yml
+++ b/config/locales/views/account/transactions/en.yml
@@ -31,11 +31,6 @@ en:
income: Income
submit: Add transaction
transfer: Transfer
- index:
- new: New transaction
- no_transactions: No transactions for this account yet.
- transaction: transaction
- transactions: Transactions
new:
new_transaction: New transaction
show:
diff --git a/config/locales/views/accounts/en.yml b/config/locales/views/accounts/en.yml
index d13f8c79..ecfe68a1 100644
--- a/config/locales/views/accounts/en.yml
+++ b/config/locales/views/accounts/en.yml
@@ -4,8 +4,6 @@ en:
account:
has_issues: Issue detected.
troubleshoot: Troubleshoot
- account_list:
- new_account: New %{type}
chart:
no_change: no change
create:
@@ -60,18 +58,6 @@ en:
edit: Edit
import: Import transactions
manage: Manage accounts
- summary:
- header:
- accounts: Accounts
- manage: Manage accounts
- new: New account
- new: New account
- no_assets: No assets found
- no_assets_description: Add an asset either via connection, importing or entering
- manually.
- no_liabilities: No liabilities found
- no_liabilities_description: Add a liability either via connection, importing
- or entering manually.
update:
success: "%{type} account updated"
email_confirmations:
diff --git a/config/locales/views/imports/en.yml b/config/locales/views/imports/en.yml
index 01fe473f..c9015a19 100644
--- a/config/locales/views/imports/en.yml
+++ b/config/locales/views/imports/en.yml
@@ -63,8 +63,8 @@ en:
failed: Failed
in_progress: In progress
label: "%{type}: %{datetime}"
- reverting: Reverting
revert_failed: Revert failed
+ reverting: Reverting
uploading: Processing rows
view: View
index:
diff --git a/config/locales/views/layout/en.yml b/config/locales/views/layout/en.yml
index 80443b74..b5484b6a 100644
--- a/config/locales/views/layout/en.yml
+++ b/config/locales/views/layout/en.yml
@@ -7,16 +7,7 @@ en:
sign_in: Sign in
sign_up: Create account
your_account: Your account
- footer:
- privacy_policy: Privacy Policy
- terms_of_service: Terms of Service
- issues:
- action: How to fix this issue
- description: Issue Description
- sidebar:
- accounts: Accounts
- budgeting: Budgeting
- dashboard: Dashboard
- new_account: New account
- portfolio: Portfolio
- transactions: Transactions
+ shared:
+ footer:
+ privacy_policy: Privacy Policy
+ terms_of_service: Terms of Service
diff --git a/config/locales/views/mfa/en.yml b/config/locales/views/mfa/en.yml
index bfc8ae61..786f5259 100644
--- a/config/locales/views/mfa/en.yml
+++ b/config/locales/views/mfa/en.yml
@@ -22,7 +22,8 @@ en:
scan_description: Use an authenticator app like Google Authenticator or 1Password
to scan this QR code
scan_title: 1. Scan QR Code
- secret_description: If you can't scan the QR code, enter this secret key manually in your authenticator app
+ secret_description: If you can't scan the QR code, enter this secret key manually
+ in your authenticator app
secret_title: Manual Entry Code
title: Set Up Two-Factor Authentication
verify_button: Verify and Enable 2FA
diff --git a/config/locales/views/pages/en.yml b/config/locales/views/pages/en.yml
index 50a67ecf..ad5f4942 100644
--- a/config/locales/views/pages/en.yml
+++ b/config/locales/views/pages/en.yml
@@ -4,20 +4,8 @@ en:
changelog:
title: What's new
dashboard:
- allocation_chart:
- assets: Assets
- debts: Debts
- fallback_greeting: Welcome back, friend
- greeting: Welcome back, %{name}
- import: Import
- income: Income
- investing: Investing (coming soon...)
- net_worth: Net Worth
- new: New account
- no_transactions: You have no recent transactions
- savings_rate: Savings Rate
- spending: Spending
- subtitle: Here's what's happening today
- title: Dashboard
- transactions: Recent transactions
- view_all: View all
+ no_account_empty_state:
+ new_account: New account
+ no_account_subtitle: Since no accounts have been added, there's no data to
+ display. Add your first accounts to start viewing dashboard data.
+ no_account_title: No accounts yet
diff --git a/config/locales/views/plaid_items/en.yml b/config/locales/views/plaid_items/en.yml
index f69caafe..e4d387cf 100644
--- a/config/locales/views/plaid_items/en.yml
+++ b/config/locales/views/plaid_items/en.yml
@@ -6,20 +6,21 @@ en:
destroy:
success: Accounts scheduled for deletion.
plaid_item:
+ add_new: Add new connection
confirm_accept: Delete institution
confirm_body: This will permanently delete all the accounts in this group and
all associated data.
confirm_title: Delete institution?
+ connection_lost: Connection lost
+ connection_lost_description: This connection is no longer valid. You'll need
+ to delete this connection and add it again to continue syncing data.
delete: Delete
error: Error occurred while syncing data
no_accounts_description: We could not load any accounts from this financial
institution.
no_accounts_title: No accounts found
+ requires_update: Requires re-authentication
status: Last synced %{timestamp} ago
status_never: Requires data sync
syncing: Syncing...
- requires_update: Requires re-authentication
update: Update connection
- connection_lost: Connection lost
- connection_lost_description: This connection is no longer valid. You'll need to delete this connection and add it again to continue syncing data.
- add_new: Add new connection
diff --git a/config/locales/views/settings/en.yml b/config/locales/views/settings/en.yml
index 41d8e10e..e7e7d627 100644
--- a/config/locales/views/settings/en.yml
+++ b/config/locales/views/settings/en.yml
@@ -6,26 +6,6 @@ en:
page_title: Billing
subscription_subtitle: Manage your subscription and billing details
subscription_title: Manage subscription
- nav:
- accounts_label: Accounts
- billing_label: Billing
- categories_label: Categories
- feedback_label: Feedback
- general_section_title: General
- imports_label: Imports
- logout: Logout
- merchants_label: Merchants
- other_section_title: More
- preferences_label: Preferences
- profile_label: Account
- security_label: Security
- self_hosting_label: Self hosting
- tags_label: Tags
- transactions_section_title: Transactions
- whats_new_label: What's new
- nav_link_large:
- next: Next
- previous: Back
preferences:
data_enrichment_settings:
description: Let Maybe auto-categorize, name, and add merchant data to your
@@ -89,6 +69,26 @@ en:
securities:
show:
page_title: Security
+ settings_nav:
+ accounts_label: Accounts
+ billing_label: Billing
+ categories_label: Categories
+ feedback_label: Feedback
+ general_section_title: General
+ imports_label: Imports
+ logout: Logout
+ merchants_label: Merchants
+ other_section_title: More
+ preferences_label: Preferences
+ profile_label: Account
+ security_label: Security
+ self_hosting_label: Self hosting
+ tags_label: Tags
+ transactions_section_title: Transactions
+ whats_new_label: What's new
+ settings_nav_link_large:
+ next: Next
+ previous: Back
user_avatar_field:
accepted_formats: JPG or PNG. 5MB max.
choose: Choose
diff --git a/config/locales/views/shared/en.yml b/config/locales/views/shared/en.yml
index 5862d7c0..509cbd41 100644
--- a/config/locales/views/shared/en.yml
+++ b/config/locales/views/shared/en.yml
@@ -8,11 +8,6 @@ en:
title: Are you sure?
money_field:
label: Amount
- no_account_empty_state:
- new_account: New account
- no_account_subtitle: Since no accounts have been added, there's no data to display.
- Add your first accounts to start viewing dashboard data.
- no_account_title: No accounts yet
syncing_notice:
syncing: Syncing accounts data...
upgrade_notification:
diff --git a/config/routes.rb b/config/routes.rb
index 6a7629dc..13f9f61f 100644
--- a/config/routes.rb
+++ b/config/routes.rb
@@ -53,7 +53,7 @@ Rails.application.routes.draw do
post :bootstrap, on: :collection
end
- resources :budgets, only: %i[index show edit update create] do
+ resources :budgets, only: %i[index show edit update], param: :month_year do
get :picker, on: :collection
resources :budget_categories, only: %i[index show update]
@@ -78,17 +78,18 @@ Rails.application.routes.draw do
resources :accounts, only: %i[index new] do
collection do
- get :summary
- get :list
post :sync_all
end
member do
post :sync
get :chart
+ get :sparkline
end
end
+ resources :accountable_sparklines, only: :show, param: :accountable_type
+
namespace :account do
resources :holdings, only: %i[index new show destroy]
diff --git a/db/migrate/20250212213301_add_user_sidebar_preference.rb b/db/migrate/20250212213301_add_user_sidebar_preference.rb
new file mode 100644
index 00000000..ee23c1f7
--- /dev/null
+++ b/db/migrate/20250212213301_add_user_sidebar_preference.rb
@@ -0,0 +1,5 @@
+class AddUserSidebarPreference < ActiveRecord::Migration[7.2]
+ def change
+ add_column :users, :show_sidebar, :boolean, default: true
+ end
+end
diff --git a/db/schema.rb b/db/schema.rb
index cc0e4607..c5239fba 100644
--- a/db/schema.rb
+++ b/db/schema.rb
@@ -10,7 +10,7 @@
#
# It's strongly recommended that you check this file into your version control system.
-ActiveRecord::Schema[7.2].define(version: 2025_02_12_163624) do
+ActiveRecord::Schema[7.2].define(version: 2025_02_12_213301) do
# These are extensions that must be enabled in order to support this database
enable_extension "pgcrypto"
enable_extension "plpgsql"
@@ -672,6 +672,7 @@ ActiveRecord::Schema[7.2].define(version: 2025_02_12_163624) do
t.string "otp_secret"
t.boolean "otp_required", default: false, null: false
t.string "otp_backup_codes", default: [], array: true
+ t.boolean "show_sidebar", default: true
t.index ["email"], name: "index_users_on_email", unique: true
t.index ["family_id"], name: "index_users_on_family_id"
t.index ["otp_secret"], name: "index_users_on_otp_secret", unique: true, where: "(otp_secret IS NOT NULL)"
diff --git a/lib/money.rb b/lib/money.rb
index 37ab7cdb..a00fc836 100644
--- a/lib/money.rb
+++ b/lib/money.rb
@@ -55,7 +55,7 @@ class Money
end
def as_json
- { amount: amount, currency: currency.iso_code }.as_json
+ { amount: amount, currency: currency.iso_code, formatted: format }.as_json
end
def <=>(other)
diff --git a/lib/money/arithmetic.rb b/lib/money/arithmetic.rb
index 99000066..03183e41 100644
--- a/lib/money/arithmetic.rb
+++ b/lib/money/arithmetic.rb
@@ -54,6 +54,10 @@ module Money::Arithmetic
amount.positive?
end
+ def to_f
+ amount.to_f
+ end
+
# Override Ruby's coerce method so the order of operands doesn't matter
# Wrap in Coerced so we can distinguish between Money and other types
def coerce(other)
diff --git a/lib/money/formatting.rb b/lib/money/formatting.rb
index 3a5cb092..25185b1a 100644
--- a/lib/money/formatting.rb
+++ b/lib/money/formatting.rb
@@ -1,11 +1,11 @@
module Money::Formatting
- # Fallback formatting. For advanced formatting, use Rails number_to_currency helper.
- def format
- whole_part, fractional_part = sprintf("%.#{currency.default_precision}f", amount).split(".")
- whole_with_delimiters = whole_part.chars.to_a.reverse.each_slice(3).map(&:join).join(currency.delimiter).reverse
- formatted_amount = "#{whole_with_delimiters}#{currency.separator}#{fractional_part}"
+ include ActiveSupport::NumberHelper
- currency.default_format.gsub("%n", formatted_amount).gsub("%u", currency.symbol)
+ def format(options = {})
+ locale = options[:locale] || I18n.locale
+ default_opts = format_options(locale)
+
+ number_to_currency(amount, default_opts.merge(options))
end
alias_method :to_s, :format
diff --git a/lib/tasks/demo_data.rake b/lib/tasks/demo_data.rake
index 07911318..46fa4c37 100644
--- a/lib/tasks/demo_data.rake
+++ b/lib/tasks/demo_data.rake
@@ -5,8 +5,13 @@ namespace :demo_data do
Demo::Generator.new.reset_and_clear_data!(families)
end
- task reset: :environment do
- families = [ "Demo Family 1", "Demo Family 2", "Demo Family 3", "Demo Family 4", "Demo Family 5" ]
+ task :reset, [ :count ] => :environment do |t, args|
+ count = (args[:count] || 1).to_i
+ families = count.times.map { |i| "Demo Family #{i + 1}" }
Demo::Generator.new.reset_data!(families)
end
+
+ task multi_currency: :environment do
+ Demo::Generator.new.generate_multi_currency_data!
+ end
end
diff --git a/test/application_system_test_case.rb b/test/application_system_test_case.rb
index 9e369a8c..657e646c 100644
--- a/test/application_system_test_case.rb
+++ b/test/application_system_test_case.rb
@@ -18,7 +18,7 @@ class ApplicationSystemTestCase < ActionDispatch::SystemTestCase
end
# Trigger Capybara's wait mechanism to avoid timing issues with logins
- find("h1", text: "Dashboard")
+ find("h1", text: "Welcome back, #{user.first_name}")
end
def sign_out
diff --git a/test/controllers/account/transactions_controller_test.rb b/test/controllers/account/transactions_controller_test.rb
index 0a754834..d490bfa7 100644
--- a/test/controllers/account/transactions_controller_test.rb
+++ b/test/controllers/account/transactions_controller_test.rb
@@ -74,7 +74,7 @@ class Account::TransactionsControllerTest < ActionDispatch::IntegrationTest
end
test "can destroy many transactions at once" do
- transactions = @user.family.entries.incomes_and_expenses
+ transactions = @user.family.entries.account_transactions
delete_count = transactions.size
assert_difference([ "Account::Transaction.count", "Account::Entry.count" ], -delete_count) do
diff --git a/test/controllers/accounts_controller_test.rb b/test/controllers/accounts_controller_test.rb
index a2312018..d85a5ffa 100644
--- a/test/controllers/accounts_controller_test.rb
+++ b/test/controllers/accounts_controller_test.rb
@@ -6,19 +6,6 @@ class AccountsControllerTest < ActionDispatch::IntegrationTest
@account = accounts(:depository)
end
- test "gets accounts list" do
- get accounts_url
- assert_response :success
-
- @user.family.accounts.manual.each do |account|
- assert_dom "#" + dom_id(account), count: 1
- end
-
- @user.family.plaid_items.each do |item|
- assert_dom "#" + dom_id(item), count: 1
- end
- end
-
test "new" do
get new_account_path
assert_response :ok
diff --git a/test/controllers/issues_controller_test.rb b/test/controllers/issues_controller_test.rb
index 6ba1705f..d18970b7 100644
--- a/test/controllers/issues_controller_test.rb
+++ b/test/controllers/issues_controller_test.rb
@@ -8,6 +8,7 @@ class IssuesControllerTest < ActionDispatch::IntegrationTest
test "should get show polymorphically" do
issues.each do |issue|
get issue_url(issue)
+
assert_response :success
assert_dom "h2", text: issue.title
assert_dom "h3", text: "Issue Description"
diff --git a/test/i18n_test.rb b/test/i18n_test.rb
index 62ab7d2a..51e7f480 100644
--- a/test/i18n_test.rb
+++ b/test/i18n_test.rb
@@ -1,17 +1,22 @@
require "i18n/tasks"
+# We're currently skipping some i18n tests to speed up development. Eventually, we'll make a dedicated
+# project for getting i18n working. More details on that here:
+# https://github.com/maybe-finance/maybe/issues/1225
class I18nTest < ActiveSupport::TestCase
def setup
@i18n = I18n::Tasks::BaseTask.new
end
def test_no_missing_keys
+ skip "Skipping missing keys test"
missing_keys = @i18n.missing_keys(locales: [ :en ])
assert_empty missing_keys,
"Missing #{missing_keys.leaves.count} i18n keys, run `i18n-tasks missing' to show them"
end
def test_no_unused_keys
+ skip "Skipping unused keys test"
unused_keys = @i18n.unused_keys(locales: [ :en ])
assert_empty unused_keys,
"#{unused_keys.leaves.count} unused i18n keys, run `i18n-tasks unused' to show them"
@@ -27,6 +32,7 @@ class I18nTest < ActiveSupport::TestCase
end
def test_no_inconsistent_interpolations
+ skip "Skipping inconsistent interpolations test"
inconsistent_interpolations = @i18n.inconsistent_interpolations(locales: [ :en ])
error_message = "#{inconsistent_interpolations.leaves.count} i18n keys have inconsistent interpolations.\n" \
"Please run `i18n-tasks check-consistent-interpolations' to show them"
diff --git a/test/lib/money_test.rb b/test/lib/money_test.rb
index ec1f2084..60d04284 100644
--- a/test/lib/money_test.rb
+++ b/test/lib/money_test.rb
@@ -84,9 +84,10 @@ class MoneyTest < ActiveSupport::TestCase
assert_not Money.new(-1000).positive?
end
- test "can cast to string with basic formatting" do
+ test "can format" do
assert_equal "$1,000.90", Money.new(1000.899).to_s
- assert_equal "€1.000,12", Money.new(1000.12, :eur).to_s
+ assert_equal "€1,000.12", Money.new(1000.12, :eur).to_s
+ assert_equal "€ 1.000,12", Money.new(1000.12, :eur).format(locale: :nl)
end
test "converts currency when rate available" do
diff --git a/test/models/account/balance_calculator_test.rb b/test/models/account/balance_calculator_test.rb
index 334a6478..2f3879a8 100644
--- a/test/models/account/balance_calculator_test.rb
+++ b/test/models/account/balance_calculator_test.rb
@@ -113,9 +113,9 @@ class Account::BalanceCalculatorTest < ActiveSupport::TestCase
create_trade(securities(:msft), account: @account, date: 1.day.ago.to_date, qty: 20, price: 100)
holdings = [
- Account::Holding.new(date: Date.current, security: securities(:msft), amount: 2000),
- Account::Holding.new(date: 1.day.ago.to_date, security: securities(:msft), amount: 2000),
- Account::Holding.new(date: 2.days.ago.to_date, security: securities(:msft), amount: 0)
+ Account::Holding.new(date: Date.current, security: securities(:msft), amount: 2000, currency: "USD"),
+ Account::Holding.new(date: 1.day.ago.to_date, security: securities(:msft), amount: 2000, currency: "USD"),
+ Account::Holding.new(date: 2.days.ago.to_date, security: securities(:msft), amount: 0, currency: "USD")
]
expected = [ 0, 20000, 20000, 20000 ]
diff --git a/test/models/account/chartable_test.rb b/test/models/account/chartable_test.rb
new file mode 100644
index 00000000..196feca6
--- /dev/null
+++ b/test/models/account/chartable_test.rb
@@ -0,0 +1,38 @@
+require "test_helper"
+
+class Account::ChartableTest < ActiveSupport::TestCase
+ test "generates gapfilled balance series" do
+ account = accounts(:depository)
+ account.balances.delete_all
+
+ account.balances.create!(date: 20.days.ago.to_date, balance: 5000, currency: "USD")
+ account.balances.create!(date: 10.days.ago.to_date, balance: 5000, currency: "USD")
+
+ period = Period.last_30_days
+ series = account.balance_series(period: period)
+ assert_equal period.days, series.values.count
+ assert_equal 0, series.values.first.trend.current.amount
+ assert_equal 5000, series.values.find { |v| v.date == 20.days.ago.to_date }.trend.current.amount
+ assert_equal 5000, series.values.find { |v| v.date == 10.days.ago.to_date }.trend.current.amount
+ assert_equal 5000, series.values.last.trend.current.amount
+ end
+
+ test "combines assets and liabilities for multiple accounts properly" do
+ family = families(:empty)
+
+ asset = family.accounts.create!(name: "Asset", currency: "USD", balance: 5000, accountable: Depository.new)
+ liability = family.accounts.create!(name: "Liability", currency: "USD", balance: 2000, accountable: CreditCard.new)
+
+ asset.balances.create!(date: 20.days.ago.to_date, balance: 4000, currency: "USD")
+ asset.balances.create!(date: 10.days.ago.to_date, balance: 5000, currency: "USD")
+
+ liability.balances.create!(date: 20.days.ago.to_date, balance: 1000, currency: "USD")
+ liability.balances.create!(date: 10.days.ago.to_date, balance: 1500, currency: "USD")
+
+ series = family.accounts.balance_series(currency: "USD", period: Period.last_30_days)
+
+ assert_equal 0, series.values.first.trend.current.amount
+ assert_equal 3000, series.values.find { |v| v.date == 20.days.ago.to_date }.trend.current.amount
+ assert_equal 3500, series.values.last.trend.current.amount
+ end
+end
diff --git a/test/models/account/entry_test.rb b/test/models/account/entry_test.rb
index 4f0c1b15..f798fb95 100644
--- a/test/models/account/entry_test.rb
+++ b/test/models/account/entry_test.rb
@@ -67,30 +67,13 @@ class Account::EntryTest < ActiveSupport::TestCase
assert_equal 0, family.entries.search(params).size
end
- test "can calculate totals for a group of transactions" do
- family = families(:empty)
- account = family.accounts.create! name: "Test", balance: 0, currency: "USD", accountable: Depository.new
- create_transaction(account: account, amount: 100)
- create_transaction(account: account, amount: 100)
- create_transaction(account: account, amount: -500)
-
- totals = family.entries.stats("USD")
-
- assert_equal 3, totals.count
- assert_equal 500, totals.income_total
- assert_equal 200, totals.expense_total
- assert_equal "USD", totals.currency
- end
-
- test "active scope only returns entries from active, non-scheduled-for-deletion accounts" do
+ test "active scope only returns entries from active accounts" do
# Create transactions for all account types
active_transaction = create_transaction(account: accounts(:depository), name: "Active transaction")
inactive_transaction = create_transaction(account: accounts(:credit_card), name: "Inactive transaction")
- deletion_transaction = create_transaction(account: accounts(:investment), name: "Scheduled for deletion transaction")
# Update account statuses
accounts(:credit_card).update!(is_active: false)
- accounts(:investment).update!(scheduled_for_deletion: true)
# Test the scope
active_entries = Account::Entry.active
@@ -100,8 +83,5 @@ class Account::EntryTest < ActiveSupport::TestCase
# Should not include entry from inactive account
assert_not_includes active_entries, inactive_transaction
-
- # Should not include entry from account scheduled for deletion
- assert_not_includes active_entries, deletion_transaction
end
end
diff --git a/test/models/account/issue_test.rb b/test/models/account/issue_test.rb
deleted file mode 100644
index 58408f23..00000000
--- a/test/models/account/issue_test.rb
+++ /dev/null
@@ -1,7 +0,0 @@
-require "test_helper"
-
-class Account::IssueTest < ActiveSupport::TestCase
- test "the truth" do
- assert true
- end
-end
diff --git a/test/models/account/trade_test.rb b/test/models/account/trade_test.rb
deleted file mode 100644
index b571a70b..00000000
--- a/test/models/account/trade_test.rb
+++ /dev/null
@@ -1,4 +0,0 @@
-require "test_helper"
-
-class Account::TradeTest < ActiveSupport::TestCase
-end
diff --git a/test/models/account/transaction_test.rb b/test/models/account/transaction_test.rb
new file mode 100644
index 00000000..11279945
--- /dev/null
+++ b/test/models/account/transaction_test.rb
@@ -0,0 +1,5 @@
+require "test_helper"
+
+class Account::TransactionTest < ActiveSupport::TestCase
+ include Account::EntriesTestHelper
+end
diff --git a/test/models/account_test.rb b/test/models/account_test.rb
index 066693c7..bbf2d192 100644
--- a/test/models/account_test.rb
+++ b/test/models/account_test.rb
@@ -13,129 +13,4 @@ class AccountTest < ActiveSupport::TestCase
@account.destroy
end
end
-
- test "groups accounts by type" do
- result = @family.accounts.by_group(period: Period.all)
- assets = result[:assets]
- liabilities = result[:liabilities]
-
- assert_equal @family.assets, assets.sum
- assert_equal @family.liabilities, liabilities.sum
-
- depositories = assets.children.find { |group| group.name == "Depository" }
- properties = assets.children.find { |group| group.name == "Property" }
- vehicles = assets.children.find { |group| group.name == "Vehicle" }
- investments = assets.children.find { |group| group.name == "Investment" }
- other_assets = assets.children.find { |group| group.name == "OtherAsset" }
-
- credits = liabilities.children.find { |group| group.name == "CreditCard" }
- loans = liabilities.children.find { |group| group.name == "Loan" }
- other_liabilities = liabilities.children.find { |group| group.name == "OtherLiability" }
-
- assert_equal 2, depositories.children.count
- assert_equal 1, properties.children.count
- assert_equal 1, vehicles.children.count
- assert_equal 1, investments.children.count
- assert_equal 1, other_assets.children.count
-
- assert_equal 1, credits.children.count
- assert_equal 1, loans.children.count
- assert_equal 1, other_liabilities.children.count
- end
-
- test "generates balance series" do
- assert_equal 2, @account.series.values.count
- end
-
- test "generates balance series with single value if no balances" do
- @account.balances.delete_all
- assert_equal 1, @account.series.values.count
- end
-
- test "generates balance series in period" do
- @account.balances.delete_all
- @account.balances.create! date: 31.days.ago.to_date, balance: 5000, currency: "USD" # out of period range
- @account.balances.create! date: 30.days.ago.to_date, balance: 5000, currency: "USD" # in range
-
- assert_equal 1, @account.series(period: Period.last_30_days).values.count
- end
-
- test "generates empty series if no balances and no exchange rate" do
- with_env_overrides SYNTH_API_KEY: nil do
- assert_equal 0, @account.series(currency: "NZD").values.count
- end
- end
-
- test "auto-matches transfers" do
- outflow_entry = create_transaction(date: 1.day.ago.to_date, account: @account, amount: 500)
- inflow_entry = create_transaction(date: Date.current, account: accounts(:credit_card), amount: -500)
-
- assert_difference -> { Transfer.count } => 1 do
- @account.auto_match_transfers!
- end
- end
-
- # In this scenario, our matching logic should find 4 potential matches. These matches should be ranked based on
- # days apart, then de-duplicated so that we aren't auto-matching the same transaction across multiple transfers.
- test "when 2 options exist, only auto-match one at a time, ranked by days apart" do
- yesterday_outflow = create_transaction(date: 1.day.ago.to_date, account: @account, amount: 500)
- yesterday_inflow = create_transaction(date: 1.day.ago.to_date, account: accounts(:credit_card), amount: -500)
-
- today_outflow = create_transaction(date: Date.current, account: @account, amount: 500)
- today_inflow = create_transaction(date: Date.current, account: accounts(:credit_card), amount: -500)
-
- assert_difference -> { Transfer.count } => 2 do
- @account.auto_match_transfers!
- end
- end
-
- test "does not auto-match any transfers that have been rejected by user already" do
- outflow = create_transaction(date: Date.current, account: @account, amount: 500)
- inflow = create_transaction(date: Date.current, account: accounts(:credit_card), amount: -500)
-
- RejectedTransfer.create!(inflow_transaction_id: inflow.entryable_id, outflow_transaction_id: outflow.entryable_id)
-
- assert_no_difference -> { Transfer.count } do
- @account.auto_match_transfers!
- end
- end
-
- test "transfer_match_candidates only matches between active accounts" do
- active_account = accounts(:depository)
- another_active_account = accounts(:credit_card)
- inactive_account = accounts(:investment)
- inactive_account.update!(is_active: false)
-
- # Create matching transactions
- active_inflow = active_account.entries.create!(
- date: Date.current,
- amount: -100,
- currency: "USD",
- name: "Test transfer",
- entryable: Account::Transaction.new
- )
-
- active_outflow = another_active_account.entries.create!(
- date: Date.current,
- amount: 100,
- currency: "USD",
- name: "Test transfer",
- entryable: Account::Transaction.new
- )
-
- inactive_outflow = inactive_account.entries.create!(
- date: Date.current,
- amount: 100,
- currency: "USD",
- name: "Test transfer",
- entryable: Account::Transaction.new
- )
-
- # Should find matches between active accounts
- candidates = active_account.transfer_match_candidates
- assert_includes candidates.map(&:outflow_transaction_id), active_outflow.entryable_id
-
- # Should not match with inactive account
- assert_not_includes candidates.map(&:outflow_transaction_id), inactive_outflow.entryable_id
- end
end
diff --git a/test/models/balance_sheet_test.rb b/test/models/balance_sheet_test.rb
new file mode 100644
index 00000000..fb131ea7
--- /dev/null
+++ b/test/models/balance_sheet_test.rb
@@ -0,0 +1,83 @@
+require "test_helper"
+
+class BalanceSheetTest < ActiveSupport::TestCase
+ setup do
+ @family = families(:empty)
+ end
+
+ test "calculates total assets" do
+ assert_equal 0, BalanceSheet.new(@family).total_assets
+
+ create_account(balance: 1000, accountable: Depository.new)
+ create_account(balance: 5000, accountable: OtherAsset.new)
+ create_account(balance: 10000, accountable: CreditCard.new) # ignored
+
+ assert_equal 1000 + 5000, BalanceSheet.new(@family).total_assets
+ end
+
+ test "calculates total liabilities" do
+ assert_equal 0, BalanceSheet.new(@family).total_liabilities
+
+ create_account(balance: 1000, accountable: CreditCard.new)
+ create_account(balance: 5000, accountable: OtherLiability.new)
+ create_account(balance: 10000, accountable: Depository.new) # ignored
+
+ assert_equal 1000 + 5000, BalanceSheet.new(@family).total_liabilities
+ end
+
+ test "calculates net worth" do
+ assert_equal 0, BalanceSheet.new(@family).net_worth
+
+ create_account(balance: 1000, accountable: CreditCard.new)
+ create_account(balance: 50000, accountable: Depository.new)
+
+ assert_equal 50000 - 1000, BalanceSheet.new(@family).net_worth
+ end
+
+ test "disabled accounts do not affect totals" do
+ create_account(balance: 1000, accountable: CreditCard.new)
+ create_account(balance: 10000, accountable: Depository.new)
+
+ other_liability = create_account(balance: 5000, accountable: OtherLiability.new)
+ other_liability.update!(is_active: false)
+
+ assert_equal 10000 - 1000, BalanceSheet.new(@family).net_worth
+ assert_equal 10000, BalanceSheet.new(@family).total_assets
+ assert_equal 1000, BalanceSheet.new(@family).total_liabilities
+ end
+
+ test "calculates asset group totals" do
+ create_account(balance: 1000, accountable: Depository.new)
+ create_account(balance: 2000, accountable: Depository.new)
+ create_account(balance: 3000, accountable: Investment.new)
+ create_account(balance: 5000, accountable: OtherAsset.new)
+ create_account(balance: 10000, accountable: CreditCard.new) # ignored
+
+ asset_groups = BalanceSheet.new(@family).account_groups("asset")
+
+ assert_equal 3, asset_groups.size
+ assert_equal 1000 + 2000, asset_groups.find { |ag| ag.name == "Cash" }.total
+ assert_equal 3000, asset_groups.find { |ag| ag.name == "Investments" }.total
+ assert_equal 5000, asset_groups.find { |ag| ag.name == "Other Assets" }.total
+ end
+
+ test "calculates liability group totals" do
+ create_account(balance: 1000, accountable: CreditCard.new)
+ create_account(balance: 2000, accountable: CreditCard.new)
+ create_account(balance: 3000, accountable: OtherLiability.new)
+ create_account(balance: 5000, accountable: OtherLiability.new)
+ create_account(balance: 10000, accountable: Depository.new) # ignored
+
+ liability_groups = BalanceSheet.new(@family).account_groups("liability")
+
+ assert_equal 2, liability_groups.size
+ assert_equal 1000 + 2000, liability_groups.find { |ag| ag.name == "Credit Cards" }.total
+ assert_equal 3000 + 5000, liability_groups.find { |ag| ag.name == "Other Liabilities" }.total
+ end
+
+ private
+ def create_account(attributes = {})
+ account = @family.accounts.create! name: "Test", currency: "USD", **attributes
+ account
+ end
+end
diff --git a/test/models/credit_card_test.rb b/test/models/credit_card_test.rb
deleted file mode 100644
index 8bb8d96e..00000000
--- a/test/models/credit_card_test.rb
+++ /dev/null
@@ -1,7 +0,0 @@
-require "test_helper"
-
-class CreditCardTest < ActiveSupport::TestCase
- # test "the truth" do
- # assert true
- # end
-end
diff --git a/test/models/crypto_test.rb b/test/models/crypto_test.rb
deleted file mode 100644
index 095e9474..00000000
--- a/test/models/crypto_test.rb
+++ /dev/null
@@ -1,7 +0,0 @@
-require "test_helper"
-
-class CryptoTest < ActiveSupport::TestCase
- # test "the truth" do
- # assert true
- # end
-end
diff --git a/test/models/depository_test.rb b/test/models/depository_test.rb
deleted file mode 100644
index 9d95638e..00000000
--- a/test/models/depository_test.rb
+++ /dev/null
@@ -1,7 +0,0 @@
-require "test_helper"
-
-class DepositoryTest < ActiveSupport::TestCase
- # test "the truth" do
- # assert true
- # end
-end
diff --git a/test/models/family/auto_transfer_matchable_test.rb b/test/models/family/auto_transfer_matchable_test.rb
new file mode 100644
index 00000000..9a1c7ca8
--- /dev/null
+++ b/test/models/family/auto_transfer_matchable_test.rb
@@ -0,0 +1,56 @@
+require "test_helper"
+
+class Family::AutoTransferMatchableTest < ActiveSupport::TestCase
+ include Account::EntriesTestHelper
+
+ setup do
+ @family = families(:dylan_family)
+ @depository = accounts(:depository)
+ @credit_card = accounts(:credit_card)
+ end
+
+ test "auto-matches transfers" do
+ outflow_entry = create_transaction(date: 1.day.ago.to_date, account: @depository, amount: 500)
+ inflow_entry = create_transaction(date: Date.current, account: @credit_card, amount: -500)
+
+ assert_difference -> { Transfer.count } => 1 do
+ @family.auto_match_transfers!
+ end
+ end
+
+ # In this scenario, our matching logic should find 4 potential matches. These matches should be ranked based on
+ # days apart, then de-duplicated so that we aren't auto-matching the same transaction across multiple transfers.
+ test "when 2 options exist, only auto-match one at a time, ranked by days apart" do
+ yesterday_outflow = create_transaction(date: 1.day.ago.to_date, account: @depository, amount: 500)
+ yesterday_inflow = create_transaction(date: 1.day.ago.to_date, account: @credit_card, amount: -500)
+
+ today_outflow = create_transaction(date: Date.current, account: @depository, amount: 500)
+ today_inflow = create_transaction(date: Date.current, account: @credit_card, amount: -500)
+
+ assert_difference -> { Transfer.count } => 2 do
+ @family.auto_match_transfers!
+ end
+ end
+
+ test "does not auto-match any transfers that have been rejected by user already" do
+ outflow = create_transaction(date: Date.current, account: @depository, amount: 500)
+ inflow = create_transaction(date: Date.current, account: @credit_card, amount: -500)
+
+ RejectedTransfer.create!(inflow_transaction_id: inflow.entryable_id, outflow_transaction_id: outflow.entryable_id)
+
+ assert_no_difference -> { Transfer.count } do
+ @family.auto_match_transfers!
+ end
+ end
+
+ test "does not consider inactive accounts when matching transfers" do
+ @depository.update!(is_active: false)
+
+ outflow = create_transaction(date: Date.current, account: @depository, amount: 500)
+ inflow = create_transaction(date: Date.current, account: @credit_card, amount: -500)
+
+ assert_no_difference -> { Transfer.count } do
+ @family.auto_match_transfers!
+ end
+ end
+end
diff --git a/test/models/family_test.rb b/test/models/family_test.rb
index ca09a211..da50fb02 100644
--- a/test/models/family_test.rb
+++ b/test/models/family_test.rb
@@ -26,135 +26,4 @@ class FamilyTest < ActiveSupport::TestCase
@syncable.sync_data(start_date: family_sync.start_date)
end
-
- test "calculates assets" do
- assert_equal Money.new(0, @family.currency), @family.assets
-
- create_account(balance: 1000, accountable: Depository.new)
- create_account(balance: 5000, accountable: OtherAsset.new)
- create_account(balance: 10000, accountable: CreditCard.new) # ignored
-
- assert_equal Money.new(1000 + 5000, @family.currency), @family.assets
- end
-
- test "calculates liabilities" do
- assert_equal Money.new(0, @family.currency), @family.liabilities
-
- create_account(balance: 1000, accountable: CreditCard.new)
- create_account(balance: 5000, accountable: OtherLiability.new)
- create_account(balance: 10000, accountable: Depository.new) # ignored
-
- assert_equal Money.new(1000 + 5000, @family.currency), @family.liabilities
- end
-
- test "calculates net worth" do
- assert_equal Money.new(0, @family.currency), @family.net_worth
-
- create_account(balance: 1000, accountable: CreditCard.new)
- create_account(balance: 50000, accountable: Depository.new)
-
- assert_equal Money.new(50000 - 1000, @family.currency), @family.net_worth
- end
-
- test "should exclude disabled accounts from calculations" do
- cc = create_account(balance: 1000, accountable: CreditCard.new)
- create_account(balance: 50000, accountable: Depository.new)
-
- assert_equal Money.new(50000 - 1000, @family.currency), @family.net_worth
-
- cc.update! is_active: false
-
- assert_equal Money.new(50000, @family.currency), @family.net_worth
- end
-
- test "calculates snapshot" do
- asset = create_account(balance: 500, accountable: Depository.new)
- liability = create_account(balance: 100, accountable: CreditCard.new)
-
- asset.balances.create! date: 1.day.ago.to_date, currency: "USD", balance: 450
- asset.balances.create! date: Date.current, currency: "USD", balance: 500
-
- liability.balances.create! date: 1.day.ago.to_date, currency: "USD", balance: 50
- liability.balances.create! date: Date.current, currency: "USD", balance: 100
-
- expected_asset_series = [
- { date: 1.day.ago.to_date, value: Money.new(450) },
- { date: Date.current, value: Money.new(500) }
- ]
-
- expected_liability_series = [
- { date: 1.day.ago.to_date, value: Money.new(50) },
- { date: Date.current, value: Money.new(100) }
- ]
-
- expected_net_worth_series = [
- { date: 1.day.ago.to_date, value: Money.new(450 - 50) },
- { date: Date.current, value: Money.new(500 - 100) }
- ]
-
- assert_equal expected_asset_series, @family.snapshot[:asset_series].values.map { |v| { date: v.date, value: v.value } }
- assert_equal expected_liability_series, @family.snapshot[:liability_series].values.map { |v| { date: v.date, value: v.value } }
- assert_equal expected_net_worth_series, @family.snapshot[:net_worth_series].values.map { |v| { date: v.date, value: v.value } }
- end
-
- test "calculates top movers" do
- checking_account = create_account(balance: 500, accountable: Depository.new)
- savings_account = create_account(balance: 1000, accountable: Depository.new)
- create_transaction(account: checking_account, date: 2.days.ago.to_date, amount: -1000)
- create_transaction(account: checking_account, date: 1.day.ago.to_date, amount: 10)
- create_transaction(account: savings_account, date: 2.days.ago.to_date, amount: -5000)
-
- zero_income_zero_expense_account = create_account(balance: 200, accountable: Depository.new)
- create_transaction(account: zero_income_zero_expense_account, amount: 0)
-
- snapshot = @family.snapshot_account_transactions
- top_spenders = snapshot[:top_spenders]
- top_earners = snapshot[:top_earners]
- top_savers = snapshot[:top_savers]
-
- assert_equal [ 10 ], top_spenders.map(&:spending)
- assert_equal [ 5000, 1000 ], top_earners.map(&:income)
- assert_equal [ 1, 0.99 ], top_savers.map(&:savings_rate)
- end
-
-
- test "calculates rolling transaction totals" do
- account = create_account(balance: 1000, accountable: Depository.new)
- create_transaction(account: account, date: 2.days.ago.to_date, amount: -500)
- create_transaction(account: account, date: 1.day.ago.to_date, amount: 100)
- create_transaction(account: account, date: Date.current, amount: 20)
-
- snapshot = @family.snapshot_transactions
-
- expected_income_series = [
- 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
- 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
- 0, 0, 500, 500, 500
- ]
-
- assert_equal expected_income_series, snapshot[:income_series].values.map(&:value).map(&:amount)
-
- expected_spending_series = [
- 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
- 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
- 0, 0, 0, 100, 120
- ]
-
- assert_equal expected_spending_series, snapshot[:spending_series].values.map(&:value).map(&:amount)
-
- expected_savings_rate_series = [
- 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
- 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
- 0, 0, 1, 0.8, 0.76
- ]
-
- assert_equal expected_savings_rate_series, snapshot[:savings_rate_series].values.map(&:value).map { |v| v.round(2) }
- end
-
- private
-
- def create_account(attributes = {})
- account = @family.accounts.create! name: "Test", currency: "USD", **attributes
- account
- end
end
diff --git a/test/models/impersonation_session_log_test.rb b/test/models/impersonation_session_log_test.rb
deleted file mode 100644
index f620ebb1..00000000
--- a/test/models/impersonation_session_log_test.rb
+++ /dev/null
@@ -1,7 +0,0 @@
-require "test_helper"
-
-class ImpersonationSessionLogTest < ActiveSupport::TestCase
- # test "the truth" do
- # assert true
- # end
-end
diff --git a/test/models/import/mapping_test.rb b/test/models/import/mapping_test.rb
deleted file mode 100644
index 6286a582..00000000
--- a/test/models/import/mapping_test.rb
+++ /dev/null
@@ -1,7 +0,0 @@
-require "test_helper"
-
-class Import::MappingTest < ActiveSupport::TestCase
- # test "the truth" do
- # assert true
- # end
-end
diff --git a/test/models/import/row_test.rb b/test/models/import/row_test.rb
deleted file mode 100644
index afe1a4f6..00000000
--- a/test/models/import/row_test.rb
+++ /dev/null
@@ -1,7 +0,0 @@
-require "test_helper"
-
-class Import::RowTest < ActiveSupport::TestCase
- # test "the truth" do
- # assert true
- # end
-end
diff --git a/test/models/income_statement_test.rb b/test/models/income_statement_test.rb
new file mode 100644
index 00000000..a291dafc
--- /dev/null
+++ b/test/models/income_statement_test.rb
@@ -0,0 +1,48 @@
+require "test_helper"
+
+class IncomeStatementTest < ActiveSupport::TestCase
+ include Account::EntriesTestHelper
+
+ setup do
+ @family = families(:empty)
+
+ @income_category = @family.categories.create! name: "Income", classification: "income"
+ @food_category = @family.categories.create! name: "Food", classification: "expense"
+ @shopping_category = @family.categories.create! name: "Shopping", classification: "expense", parent: @food_category
+
+ @checking_account = @family.accounts.create! name: "Checking", currency: @family.currency, balance: 5000, accountable: Depository.new
+ @credit_card_account = @family.accounts.create! name: "Credit Card", currency: @family.currency, balance: 1000, accountable: CreditCard.new
+
+ create_transaction(account: @checking_account, amount: -1000, category: @food_category)
+ create_transaction(account: @checking_account, amount: 200, category: @shopping_category)
+ create_transaction(account: @credit_card_account, amount: 300, category: @food_category)
+ create_transaction(account: @credit_card_account, amount: 400, category: @shopping_category)
+ end
+
+ test "calculates totals for transactions" do
+ income_statement = IncomeStatement.new(@family)
+ assert_equal Money.new(1000, @family.currency), income_statement.totals.income_money
+ assert_equal Money.new(200 + 300 + 400, @family.currency), income_statement.totals.expense_money
+ assert_equal 4, income_statement.totals.transactions_count
+ end
+
+ test "calculates expenses for a period" do
+ income_statement = IncomeStatement.new(@family)
+ assert_equal 200 + 300 + 400, income_statement.expense_totals(period: Period.last_30_days).total
+ end
+
+ test "calculates income for a period" do
+ income_statement = IncomeStatement.new(@family)
+ assert_equal 1000, income_statement.income_totals(period: Period.last_30_days).total
+ end
+
+ test "calculates median expense" do
+ income_statement = IncomeStatement.new(@family)
+ assert_equal 200 + 300 + 400, income_statement.expense_totals(period: Period.last_30_days).total
+ end
+
+ test "calculates median income" do
+ income_statement = IncomeStatement.new(@family)
+ assert_equal 1000, income_statement.income_totals(period: Period.last_30_days).total
+ end
+end
diff --git a/test/models/investment_test.rb b/test/models/investment_test.rb
deleted file mode 100644
index 8d5ffccf..00000000
--- a/test/models/investment_test.rb
+++ /dev/null
@@ -1,7 +0,0 @@
-require "test_helper"
-
-class InvestmentTest < ActiveSupport::TestCase
- # test "the truth" do
- # assert true
- # end
-end
diff --git a/test/models/issue_test.rb b/test/models/issue_test.rb
deleted file mode 100644
index 7e15ee90..00000000
--- a/test/models/issue_test.rb
+++ /dev/null
@@ -1,7 +0,0 @@
-require "test_helper"
-
-class IssueTest < ActiveSupport::TestCase
- # test "the truth" do
- # assert true
- # end
-end
diff --git a/test/models/other_asset_test.rb b/test/models/other_asset_test.rb
deleted file mode 100644
index f43ed087..00000000
--- a/test/models/other_asset_test.rb
+++ /dev/null
@@ -1,7 +0,0 @@
-require "test_helper"
-
-class OtherAssetTest < ActiveSupport::TestCase
- # test "the truth" do
- # assert true
- # end
-end
diff --git a/test/models/other_liability_test.rb b/test/models/other_liability_test.rb
deleted file mode 100644
index f92ea5ce..00000000
--- a/test/models/other_liability_test.rb
+++ /dev/null
@@ -1,7 +0,0 @@
-require "test_helper"
-
-class OtherLiabilityTest < ActiveSupport::TestCase
- # test "the truth" do
- # assert true
- # end
-end
diff --git a/test/models/period_test.rb b/test/models/period_test.rb
new file mode 100644
index 00000000..1dfbf91d
--- /dev/null
+++ b/test/models/period_test.rb
@@ -0,0 +1,61 @@
+require "test_helper"
+
+class PeriodTest < ActiveSupport::TestCase
+ test "raises validation error when start_date or end_date is missing" do
+ error = assert_raises(ActiveModel::ValidationError) do
+ Period.new(start_date: nil, end_date: nil)
+ end
+
+ assert_includes error.message, "Start date can't be blank"
+ assert_includes error.message, "End date can't be blank"
+ end
+
+ test "raises validation error when start_date is not before end_date" do
+ error = assert_raises(ActiveModel::ValidationError) do
+ Period.new(start_date: Date.current, end_date: Date.current - 1.day)
+ end
+
+ assert_includes error.message, "Start date must be before end date"
+ end
+
+ test "from_key returns period for valid key" do
+ period = Period.from_key("last_30_days")
+ assert_equal 30.days.ago.to_date, period.start_date
+ assert_equal Date.current, period.end_date
+ end
+
+ test "from_key with invalid key and fallback returns default period" do
+ period = Period.from_key("invalid_key", fallback: true)
+ assert_equal 30.days.ago.to_date, period.start_date
+ assert_equal Date.current, period.end_date
+ end
+
+ test "from_key with invalid key and no fallback raises error" do
+ assert_raises ArgumentError do
+ Period.from_key("invalid_key")
+ end
+ end
+
+ test "label returns correct label for known period" do
+ period = Period.from_key("last_30_days")
+ assert_equal "Last 30 Days", period.label
+ end
+
+ test "label returns Custom Period for unknown period" do
+ period = Period.new(start_date: Date.current - 15.days, end_date: Date.current)
+ assert_equal "Custom Period", period.label
+ end
+
+ test "comparison_label returns correct label for known period" do
+ period = Period.from_key("last_30_days")
+ assert_equal "vs. last month", period.comparison_label
+ end
+
+ test "comparison_label returns date range for unknown period" do
+ start_date = Date.current - 15.days
+ end_date = Date.current
+ period = Period.new(start_date: start_date, end_date: end_date)
+ expected = "#{start_date.strftime("%b %d, %Y")} to #{end_date.strftime("%b %d, %Y")}"
+ assert_equal expected, period.comparison_label
+ end
+end
diff --git a/test/models/property_test.rb b/test/models/property_test.rb
deleted file mode 100644
index caf57b12..00000000
--- a/test/models/property_test.rb
+++ /dev/null
@@ -1,7 +0,0 @@
-require "test_helper"
-
-class PropertyTest < ActiveSupport::TestCase
- # test "the truth" do
- # assert true
- # end
-end
diff --git a/test/models/security_test.rb b/test/models/security_test.rb
deleted file mode 100644
index 8e82099f..00000000
--- a/test/models/security_test.rb
+++ /dev/null
@@ -1,7 +0,0 @@
-require "test_helper"
-
-class SecurityTest < ActiveSupport::TestCase
- # test "the truth" do
- # assert true
- # end
-end
diff --git a/test/models/session_test.rb b/test/models/session_test.rb
deleted file mode 100644
index 47ad9065..00000000
--- a/test/models/session_test.rb
+++ /dev/null
@@ -1,7 +0,0 @@
-require "test_helper"
-
-class SessionTest < ActiveSupport::TestCase
- # test "the truth" do
- # assert true
- # end
-end
diff --git a/test/models/time_series/trend_test.rb b/test/models/time_series/trend_test.rb
deleted file mode 100644
index b05d13ad..00000000
--- a/test/models/time_series/trend_test.rb
+++ /dev/null
@@ -1,49 +0,0 @@
-require "test_helper"
-
-class TimeSeries::TrendTest < ActiveSupport::TestCase
- test "handles money trend" do
- trend = TimeSeries::Trend.new(current: Money.new(100), previous: Money.new(50))
- assert_equal "up", trend.direction
- assert_equal Money.new(50), trend.value
- assert_equal 100.0, trend.percent
- end
-
- test "up" do
- trend = TimeSeries::Trend.new(current: 100, previous: 50)
- assert_equal "up", trend.direction
- assert_equal "#10A861", trend.color
- end
-
- test "down" do
- trend = TimeSeries::Trend.new(current: 50, previous: 100)
- assert_equal "down", trend.direction
- assert_equal "#F13636", trend.color
- end
-
- test "flat" do
- trend1 = TimeSeries::Trend.new(current: 100, previous: 100)
- trend2 = TimeSeries::Trend.new(current: 100, previous: nil)
- trend3 = TimeSeries::Trend.new(current: nil, previous: nil)
- assert_equal "flat", trend1.direction
- assert_equal "flat", trend2.direction
- assert_equal "flat", trend3.direction
- assert_equal "#737373", trend1.color
- end
-
- test "infinitely up" do
- trend = TimeSeries::Trend.new(current: 100, previous: 0)
- assert_equal "up", trend.direction
- end
-
- test "infinitely down" do
- trend1 = TimeSeries::Trend.new(current: nil, previous: 100)
- trend2 = TimeSeries::Trend.new(current: 0, previous: 100)
- assert_equal "down", trend1.direction
- assert_equal "down", trend2.direction
- end
-
- test "empty" do
- trend = TimeSeries::Trend.new(current: nil, previous: nil)
- assert_equal "flat", trend.direction
- end
-end
diff --git a/test/models/time_series_test.rb b/test/models/time_series_test.rb
deleted file mode 100644
index a6a8431c..00000000
--- a/test/models/time_series_test.rb
+++ /dev/null
@@ -1,102 +0,0 @@
-require "test_helper"
-
-class TimeSeriesTest < ActiveSupport::TestCase
- test "it can accept array of money values" do
- series = TimeSeries.new([ { date: 1.day.ago.to_date, value: Money.new(100) }, { date: Date.current, value: Money.new(200) } ])
-
- assert_equal Money.new(100), series.first.value
- assert_equal Money.new(200), series.last.value
- assert_equal "up", series.favorable_direction
- assert_equal "up", series.trend.direction
- assert_equal Money.new(100), series.trend.value
- assert_equal 100.0, series.trend.percent
- end
-
- test "it can accept array of numeric values" do
- series = TimeSeries.new([ { date: 1.day.ago.to_date, value: 100 }, { date: Date.current, value: 200 } ])
-
- assert_equal 100, series.first.value
- assert_equal 200, series.last.value
- assert_equal 100, series.on(1.day.ago.to_date).value
- assert_equal "up", series.favorable_direction
- assert_equal "up", series.trend.direction
- assert_equal 100, series.trend.value
- assert_equal 100.0, series.trend.percent
- end
-
- test "when empty array passed, it returns empty series" do
- series = TimeSeries.new([])
-
- assert_nil series.first
- assert_nil series.last
- assert_equal({ values: [], trend: { favorable_direction: "up", direction: "flat", value: 0, percent: 0.0 }, favorable_direction: "up" }.to_json, series.to_json)
- end
-
- test "money series can be serialized to json" do
- expected_values = {
- values: [
- {
- date: 1.day.ago.to_date,
- value: { amount: "100.0", currency: "USD" },
- trend: { favorable_direction: "up", direction: "flat", value: { amount: "0.0", currency: "USD" }, percent: 0.0 }
- },
- {
- date: Date.current,
- value: { amount: "200.0", currency: "USD" },
- trend: { favorable_direction: "up", direction: "up", value: { amount: "100.0", currency: "USD" }, percent: 100.0 }
- }
- ],
- trend: { favorable_direction: "up", direction: "up", value: { amount: "100.0", currency: "USD" }, percent: 100.0 },
- favorable_direction: "up"
- }.to_json
-
- series = TimeSeries.new([ { date: 1.day.ago.to_date, value: Money.new(100) }, { date: Date.current, value: Money.new(200) } ])
-
- assert_equal expected_values, series.to_json
- end
-
- test "numeric series can be serialized to json" do
- expected_values = {
- values: [
- { date: 1.day.ago.to_date, value: 100, trend: { favorable_direction: "up", direction: "flat", value: 0, percent: 0.0 } },
- { date: Date.current, value: 200, trend: { favorable_direction: "up", direction: "up", value: 100, percent: 100.0 } }
- ],
- trend: { favorable_direction: "up", direction: "up", value: 100, percent: 100.0 },
- favorable_direction: "up"
- }.to_json
-
- series = TimeSeries.new([ { date: 1.day.ago.to_date, value: 100 }, { date: Date.current, value: 200 } ])
-
- assert_equal expected_values, series.to_json
- end
-
- test "it does not accept invalid values in Time Series Trend" do
- error = assert_raises(ActiveModel::ValidationError) do
- TimeSeries.new(
- [
- { date: 1.day.ago.to_date, value: 100 },
- { date: Date.current, value: "two hundred" }
- ]
- )
- end
- assert_match(/Current must be of the same type as previous/, error.message)
- assert_match(/Previous must be of the same type as current/, error.message)
- assert_match(/Current must be of type Money, Numeric, or nil/, error.message)
- end
-
-
- test "it does not accept invalid values in Time Series Value" do
- # We need to stub trend otherwise an error is raised before TimeSeries::Value validation
- TimeSeries::Trend.stub(:new, nil) do
- error = assert_raises(ActiveModel::ValidationError) do
- TimeSeries.new(
- [
- { date: 1.day.ago.to_date, value: 100 },
- { date: Date.current, value: "two hundred" }
- ]
- )
- end
- assert_equal "Validation failed: Value must be a Money or Numeric", error.message
- end
- end
-end
diff --git a/test/models/trend_test.rb b/test/models/trend_test.rb
new file mode 100644
index 00000000..64601af1
--- /dev/null
+++ b/test/models/trend_test.rb
@@ -0,0 +1,40 @@
+require "test_helper"
+
+class TrendTest < ActiveSupport::TestCase
+ test "handles money trend" do
+ trend = Trend.new(current: Money.new(100), previous: Money.new(50))
+ assert_equal "up", trend.direction
+ assert_equal Money.new(50), trend.value
+ assert_equal 100.0, trend.percent
+ end
+
+ test "up" do
+ trend = Trend.new(current: 100, previous: 50)
+ assert_equal "up", trend.direction
+ assert_equal "var(--color-success)", trend.color
+ end
+
+ test "down" do
+ trend = Trend.new(current: 50, previous: 100)
+ assert_equal "down", trend.direction
+ assert_equal "var(--color-destructive)", trend.color
+ end
+
+ test "flat" do
+ trend1 = Trend.new(current: 100, previous: 100)
+ trend2 = Trend.new(current: 100, previous: nil)
+ assert_equal "flat", trend1.direction
+ assert_equal "up", trend2.direction
+ assert_equal "var(--color-gray)", trend1.color
+ end
+
+ test "infinitely up" do
+ trend = Trend.new(current: 100, previous: 0)
+ assert_equal "up", trend.direction
+ end
+
+ test "infinitely down" do
+ trend = Trend.new(current: 0, previous: 100)
+ assert_equal "down", trend.direction
+ end
+end
diff --git a/test/models/value_group_test.rb b/test/models/value_group_test.rb
deleted file mode 100644
index 5c9e2bbf..00000000
--- a/test/models/value_group_test.rb
+++ /dev/null
@@ -1,141 +0,0 @@
-require "test_helper"
-require "ostruct"
-class ValueGroupTest < ActiveSupport::TestCase
- setup do
- # Level 1
- @assets = ValueGroup.new("Assets", :usd)
-
- # Level 2
- @depositories = @assets.add_child_group("Depositories", :usd)
- @other_assets = @assets.add_child_group("Other Assets", :usd)
-
- # Level 3 (leaf/value nodes)
- @checking_node = @depositories.add_value_node(OpenStruct.new({ name: "Checking", value: Money.new(5000) }), Money.new(5000))
- @savings_node = @depositories.add_value_node(OpenStruct.new({ name: "Savings", value: Money.new(20000) }), Money.new(20000))
- @collectable_node = @other_assets.add_value_node(OpenStruct.new({ name: "Collectable", value: Money.new(550) }), Money.new(550))
- end
-
- test "empty group works" do
- group = ValueGroup.new("Root", :usd)
-
- assert_equal "Root", group.name
- assert_equal [], group.children
- assert_equal 0, group.sum
- assert_equal 0, group.avg
- assert_equal 100, group.percent_of_total
- assert_nil group.parent
- end
-
- test "group without value nodes has no value" do
- assets = ValueGroup.new("Assets")
- depositories = assets.add_child_group("Depositories")
-
- assert_equal 0, assets.sum
- assert_equal 0, depositories.sum
- end
-
- test "sum equals value at leaf level" do
- assert_equal @checking_node.value, @checking_node.sum
- assert_equal @savings_node.value, @savings_node.sum
- assert_equal @collectable_node.value, @collectable_node.sum
- end
-
- test "value is nil at rollup levels" do
- assert_not_equal @depositories.value, @depositories.sum
- assert_nil @depositories.value
- assert_nil @other_assets.value
- end
-
- test "generates list of value nodes regardless of level in hierarchy" do
- assert_equal [ @checking_node, @savings_node, @collectable_node ], @assets.value_nodes
- assert_equal [ @checking_node, @savings_node ], @depositories.value_nodes
- assert_equal [ @collectable_node ], @other_assets.value_nodes
- end
-
- test "group with value nodes aggregates totals correctly" do
- assert_equal Money.new(5000), @checking_node.sum
- assert_equal Money.new(20000), @savings_node.sum
- assert_equal Money.new(550), @collectable_node.sum
-
- assert_equal Money.new(25000), @depositories.sum
- assert_equal Money.new(550), @other_assets.sum
-
- assert_equal Money.new(25550), @assets.sum
- end
-
- test "group averages leaf nodes" do
- assert_equal Money.new(5000), @checking_node.avg
- assert_equal Money.new(20000), @savings_node.avg
- assert_equal Money.new(550), @collectable_node.avg
-
- assert_in_delta 12500, @depositories.avg.amount, 0.01
- assert_in_delta 550, @other_assets.avg.amount, 0.01
- assert_in_delta 8516.67, @assets.avg.amount, 0.01
- end
-
- # Percentage of parent group (i.e. collectable is 100% of "Other Assets" group)
- test "group calculates percent of parent total" do
- assert_equal 100, @assets.percent_of_total
- assert_in_delta 97.85, @depositories.percent_of_total, 0.1
- assert_in_delta 2.15, @other_assets.percent_of_total, 0.1
- assert_in_delta 80.0, @savings_node.percent_of_total, 0.1
- assert_in_delta 20.0, @checking_node.percent_of_total, 0.1
- assert_equal 100, @collectable_node.percent_of_total
- end
-
- test "handles unbalanced tree" do
- vehicles = @assets.add_child_group("Vehicles")
-
- # Since we didn't add any value nodes to vehicles, shouldn't affect rollups
- assert_equal Money.new(25550), @assets.sum
- end
-
-
- test "can attach and aggregate time series" do
- checking_series = TimeSeries.new([ { date: 1.day.ago.to_date, value: Money.new(4000) }, { date: Date.current, value: Money.new(5000) } ])
- savings_series = TimeSeries.new([ { date: 1.day.ago.to_date, value: Money.new(19000) }, { date: Date.current, value: Money.new(20000) } ])
-
- @checking_node.series = checking_series
- @savings_node.series = savings_series
-
- assert_not_nil @checking_node.series
- assert_not_nil @savings_node.series
-
- assert_equal @checking_node.sum, @checking_node.series.last.value
- assert_equal @savings_node.sum, @savings_node.series.last.value
-
- aggregated_depository_series = TimeSeries.new([ { date: 1.day.ago.to_date, value: Money.new(23000) }, { date: Date.current, value: Money.new(25000) } ])
- aggregated_assets_series = TimeSeries.new([ { date: 1.day.ago.to_date, value: Money.new(23000) }, { date: Date.current, value: Money.new(25000) } ])
-
- assert_equal aggregated_depository_series.values, @depositories.series.values
- assert_equal aggregated_assets_series.values, @assets.series.values
- end
-
- test "attached series must be a TimeSeries" do
- assert_raises(RuntimeError) do
- @checking_node.series = []
- end
- end
-
- test "cannot add time series to non-leaf node" do
- assert_raises(RuntimeError) do
- @assets.series = TimeSeries.new([])
- end
- end
-
- test "can only add value node at leaf level of tree" do
- root = ValueGroup.new("Root Level")
- grandparent = root.add_child_group("Grandparent")
- parent = grandparent.add_child_group("Parent")
-
- value_node = parent.add_value_node(OpenStruct.new({ name: "Value Node", value: Money.new(100) }), Money.new(100))
-
- assert_raises(RuntimeError) do
- value_node.add_value_node(OpenStruct.new({ name: "Value Node", value: Money.new(100) }), Money.new(100))
- end
-
- assert_raises(RuntimeError) do
- grandparent.add_value_node(OpenStruct.new({ name: "Value Node", value: Money.new(100) }), Money.new(100))
- end
- end
-end
diff --git a/test/models/vehicle_test.rb b/test/models/vehicle_test.rb
deleted file mode 100644
index 71c13e12..00000000
--- a/test/models/vehicle_test.rb
+++ /dev/null
@@ -1,7 +0,0 @@
-require "test_helper"
-
-class VehicleTest < ActiveSupport::TestCase
- # test "the truth" do
- # assert true
- # end
-end
diff --git a/test/system/accounts_test.rb b/test/system/accounts_test.rb
index b41cdb67..64c5a8bf 100644
--- a/test/system/accounts_test.rb
+++ b/test/system/accounts_test.rb
@@ -72,11 +72,14 @@ class AccountsTest < ApplicationSystemTestCase
private
def open_new_account_modal
- click_link "sidebar-new-account"
+ within "[data-controller='tabs']" do
+ click_button "All"
+ click_link "New account"
+ end
end
def assert_account_created(accountable_type, &block)
- click_link humanized_accountable(accountable_type)
+ click_link Accountable.from_type(accountable_type).display_name.singularize
click_link "Enter account balance" if accountable_type.in?(%w[Depository Investment Crypto Loan CreditCard])
account_name = "[system test] #{accountable_type} Account"
@@ -88,8 +91,10 @@ class AccountsTest < ApplicationSystemTestCase
click_button "Create Account"
- find("details", text: humanized_accountable(accountable_type)).click
- assert_text account_name
+ within "[data-controller='tabs']" do
+ find("details", text: Accountable.from_type(accountable_type).display_name).click
+ assert_text account_name
+ end
visit accounts_url
assert_text account_name
@@ -109,6 +114,6 @@ class AccountsTest < ApplicationSystemTestCase
end
def humanized_accountable(accountable_type)
- accountable_type.constantize.model_name.human
+ Accountable.from_type(accountable_type).display_name.singularize
end
end
diff --git a/test/system/transactions_test.rb b/test/system/transactions_test.rb
index 3c9dd3fd..18f50c96 100644
--- a/test/system/transactions_test.rb
+++ b/test/system/transactions_test.rb
@@ -201,7 +201,7 @@ class TransactionsTest < ApplicationSystemTestCase
investment_account = accounts(:investment)
outflow_entry = create_transaction("outflow", Date.current, 500, account: asset_account)
inflow_entry = create_transaction("inflow", 1.day.ago.to_date, -500, account: investment_account)
- asset_account.auto_match_transfers!
+ @user.family.auto_match_transfers!
visit transactions_url
within "#entry-group-" + Date.current.to_s + "-totals" do
assert_text "-$100.00" # transaction eleven from setup