The personal finance app for everyone
Add missing migrations for good_job 4x (#967)
Tony Vincentde5a2e55b3e5
diff --git a/db/migrate/20240709113713_create_good_job_execution_error_backtrace.rb b/db/migrate/20240709113713_create_good_job_execution_error_backtrace.rbnew file mode 100644index 00000000..c6d3f64c--- /dev/null+++ b/db/migrate/20240709113713_create_good_job_execution_error_backtrace.rb@@ -0,0 +1,15 @@+# frozen_string_literal: true++class CreateGoodJobExecutionErrorBacktrace < ActiveRecord::Migration[7.2]+ def change+ reversible do |dir|+ dir.up do+ # Ensure this incremental update migration is idempotent+ # with monolithic install migration.+ return if connection.column_exists?(:good_job_executions, :error_backtrace)+ end+ end++ add_column :good_job_executions, :error_backtrace, :text, array: true+ end+enddiff --git a/db/migrate/20240709113714_create_good_job_process_lock_ids.rb b/db/migrate/20240709113714_create_good_job_process_lock_ids.rbnew file mode 100644index 00000000..94b8b674--- /dev/null+++ b/db/migrate/20240709113714_create_good_job_process_lock_ids.rb@@ -0,0 +1,18 @@+# frozen_string_literal: true++class CreateGoodJobProcessLockIds < ActiveRecord::Migration[7.2]+ def change+ reversible do |dir|+ dir.up do+ # Ensure this incremental update migration is idempotent+ # with monolithic install migration.+ return if connection.column_exists?(:good_jobs, :locked_by_id)+ end+ end++ add_column :good_jobs, :locked_by_id, :uuid+ add_column :good_jobs, :locked_at, :datetime+ add_column :good_job_executions, :process_id, :uuid+ add_column :good_job_processes, :lock_type, :integer, limit: 2+ end+enddiff --git a/db/migrate/20240709113715_create_good_job_process_lock_indexes.rb b/db/migrate/20240709113715_create_good_job_process_lock_indexes.rbnew file mode 100644index 00000000..c9cc6e69--- /dev/null+++ b/db/migrate/20240709113715_create_good_job_process_lock_indexes.rb@@ -0,0 +1,38 @@+# frozen_string_literal: true++class CreateGoodJobProcessLockIndexes < ActiveRecord::Migration[7.2]+ disable_ddl_transaction!++ def change+ reversible do |dir|+ dir.up do+ unless connection.index_name_exists?(:good_jobs, :index_good_jobs_on_priority_scheduled_at_unfinished_unlocked)+ add_index :good_jobs, [ :priority, :scheduled_at ],+ order: { priority: "ASC NULLS LAST", scheduled_at: :asc },+ where: "finished_at IS NULL AND locked_by_id IS NULL",+ name: :index_good_jobs_on_priority_scheduled_at_unfinished_unlocked,+ algorithm: :concurrently+ end++ unless connection.index_name_exists?(:good_jobs, :index_good_jobs_on_locked_by_id)+ add_index :good_jobs, :locked_by_id,+ where: "locked_by_id IS NOT NULL",+ name: :index_good_jobs_on_locked_by_id,+ algorithm: :concurrently+ end++ unless connection.index_name_exists?(:good_job_executions, :index_good_job_executions_on_process_id_and_created_at)+ add_index :good_job_executions, [ :process_id, :created_at ],+ name: :index_good_job_executions_on_process_id_and_created_at,+ algorithm: :concurrently+ end+ end++ dir.down do+ remove_index(:good_jobs, name: :index_good_jobs_on_priority_scheduled_at_unfinished_unlocked) if connection.index_name_exists?(:good_jobs, :index_good_jobs_on_priority_scheduled_at_unfinished_unlocked)+ remove_index(:good_jobs, name: :index_good_jobs_on_locked_by_id) if connection.index_name_exists?(:good_jobs, :index_good_jobs_on_locked_by_id)+ remove_index(:good_job_executions, name: :index_good_job_executions_on_process_id_and_created_at) if connection.index_name_exists?(:good_job_executions, :index_good_job_executions_on_process_id_and_created_at)+ end+ end+ end+enddiff --git a/db/migrate/20240709152243_create_good_job_execution_duration.rb b/db/migrate/20240709152243_create_good_job_execution_duration.rbnew file mode 100644index 00000000..4b17b33d--- /dev/null+++ b/db/migrate/20240709152243_create_good_job_execution_duration.rb@@ -0,0 +1,15 @@+# frozen_string_literal: true++class CreateGoodJobExecutionDuration < ActiveRecord::Migration[7.2]+ def change+ reversible do |dir|+ dir.up do+ # Ensure this incremental update migration is idempotent+ # with monolithic install migration.+ return if connection.column_exists?(:good_job_executions, :duration)+ end+ end++ add_column :good_job_executions, :duration, :interval+ end+enddiff --git a/db/schema.rb b/db/schema.rbindex 778d5b34..e13e7f6d 100644--- a/db/schema.rb+++ b/db/schema.rb@@ -10,7 +10,7 @@## It's strongly recommended that you check this file into your version control system.-ActiveRecord::Schema[7.2].define(version: 2024_07_06_151026) do+ActiveRecord::Schema[7.2].define(version: 2024_07_09_152243) do# These are extensions that must be enabled in order to support this databaseenable_extension "pgcrypto"enable_extension "plpgsql"@@ -189,13 +189,18 @@ ActiveRecord::Schema[7.2].define(version: 2024_07_06_151026) dot.datetime "finished_at"t.text "error"t.integer "error_event", limit: 2+ t.text "error_backtrace", array: true+ t.uuid "process_id"+ t.interval "duration"t.index ["active_job_id", "created_at"], name: "index_good_job_executions_on_active_job_id_and_created_at"+ t.index ["process_id", "created_at"], name: "index_good_job_executions_on_process_id_and_created_at"endcreate_table "good_job_processes", id: :uuid, default: -> { "gen_random_uuid()" }, force: :cascade do |t|t.datetime "created_at", null: falset.datetime "updated_at", null: falset.jsonb "state"+ t.integer "lock_type", limit: 2endcreate_table "good_job_settings", id: :uuid, default: -> { "gen_random_uuid()" }, force: :cascade do |t|@@ -228,6 +233,8 @@ ActiveRecord::Schema[7.2].define(version: 2024_07_06_151026) dot.text "job_class"t.integer "error_event", limit: 2t.text "labels", array: true+ t.uuid "locked_by_id"+ t.datetime "locked_at"t.index ["active_job_id", "created_at"], name: "index_good_jobs_on_active_job_id_and_created_at"t.index ["batch_callback_id"], name: "index_good_jobs_on_batch_callback_id", where: "(batch_callback_id IS NOT NULL)"t.index ["batch_id"], name: "index_good_jobs_on_batch_id", where: "(batch_id IS NOT NULL)"@@ -236,8 +243,10 @@ ActiveRecord::Schema[7.2].define(version: 2024_07_06_151026) dot.index ["cron_key", "cron_at"], name: "index_good_jobs_on_cron_key_and_cron_at_cond", unique: true, where: "(cron_key IS NOT NULL)"t.index ["finished_at"], name: "index_good_jobs_jobs_on_finished_at", where: "((retried_good_job_id IS NULL) AND (finished_at IS NOT NULL))"t.index ["labels"], name: "index_good_jobs_on_labels", where: "(labels IS NOT NULL)", using: :gin+ t.index ["locked_by_id"], name: "index_good_jobs_on_locked_by_id", where: "(locked_by_id IS NOT NULL)"t.index ["priority", "created_at"], name: "index_good_job_jobs_for_candidate_lookup", where: "(finished_at IS NULL)"t.index ["priority", "created_at"], name: "index_good_jobs_jobs_on_priority_created_at_when_unfinished", order: { priority: "DESC NULLS LAST" }, where: "(finished_at IS NULL)"+ t.index ["priority", "scheduled_at"], name: "index_good_jobs_on_priority_scheduled_at_unfinished_unlocked", where: "((finished_at IS NULL) AND (locked_by_id IS NULL))"t.index ["queue_name", "scheduled_at"], name: "index_good_jobs_on_queue_name_and_scheduled_at", where: "(finished_at IS NULL)"t.index ["scheduled_at"], name: "index_good_jobs_on_scheduled_at", where: "(finished_at IS NULL)"end