Skip to content

armgit / maybe

Public Imported from GitHub
0

The personal finance app for everyone

Properly handle Plaid investment account transfers (#2420)

Zach Gollwitzere4a82d85e89e
diff --git a/app/models/plaid_account/investments/transactions_processor.rb b/app/models/plaid_account/investments/transactions_processor.rb
index fdcf95ec..df494504 100644
--- a/app/models/plaid_account/investments/transactions_processor.rb
+++ b/app/models/plaid_account/investments/transactions_processor.rb
@@ -24,7 +24,7 @@ class PlaidAccount::Investments::TransactionsProcessor
end
def cash_transaction?(transaction)
- transaction["type"] == "cash" || transaction["type"] == "fee"
+ transaction["type"] == "cash" || transaction["type"] == "fee" || transaction["type"] == "transfer"
end
def find_or_create_trade_entry(transaction)
diff --git a/test/models/plaid_account/investments/transactions_processor_test.rb b/test/models/plaid_account/investments/transactions_processor_test.rb
index 7cee38bd..2eb044f1 100644
--- a/test/models/plaid_account/investments/transactions_processor_test.rb
+++ b/test/models/plaid_account/investments/transactions_processor_test.rb
@@ -147,4 +147,37 @@ class PlaidAccount::Investments::TransactionsProcessorTest < ActiveSupport::Test
assert_equal -1, entry.trade.qty
end
+
+ test "creates transfer transactions as cash transactions" do
+ test_investments_payload = {
+ transactions: [
+ {
+ "investment_transaction_id" => "123",
+ "type" => "transfer",
+ "amount" => -100.0,
+ "iso_currency_code" => "USD",
+ "date" => Date.current,
+ "name" => "Bank Transfer"
+ }
+ ]
+ }
+
+ @plaid_account.update!(raw_investments_payload: test_investments_payload)
+
+ @security_resolver.expects(:resolve).never
+
+ processor = PlaidAccount::Investments::TransactionsProcessor.new(@plaid_account, security_resolver: @security_resolver)
+
+ assert_difference [ "Entry.count", "Transaction.count" ], 1 do
+ processor.process
+ end
+
+ entry = Entry.order(created_at: :desc).first
+
+ assert_equal -100.0, entry.amount
+ assert_equal "USD", entry.currency
+ assert_equal Date.current, entry.date
+ assert_equal "Bank Transfer", entry.name
+ assert_instance_of Transaction, entry.entryable
+ end
end