Skip to content

A self-hosted media server and file management system

fix: Bug: Subtitle Scaling Fixes #289

aminnausin04dc41379e71
diff --git a/resources/js/components/video/subtitles/OctopusRenderer.ts b/resources/js/components/video/subtitles/OctopusRenderer.ts
index dfdf6e13..46019670 100644
--- a/resources/js/components/video/subtitles/OctopusRenderer.ts
+++ b/resources/js/components/video/subtitles/OctopusRenderer.ts
@@ -2,6 +2,7 @@ import type { SubtitlesOctopusOptions } from '@jellyfin/libass-wasm';
import type { SubtitleResource } from '@/contracts/media';
import type SubtitlesOctopus from '@jellyfin/libass-wasm';
+import { debounce } from 'lodash-es';
import { toast } from '@aminnausin/cedar-ui';
import { ref } from 'vue';
@@ -71,10 +72,16 @@ export default function useOctopusRenderer() {
assInstance.value = null;
};
+ const resetOctopusCache = async () => {
+ assInstance.value?.resetRenderAheadCache();
+ };
+
const resizeOctopus = () => {
- if (assInstance.value?.worker) assInstance.value.resize();
+ assInstance.value?.resize();
};
+ const debouncedResetOctopusCache = debounce(resetOctopusCache, 300);
+
/**
* Generates a list of language specific fonts based on a predetermined list of files
*
@@ -100,6 +107,7 @@ export default function useOctopusRenderer() {
};
return {
+ debouncedResetOctopusCache,
instantiateOctopus,
clearOctopus,
resizeOctopus,
diff --git a/resources/js/components/video/subtitles/PlayerSubtitles.vue b/resources/js/components/video/subtitles/PlayerSubtitles.vue
index 3b52bc9b..30abd616 100644
--- a/resources/js/components/video/subtitles/PlayerSubtitles.vue
+++ b/resources/js/components/video/subtitles/PlayerSubtitles.vue
@@ -3,7 +3,7 @@ import type { SubtitleResource } from '@/types/resources';
import type { PopoverItem } from '@aminnausin/cedar-ui';
import type { Ref } from 'vue';
-import { computed, inject, nextTick, ref, useTemplateRef } from 'vue';
+import { computed, inject, nextTick, onMounted, onUnmounted, ref, useTemplateRef } from 'vue';
import { useContentStore } from '@/stores/ContentStore';
import { storeToRefs } from 'pinia';
import { round } from 'lodash-es';
@@ -25,7 +25,7 @@ interface PlayerSubtitlesProps {
getCurrentTime: () => number;
}
-const { instantiateOctopus, clearOctopus, resizeOctopus } = useOctopusRenderer();
+const { instantiateOctopus, clearOctopus, debouncedResetOctopusCache, resizeOctopus } = useOctopusRenderer();
//#region Shared State
const { stateVideo } = storeToRefs(useContentStore());
@@ -166,6 +166,14 @@ const buildSubtitleUrl = (subtitle?: SubtitleResource): string => {
return `/data/subtitles/${metadata_uuid}/${track_id}${languageSlug}${extension}`;
};
+onMounted(() => {
+ window.addEventListener('resize', debouncedResetOctopusCache);
+});
+
+onUnmounted(async () => {
+ window.removeEventListener('resize', debouncedResetOctopusCache);
+});
+
//#endregion
defineExpose({
handleSubtitles,