Skip to content

A self-hosted media server and file management system

fix: other session ip address should not be visible on demo environments

aminnausin0e05d992a671
diff --git a/app/Http/Controllers/Api/V1/SessionController.php b/app/Http/Controllers/Api/V1/SessionController.php
index 295bdf51..0e609666 100644
--- a/app/Http/Controllers/Api/V1/SessionController.php
+++ b/app/Http/Controllers/Api/V1/SessionController.php
@@ -11,16 +11,19 @@ use Illuminate\Support\Facades\DB;
class SessionController extends Controller {
public function index(Request $request) {
$user = $request->user();
+ $requestIp = $request->ip();
+ $requestId = $request->hasSession() ? $request->session()->getId() : null;
+
$sessions = DB::table('sessions')
->where('user_id', $user->id)
->orderByDesc('last_activity')
->get()
- ->map(function ($session) use ($request) {
+ ->map(function ($session) use ($requestId, $requestIp) {
return [
'id' => $session->id,
- 'ip_address' => $session->ip_address,
+ 'ip_address' => config('app.env') === 'demo' && $session->ip_address !== $requestIp ? 'hidden' : $session->ip_address,
'user_agent' => $session->user_agent,
- 'is_current' => $request->hasSession() && $session->id === $request->session()->getId(),
+ 'is_current' => $session->id === $requestId,
'last_active' => Carbon::createFromTimestamp($session->last_activity)->diffForHumans(),
];
});
diff --git a/package.json b/package.json
index 2eede5e5..8239950e 100755
--- a/package.json
+++ b/package.json
@@ -2,7 +2,7 @@
"private": true,
"type": "module",
"scripts": {
- "dev": "vite --host",
+ "dev": "vite",
"php:serve": "php artisan serve",
"php:pail": "php artisan pail",
"php:queue": "php artisan queue:listen --timeout=3600",
diff --git a/resources/js/components/cards/SessionCard.vue b/resources/js/components/cards/SessionCard.vue
index 383dca4b..4bdf688c 100644
--- a/resources/js/components/cards/SessionCard.vue
+++ b/resources/js/components/cards/SessionCard.vue
@@ -32,7 +32,7 @@ const agent = computed(() => {
</div>
<div class="text-xs text-neutral-600 dark:text-neutral-400">
- {{ session.ip_address }},
+ <span class="capitalize">{{ session.ip_address }},</span>
<span v-if="session.is_current" class="font-semibold text-green-500 animate-pulse ms-1">
<span class="recent rounded bg-green-500 size-2 inline-block animate-pulse"></span>