Skip to content

A self-hosted media server and file management system

chore: code smells

aminnausin131eeee30a39
diff --git a/app/Http/Controllers/Api/V1/Server/ServerConfigController.php b/app/Http/Controllers/Api/V1/Server/ServerConfigController.php
index 751334ef..565ca3e5 100644
--- a/app/Http/Controllers/Api/V1/Server/ServerConfigController.php
+++ b/app/Http/Controllers/Api/V1/Server/ServerConfigController.php
@@ -27,9 +27,7 @@ class ServerConfigController extends Controller {
}
public function updateScanner(UpdateScannerConfigRequest $request) {
- $validated = $request->validated();
-
- $this->config->setMany($validated);
+ $this->updateSection($request->validated());
return response()->noContent();
}
@@ -44,9 +42,7 @@ class ServerConfigController extends Controller {
}
public function updateStorage(UpdateStorageConfigRequest $request) {
- $validated = $request->validated();
-
- $this->config->setMany($validated);
+ $this->updateSection($request->validated());
return response()->noContent();
}
@@ -58,4 +54,8 @@ class ServerConfigController extends Controller {
return response()->noContent();
}
+
+ private function updateSection(array $validated) {
+ $this->config->setMany($validated);
+ }
}
diff --git a/app/Http/Requests/Server/UpdateStorageConfigRequest.php b/app/Http/Requests/Server/UpdateStorageConfigRequest.php
index 017d7d98..04ae0ddf 100644
--- a/app/Http/Requests/Server/UpdateStorageConfigRequest.php
+++ b/app/Http/Requests/Server/UpdateStorageConfigRequest.php
@@ -33,10 +33,10 @@ class UpdateStorageConfigRequest extends FormRequest {
*/
public function rules(): array {
return [
- 'cache_path' => ['nullable', 'string', function ($attr, $value, $fail) {
+ 'cache_path' => ['nullable', 'string', function ($_, $value, $fail) {
$this->validatePath($value, $fail);
}],
- 'metadata_path' => ['nullable', 'string', function ($attr, $value, $fail) {
+ 'metadata_path' => ['nullable', 'string', function ($_, $value, $fail) {
$this->validatePath($value, $fail);
}],
];
diff --git a/resources/js/views/SettingsView.vue b/resources/js/views/SettingsView.vue
index 8c48e7cc..58aedc05 100755
--- a/resources/js/views/SettingsView.vue
+++ b/resources/js/views/SettingsView.vue
@@ -1,10 +1,9 @@
<script setup lang="ts">
+import { onMounted, watch } from 'vue';
import { useSettingsTabs } from '@/components/settings/SettingsTabs';
import { getScreenSize } from '@/service/util';
import { useAppStore } from '@/stores/AppStore';
-import { onMounted } from 'vue';
import { useRoute } from 'vue-router';
-import { watch } from 'vue';
import SettingsPreferences from '@/components/settings/SettingsPreferences.vue';
import SettingsAccount from '@/components/settings/SettingsAccount.vue';