A self-hosted media server and file management system
Vue ffmpegfile-serverjellyfinlaravelmediamedia-playermedia-servermediabrowsermediaservermusicmusic-librarymusic-playermusicplayerself-hostedvuejs
fix: update task returns error instead of null when task doesnt exist
aminnausin1615b54adc73
diff --git a/app/Services/TaskService.php b/app/Services/TaskService.phpindex 919dd20c..8f5fc044 100644--- a/app/Services/TaskService.php+++ b/app/Services/TaskService.php@@ -39,31 +39,19 @@ class TaskService {} else {TaskUpdated::dispatch($taskId);}-- return Task::findOrFail($taskId);+ return Task::find($taskId);}/*** Update SubTask by ID.*/public function updateSubTask(int $subTaskId, array $attr, bool $broadcast = false): ?SubTask {- $subTask = SubTask::find($subTaskId);+ DB::table('sub_tasks')->where('id', $subTaskId)->update($attr);- if (! $subTask) {- return null;- }+ $subTask = SubTask::find($subTaskId);- foreach ($attr as $key => $value) {- $subTask->{$key} = $value;- }- $subTask->save();- if ($broadcast) {- try {- SubTaskUpdated::dispatch($subTask->id, $subTask->task->id);- } catch (\Throwable $th) {- dump($th->getMessage());- Log::error('Unable to broadcast subTask update', ['error' => $th->getMessage()]);- }+ if ($broadcast && $subTask) {+ SubTaskUpdated::dispatch($subTaskId, $subTask->task->id);}return $subTask;@@ -91,6 +79,6 @@ class TaskService {TaskUpdated::dispatch($taskId);}- return Task::findOrFail($taskId);+ return Task::find($taskId);}}