Skip to content

A self-hosted media server and file management system

feat: apply rate limits to public api

aminnausin373dd72e0850
diff --git a/app/Http/Controllers/Api/V1/ExternalMetadataController.php b/app/Http/Controllers/Api/V1/ExternalMetadataController.php
index 658a9091..0c966470 100644
--- a/app/Http/Controllers/Api/V1/ExternalMetadataController.php
+++ b/app/Http/Controllers/Api/V1/ExternalMetadataController.php
@@ -10,15 +10,11 @@ use Illuminate\Http\Request;
class ExternalMetadataController extends Controller {
public function __construct(protected LrcLibService $lrcLibService) {}
- public function importLyrics(Request $request, $id) {
- $metadata = Metadata::FindOrFail($id);
-
+ public function importLyrics(Metadata $metadata) {
return response()->json($this->lrcLibService->importLyrics($metadata));
}
- public function searchLyrics(Request $request, $id) {
- $metadata = Metadata::FindOrFail($id);
-
+ public function searchLyrics(Request $request, Metadata $metadata) {
return response()->json($this->lrcLibService->searchLyrics($metadata, $request));
}
}
diff --git a/routes/api.php b/routes/api.php
index 699c48fa..a1bc729a 100755
--- a/routes/api.php
+++ b/routes/api.php
@@ -125,7 +125,7 @@ Route::post('/login', [AuthController::class, 'login']);
Route::post('/register', [AuthController::class, 'register'])->middleware('throttle:6,1')->name('register');
Route::post('/recovery', [PasswordResetLinkController::class, 'store'])->name('password.recovery');
Route::post('/reset-password/{token}', [PasswordController::class, 'store'])->name('password.reset');
-Route::post('/guest-token', [GuestTokenController::class, 'issue']);
+Route::post('/guest-token', [GuestTokenController::class, 'issue'])->middleware('throttle:guest-token');
// App Info
Route::get('/manifest', fn () => response()->json(AppManifest::info()));
@@ -155,13 +155,14 @@ Route::prefix('/media/{video}')->group(function () {
Route::prefix('/metadata/{metadata}')->group(function () {
// Progress
Route::get('/progress', [PlaybackProgressController::class, 'show']);
- Route::put('/progress', [PlaybackProgressController::class, 'upsert']);
+ Route::put('/progress', [PlaybackProgressController::class, 'upsert'])->middleware('throttle:playback-progress');
+ // Lyrics Service
+ Route::prefix('/lyrics')->middleware('throttle:lrclib')->group(function () {
+ Route::get('/import', [ExternalMetadataController::class, 'importLyrics']);
+ Route::get('/search', [ExternalMetadataController::class, 'searchLyrics']);
+ });
});
-// Lyrics Service
-Route::get('/metadata/{id}/lyrics/import', [ExternalMetadataController::class, 'importLyrics']);
-Route::get('/metadata/{id}/lyrics/search', [ExternalMetadataController::class, 'searchLyrics']);
-
// Content
Route::get('/{dir}', [DirectoryController::class, 'showDirectoryAPI']);
Route::get('/{dir}/{folderName}', [DirectoryController::class, 'showDirectoryAPI']);