Skip to content

A self-hosted media server and file management system

chore: code smells in regex

aminnausin552945b338b6
diff --git a/resources/js/components/video/transcript/transcriptParser.ts b/resources/js/components/video/transcript/transcriptParser.ts
index 6784473c..1dd33acc 100644
--- a/resources/js/components/video/transcript/transcriptParser.ts
+++ b/resources/js/components/video/transcript/transcriptParser.ts
@@ -1,6 +1,6 @@
import { timestampToSeconds } from '@/components/video/transcript/transcriptUtil';
-const STRIP_TAGS = /<(?!\/?(?:i|u)>|br\s*\/?>)[^>]*>/gi;
+const STRIP_TAGS = /<(?!\/?[iu]>|br\s*\/?>)[^>]*>/gi;
export interface TranscriptLine {
index: number;
diff --git a/resources/js/components/video/transcript/useTranscript.ts b/resources/js/components/video/transcript/useTranscript.ts
index a90fc7a2..80030228 100644
--- a/resources/js/components/video/transcript/useTranscript.ts
+++ b/resources/js/components/video/transcript/useTranscript.ts
@@ -17,6 +17,8 @@ const { isDesktop } = useReactiveBreakpoints();
let controller: AbortController | null = null;
+const SEARCH_TAGS = /<\/?[a-z][^>]*>/gi;
+
const generationStatus = ref<'idle' | 'requesting' | 'queued' | 'processing' | 'error'>('idle');
const isShowingTranscript = ref(false);
@@ -33,7 +35,7 @@ const currentTime = ref(0);
const searchQuery = ref('');
-const searchIndex = computed(() => parsedTranscript.value.map((l) => l.text.replace(/<[^>]*>/g, '').toLowerCase()));
+const searchIndex = computed(() => parsedTranscript.value.map((l) => l.text.replace(SEARCH_TAGS, '').toLowerCase()));
const placement = computed<'hidden' | 'sidebar' | 'overlay'>(() => {
if (!isShowingTranscript.value) return 'hidden';