Skip to content

A self-hosted media server and file management system

chore: code smells

aminnausin55b6d39c0507
diff --git a/resources/js/components/video/VideoPlayer.vue b/resources/js/components/video/VideoPlayer.vue
index d5e0c73c..5d9cef0a 100755
--- a/resources/js/components/video/VideoPlayer.vue
+++ b/resources/js/components/video/VideoPlayer.vue
@@ -473,7 +473,7 @@ const initBrowserMetadata = () => {
const handleInitMediaSession = () => {
navigator.mediaSession.metadata = null;
- if (!isMediaSession.value || isNaN(metadataId.value)) return;
+ if (!isMediaSession.value || Number.isNaN(metadataId.value)) return;
const artworkURL =
handleStorageURL(stateVideo.value.metadata?.poster_url) ||
diff --git a/resources/js/composables/player/useOpenGraph.ts b/resources/js/composables/player/useOpenGraph.ts
index 13e60872..b26c3d95 100644
--- a/resources/js/composables/player/useOpenGraph.ts
+++ b/resources/js/composables/player/useOpenGraph.ts
@@ -15,10 +15,8 @@ export function useOpenGraph(folderData: Ref<FolderResource>, mediaData: Ref<Vid
meta = document.createElement('meta');
meta.setAttribute('property', property);
document.head.appendChild(meta);
- } else {
- if (!originalMetaTags.has(property)) {
- originalMetaTags.set(property, meta.getAttribute('content'));
- }
+ } else if (!originalMetaTags.has(property)) {
+ originalMetaTags.set(property, meta.getAttribute('content'));
}
meta.setAttribute('content', content);
@@ -37,21 +35,6 @@ export function useOpenGraph(folderData: Ref<FolderResource>, mediaData: Ref<Vid
});
};
- // Unused
- const restoreOriginalTags = () => {
- originalMetaTags.forEach((content, property) => {
- const meta = document.querySelector(`meta[property="${property}"]`);
-
- if (content === null) return;
-
- if (meta && content !== null) {
- meta.setAttribute('content', content);
- } else if (meta && content === null) {
- meta.remove();
- }
- });
- };
-
const updateOpenGraph = () => {
if (mediaData.value.metadata?.media_type == MediaType.AUDIO) {
clearMetaTags();
@@ -74,7 +57,6 @@ export function useOpenGraph(folderData: Ref<FolderResource>, mediaData: Ref<Vid
onUnmounted(() => {
clearMetaTags();
- // restoreOriginalTags();
});
return { updateOpenGraph, setMetaTag, removeMetaTag };