Skip to content

A self-hosted media server and file management system

chore: add comments

aminnausin6b289acae956
diff --git a/app/Services/Ffmpeg/FFmpegCommandBuilder.php b/app/Services/Ffmpeg/FFmpegCommandBuilder.php
index 932566b0..360cd26c 100644
--- a/app/Services/Ffmpeg/FFmpegCommandBuilder.php
+++ b/app/Services/Ffmpeg/FFmpegCommandBuilder.php
@@ -9,8 +9,7 @@ use App\Services\Images\Storyboard\StoryboardOptions;
class FFmpegCommandBuilder {
public function __construct(
private HardwareDetectionService $hardware,
- ) {
- }
+ ) {}
public function storyboard(string $filePath, string $outputPattern, StoryboardOptions $options): array {
$profile = $this->hardware->detect();
diff --git a/app/Services/Hardware/HardwareDetectionService.php b/app/Services/Hardware/HardwareDetectionService.php
index 82c6390f..730722a6 100644
--- a/app/Services/Hardware/HardwareDetectionService.php
+++ b/app/Services/Hardware/HardwareDetectionService.php
@@ -151,6 +151,7 @@ class HardwareDetectionService {
/**
* Windows QSV detection using D3D11VA and the Intel vendor ID
+ * Doesn't really work because `qsv=qs@dx11` fails on the native ffmpeg binary, might be a jellyfin specific thing
*/
private function validateQsvD3d11va(): bool {
$process = new Process([
@@ -198,6 +199,8 @@ class HardwareDetectionService {
/**
* Old way of deriving basic qsv without vaapi or D3d11va
* This method was often slower than just using the CPU
+ *
+ * For reference only
*/
private function validateQsvPlain(): bool {
$process = new Process([