Skip to content

A self-hosted media server and file management system

fix: subtitle tests were missing source_key

aminnausin6bfb33fd9f46
diff --git a/database/factories/SubtitleFactory.php b/database/factories/SubtitleFactory.php
index b9fbb2c0..326295f1 100644
--- a/database/factories/SubtitleFactory.php
+++ b/database/factories/SubtitleFactory.php
@@ -2,6 +2,7 @@
namespace Database\Factories;
+use App\Enums\SubtitleSource;
use Illuminate\Database\Eloquent\Factories\Factory;
/**
@@ -14,8 +15,12 @@ class SubtitleFactory extends Factory {
* @return array<string, mixed>
*/
public function definition(): array {
+ $track = fake()->unique()->randomNumber(3);
+
return [
+ 'track_id' => $track,
'language' => 'eng',
+ 'source_key' => SubtitleSource::EMBEDDED->makeKey($track),
];
}
}
diff --git a/tests/Feature/Subtitles/SubtitleControllerTest.php b/tests/Feature/Subtitles/SubtitleControllerTest.php
index 5ec47366..9587fb43 100644
--- a/tests/Feature/Subtitles/SubtitleControllerTest.php
+++ b/tests/Feature/Subtitles/SubtitleControllerTest.php
@@ -2,6 +2,7 @@
namespace Tests\Feature\Subtitles;
+use App\Enums\SubtitleSource;
use App\Models\Metadata;
use App\Models\Subtitle;
use App\Services\Subtitles\SubtitleExtractor;
@@ -51,6 +52,7 @@ class SubtitleControllerTest extends TestCase {
Subtitle::factory()->create([
'metadata_uuid' => $metadata->uuid,
'track_id' => 2,
+ 'source_key' => SubtitleSource::EMBEDDED->makeKey(2),
]);
Storage::fake('local');
diff --git a/tests/Unit/Services/Subtitles/SubtitleScannerTest.php b/tests/Unit/Services/Subtitles/SubtitleScannerTest.php
index 75c1edbb..39cc8f7e 100644
--- a/tests/Unit/Services/Subtitles/SubtitleScannerTest.php
+++ b/tests/Unit/Services/Subtitles/SubtitleScannerTest.php
@@ -2,6 +2,7 @@
namespace Tests\Unit\Services\Subtitles;
+use App\Enums\SubtitleSource;
use App\Services\Subtitles\SubtitleScanner;
use Illuminate\Support\Facades\Log;
use Tests\TestCase;
@@ -51,6 +52,8 @@ class SubtitleScannerTest extends TestCase {
'codec' => 'subrip',
'is_default' => true,
'is_forced' => false,
+ 'external_path' => null,
+ 'source_key' => SubtitleSource::EMBEDDED->makeKey('2'),
],
], $result);
}