Skip to content

A self-hosted media server and file management system

chore: code smells

aminnausin9ecb2f35863d
diff --git a/app/Http/Resources/Pulse/ScheduleResource.php b/app/Http/Resources/Pulse/ScheduleResource.php
index 88cf4f15..74448aeb 100644
--- a/app/Http/Resources/Pulse/ScheduleResource.php
+++ b/app/Http/Resources/Pulse/ScheduleResource.php
@@ -54,6 +54,8 @@ class ScheduleResource extends PulseResource {
return 'unknown';
}
+ $closure = '';
+
$prop = $refClass->getProperty('callback');
$prop->setAccessible(true);
$callback = $prop->getValue($event);
@@ -61,24 +63,22 @@ class ScheduleResource extends PulseResource {
if ($callback instanceof Closure) {
$function = new ReflectionFunction($callback);
- return sprintf(
+ $closure = sprintf(
'%s:%s',
str_replace(app()->basePath() . DIRECTORY_SEPARATOR, '', $function->getFileName() ?: ''),
$function->getStartLine()
);
- }
-
- if (is_string($callback)) {
- return $callback;
- }
-
- if (is_array($callback)) {
+ } elseif (is_string($callback)) {
+ $closure = $callback;
+ } elseif (is_array($callback)) {
$className = is_string($callback[0]) ? $callback[0] : $callback[0]::class;
- return sprintf('%s::%s', $className, $callback[1]);
+ $closure = sprintf('%s::%s', $className, $callback[1]);
+ } else {
+ $closure = sprintf('%s::__invoke', $callback::class); // @phpstan-ignore-line
}
- return sprintf('%s::__invoke', $callback::class); // @phpstan-ignore-line
+ return $closure;
}
private function getCommand(Event $event): string {
diff --git a/resources/js/router/index.ts b/resources/js/router/index.ts
index e30e6d10..a5943910 100644
--- a/resources/js/router/index.ts
+++ b/resources/js/router/index.ts
@@ -3,7 +3,6 @@ import type { NavigationGuardNext, RouteLocationNormalizedGeneric, RouteLocation
import { createRouter, createWebHistory } from 'vue-router';
import { useAuthStore } from '@/stores/AuthStore';
import { toTitleCase } from '@/service/util';
-import { storeToRefs } from 'pinia';
import { logout } from '@/service/authAPI';
import { toast } from '@/service/toaster/toastService';
diff --git a/resources/js/stores/ContentStore.js b/resources/js/stores/ContentStore.js
index 784040ef..657849e9 100755
--- a/resources/js/stores/ContentStore.js
+++ b/resources/js/stores/ContentStore.js
@@ -147,8 +147,6 @@ export const useContentStore = defineStore('Content', () => {
if (!limit) fullRecordsLoaded.value = true;
- // stateRecords.value = [];
-
const { data, error } = await recordsService.getRecords(limit);
if (error) {