A self-hosted media server and file management system
Vue ffmpegfile-serverjellyfinlaravelmediamedia-playermedia-servermediabrowsermediaservermusicmusic-librarymusic-playermusicplayerself-hostedvuejs
fix: failed embed job errors have no info
aminnausina37314b29beb
diff --git a/app/Jobs/EmbedUidInMetadata.php b/app/Jobs/EmbedUidInMetadata.phpindex 157e428e..cd8c4e95 100644--- a/app/Jobs/EmbedUidInMetadata.php+++ b/app/Jobs/EmbedUidInMetadata.php@@ -192,15 +192,33 @@ class EmbedUidInMetadata extends ManagedSubTask {throw new ProcessFailedException($process);}- if (file_exists($tempFilePath)) {- // Get the original file's timestamps- $originalModifiedTime = filemtime($this->filePath);- // Replace the original file with the temporary file- rename($tempFilePath, $this->filePath);- // Restore the original timestamps- touch($this->filePath, $originalModifiedTime);- } else {- throw new \Exception('Failed to create the temporary file with metadata.');+ if (! file_exists($tempFilePath)) {+ throw new \RuntimeException(+ "FFmpeg completed successfully, but the output file was not created: {$tempFilePath}"+ );+ }++ $originalModifiedTime = filemtime($this->filePath);++ // Get the original file's timestamps+ if ($originalModifiedTime === false) {+ throw new \RuntimeException(+ "Failed to read the original file's modification time: {$this->filePath}"+ );+ }++ // Replace the original file with the temporary file+ if (! rename($tempFilePath, $this->filePath)) {+ throw new \RuntimeException(+ "Failed to replace original file '{$this->filePath}' with temporary file '{$tempFilePath}'."+ );+ }++ // Restore the original timestamps+ if (! touch($this->filePath, $originalModifiedTime)) {+ throw new \RuntimeException(+ "File was replaced successfully, but failed to restore its modification time: {$this->filePath}"+ );}}}