Skip to content

A self-hosted media server and file management system

fix: rate limits missing for public playbackProgress and lrclib Api

aminnausina69146fad3bd
diff --git a/app/Providers/Api/RouteServiceProvider.php b/app/Providers/Api/RouteServiceProvider.php
new file mode 100644
index 00000000..f4584e50
--- /dev/null
+++ b/app/Providers/Api/RouteServiceProvider.php
@@ -0,0 +1,36 @@
+<?php
+
+namespace App\Providers\Api;
+
+use Illuminate\Cache\RateLimiting\Limit;
+use Illuminate\Http\Request;
+use Illuminate\Support\Facades\RateLimiter;
+use Illuminate\Support\ServiceProvider;
+
+class RouteServiceProvider extends ServiceProvider {
+ public function boot(): void {
+ $this->configureRateLimiting();
+ }
+
+ protected function configureRateLimiting(): void {
+ // guest token endpoint
+ RateLimiter::for('guest-token', function ($_) {
+ return Limit::perMinute(10)->by(request()->ip());
+ });
+
+ // playback progress endpoint
+ RateLimiter::for('playback-progress', function ($_) {
+ // If expecting a request every 5 seconds (12 per minute per stream)
+ // this allows for 8 simultaneous streams from a single ip
+ return Limit::perMinute(96)->by(request()->ip());
+ });
+
+ RateLimiter::for('lrclib', function (Request $request) {
+ return Limit::perMinute(10)->by($request->user()?->id ?: $request->ip());
+ });
+
+ RateLimiter::for('api', function (Request $request) {
+ return Limit::perMinute(60)->by($request->user()?->id ?: $request->ip());
+ });
+ }
+}
diff --git a/bootstrap/cache/services.php b/bootstrap/cache/services.php
index 63e30641..eaf01212 100755
--- a/bootstrap/cache/services.php
+++ b/bootstrap/cache/services.php
@@ -48,6 +48,7 @@
44 => 'App\\Providers\\AppServiceProvider',
45 => 'App\\Providers\\HorizonServiceProvider',
46 => 'App\\Providers\\PathResolverServiceProvider',
+ 47 => 'App\\Providers\\Api\\RouteServiceProvider',
),
'eager' =>
array (
@@ -81,6 +82,7 @@
27 => 'App\\Providers\\AppServiceProvider',
28 => 'App\\Providers\\HorizonServiceProvider',
29 => 'App\\Providers\\PathResolverServiceProvider',
+ 30 => 'App\\Providers\\Api\\RouteServiceProvider',
),
'deferred' =>
array (
diff --git a/bootstrap/providers.php b/bootstrap/providers.php
index 70c56a4e..7b79d38a 100644
--- a/bootstrap/providers.php
+++ b/bootstrap/providers.php
@@ -4,4 +4,5 @@ return [
App\Providers\AppServiceProvider::class,
App\Providers\HorizonServiceProvider::class,
App\Providers\PathResolverServiceProvider::class,
+ App\Providers\Api\RouteServiceProvider::class,
];