A self-hosted media server and file management system
Vue ffmpegfile-serverjellyfinlaravelmediamedia-playermedia-servermediabrowsermediaservermusicmusic-librarymusic-playermusicplayerself-hostedvuejs
chore: code smells
aminnausinac040b59a29e
diff --git a/app/Jobs/VerifyFolders.php b/app/Jobs/VerifyFolders.phpindex 652b302a..c1b6a1ca 100644--- a/app/Jobs/VerifyFolders.php+++ b/app/Jobs/VerifyFolders.php@@ -134,9 +134,7 @@ class VerifyFolders extends ManagedSubTask {Series::upsert($transactions, 'id', ['folder_id', 'title', 'episodes', 'thumbnail_url', 'raw_thumbnail_url', 'total_size', 'primary_media_type', 'updated_at']);- $summary = 'Updated ' . count($transactions) . ' folders from id ' . ($transactions[0]['folder_id']) . ' to ' . ($transactions[count($transactions) - 1]['folder_id']);-- return $summary;+ return $summary = 'Updated ' . count($transactions) . ' folders from id ' . ($transactions[0]['folder_id']) . ' to ' . ($transactions[count($transactions) - 1]['folder_id']);} catch (\Throwable $th) {$ids = array_column($transactions, 'id');diff --git a/resources/js/components/video/subtitles/PlayerSubtitles.vue b/resources/js/components/video/subtitles/PlayerSubtitles.vueindex 7ddef3b1..0a935479 100644--- a/resources/js/components/video/subtitles/PlayerSubtitles.vue+++ b/resources/js/components/video/subtitles/PlayerSubtitles.vue@@ -81,7 +81,10 @@ const defaultSubtitleTrack = computed<SubtitleResource | undefined>(() => {const handleSizeChange = (_: Event, dir: number = 0) => {if (dir) {- subtitleSizeMultiplier.value = round(Math.max(Math.min(parseFloat(`${subtitleSizeMultiplier.value}`) + subtitleSizeDelta * dir, subtitleSizeMax), subtitleSizeMin), 2);+ subtitleSizeMultiplier.value = round(+ Math.max(Math.min(Number.parseFloat(`${subtitleSizeMultiplier.value}`) + subtitleSizeDelta * dir, subtitleSizeMax), subtitleSizeMin),+ 2,+ );}};diff --git a/resources/js/service/util.ts b/resources/js/service/util.tsindex d7f7bb32..7e3795c1 100644--- a/resources/js/service/util.ts+++ b/resources/js/service/util.ts@@ -148,7 +148,7 @@ export function isMobileDevice(): boolean {* @returns {string} `${formattedSize} ${unit}`.*/export function formatFileSize(size: number, space = true, divisor: number = 1024): string {- if (isNaN(size) || size < 0) {+ if (Number.isNaN(size) || size < 0) {return 'Invalid size';}@@ -166,7 +166,7 @@ export function formatFileSize(size: number, space = true, divisor: number = 102}export function formatBitrate(rate: number, space = true): string {- if (isNaN(rate) || rate < 0) {+ if (Number.isNaN(rate) || rate < 0) {return 'Invalid rate';}