Skip to content

A self-hosted media server and file management system

chore: code smells

aminnausincadd2c79019e
diff --git a/resources/js/components/video/VideoLyrics.vue b/resources/js/components/video/VideoLyrics.vue
index 0a02f622..22c9c404 100644
--- a/resources/js/components/video/VideoLyrics.vue
+++ b/resources/js/components/video/VideoLyrics.vue
@@ -59,7 +59,7 @@ const toPercentageTime = (seconds: number): number => {
const handleClick = (id: string, seconds: number) => {
document.getElementById(id)?.scrollIntoView({ behavior: 'smooth', block: 'center' });
- if (!isNaN(seconds)) emit('seek', seconds);
+ if (!Number.isNaN(seconds)) emit('seek', seconds);
};
function findCurrentLyric(lyrics: LyricItem[], currentTime: number, asPercentage: boolean = true): number {
@@ -103,7 +103,7 @@ const handleUpdate = async (scrollOverride: boolean = false) => {
const currentTime = (props.player.currentTime / props.timeDuration) * 100;
- if (isNaN(currentTime) || !lyricItems.value) return;
+ if (Number.isNaN(currentTime) || !lyricItems.value) return;
const index = findCurrentLyric(lyricItems.value, currentTime);
if (index < 0) return;
diff --git a/resources/js/components/video/VideoPlayer.vue b/resources/js/components/video/VideoPlayer.vue
index c247b74e..63b63327 100755
--- a/resources/js/components/video/VideoPlayer.vue
+++ b/resources/js/components/video/VideoPlayer.vue
@@ -122,7 +122,7 @@ const { userData } = storeToRefs(useAuthStore());
// API Cache
const progressCache = ref<{ metadata_id: number; progress: number }[]>([]);
-const metadataId = ref<number>(NaN);
+const metadataId = ref<number>(Number.NaN);
const currentId = ref<number | null>(null);
// API
@@ -135,7 +135,7 @@ const {
startInterval: startProgressInterval,
stopInterval: stopProgressInterval,
} = usePlaybackProgress(
- computed(() => (currentId.value ? metadataId.value : NaN)),
+ computed(() => (currentId.value ? metadataId.value : Number.NaN)),
getCurrentTime,
);
diff --git a/resources/js/composables/player/usePlaybackProgress.ts b/resources/js/composables/player/usePlaybackProgress.ts
index bdbc8944..bdd14f3d 100644
--- a/resources/js/composables/player/usePlaybackProgress.ts
+++ b/resources/js/composables/player/usePlaybackProgress.ts
@@ -11,7 +11,7 @@ export function usePlaybackProgress(mediaId: Ref<number>, getCurrentTime: () =>
let interval: ReturnType<typeof setInterval> | null = null;
const save = async (id = mediaId.value) => {
- if (isNaN(id)) return;
+ if (Number.isNaN(id)) return;
const metadata = contentStore.getMetadataById(id);
const duration = metadata?.duration ?? 0;
@@ -42,14 +42,14 @@ export function usePlaybackProgress(mediaId: Ref<number>, getCurrentTime: () =>
};
const getResumeOffset = async (id = mediaId.value) => {
- if (isNaN(id)) return null;
+ if (Number.isNaN(id)) return null;
const { data }: { data: { progress_offset?: number } } = await getProgress(id);
return data?.progress_offset ?? null;
};
watch(mediaId, async (_, oldId) => {
- if (isNaN(oldId)) return;
+ if (Number.isNaN(oldId)) return;
stopInterval();
await save(oldId); // Save previous media progress on switch
});
diff --git a/resources/js/stores/ContentStore.ts b/resources/js/stores/ContentStore.ts
index 01480125..4a201e41 100644
--- a/resources/js/stores/ContentStore.ts
+++ b/resources/js/stores/ContentStore.ts
@@ -312,7 +312,7 @@ export const useContentStore = defineStore('Content', () => {
function updatePlaybackProgress(id: number, data: { progress_offset: number; progress_percentage: number }) {
console.log('updatePlaybackProgress', id, data);
- if (isNaN(id)) return;
+ if (Number.isNaN(id)) return;
if (data.progress_offset < 0 || data.progress_percentage < 0 || data.progress_percentage > 100) return;
const apply = (video: VideoResource) => {
diff --git a/vite.config.ts b/vite.config.ts
index 08aedb29..caf41ae1 100644
--- a/vite.config.ts
+++ b/vite.config.ts
@@ -1,7 +1,6 @@
import { defineConfig, loadEnv } from 'vite';
import { viteStaticCopy } from 'vite-plugin-static-copy';
import { fileURLToPath } from 'node:url';
-import { wayfinder } from '@laravel/vite-plugin-wayfinder';
import viteCompression from 'vite-plugin-compression';
import tailwindcss from '@tailwindcss/vite';
@@ -34,7 +33,6 @@ export default defineConfig({
{ src: 'node_modules/@jellyfin/libass-wasm/dist/js/subtitles-octopus-worker.wasm', dest: 'lib/subtitles-octopus' },
],
}),
- // wayfinder(),
Icons({
compiler: 'vue3',
autoInstall: true,