Skip to content

A self-hosted media server and file management system

chore: code smells

aminnausinea8ba4d0e508
diff --git a/app/Http/Requests/MetadataStoreRequest.php b/app/Http/Requests/MetadataStoreRequest.php
index aabdb31e..65098e04 100644
--- a/app/Http/Requests/MetadataStoreRequest.php
+++ b/app/Http/Requests/MetadataStoreRequest.php
@@ -2,7 +2,6 @@
namespace App\Http\Requests;
-use App\Support\RequestPresets;
use Illuminate\Foundation\Http\FormRequest;
use Illuminate\Support\Facades\Auth;
@@ -29,21 +28,11 @@ class MetadataStoreRequest extends FormRequest {
* @return array<string, \Illuminate\Contracts\Validation\ValidationRule|array<mixed>|string>
*/
public function rules(): array {
+ $storeRequestRules = (new MetadataUpdateRequest)->rules();
+
return [
'video_id' => 'required|integer|exists:videos,id',
- 'title' => 'required|max:255',
- 'description' => 'nullable',
- 'lyrics' => 'nullable',
- 'episode' => RequestPresets::NON_NEGATIVE_INT,
- 'season' => RequestPresets::NON_NEGATIVE_INT,
- 'poster_url' => 'nullable|url',
- 'released_at' => 'nullable|date|date_format:Y-m-d',
- 'tags' => 'nullable|max:128',
- 'video_tags' => 'nullable|array',
- 'video_tags.*.name' => 'required|min:1|max:64',
- 'video_tags.*.id' => 'required|integer',
- 'deleted_tags' => 'nullable|array',
- 'deleted_tags.*' => 'integer',
+ ...$storeRequestRules,
];
}
}
diff --git a/resources/js/service/util.ts b/resources/js/service/util.ts
index 875de639..84de2a1e 100644
--- a/resources/js/service/util.ts
+++ b/resources/js/service/util.ts
@@ -112,11 +112,13 @@ export function formatInteger(integer: number, minimumDigits = 2) {
return integer.toLocaleString('en-CA', { minimumIntegerDigits: minimumDigits });
}
-export function toCalendarFormattedDate(date?: string, format: Intl.DateTimeFormatOptions = { month: 'long', day: '2-digit', year: 'numeric' }) {
+export function toCalendarFormattedDate(date?: string, format?: Intl.DateTimeFormatOptions) {
if (!date) return null;
const rawDate = new Date(date);
- return rawDate.toLocaleDateString('en-CA', format).replaceAll('.', '');
+ const defaultDateFormat = { month: 'long', day: '2-digit', year: 'numeric' } satisfies Intl.DateTimeFormatOptions;
+
+ return rawDate.toLocaleDateString('en-CA', format ?? defaultDateFormat).replaceAll('.', '');
}
/**
diff --git a/sonar-project.properties b/sonar-project.properties
index 4d856eb0..5388d490 100644
--- a/sonar-project.properties
+++ b/sonar-project.properties
@@ -10,4 +10,4 @@ sonar.issue.ignore.multicriteria.e1.ruleKey=typescript:S2686
sonar.issue.ignore.multicriteria.e1.resourceKey=resources/js/**/*.ts
sonar.typescript.tsconfigPath=tsconfig.app.json
-
+sonar.cpd.exclusions=**/database/migrations/**