A self-hosted media server and file management system
Vue ffmpegfile-serverjellyfinlaravelmediamedia-playermedia-servermediabrowsermediaservermusicmusic-librarymusic-playermusicplayerself-hostedvuejs
fix: using a slot for transcript timestamps can cause re-renders
aminnausinf98e6b59b0bc
diff --git a/resources/js/components/video/transcript/PlayerTranscript.vue b/resources/js/components/video/transcript/PlayerTranscript.vueindex 8523a5a0..353cb0f7 100644--- a/resources/js/components/video/transcript/PlayerTranscript.vue+++ b/resources/js/components/video/transcript/PlayerTranscript.vue@@ -8,10 +8,10 @@ import { useAppStore } from '@/stores/AppStore';import { cn } from '@aminnausin/cedar-ui';import GenerateTranscript from '@/components/video/transcript/GenerateTranscript.vue';+import TranscriptLine from '@/components/video/transcript/TranscriptLine.vue';import ProiconsPanelRight from '~icons/proicons/panel-right';import ProiconsCancel from '~icons/proicons/cancel';-import TranscriptLine from './TranscriptLine.vue';const props = defineProps<{ isVisible?: boolean }>();@@ -19,7 +19,6 @@ const { cycleSideBar } = useAppStore();const { isDesktop } = useReactiveBreakpoints();const {- player,isNormalView,subtitleTrack,rawTranscript,@@ -41,6 +40,7 @@ const transcriptLineRefs = ref<(HTMLElement | null)[]>([]);const isFollowing = ref(true);const transcriptDuration = computed(() => parsedTranscript.value.at(-1)?.end ?? 0);+const timestamps = computed(() => parsedTranscript.value.map((line) => formatTimestamp(line.start, transcriptDuration.value)));function onSelect(start: number) {isFollowing.value = true;@@ -126,6 +126,9 @@ onBeforeUnmount(() => {transcriptContainer.value?.removeEventListener('wheel', handleUserScroll);transcriptContainer.value?.removeEventListener('touchmove', handleUserScroll);});++import { onRenderTriggered } from 'vue';+onRenderTriggered(console.log);</script><template>@@ -187,10 +190,9 @@ onBeforeUnmount(() => {:active="line.index === activeIndex":live="line.index === activeIndex && isActiveLive":title="`${line.index + 1} of ${parsedTranscript.length}`"+ :timestamp="timestamps[line.index]"@select="onSelect"- >- {{ formatTimestamp(line.start, transcriptDuration) }}- </TranscriptLine>+ /></div></div><GenerateTranscriptdiff --git a/resources/js/components/video/transcript/TranscriptLine.vue b/resources/js/components/video/transcript/TranscriptLine.vueindex dce867b6..db3876f6 100644--- a/resources/js/components/video/transcript/TranscriptLine.vue+++ b/resources/js/components/video/transcript/TranscriptLine.vue@@ -3,7 +3,7 @@ import type { TranscriptLine } from '@/components/video/transcript/transcriptParimport { cn } from '@aminnausin/cedar-ui';-defineProps<{ line: TranscriptLine; active: boolean; live: boolean }>();+defineProps<{ line: TranscriptLine; active: boolean; live: boolean; timestamp: string }>();defineEmits<{ select: [start: number] }>();</script>@@ -26,7 +26,7 @@ defineEmits<{ select: [start: number] }>();})">- <slot></slot>+ {{ timestamp }}</span><span class="font-dm-sans line-clamp-3 leading-5 select-text" role="text" v-html="line.text"></span></button>