A self-hosted media server and file management system
Vue ffmpegfile-serverjellyfinlaravelmediamedia-playermedia-servermediabrowsermediaservermusicmusic-librarymusic-playermusicplayerself-hostedvuejs
fix(attempt): picture in picture toiggles don't exist on firefox
aminnausinff6bfb1954a1
diff --git a/resources/js/components/video/VideoPlayer.vue b/resources/js/components/video/VideoPlayer.vueindex d8c8cf1a..9726c2fa 100755--- a/resources/js/components/video/VideoPlayer.vue+++ b/resources/js/components/video/VideoPlayer.vue@@ -319,7 +319,7 @@ const playerContextMenuItems = computed<ContextMenuItem[]>(() => [{text: 'Show Miniplayer',icon: isPictureInPicture.value ? ProiconsCheckmark : undefined,- hidden: !document.pictureInPictureEnabled || isAudio.value,+ hidden: !(document.pictureInPictureEnabled || 'documentPictureInPicture' in window) || isAudio.value,action: () => {if (isLoading.value) return;togglePictureInPicture();@@ -432,7 +432,7 @@ const videoPopoverItems = computed(() => {icon: isPictureInPicture.value ? ProiconsPictureInPictureExit : ProiconsPictureInPictureEnter,selectedIcon: ProiconsCheckmark,selected: isPictureInPicture.value,- disabled: !document.pictureInPictureEnabled || isAudio.value,+ disabled: !(document.pictureInPictureEnabled || 'documentPictureInPicture' in window) || isAudio.value,action: () => {if (isLoading.value) return;togglePictureInPicture();@@ -1221,10 +1221,23 @@ const togglePictureInPicture = async () => {if (!player.value || isLoading.value) return;try {- if (document.pictureInPictureElement) {- await document.exitPictureInPicture();+ const pipCallers =+ 'documentPictureInPicture' in window+ ? {+ isOpen: !!window.documentPictureInPicture.window,+ open: () =>+ window.documentPictureInPicture.requestWindow({+ width: 1280,+ height: 720,+ }),+ close: () => window.documentPictureInPicture.window!.close(),+ }+ : { isOpen: !!document.pictureInPictureElement, open: () => player.value!.requestPictureInPicture(), close: () => document.exitPictureInPicture() };++ if (pipCallers.isOpen) {+ await pipCallers.close();} else {- await player.value.requestPictureInPicture();+ await pipCallers.open();}popover.value?.handleClose();diff --git a/resources/js/types/global.d.ts b/resources/js/types/global.d.tsindex 009a9b90..7a63e023 100644--- a/resources/js/types/global.d.ts+++ b/resources/js/types/global.d.ts@@ -13,5 +13,12 @@ declare global {Pusher: typeof Pusher;Echo: Echo<keyof Broadcaster> | null;plausible?: PlausibleEvent;+ readonly documentPictureInPicture: DocumentPictureInPicture;+ }++ interface DocumentPictureInPicture extends EventTarget {+ readonly window: Window | null;++ requestWindow(options?: { width?: number; height?: number; disallowReturnToOpener?: boolean; preferInitialWindowPlacement?: boolean }): Promise<Window>;}}