Skip to content

armgit / meet

Public Imported from GitHub
0

Open source video conferencing app powered by LiveKit. Built with Django and React.

πŸ”’οΈ(backend) reject inactive users in resource server backend

lebaudantoine04fd79b56bd7
diff --git a/CHANGELOG.md b/CHANGELOG.md
index a2feb80b..48041d0b 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -8,17 +8,18 @@ and this project adheres to
## [Unreleased]
-### Fixed
-
-- πŸ›(backend) acknowledge unknown LiveKit webhook events instead of 422
-- πŸ”’οΈ(backend) enforce display name setting on rename API
-
### Changed
- πŸ“ˆ(frontend) include LiveKit SIDs in the connection analytics event
- πŸ”‡(backend) silence expected 401 warnings on /me
- πŸ”‡(backend) silence noisy request summary info logs
+### Fixed
+
+- πŸ›(backend) acknowledge unknown LiveKit webhook events instead of 422
+- πŸ”’οΈ(backend) enforce display name setting on rename API
+- πŸ”’οΈ(backend) reject inactive users in resource server backend
+
## [1.31.0] - 2026-09-08
### Added
diff --git a/src/backend/core/external_api/authentication.py b/src/backend/core/external_api/authentication.py
index 496624f3..445eb02f 100644
--- a/src/backend/core/external_api/authentication.py
+++ b/src/backend/core/external_api/authentication.py
@@ -286,6 +286,10 @@ class ResourceServerBackend(LaSuiteBackend):
if user is None and settings.OIDC_CREATE_USER:
user = self.create_user(sub)
+ if user is not None and not user.is_active:
+ logger.warning("Inactive user attempted authentication: %s", user.pk)
+ raise SuspiciousOperation("User account is disabled.")
+
return user
def create_user(self, sub):
diff --git a/src/backend/core/tests/test_external_api_authentication.py b/src/backend/core/tests/test_external_api_authentication.py
new file mode 100644
index 00000000..ad628df5
--- /dev/null
+++ b/src/backend/core/tests/test_external_api_authentication.py
@@ -0,0 +1,96 @@
+"""Tests for the external API ResourceServerBackend."""
+
+from django.core.exceptions import SuspiciousOperation
+
+import pytest
+import responses
+from rest_framework.test import APIClient
+
+from core.external_api.authentication import ResourceServerBackend
+from core.factories import UserFactory
+from core.models import User
+
+pytestmark = pytest.mark.django_db
+
+
+def _payload(sub):
+ return {"sub": sub, "active": True, "scope": "lasuite_meet", "client_id": "app"}
+
+
+def test_resource_server_backend_get_or_create_user_active():
+ """An existing active user matching the sub should be returned."""
+
+ user = UserFactory()
+
+ result = ResourceServerBackend().get_or_create_user(
+ access_token="token", id_token=None, payload=_payload(user.sub)
+ )
+
+ assert result == user
+
+
+def test_resource_server_backend_get_or_create_user_inactive():
+ """An inactive user should be rejected even with a valid token."""
+
+ user = UserFactory(is_active=False)
+
+ with pytest.raises(SuspiciousOperation, match="User account is disabled."):
+ ResourceServerBackend().get_or_create_user(
+ access_token="token", id_token=None, payload=_payload(user.sub)
+ )
+
+
+def test_resource_server_backend_get_or_create_user_creates(settings):
+ """An unknown sub should create an active user when OIDC_CREATE_USER is set."""
+
+ settings.OIDC_CREATE_USER = True
+
+ result = ResourceServerBackend().get_or_create_user(
+ access_token="token", id_token=None, payload=_payload("new-sub")
+ )
+
+ assert result.sub == "new-sub"
+ assert result.is_active is True
+ assert User.objects.filter(sub="new-sub").exists()
+
+
+def test_resource_server_backend_get_or_create_user_no_creation(settings):
+ """An unknown sub should return None when OIDC_CREATE_USER is unset."""
+
+ settings.OIDC_CREATE_USER = False
+
+ result = ResourceServerBackend().get_or_create_user(
+ access_token="token", id_token=None, payload=_payload("new-sub")
+ )
+
+ assert result is None
+ assert not User.objects.filter(sub="new-sub").exists()
+
+
+def test_api_rooms_list_resource_server_inactive_user(settings):
+ """End to end: a valid introspected token for an inactive user should get 401."""
+
+ settings.OIDC_OP_INTROSPECTION_ENDPOINT = "https://oidc.example.com/introspect"
+ settings.OIDC_OP_URL = "https://oidc.example.com"
+
+ user = UserFactory(is_active=False)
+
+ responses.add(
+ responses.POST,
+ "https://oidc.example.com/introspect",
+ json={
+ "iss": "https://oidc.example.com",
+ "active": True,
+ "sub": user.sub,
+ "scope": "openid lasuite_meet rooms:list",
+ "client_id": "app",
+ },
+ )
+
+ client = APIClient()
+ client.credentials(HTTP_AUTHORIZATION="Bearer rs-token")
+ response = client.get("/external-api/v1.0/rooms/")
+
+ assert response.status_code == 401
+ assert "login failed" in str(response.data).lower()