Skip to content

armgit / meet

Public Imported from GitHub
0

Open source video conferencing app powered by LiveKit. Built with Django and React.

📝(backend) improve user provisioning documentation

lebaudantoine10aac93c36c1
diff --git a/src/backend/core/external_api/viewsets.py b/src/backend/core/external_api/viewsets.py
index c8d12667..a4ab2110 100644
--- a/src/backend/core/external_api/viewsets.py
+++ b/src/backend/core/external_api/viewsets.py
@@ -100,7 +100,15 @@ class ApplicationViewSet(viewsets.GenericViewSet):
and settings.OIDC_FALLBACK_TO_EMAIL_FOR_IDENTIFICATION
and not settings.OIDC_USER_SUB_FIELD_IMMUTABLE
):
- # Create a pending user without sub, but with an email.
+ # Create a provisional user without `sub`, identified by email only.
+ #
+ # This relies on Django LaSuite implicitly updating the `sub` field on the
+ # user's first successful OIDC authentication. If this stops working,
+ # check for behavior changes in Django LaSuite.
+ #
+ # `OIDC_USER_SUB_FIELD_IMMUTABLE` comes from Django LaSuite and prevents `sub`
+ # updates. We override its default value to allow setting `sub` for
+ # provisional users.
user = models.User(
sub=None,
email=email,