Open source video conferencing app powered by LiveKit. Built with Django and React.
♿️(frontend) add keyboard navigation to screen share zoom toolbar
Ovgodd27e32c0370ad
diff --git a/src/frontend/src/features/rooms/livekit/components/ScreenShareZoomControls.tsx b/src/frontend/src/features/rooms/livekit/components/ScreenShareZoomControls.tsxindex f946cf19..3c47a2c9 100644--- a/src/frontend/src/features/rooms/livekit/components/ScreenShareZoomControls.tsx+++ b/src/frontend/src/features/rooms/livekit/components/ScreenShareZoomControls.tsx@@ -1,5 +1,4 @@import { css } from '@/styled-system/css'-import { HStack } from '@/styled-system/jsx'import { Button } from '@/primitives'import {RiFullscreenExitLine,@@ -7,6 +6,7 @@ import {RiZoomOutLine,} from '@remixicon/react'import { useTranslation } from 'react-i18next'+import { Toolbar } from 'react-aria-components'import { useEffect, useRef } from 'react'import { isMacintosh } from '@/utils/livekit'import { srOnly } from '@/styles/a11y'@@ -59,15 +59,14 @@ export const ScreenShareZoomControls = ({pointerEvents: 'auto',})}>- <HStack- gap={0}- role="toolbar"+ <Toolbararia-label={t('toolbarLabel')}className={css({+ display: 'flex',+ alignItems: 'center',backgroundColor: 'primaryDark.50',borderRadius: '2rem',padding: '0.5rem',- alignItems: 'center',opacity: 0.7,transition: 'opacity 200ms linear',_hover: {@@ -160,7 +159,7 @@ export const ScreenShareZoomControls = ({<RiZoomInLine size={20} /></Button><ScreenShareFullscreenButton containerRef={containerRef} />- </HStack>+ </Toolbar></div>)}diff --git a/src/frontend/src/features/rooms/livekit/hooks/useScreenShareZoom.ts b/src/frontend/src/features/rooms/livekit/hooks/useScreenShareZoom.tsindex 9fbfb63e..68f8c0f7 100644--- a/src/frontend/src/features/rooms/livekit/hooks/useScreenShareZoom.ts+++ b/src/frontend/src/features/rooms/livekit/hooks/useScreenShareZoom.ts@@ -216,6 +216,8 @@ export const useScreenShareZoom = () => {const isZoomed = zoomRef.current > MIN_ZOOMif (!isZoomed && e.key !== '+' && e.key !== '=') return+ if (e.key.startsWith('Arrow') && e.target !== e.currentTarget) return+switch (e.key) {case 'ArrowLeft':e.preventDefault()diff --git a/src/frontend/src/locales/de/rooms.json b/src/frontend/src/locales/de/rooms.jsonindex 5fd229a8..565c3f3f 100644--- a/src/frontend/src/locales/de/rooms.json+++ b/src/frontend/src/locales/de/rooms.json@@ -770,7 +770,7 @@"fullScreen": "Vollbild","exitFullScreen": "Vollbild beenden","currentZoomLevel": "Zoom {{level}} %",- "panHint": "Zoom {{level}} %. Mit der Maus ziehen oder Pfeiltasten zum Navigieren verwenden.",+ "panHint": "Zoom {{level}} %. Mit der Maus ziehen oder den Fokus zurück auf die Bildschirmfreigabe setzen und mit den Pfeiltasten im Bild navigieren.","fullScreenEntered": "Vollbild aktiviert","fullScreenExited": "Vollbild deaktiviert"},diff --git a/src/frontend/src/locales/en/rooms.json b/src/frontend/src/locales/en/rooms.jsonindex c8ec5eff..082973e8 100644--- a/src/frontend/src/locales/en/rooms.json+++ b/src/frontend/src/locales/en/rooms.json@@ -770,7 +770,7 @@"fullScreen": "Full screen","exitFullScreen": "Exit full screen","currentZoomLevel": "Zoom {{level}} %",- "panHint": "Zoom {{level}} %. Drag with mouse or use arrow keys to navigate.",+ "panHint": "Zoom {{level}} %. Drag with mouse, or move focus back to the screen share and use arrow keys to navigate the picture.","fullScreenEntered": "Full screen enabled","fullScreenExited": "Full screen disabled"},diff --git a/src/frontend/src/locales/fr/rooms.json b/src/frontend/src/locales/fr/rooms.jsonindex 91ee3e0a..de4382c3 100644--- a/src/frontend/src/locales/fr/rooms.json+++ b/src/frontend/src/locales/fr/rooms.json@@ -770,7 +770,7 @@"fullScreen": "Plein écran","exitFullScreen": "Quitter le plein écran","currentZoomLevel": "Zoom {{level}} %",- "panHint": "Zoom {{level}} %. Glissez avec la souris ou utilisez les touches fléchées pour naviguer.",+ "panHint": "Zoom {{level}} %. Glissez avec la souris, ou revenez sur le partage d'écran et utilisez les touches fléchées pour naviguer dans l'image.","fullScreenEntered": "Plein écran activé","fullScreenExited": "Plein écran désactivé"},diff --git a/src/frontend/src/locales/nl/rooms.json b/src/frontend/src/locales/nl/rooms.jsonindex a19e8027..4c9d419e 100644--- a/src/frontend/src/locales/nl/rooms.json+++ b/src/frontend/src/locales/nl/rooms.json@@ -770,7 +770,7 @@"fullScreen": "Volledig scherm","exitFullScreen": "Volledig scherm verlaten","currentZoomLevel": "Zoom {{level}} %",- "panHint": "Zoom {{level}} %. Sleep met de muis of gebruik de pijltjestoetsen om te navigeren.",+ "panHint": "Zoom {{level}} %. Sleep met de muis, of zet de focus terug op de schermdeling en gebruik de pijltjestoetsen om door het beeld te navigeren.","fullScreenEntered": "Volledig scherm ingeschakeld","fullScreenExited": "Volledig scherm uitgeschakeld"},