Open source video conferencing app powered by LiveKit. Built with Django and React.
🥅(backend) catch request timeout and Brevo contact addition errors
lebaudantoine2a7d963f509e
diff --git a/src/backend/core/services/marketing.py b/src/backend/core/services/marketing.pyindex a8c8fc8f..27243a3f 100644--- a/src/backend/core/services/marketing.py+++ b/src/backend/core/services/marketing.py@@ -10,6 +10,7 @@ from django.core.exceptions import ImproperlyConfiguredfrom django.utils.module_loading import import_stringimport brevo_python+import requestslogger = logging.getLogger(__name__)@@ -120,7 +121,7 @@ class BrevoMarketingService:try:response = contact_api.create_contact(contact, **api_configurations)- except brevo_python.rest.ApiException as err:+ except (brevo_python.rest.ApiException, requests.exceptions.ReadTimeout) as err:logger.exception("Failed to create contact in Brevo")raise ContactCreationError("Failed to create contact in Brevo") from errdiff --git a/src/backend/core/tests/services/test_marketing.py b/src/backend/core/tests/services/test_marketing.pyindex 6a19c70d..ac1b31a4 100644--- a/src/backend/core/tests/services/test_marketing.py+++ b/src/backend/core/tests/services/test_marketing.py@@ -11,6 +11,7 @@ from django.core.exceptions import ImproperlyConfiguredimport brevo_pythonimport pytest+import requestsfrom core.services.marketing import (BrevoMarketingService,@@ -133,6 +134,30 @@ def test_create_contact_api_error(mock_contact_api):brevo_service.create_contact(valid_contact_data)[email protected]("brevo_python.ContactsApi")+def test_create_contact_timeout_error(mock_contact_api):+ """Test contact creation timeout error handling."""++ mock_api = mock_contact_api.return_value+ settings.BREVO_API_KEY = "test-api-key"+ settings.BREVO_API_CONTACT_LIST_IDS = [1, 2, 3, 4]+ settings.BREVO_API_CONTACT_ATTRIBUTES = {"source": "test"}++ valid_contact_data = ContactData(+ email="[email protected]",+ attributes={"first_name": "Test"},+ list_ids=[1, 2],+ update_enabled=True,+ )++ brevo_service = BrevoMarketingService()++ mock_api.create_contact.side_effect = requests.exceptions.ReadTimeout()++ with pytest.raises(ContactCreationError, match="Failed to create contact in Brevo"):+ brevo_service.create_contact(valid_contact_data)++@pytest.fixturedef clear_marketing_cache():"""Clear marketing service cache between tests."""