Open source video conferencing app powered by LiveKit. Built with Django and React.
♻️(backend) rework permission to better align with DRF responsibilities
lebaudantoine3887255e9cd0
diff --git a/src/backend/core/external_api/permissions.py b/src/backend/core/external_api/permissions.pyindex 1bf29e81..37591b3f 100644--- a/src/backend/core/external_api/permissions.py+++ b/src/backend/core/external_api/permissions.py@@ -33,12 +33,11 @@ class BaseScopePermission(permissions.BasePermission):Raises:PermissionDenied: If required scope is missing from token"""- # Get the current action (e.g., 'list', 'create')+ # Get the current action (e.g., 'list', 'create'), if None let DRF handle itaction = getattr(view, "action", None)if not action:- raise exceptions.PermissionDenied(- "Insufficient permissions. Unknown action."- )+ # DRF routers return a 405 for unsupported methods+ return Truerequired_scope = self.scope_map.get(action)if not required_scope:diff --git a/src/backend/core/tests/test_external_api_rooms.py b/src/backend/core/tests/test_external_api_rooms.pyindex eaf69ea1..1fc8c276 100644--- a/src/backend/core/tests/test_external_api_rooms.py+++ b/src/backend/core/tests/test_external_api_rooms.py@@ -611,15 +611,15 @@ def test_api_rooms_unknown_actions(settings):client.credentials(HTTP_AUTHORIZATION=f"Bearer {token}")response = client.delete(f"/external-api/v1.0/rooms/{room.id}/")- assert response.status_code == 403- assert "insufficient permissions. unknown action." in str(response.data).lower()+ assert response.status_code == 405+ assert 'method "delete" not allowed.' in str(response.data).lower()client = APIClient()client.credentials(HTTP_AUTHORIZATION=f"Bearer {token}")response = client.patch(f"/external-api/v1.0/rooms/{room.id}/")- assert response.status_code == 403- assert "insufficient permissions. unknown action." in str(response.data).lower()+ assert response.status_code == 405+ assert 'method "patch" not allowed.' in str(response.data).lower()def test_api_rooms_response_no_url(settings):