Skip to content

armgit / meet

Public Imported from GitHub
0

Open source video conferencing app powered by LiveKit. Built with Django and React.

♿️(frontend) enhance vocalization of blur options

lebaudantoine3ddb075c6be0
diff --git a/src/frontend/src/components/icons/BlurOn.tsx b/src/frontend/src/components/icons/BlurOn.tsx
index c4bd4ec0..fd4522d6 100644
--- a/src/frontend/src/components/icons/BlurOn.tsx
+++ b/src/frontend/src/components/icons/BlurOn.tsx
@@ -6,6 +6,7 @@ export const BlurOn = () => {
viewBox="0 0 24 24"
fill="none"
xmlns="http://www.w3.org/2000/svg"
+ aria-hidden="true"
>
<path
d="M3 14.5C2.86667 14.5 2.75 14.45 2.65 14.35C2.55 14.25 2.5 14.1333 2.5 14C2.5 13.8667 2.55 13.75 2.65 13.65C2.75 13.55 2.86667 13.5 3 13.5C3.13333 13.5 3.25 13.55 3.35 13.65C3.45 13.75 3.5 13.8667 3.5 14C3.5 14.1333 3.45 14.25 3.35 14.35C3.25 14.45 3.13333 14.5 3 14.5ZM3 10.5C2.86667 10.5 2.75 10.45 2.65 10.35C2.55 10.25 2.5 10.1333 2.5 10C2.5 9.86667 2.55 9.75 2.65 9.65C2.75 9.55 2.86667 9.5 3 9.5C3.13333 9.5 3.25 9.55 3.35 9.65C3.45 9.75 3.5 9.86667 3.5 10C3.5 10.1333 3.45 10.25 3.35 10.35C3.25 10.45 3.13333 10.5 3 10.5ZM6 19C5.71667 19 5.47917 18.9042 5.2875 18.7125C5.09583 18.5208 5 18.2833 5 18C5 17.7167 5.09583 17.4792 5.2875 17.2875C5.47917 17.0958 5.71667 17 6 17C6.28333 17 6.52083 17.0958 6.7125 17.2875C6.90417 17.4792 7 17.7167 7 18C7 18.2833 6.90417 18.5208 6.7125 18.7125C6.52083 18.9042 6.28333 19 6 19ZM6 15C5.71667 15 5.47917 14.9042 5.2875 14.7125C5.09583 14.5208 5 14.2833 5 14C5 13.7167 5.09583 13.4792 5.2875 13.2875C5.47917 13.0958 5.71667 13 6 13C6.28333 13 6.52083 13.0958 6.7125 13.2875C6.90417 13.4792 7 13.7167 7 14C7 14.2833 6.90417 14.5208 6.7125 14.7125C6.52083 14.9042 6.28333 15 6 15ZM6 11C5.71667 11 5.47917 10.9042 5.2875 10.7125C5.09583 10.5208 5 10.2833 5 10C5 9.71667 5.09583 9.47917 5.2875 9.2875C5.47917 9.09583 5.71667 9 6 9C6.28333 9 6.52083 9.09583 6.7125 9.2875C6.90417 9.47917 7 9.71667 7 10C7 10.2833 6.90417 10.5208 6.7125 10.7125C6.52083 10.9042 6.28333 11 6 11ZM6 7C5.71667 7 5.47917 6.90417 5.2875 6.7125C5.09583 6.52083 5 6.28333 5 6C5 5.71667 5.09583 5.47917 5.2875 5.2875C5.47917 5.09583 5.71667 5 6 5C6.28333 5 6.52083 5.09583 6.7125 5.2875C6.90417 5.47917 7 5.71667 7 6C7 6.28333 6.90417 6.52083 6.7125 6.7125C6.52083 6.90417 6.28333 7 6 7ZM10 15.5C9.58333 15.5 9.22917 15.3542 8.9375 15.0625C8.64583 14.7708 8.5 14.4167 8.5 14C8.5 13.5833 8.64583 13.2292 8.9375 12.9375C9.22917 12.6458 9.58333 12.5 10 12.5C10.4167 12.5 10.7708 12.6458 11.0625 12.9375C11.3542 13.2292 11.5 13.5833 11.5 14C11.5 14.4167 11.3542 14.7708 11.0625 15.0625C10.7708 15.3542 10.4167 15.5 10 15.5ZM10 11.5C9.58333 11.5 9.22917 11.3542 8.9375 11.0625C8.64583 10.7708 8.5 10.4167 8.5 10C8.5 9.58333 8.64583 9.22917 8.9375 8.9375C9.22917 8.64583 9.58333 8.5 10 8.5C10.4167 8.5 10.7708 8.64583 11.0625 8.9375C11.3542 9.22917 11.5 9.58333 11.5 10C11.5 10.4167 11.3542 10.7708 11.0625 11.0625C10.7708 11.3542 10.4167 11.5 10 11.5ZM10 19C9.71667 19 9.47917 18.9042 9.2875 18.7125C9.09583 18.5208 9 18.2833 9 18C9 17.7167 9.09583 17.4792 9.2875 17.2875C9.47917 17.0958 9.71667 17 10 17C10.2833 17 10.5208 17.0958 10.7125 17.2875C10.9042 17.4792 11 17.7167 11 18C11 18.2833 10.9042 18.5208 10.7125 18.7125C10.5208 18.9042 10.2833 19 10 19ZM10 7C9.71667 7 9.47917 6.90417 9.2875 6.7125C9.09583 6.52083 9 6.28333 9 6C9 5.71667 9.09583 5.47917 9.2875 5.2875C9.47917 5.09583 9.71667 5 10 5C10.2833 5 10.5208 5.09583 10.7125 5.2875C10.9042 5.47917 11 5.71667 11 6C11 6.28333 10.9042 6.52083 10.7125 6.7125C10.5208 6.90417 10.2833 7 10 7ZM10 21.5C9.86667 21.5 9.75 21.45 9.65 21.35C9.55 21.25 9.5 21.1333 9.5 21C9.5 20.8667 9.55 20.75 9.65 20.65C9.75 20.55 9.86667 20.5 10 20.5C10.1333 20.5 10.25 20.55 10.35 20.65C10.45 20.75 10.5 20.8667 10.5 21C10.5 21.1333 10.45 21.25 10.35 21.35C10.25 21.45 10.1333 21.5 10 21.5ZM10 3.5C9.86667 3.5 9.75 3.45 9.65 3.35C9.55 3.25 9.5 3.13333 9.5 3C9.5 2.86667 9.55 2.75 9.65 2.65C9.75 2.55 9.86667 2.5 10 2.5C10.1333 2.5 10.25 2.55 10.35 2.65C10.45 2.75 10.5 2.86667 10.5 3C10.5 3.13333 10.45 3.25 10.35 3.35C10.25 3.45 10.1333 3.5 10 3.5ZM14 15.5C13.5833 15.5 13.2292 15.3542 12.9375 15.0625C12.6458 14.7708 12.5 14.4167 12.5 14C12.5 13.5833 12.6458 13.2292 12.9375 12.9375C13.2292 12.6458 13.5833 12.5 14 12.5C14.4167 12.5 14.7708 12.6458 15.0625 12.9375C15.3542 13.2292 15.5 13.5833 15.5 14C15.5 14.4167 15.3542 14.7708 15.0625 15.0625C14.7708 15.3542 14.4167 15.5 14 15.5ZM14 11.5C13.5833 11.5 13.2292 11.3542 12.9375 11.0625C12.6458 10.7708 12.5 10.4167 12.5 10C12.5 9.58333 12.6458 9.22917 12.9375 8.9375C13.2292 8.64583 13.5833 8.5 14 8.5C14.4167 8.5 14.7708 8.64583 15.0625 8.9375C15.3542 9.22917 15.5 9.58333 15.5 10C15.5 10.4167 15.3542 10.7708 15.0625 11.0625C14.7708 11.3542 14.4167 11.5 14 11.5ZM14 19C13.7167 19 13.4792 18.9042 13.2875 18.7125C13.0958 18.5208 13 18.2833 13 18C13 17.7167 13.0958 17.4792 13.2875 17.2875C13.4792 17.0958 13.7167 17 14 17C14.2833 17 14.5208 17.0958 14.7125 17.2875C14.9042 17.4792 15 17.7167 15 18C15 18.2833 14.9042 18.5208 14.7125 18.7125C14.5208 18.9042 14.2833 19 14 19ZM14 7C13.7167 7 13.4792 6.90417 13.2875 6.7125C13.0958 6.52083 13 6.28333 13 6C13 5.71667 13.0958 5.47917 13.2875 5.2875C13.4792 5.09583 13.7167 5 14 5C14.2833 5 14.5208 5.09583 14.7125 5.2875C14.9042 5.47917 15 5.71667 15 6C15 6.28333 14.9042 6.52083 14.7125 6.7125C14.5208 6.90417 14.2833 7 14 7ZM14 21.5C13.8667 21.5 13.75 21.45 13.65 21.35C13.55 21.25 13.5 21.1333 13.5 21C13.5 20.8667 13.55 20.75 13.65 20.65C13.75 20.55 13.8667 20.5 14 20.5C14.1333 20.5 14.25 20.55 14.35 20.65C14.45 20.75 14.5 20.8667 14.5 21C14.5 21.1333 14.45 21.25 14.35 21.35C14.25 21.45 14.1333 21.5 14 21.5ZM14 3.5C13.8667 3.5 13.75 3.45 13.65 3.35C13.55 3.25 13.5 3.13333 13.5 3C13.5 2.86667 13.55 2.75 13.65 2.65C13.75 2.55 13.8667 2.5 14 2.5C14.1333 2.5 14.25 2.55 14.35 2.65C14.45 2.75 14.5 2.86667 14.5 3C14.5 3.13333 14.45 3.25 14.35 3.35C14.25 3.45 14.1333 3.5 14 3.5ZM18 19C17.7167 19 17.4792 18.9042 17.2875 18.7125C17.0958 18.5208 17 18.2833 17 18C17 17.7167 17.0958 17.4792 17.2875 17.2875C17.4792 17.0958 17.7167 17 18 17C18.2833 17 18.5208 17.0958 18.7125 17.2875C18.9042 17.4792 19 17.7167 19 18C19 18.2833 18.9042 18.5208 18.7125 18.7125C18.5208 18.9042 18.2833 19 18 19ZM18 15C17.7167 15 17.4792 14.9042 17.2875 14.7125C17.0958 14.5208 17 14.2833 17 14C17 13.7167 17.0958 13.4792 17.2875 13.2875C17.4792 13.0958 17.7167 13 18 13C18.2833 13 18.5208 13.0958 18.7125 13.2875C18.9042 13.4792 19 13.7167 19 14C19 14.2833 18.9042 14.5208 18.7125 14.7125C18.5208 14.9042 18.2833 15 18 15ZM18 11C17.7167 11 17.4792 10.9042 17.2875 10.7125C17.0958 10.5208 17 10.2833 17 10C17 9.71667 17.0958 9.47917 17.2875 9.2875C17.4792 9.09583 17.7167 9 18 9C18.2833 9 18.5208 9.09583 18.7125 9.2875C18.9042 9.47917 19 9.71667 19 10C19 10.2833 18.9042 10.5208 18.7125 10.7125C18.5208 10.9042 18.2833 11 18 11ZM18 7C17.7167 7 17.4792 6.90417 17.2875 6.7125C17.0958 6.52083 17 6.28333 17 6C17 5.71667 17.0958 5.47917 17.2875 5.2875C17.4792 5.09583 17.7167 5 18 5C18.2833 5 18.5208 5.09583 18.7125 5.2875C18.9042 5.47917 19 5.71667 19 6C19 6.28333 18.9042 6.52083 18.7125 6.7125C18.5208 6.90417 18.2833 7 18 7ZM21 14.5C20.8667 14.5 20.75 14.45 20.65 14.35C20.55 14.25 20.5 14.1333 20.5 14C20.5 13.8667 20.55 13.75 20.65 13.65C20.75 13.55 20.8667 13.5 21 13.5C21.1333 13.5 21.25 13.55 21.35 13.65C21.45 13.75 21.5 13.8667 21.5 14C21.5 14.1333 21.45 14.25 21.35 14.35C21.25 14.45 21.1333 14.5 21 14.5ZM21 10.5C20.8667 10.5 20.75 10.45 20.65 10.35C20.55 10.25 20.5 10.1333 20.5 10C20.5 9.86667 20.55 9.75 20.65 9.65C20.75 9.55 20.8667 9.5 21 9.5C21.1333 9.5 21.25 9.55 21.35 9.65C21.45 9.75 21.5 9.86667 21.5 10C21.5 10.1333 21.45 10.25 21.35 10.35C21.25 10.45 21.1333 10.5 21 10.5Z"
diff --git a/src/frontend/src/components/icons/BlurOnStrong.tsx b/src/frontend/src/components/icons/BlurOnStrong.tsx
index cc42fd33..319f9b38 100644
--- a/src/frontend/src/components/icons/BlurOnStrong.tsx
+++ b/src/frontend/src/components/icons/BlurOnStrong.tsx
@@ -6,6 +6,7 @@ export const BlurOnStrong = () => {
viewBox="0 0 24 24"
fill="none"
xmlns="http://www.w3.org/2000/svg"
+ aria-hidden="true"
>
<path
fillRule="evenodd"
diff --git a/src/frontend/src/features/rooms/livekit/components/effects/EffectsConfiguration.tsx b/src/frontend/src/features/rooms/livekit/components/effects/EffectsConfiguration.tsx
index 7a5fcf76..42588372 100644
--- a/src/frontend/src/features/rooms/livekit/components/effects/EffectsConfiguration.tsx
+++ b/src/frontend/src/features/rooms/livekit/components/effects/EffectsConfiguration.tsx
@@ -152,8 +152,10 @@ export const EffectsConfiguration = ({
)
}
- const tooltipLabel = (type: ProcessorType, options: BackgroundOptions) => {
- return t(`${type}.${isSelected(type, options) ? 'clear' : 'apply'}`)
+ const tooltipBlur = (type: ProcessorType, options: BackgroundOptions) => {
+ return t(
+ `${type}.${options.blurRadius == BlurRadius.LIGHT ? 'light' : 'normal'}.${isSelected(type, options) ? 'clear' : 'apply'}`
+ )
}
const tooltipVirtualBackground = (index: number): string => {
@@ -276,10 +278,7 @@ export const EffectsConfiguration = ({
>
<ToggleButton
variant="bigSquare"
- aria-label={tooltipLabel(ProcessorType.BLUR, {
- blurRadius: BlurRadius.LIGHT,
- })}
- tooltip={tooltipLabel(ProcessorType.BLUR, {
+ tooltip={tooltipBlur(ProcessorType.BLUR, {
blurRadius: BlurRadius.LIGHT,
})}
isDisabled={processorPendingReveal || isDisabled}
@@ -297,10 +296,7 @@ export const EffectsConfiguration = ({
</ToggleButton>
<ToggleButton
variant="bigSquare"
- aria-label={tooltipLabel(ProcessorType.BLUR, {
- blurRadius: BlurRadius.NORMAL,
- })}
- tooltip={tooltipLabel(ProcessorType.BLUR, {
+ tooltip={tooltipBlur(ProcessorType.BLUR, {
blurRadius: BlurRadius.NORMAL,
})}
isDisabled={processorPendingReveal || isDisabled}
diff --git a/src/frontend/src/locales/de/rooms.json b/src/frontend/src/locales/de/rooms.json
index c77b1356..19f823e5 100644
--- a/src/frontend/src/locales/de/rooms.json
+++ b/src/frontend/src/locales/de/rooms.json
@@ -233,10 +233,14 @@
"clear": "Effekt deaktivieren",
"blur": {
"title": "Hintergrundunschärfe",
- "light": "Leichte Unschärfe",
- "normal": "Unschärfe",
- "apply": "Unschärfe aktivieren",
- "clear": "Unschärfe deaktivieren"
+ "light": {
+ "apply": "Hintergrund leicht verwischen",
+ "clear": "Unschärfe deaktivieren"
+ },
+ "normal": {
+ "apply": "Hintergrund verwischen",
+ "clear": "Unschärfe deaktivieren"
+ }
},
"virtual": {
"title": "Virtueller Hintergrund",
diff --git a/src/frontend/src/locales/en/rooms.json b/src/frontend/src/locales/en/rooms.json
index 4f0c071b..7f1b32d9 100644
--- a/src/frontend/src/locales/en/rooms.json
+++ b/src/frontend/src/locales/en/rooms.json
@@ -233,10 +233,14 @@
"clear": "Disable effect",
"blur": {
"title": "Background blur",
- "light": "Light blur",
- "normal": "Blur",
- "apply": "Enable blur",
- "clear": "Disable blur"
+ "light": {
+ "apply": "Slightly blur your background",
+ "clear": "Disable blur"
+ },
+ "normal": {
+ "apply": "Blur your background",
+ "clear": "Disable blur"
+ }
},
"virtual": {
"title": "Virtual background",
diff --git a/src/frontend/src/locales/fr/rooms.json b/src/frontend/src/locales/fr/rooms.json
index c0115d80..2adcc6ba 100644
--- a/src/frontend/src/locales/fr/rooms.json
+++ b/src/frontend/src/locales/fr/rooms.json
@@ -233,10 +233,14 @@
"clear": "Désactiver l'effect",
"blur": {
"title": "Flou d'arrière-plan",
- "light": "Flou léger",
- "normal": "Flou",
- "apply": "Activer le flou",
- "clear": "Désactiver le flou"
+ "light": {
+ "apply": "Flouter légèrement votre arrière-plan",
+ "clear": "Désactiver le flou"
+ },
+ "normal": {
+ "apply": "Flouter votre arrière-plan",
+ "clear": "Désactiver le flou"
+ }
},
"virtual": {
"title": "Arrière-plan virtuel",
diff --git a/src/frontend/src/locales/nl/rooms.json b/src/frontend/src/locales/nl/rooms.json
index 66e43c0f..be7c0f25 100644
--- a/src/frontend/src/locales/nl/rooms.json
+++ b/src/frontend/src/locales/nl/rooms.json
@@ -233,10 +233,14 @@
"clear": "Effect uitschakelen",
"blur": {
"title": "Achtergrondvervaging",
- "light": "Lichte vervaging",
- "normal": "Vervaging",
- "apply": "Vervaging inschakelen",
- "clear": "Vervaging uitschakelen"
+ "light": {
+ "apply": "Vervaag je achtergrond lichtjes",
+ "clear": "Vervaging uitschakelen"
+ },
+ "normal": {
+ "apply": "Vervaag je achtergrond",
+ "clear": "Vervaging uitschakelen"
+ }
},
"virtual": {
"title": "Virtuele achtergrond",