Skip to content

armgit / meet

Public Imported from GitHub
0

Open source video conferencing app powered by LiveKit. Built with Django and React.

🎨(backend) simplify boolean comparisons by using opposite operators

lebaudantoine3e315e92fa6a
diff --git a/src/backend/core/api/serializers.py b/src/backend/core/api/serializers.py
index 5382be25..c5afa243 100644
--- a/src/backend/core/api/serializers.py
+++ b/src/backend/core/api/serializers.py
@@ -42,7 +42,7 @@ class ResourceAccessSerializerMixin:
data.get("role") == models.RoleChoices.OWNER
and not self.instance.resource.is_owner(user)
or self.instance.role == models.RoleChoices.OWNER
- and not self.instance.user == user
+ and self.instance.user != user
)
) or (
# Create
diff --git a/src/backend/core/migrations/0014_room_pin_code.py b/src/backend/core/migrations/0014_room_pin_code.py
index 51886415..f80c5b68 100644
--- a/src/backend/core/migrations/0014_room_pin_code.py
+++ b/src/backend/core/migrations/0014_room_pin_code.py
@@ -17,7 +17,7 @@ def generate_pin_for_rooms(apps, schema_editor):
def generate_pin_code():
while True:
pin_code = str(secrets.randbelow(10 ** length)).zfill(length)
- if not pin_code in existing_pins:
+ if pin_code not in existing_pins:
return pin_code
for room in rooms_without_pin_code:
diff --git a/src/backend/core/recording/event/parsers.py b/src/backend/core/recording/event/parsers.py
index 680b1623..ccf12d6a 100644
--- a/src/backend/core/recording/event/parsers.py
+++ b/src/backend/core/recording/event/parsers.py
@@ -123,7 +123,7 @@ class MinioParser:
f"Invalid bucket: expected {self._bucket_name}, got {event_data.bucket_name}"
)
- if not event_data.filetype in self._allowed_filetypes:
+ if event_data.filetype not in self._allowed_filetypes:
raise InvalidFileTypeError(
f"Invalid file type, expected {self._allowed_filetypes},"
f"got '{event_data.filetype}'"