Open source video conferencing app powered by LiveKit. Built with Django and React.
♻️(backend) simplify ResourceAccess viewset implementation
lebaudantoine63565b38c303
diff --git a/src/backend/core/api/viewsets.py b/src/backend/core/api/viewsets.pyindex 5270ec69..76fdf8ae 100644--- a/src/backend/core/api/viewsets.py+++ b/src/backend/core/api/viewsets.py@@ -531,21 +531,29 @@ class RoomViewSet()-class ResourceAccessListModelMixin:- """List mixin for resource access API."""-- def get_permissions(self):- """User only needs to be authenticated to list rooms access"""- if self.action == "list":- permission_classes = [permissions.IsAuthenticated]- else:- return super().get_permissions()+class ResourceAccessViewSet(+ mixins.CreateModelMixin,+ mixins.DestroyModelMixin,+ mixins.RetrieveModelMixin,+ mixins.UpdateModelMixin,+ mixins.ListModelMixin,+ viewsets.GenericViewSet,+):+ """+ API endpoints to access and perform actions on resource accesses.+ """- return [permission() for permission in permission_classes]+ permission_classes = [permissions.ResourceAccessPermission]+ queryset = models.ResourceAccess.objects.all()+ serializer_class = serializers.ResourceAccessSerializerdef get_queryset(self):"""Return the queryset according to the action."""+queryset = super().get_queryset()++ # Restrict access to resources the user either has explicit+ # permissions for or administrative privileges over.if self.action == "list":user = self.request.userqueryset = queryset.filter(@@ -555,25 +563,8 @@ class ResourceAccessListModelMixin:models.RoleChoices.OWNER,],).distinct()- return queryset---class ResourceAccessViewSet(- ResourceAccessListModelMixin,- mixins.CreateModelMixin,- mixins.DestroyModelMixin,- mixins.ListModelMixin,- mixins.RetrieveModelMixin,- mixins.UpdateModelMixin,- viewsets.GenericViewSet,-):- """- API endpoints to access and perform actions on resource accesses.- """- permission_classes = [permissions.ResourceAccessPermission]- queryset = models.ResourceAccess.objects.all()- serializer_class = serializers.ResourceAccessSerializer+ return querysetclass RecordingViewSet(