Skip to content

armgit / meet

Public Imported from GitHub
0

Open source video conferencing app powered by LiveKit. Built with Django and React.

♻️(backend) extract forbidden permission fields from the serializer

lebaudantoine720eb6a93e3a
diff --git a/src/backend/core/api/serializers.py b/src/backend/core/api/serializers.py
index 5405b1cb..ae050399 100644
--- a/src/backend/core/api/serializers.py
+++ b/src/backend/core/api/serializers.py
@@ -2,6 +2,7 @@
# pylint: disable=abstract-method,no-name-in-module
+from django.conf import settings
from django.core.exceptions import SuspiciousOperation
from django.utils.translation import gettext_lazy as _
@@ -318,7 +319,7 @@ class UpdateParticipantSerializer(BaseParticipantsManagementSerializer):
suspicious_fields = [
field
- for field in ("hidden", "recorder", "agent")
+ for field in settings.PARTICIPANT_FORBIDDEN_PERMISSION_FIELDS
if getattr(permission, field) is not None
]
if suspicious_fields:
diff --git a/src/backend/meet/settings.py b/src/backend/meet/settings.py
index eda28a76..937abff5 100755
--- a/src/backend/meet/settings.py
+++ b/src/backend/meet/settings.py
@@ -596,6 +596,12 @@ class Base(Configuration):
ALLOW_UNREGISTERED_ROOMS = values.BooleanValue(
True, environ_name="ALLOW_UNREGISTERED_ROOMS", environ_prefix=None
)
+ # if provided, treat as suspicious (possible privilege escalation attempt).
+ PARTICIPANT_FORBIDDEN_PERMISSION_FIELDS = values.ListValue(
+ ["hidden", "recorder", "agent"],
+ environ_name="PARTICIPANT_FORBIDDEN_PERMISSION_FIELDS",
+ environ_prefix=None,
+ )
# Recording settings
RECORDING_ENABLE = values.BooleanValue(