Skip to content

armgit / meet

Public Imported from GitHub
0

Open source video conferencing app powered by LiveKit. Built with Django and React.

🔒️(frontend) fix an XSS vulnerability on the recording page

lebaudantoine8f710a46261b
diff --git a/CHANGELOG.md b/CHANGELOG.md
index a4f43e10..017fdbf7 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -8,6 +8,10 @@ and this project adheres to
## [Unreleased]
+### Fixed
+
+- 🔒️(frontend) fix an XSS vulnerability on the recording page #911
+
## [1.4.0] - 2026-01-25
### Added
diff --git a/src/frontend/src/features/recording/routes/RecordingDownload.tsx b/src/frontend/src/features/recording/routes/RecordingDownload.tsx
index 52fcebf9..e69f47d7 100644
--- a/src/frontend/src/features/recording/routes/RecordingDownload.tsx
+++ b/src/frontend/src/features/recording/routes/RecordingDownload.tsx
@@ -104,14 +104,12 @@ export const RecordingDownload = () => {
{t('success.title')}
</H>
<Text centered margin="md" wrap={'balance'}>
- <span
- dangerouslySetInnerHTML={{
- __html: t('success.body', {
- room: data.room.name,
- created_at: formatDate(data.created_at, 'YYYY-MM-DD HH:mm'),
- }),
- }}
- />
+ <span>
+ {t('success.body', {
+ room: data.room.name,
+ created_at: formatDate(data.created_at, 'YYYY-MM-DD HH:mm'),
+ })}
+ </span>
<span>
{configData?.recording?.expiration_days && (
<>
diff --git a/src/frontend/src/locales/de/recording.json b/src/frontend/src/locales/de/recording.json
index 59fa8349..4c46cb9b 100644
--- a/src/frontend/src/locales/de/recording.json
+++ b/src/frontend/src/locales/de/recording.json
@@ -17,7 +17,7 @@
},
"success": {
"title": "Ihre Aufzeichnung ist bereit!",
- "body": "Aufzeichnung des Treffens <b>{{room}}</b> vom {{created_at}}.",
+ "body": "Aufzeichnung des Treffens {{room}} vom {{created_at}}.",
"expiration": "Achtung, diese Aufzeichnung wird nach {{expiration_days}} Tag(en) gelöscht.",
"button": "Herunterladen",
"warning": {
diff --git a/src/frontend/src/locales/en/recording.json b/src/frontend/src/locales/en/recording.json
index b70bf6ef..72cd8694 100644
--- a/src/frontend/src/locales/en/recording.json
+++ b/src/frontend/src/locales/en/recording.json
@@ -17,7 +17,7 @@
},
"success": {
"title": "Your recording is ready!",
- "body": "Recording of the meeting <b>{{room}}</b> from {{created_at}}.",
+ "body": "Recording of the meeting {{room}} from {{created_at}}.",
"expiration": "Attention, this recording will expire after {{expiration_days}} day(s).",
"button": "Download",
"warning": {
diff --git a/src/frontend/src/locales/fr/recording.json b/src/frontend/src/locales/fr/recording.json
index deaebad6..ff86ccd0 100644
--- a/src/frontend/src/locales/fr/recording.json
+++ b/src/frontend/src/locales/fr/recording.json
@@ -17,7 +17,7 @@
},
"success": {
"title": "Votre enregistrement est prêt !",
- "body": "Enregistrement de la réunion <b>{{room}}</b> du {{created_at}}.",
+ "body": "Enregistrement de la réunion {{room}} du {{created_at}}.",
"expiration": "Attention cet enregistrement expirera au bout de {{expiration_days}} jour(s).",
"button": "Télécharger",
"warning": {
diff --git a/src/frontend/src/locales/nl/recording.json b/src/frontend/src/locales/nl/recording.json
index a6f76e48..5c955391 100644
--- a/src/frontend/src/locales/nl/recording.json
+++ b/src/frontend/src/locales/nl/recording.json
@@ -17,7 +17,7 @@
},
"success": {
"title": "Je opname is klaar!",
- "body": "Opname van de vergadering <b>{{room}}</b> op {{created_at}}.",
+ "body": "Opname van de vergadering {{room}} op {{created_at}}.",
"expiration": "Let op, deze opname verloopt na {{expiration_days}} dag(en).",
"button": "Downloaden",
"warning": {