Skip to content

armgit / meet

Public Imported from GitHub
0

Open source video conferencing app powered by LiveKit. Built with Django and React.

🐛(frontend) fix nested React components in participant list

lebaudantoine9b6b32c3d561
diff --git a/src/frontend/src/features/rooms/livekit/components/controls/Participants/ParticipantsCollapsableList.tsx b/src/frontend/src/features/rooms/livekit/components/controls/Participants/ParticipantsCollapsableList.tsx
index 8f835737..a0c3d13a 100644
--- a/src/frontend/src/features/rooms/livekit/components/controls/Participants/ParticipantsCollapsableList.tsx
+++ b/src/frontend/src/features/rooms/livekit/components/controls/Participants/ParticipantsCollapsableList.tsx
@@ -1,4 +1,4 @@
-import { useState } from 'react'
+import { ReactNode, useState } from 'react'
import { css } from '@/styled-system/css'
import { ToggleButton } from 'react-aria-components'
import { HStack, styled, VStack } from '@/styled-system/jsx'
@@ -51,7 +51,7 @@ export type ParticipantsCollapsableListProps<T> = {
heading: string
participants: Array<T>
renderParticipant: (participant: T) => JSX.Element
- action?: () => JSX.Element
+ action?: ReactNode
}
export function ParticipantsCollapsableList<T>({
@@ -101,7 +101,7 @@ export function ParticipantsCollapsableList<T>({
</ToggleHeader>
{isOpen && (
<ListContainer>
- {action && action()}
+ {action}
{participants.map((participant) => renderParticipant(participant))}
</ListContainer>
)}
diff --git a/src/frontend/src/features/rooms/livekit/components/controls/Participants/ParticipantsList.tsx b/src/frontend/src/features/rooms/livekit/components/controls/Participants/ParticipantsList.tsx
index 340d9cb3..d9d727d7 100644
--- a/src/frontend/src/features/rooms/livekit/components/controls/Participants/ParticipantsList.tsx
+++ b/src/frontend/src/features/rooms/livekit/components/controls/Participants/ParticipantsList.tsx
@@ -75,7 +75,7 @@ export const ParticipantsList = () => {
onAction={handleParticipantEntry}
/>
)}
- action={() => <></>}
+ action={<></>}
/>
</Div>
)}
@@ -90,9 +90,9 @@ export const ParticipantsList = () => {
participant={participant}
/>
)}
- action={() => (
+ action={
<LowerAllHandsButton participants={raisedHandParticipants} />
- )}
+ }
/>
</Div>
)}
@@ -105,9 +105,7 @@ export const ParticipantsList = () => {
participant={participant}
/>
)}
- action={() => (
- <MuteEveryoneButton participants={sortedRemoteParticipants} />
- )}
+ action={<MuteEveryoneButton participants={sortedRemoteParticipants} />}
/>
</Div>
)