Open source video conferencing app powered by LiveKit. Built with Django and React.
♻️(frontend) refactor useParticipants to streamline updatesOnlyOn logic
lebaudantoine9d0767ccfebd
diff --git a/src/frontend/src/features/rooms/livekit/components/controls/Participants/ParticipantsList.tsx b/src/frontend/src/features/rooms/livekit/components/controls/Participants/ParticipantsList.tsxindex 6c79ee9c..63207799 100644--- a/src/frontend/src/features/rooms/livekit/components/controls/Participants/ParticipantsList.tsx+++ b/src/frontend/src/features/rooms/livekit/components/controls/Participants/ParticipantsList.tsx@@ -1,13 +1,14 @@import { css } from '@/styled-system/css'+import { allParticipantRoomEvents } from '@livekit/components-core'import { useParticipants } from '@livekit/components-react'import { Div, H } from '@/primitives'import { useTranslation } from 'react-i18next'-import { allParticipantRoomEvents } from '@/features/rooms/livekit/constants/events'import { ParticipantListItem } from '../../controls/Participants/ParticipantListItem'import { ParticipantsCollapsableList } from '../../controls/Participants/ParticipantsCollapsableList'import { HandRaisedListItem } from '../../controls/Participants/HandRaisedListItem'import { LowerAllHandsButton } from '../../controls/Participants/LowerAllHandsButton'+import { RoomEvent } from 'livekit-client'// TODO: Optimize rendering performance, especially for longer participant lists, even though they are generally short.export const ParticipantsList = () => {@@ -17,7 +18,10 @@ export const ParticipantsList = () => {// because the 'useLocalParticipant' hook does not update the participant's information when their// metadata/name changes. The LiveKit team has marked this as a TODO item in the code.const participants = useParticipants({- updateOnlyOn: allParticipantRoomEvents,+ updateOnlyOn: [+ RoomEvent.ParticipantNameChanged,+ ...allParticipantRoomEvents,+ ],})const sortedRemoteParticipants = participantsdiff --git a/src/frontend/src/features/rooms/livekit/constants/events.ts b/src/frontend/src/features/rooms/livekit/constants/events.tsdeleted file mode 100644index 1d1c6a87..00000000--- a/src/frontend/src/features/rooms/livekit/constants/events.ts+++ /dev/null@@ -1,33 +0,0 @@-import { RoomEvent } from 'livekit-client'--// Issue: 'allRemoteParticipantRoomEvents' is not exposed or importable. One event is missing-// to trigger the real-time update of participants when they change their name.-// This code is duplicated from LiveKit.-export const allRemoteParticipantRoomEvents = [- RoomEvent.ConnectionStateChanged,- RoomEvent.RoomMetadataChanged,-- RoomEvent.ActiveSpeakersChanged,- RoomEvent.ConnectionQualityChanged,-- RoomEvent.ParticipantConnected,- RoomEvent.ParticipantDisconnected,- RoomEvent.ParticipantPermissionsChanged,- RoomEvent.ParticipantMetadataChanged,- RoomEvent.ParticipantNameChanged, // This element is missing in LiveKit and causes problems-- RoomEvent.TrackMuted,- RoomEvent.TrackUnmuted,- RoomEvent.TrackPublished,- RoomEvent.TrackUnpublished,- RoomEvent.TrackStreamStateChanged,- RoomEvent.TrackSubscriptionFailed,- RoomEvent.TrackSubscriptionPermissionChanged,- RoomEvent.TrackSubscriptionStatusChanged,-]--export const allParticipantRoomEvents = [- ...allRemoteParticipantRoomEvents,- RoomEvent.LocalTrackPublished,- RoomEvent.LocalTrackUnpublished,-]