Skip to content

armgit / meet

Public Imported from GitHub
0

Open source video conferencing app powered by LiveKit. Built with Django and React.

⚡️(frontend) optimize device icon hook to share icons between components

lebaudantoinea5d8aae2934b
diff --git a/src/frontend/src/features/rooms/livekit/components/controls/Device/SelectDevice.tsx b/src/frontend/src/features/rooms/livekit/components/controls/Device/SelectDevice.tsx
index c1486e4d..1e16a35f 100644
--- a/src/frontend/src/features/rooms/livekit/components/controls/Device/SelectDevice.tsx
+++ b/src/frontend/src/features/rooms/livekit/components/controls/Device/SelectDevice.tsx
@@ -21,18 +21,17 @@ type SelectDeviceProps = {
}
type SelectDevicePermissionsProps<T> = SelectDeviceProps &
- Pick<SelectProps<T>, 'placement' | 'variant'>
+ Pick<SelectProps<T>, 'placement' | 'variant' | 'iconComponent'>
const SelectDevicePermissions = <T extends string | number>({
id,
kind,
onSubmit,
+ iconComponent,
...props
}: SelectDevicePermissionsProps<T>) => {
const { t } = useTranslation('rooms', { keyPrefix: 'selectDevice' })
- const deviceIcons = useDeviceIcons(kind)
-
const { devices, activeDeviceId, setActiveMediaDevice } =
useMediaDeviceSelect({ kind: kind, requestPermissions: true })
@@ -65,7 +64,7 @@ const SelectDevicePermissions = <T extends string | number>({
label=""
isDisabled={items.length === 0}
items={items}
- iconComponent={deviceIcons.select}
+ iconComponent={iconComponent}
placeholder={items.length === 0 ? t('loading') : t('select')}
selectedKey={id || activeDeviceId}
onSelectionChange={(key) => {
@@ -114,6 +113,7 @@ export const SelectDevice = ({
id={id}
onSubmit={onSubmit}
kind={kind}
+ iconComponent={deviceIcons.select}
{...contextProps}
/>
)