Open source video conferencing app powered by LiveKit. Built with Django and React.
♻️(backend) refactor analytics backend from Protocol to abstract class
lebaudantoineb00c4e5d6d65
diff --git a/CHANGELOG.md b/CHANGELOG.mdindex bafcbd2f..515e0237 100644--- a/CHANGELOG.md+++ b/CHANGELOG.md@@ -14,6 +14,7 @@ and this project adheres to- ⬆️(dependencies) update python dependencies- 💥(summary) remove v1 related code #1362- ✨(meet) use compatible with summary v2 #1362+- ♻️(backend) refactor analytics backend from Protocol to abstract class### Fixeddiff --git a/src/backend/core/analytics/base.py b/src/backend/core/analytics/base.pyindex 3c2b6b69..0f6ab388 100644--- a/src/backend/core/analytics/base.py+++ b/src/backend/core/analytics/base.py@@ -1,12 +1,13 @@"""Analytics backend protocol and default no-op implementation."""-from typing import Any, Protocol+from abc import ABC, abstractmethod+from typing import Anyfrom ..models import Userfrom .events import AnalyticsEvent-class AnalyticsBackend(Protocol):+class AnalyticsBackend(ABC):"""Interface every analytics backend must implement.@@ -17,11 +18,11 @@ class AnalyticsBackend(Protocol):ANALYTICS_BACKEND_SETTINGS = {"api_key": "...", "host": "..."}"""- def __init__(self, **kwargs: Any) -> None: ...-+ @abstractmethoddef identify(self, user: User, properties: dict[str, Any] | None = None) -> None:"""Associate traits (email, name, ...) with an identified user."""+ @abstractmethoddef capture(self,user: User,@@ -30,16 +31,14 @@ class AnalyticsBackend(Protocol):) -> None:"""Record an event performed by an identified user."""+ @abstractmethoddef shutdown(self) -> None:"""Flush pending events. Called on process exit."""-class NoOpAnalytics:+class NoOpAnalytics(AnalyticsBackend):"""Default backend: silently discards everything."""- def __init__(self, **kwargs: Any) -> None:- """No-op: accepts and ignores any backend settings kwargs."""-def identify(self, user: User, properties=None) -> None:"""No-op: discards identify calls."""diff --git a/src/backend/core/analytics/posthog.py b/src/backend/core/analytics/posthog.pyindex 1fef96b9..20b44ee8 100644--- a/src/backend/core/analytics/posthog.py+++ b/src/backend/core/analytics/posthog.py@@ -6,12 +6,13 @@ from typing import Anyfrom posthog import Posthogfrom ..models import User+from . import AnalyticsBackendfrom .events import AnalyticsEventlogger = logging.getLogger(__name__)-class PostHogAnalytics:+class PostHogAnalytics(AnalyticsBackend):"""Send events to PostHog, keyed on the user's primary key (UUID)."""def __init__(