Open source video conferencing app powered by LiveKit. Built with Django and React.
🔒️(backend) avoid serializing rooms's pin code when restricted
lebaudantoineb0e27b38e2f3
diff --git a/src/backend/core/api/serializers.py b/src/backend/core/api/serializers.pyindex 3b0743e4..b1fd406b 100644--- a/src/backend/core/api/serializers.py+++ b/src/backend/core/api/serializers.py@@ -159,6 +159,8 @@ class RoomSerializer(serializers.ModelSerializer):configuration=configuration,is_admin_or_owner=is_admin_or_owner,)+ else:+ del output["pin_code"]output["is_administrable"] = is_admin_or_ownerdiff --git a/src/backend/core/tests/rooms/test_api_rooms_retrieve.py b/src/backend/core/tests/rooms/test_api_rooms_retrieve.pyindex eb93ccf2..f317ddd8 100644--- a/src/backend/core/tests/rooms/test_api_rooms_retrieve.py+++ b/src/backend/core/tests/rooms/test_api_rooms_retrieve.py@@ -32,7 +32,6 @@ def test_api_rooms_retrieve_anonymous_private_pk():"id": str(room.id),"is_administrable": False,"name": room.name,- "pin_code": room.pin_code,"slug": room.slug,}@@ -52,7 +51,6 @@ def test_api_rooms_retrieve_anonymous_trusted_pk():"id": str(room.id),"is_administrable": False,"name": room.name,- "pin_code": room.pin_code,"slug": room.slug,}@@ -71,7 +69,6 @@ def test_api_rooms_retrieve_anonymous_private_pk_no_dashes():"id": str(room.id),"is_administrable": False,"name": room.name,- "pin_code": room.pin_code,"slug": room.slug,}@@ -88,7 +85,6 @@ def test_api_rooms_retrieve_anonymous_private_slug():"id": str(room.id),"is_administrable": False,"name": room.name,- "pin_code": room.pin_code,"slug": room.slug,}@@ -105,7 +101,6 @@ def test_api_rooms_retrieve_anonymous_private_slug_not_normalized():"id": str(room.id),"is_administrable": False,"name": room.name,- "pin_code": room.pin_code,"slug": room.slug,}@@ -347,7 +342,6 @@ def test_api_rooms_retrieve_authenticated():"id": str(room.id),"is_administrable": False,"name": room.name,- "pin_code": room.pin_code,"slug": room.slug,}