Skip to content

armgit / meet

Public Imported from GitHub
0

Open source video conferencing app powered by LiveKit. Built with Django and React.

♻️(frontend) extract feature flag into a dedicated enum

lebaudantoineba9d22f6c8e1
diff --git a/src/frontend/src/features/analytics/enums.ts b/src/frontend/src/features/analytics/enums.ts
new file mode 100644
index 00000000..ba8c7474
--- /dev/null
+++ b/src/frontend/src/features/analytics/enums.ts
@@ -0,0 +1,4 @@
+export enum FeatureFlags {
+ Transcript = 'transcription-summary',
+ faceLandmarks = 'face-landmarks',
+}
diff --git a/src/frontend/src/features/recording/hooks/useHasRecordingAccess.ts b/src/frontend/src/features/recording/hooks/useHasRecordingAccess.ts
index 18f96747..5fc7b13f 100644
--- a/src/frontend/src/features/recording/hooks/useHasRecordingAccess.ts
+++ b/src/frontend/src/features/recording/hooks/useHasRecordingAccess.ts
@@ -3,10 +3,11 @@ import { useIsAnalyticsEnabled } from '@/features/analytics/hooks/useIsAnalytics
import { RecordingMode } from '../types'
import { useIsRecordingModeEnabled } from './useIsRecordingModeEnabled'
import { useIsAdminOrOwner } from '@/features/rooms/livekit/hooks/useIsAdminOrOwner'
+import { FeatureFlags } from '@/features/analytics/enums'
export const useHasRecordingAccess = (
mode: RecordingMode,
- featureFlag: string
+ featureFlag: FeatureFlags
) => {
const featureEnabled = useFeatureFlagEnabled(featureFlag)
const isAnalyticsEnabled = useIsAnalyticsEnabled()
diff --git a/src/frontend/src/features/rooms/livekit/components/Transcript.tsx b/src/frontend/src/features/rooms/livekit/components/Transcript.tsx
index f98a67ba..c7039d75 100644
--- a/src/frontend/src/features/rooms/livekit/components/Transcript.tsx
+++ b/src/frontend/src/features/rooms/livekit/components/Transcript.tsx
@@ -23,6 +23,7 @@ import {
BETA_USERS_FORM_URL,
CRISP_HELP_ARTICLE_TRANSCRIPT,
} from '@/utils/constants'
+import { FeatureFlags } from '@/features/analytics/enums'
export const Transcript = () => {
const [isLoading, setIsLoading] = useState(false)
@@ -30,7 +31,7 @@ export const Transcript = () => {
const hasTranscriptAccess = useHasRecordingAccess(
RecordingMode.Transcript,
- 'transcription-summary'
+ FeatureFlags.Transcript
)
const roomId = useRoomId()
diff --git a/src/frontend/src/features/rooms/livekit/hooks/useHasFaceLandmarksAccess.ts b/src/frontend/src/features/rooms/livekit/hooks/useHasFaceLandmarksAccess.ts
index 6603f30e..32c8fb35 100644
--- a/src/frontend/src/features/rooms/livekit/hooks/useHasFaceLandmarksAccess.ts
+++ b/src/frontend/src/features/rooms/livekit/hooks/useHasFaceLandmarksAccess.ts
@@ -1,8 +1,9 @@
import { useFeatureFlagEnabled } from 'posthog-js/react'
import { useIsAnalyticsEnabled } from '@/features/analytics/hooks/useIsAnalyticsEnabled'
+import { FeatureFlags } from '@/features/analytics/enums'
export const useHasFaceLandmarksAccess = () => {
- const featureEnabled = useFeatureFlagEnabled('face-landmarks')
+ const featureEnabled = useFeatureFlagEnabled(FeatureFlags.faceLandmarks)
const isAnalyticsEnabled = useIsAnalyticsEnabled()
return featureEnabled || !isAnalyticsEnabled