Skip to content

armgit / meet

Public Imported from GitHub
0

Open source video conferencing app powered by LiveKit. Built with Django and React.

πŸ”’οΈ(backend) refuse unregistered rooms whose slug is a UUID

briquetc4fbfdd302bb
diff --git a/CHANGELOG.md b/CHANGELOG.md
index a0b21f4e..712c418c 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -32,6 +32,7 @@ and this project adheres to
- πŸ›(frontend) show the transcript mic hint when every mic is muted
- πŸ›(frontend) show join errors instead of silently waiting in the lobby
- πŸ›(frontend) send users who cannot enter directly back to the lobby
+- πŸ”’οΈ(backend) refuse unregistered rooms whose slug is a UUID
## [1.37.0] - 2026-11-01
diff --git a/UPGRADE.md b/UPGRADE.md
index f0193c9c..f350a56c 100644
--- a/UPGRADE.md
+++ b/UPGRADE.md
@@ -35,6 +35,16 @@ participant identity each time.
- Unregistered rooms are always entered directly: joining one always returns a `livekit` block.
- Unregistered rooms are no longer described with an `is_administrable` field,
+### Unregistered rooms can no longer be named after a UUID
+
+When `ALLOW_UNREGISTERED_ROOMS` is enabled, reading or joining a room whose identifier normalizes to an empty slug or to
+a UUID now returns a 404 instead of describing or letting callers join the unregistered room.
+
+This closes a lobby bypass since a registered LiveKit room is named after its room id. An identifier crafted to not
+parse as a UUID, yet to normalize to an existing room's id, matched no registered room and was treated as an
+unregistered one. The token minted for that unregistered room was valid for the registered room: anyone could join a
+trusted or restricted room without being admitted through the lobby.
+
## v1.37.0
### Crisp support chat replaced by the La Suite support form
diff --git a/src/backend/core/api/viewsets.py b/src/backend/core/api/viewsets.py
index 5641417f..1fbd30d9 100644
--- a/src/backend/core/api/viewsets.py
+++ b/src/backend/core/api/viewsets.py
@@ -315,7 +315,7 @@ class RoomViewSet( # pylint: disable=too-many-public-methods
return self.get_object(), None
except Http404:
slug = slugify(self.kwargs["pk"])
- if not settings.ALLOW_UNREGISTERED_ROOMS or not slug:
+ if not settings.ALLOW_UNREGISTERED_ROOMS or not slug or utils.is_uuid(slug):
raise
return None, slug
diff --git a/src/backend/core/tests/rooms/test_api_rooms_join.py b/src/backend/core/tests/rooms/test_api_rooms_join.py
index 13b6bcac..4d204bea 100644
--- a/src/backend/core/tests/rooms/test_api_rooms_join.py
+++ b/src/backend/core/tests/rooms/test_api_rooms_join.py
@@ -312,6 +312,30 @@ def test_api_rooms_join_unregistered_empty_slug(mock_token, lookup, settings):
mock_token.assert_not_called()
[email protected]("template", ["{}!", "_{}", "{}~", "{}!!"])
+ "access_level", [RoomAccessLevel.TRUSTED, RoomAccessLevel.RESTRICTED]
+)
[email protected]("core.utils.generate_token", return_value=livekit_token)
+def test_api_rooms_join_unregistered_uuid_slug(
+ mock_token, access_level, template, settings
+):
+ """
+ Joining an unregistered room whose slug is a UUID once normalized should
+ return a 404 rather than credentials for the registered room with that id.
+ """
+ settings.ALLOW_UNREGISTERED_ROOMS = True
+ room = RoomFactory(access_level=access_level)
+
+ response = APIClient().post(
+ join_url(template.format(str(room.id).upper())), {}, format="json"
+ )
+
+ assert response.status_code == 404
+ assert response.json() == {"detail": "No Room matches the given query."}
+ mock_token.assert_not_called()
+
+
@pytest.mark.parametrize("allow_unregistered_rooms", [True, False])
@pytest.mark.parametrize("lookup", ["id", "slug"])
@mock.patch("core.utils.generate_token", return_value=livekit_token)
diff --git a/src/backend/core/tests/rooms/test_api_rooms_retrieve.py b/src/backend/core/tests/rooms/test_api_rooms_retrieve.py
index 0ac7957d..edcb4381 100644
--- a/src/backend/core/tests/rooms/test_api_rooms_retrieve.py
+++ b/src/backend/core/tests/rooms/test_api_rooms_retrieve.py
@@ -174,6 +174,22 @@ def test_api_rooms_retrieve_anonymous_unregistered_empty_slug(lookup):
assert response.json() == {"detail": "No Room matches the given query."}
+@override_settings(ALLOW_UNREGISTERED_ROOMS=True)
[email protected]("template", ["{}!", "_{}", "{}~"])
+def test_api_rooms_retrieve_anonymous_unregistered_uuid_slug(template):
+ """
+ Retrieving an unregistered room whose slug is a UUID once normalized should
+ return a 404.
+ """
+ room = RoomFactory(access_level=RoomAccessLevel.RESTRICTED)
+
+ client = APIClient()
+ response = client.get(f"/api/v1.0/rooms/{template.format(room.id)}/")
+
+ assert response.status_code == 404
+ assert response.json() == {"detail": "No Room matches the given query."}
+
+
@pytest.mark.parametrize("allow_unregistered_rooms", [True, False])
@pytest.mark.parametrize("lookup", ["id", "slug"])
@mock.patch("core.utils.generate_token", return_value="foo")
diff --git a/src/backend/core/tests/test_utils_is_uuid.py b/src/backend/core/tests/test_utils_is_uuid.py
new file mode 100644
index 00000000..96d21949
--- /dev/null
+++ b/src/backend/core/tests/test_utils_is_uuid.py
@@ -0,0 +1,38 @@
+"""
+Test utils.is_uuid
+"""
+
+import pytest
+from faker import Faker
+
+from core import utils
+
+fake = Faker()
+
+UUID = fake.uuid4()
+
+
+ "value",
+ [
+ UUID,
+ UUID.upper(),
+ UUID.replace("-", ""),
+ f"{{{UUID}}}",
+ f"urn:uuid:{UUID}",
+ ],
+ ids=["canonical", "uppercase", "hex", "braces", "urn"],
+)
+def test_utils_is_uuid_true(value):
+ """Strings that parse as a UUID should be recognized."""
+ assert utils.is_uuid(value) is True
+
+
+ "value",
+ ["", "my-room", "abc-defg-hij", f"{UUID}!", f"_{UUID}", UUID[:-1]],
+ ids=["empty", "slug", "room-slug", "suffix", "prefix", "truncated"],
+)
+def test_utils_is_uuid_false(value):
+ """Strings that do not parse as a UUID should not be recognized."""
+ assert utils.is_uuid(value) is False
diff --git a/src/backend/core/utils.py b/src/backend/core/utils.py
index 3ee2f75e..dbb5b161 100644
--- a/src/backend/core/utils.py
+++ b/src/backend/core/utils.py
@@ -16,7 +16,7 @@ import string
from datetime import timedelta
from functools import lru_cache
from typing import List, Optional
-from uuid import uuid4
+from uuid import UUID, uuid4
from django.conf import settings
from django.core.files.storage import default_storage
@@ -336,6 +336,15 @@ def generate_room_slug():
return "-".join(parts)
+def is_uuid(value: str) -> bool:
+ """Tell whether a value parses as a UUID."""
+ try:
+ UUID(value)
+ except ValueError:
+ return False
+ return True
+
+
def detect_mimetype(file_buffer: bytes, filename: str | None = None) -> str:
"""
Detect MIME type using multiple methods for better accuracy.