Skip to content

armgit / meet

Public Imported from GitHub
0

Open source video conferencing app powered by LiveKit. Built with Django and React.

✨(backend) serialize room pin code for frontend access

lebaudantoined3178eff5dad
diff --git a/src/backend/core/api/serializers.py b/src/backend/core/api/serializers.py
index c5afa243..c35b5165 100644
--- a/src/backend/core/api/serializers.py
+++ b/src/backend/core/api/serializers.py
@@ -107,8 +107,8 @@ class RoomSerializer(serializers.ModelSerializer):
class Meta:
model = models.Room
- fields = ["id", "name", "slug", "configuration", "access_level"]
- read_only_fields = ["id", "slug"]
+ fields = ["id", "name", "slug", "configuration", "access_level", "pin_code"]
+ read_only_fields = ["id", "slug", "pin_code"]
def to_representation(self, instance):
"""
diff --git a/src/backend/core/tests/rooms/test_api_rooms_retrieve.py b/src/backend/core/tests/rooms/test_api_rooms_retrieve.py
index 1788f641..1ebbaf50 100644
--- a/src/backend/core/tests/rooms/test_api_rooms_retrieve.py
+++ b/src/backend/core/tests/rooms/test_api_rooms_retrieve.py
@@ -32,6 +32,7 @@ def test_api_rooms_retrieve_anonymous_private_pk():
"id": str(room.id),
"is_administrable": False,
"name": room.name,
+ "pin_code": room.pin_code,
"slug": room.slug,
}
@@ -51,6 +52,7 @@ def test_api_rooms_retrieve_anonymous_trusted_pk():
"id": str(room.id),
"is_administrable": False,
"name": room.name,
+ "pin_code": room.pin_code,
"slug": room.slug,
}
@@ -69,6 +71,7 @@ def test_api_rooms_retrieve_anonymous_private_pk_no_dashes():
"id": str(room.id),
"is_administrable": False,
"name": room.name,
+ "pin_code": room.pin_code,
"slug": room.slug,
}
@@ -85,6 +88,7 @@ def test_api_rooms_retrieve_anonymous_private_slug():
"id": str(room.id),
"is_administrable": False,
"name": room.name,
+ "pin_code": room.pin_code,
"slug": room.slug,
}
@@ -101,6 +105,7 @@ def test_api_rooms_retrieve_anonymous_private_slug_not_normalized():
"id": str(room.id),
"is_administrable": False,
"name": room.name,
+ "pin_code": room.pin_code,
"slug": room.slug,
}
@@ -209,6 +214,7 @@ def test_api_rooms_retrieve_anonymous_public(mock_token):
"token": "foo",
},
"name": room.name,
+ "pin_code": room.pin_code,
"slug": room.slug,
}
@@ -251,6 +257,7 @@ def test_api_rooms_retrieve_authenticated_public(mock_token):
"token": "foo",
},
"name": room.name,
+ "pin_code": room.pin_code,
"slug": room.slug,
}
@@ -295,6 +302,7 @@ def test_api_rooms_retrieve_authenticated_trusted(mock_token):
"token": "foo",
},
"name": room.name,
+ "pin_code": room.pin_code,
"slug": room.slug,
}
@@ -324,6 +332,7 @@ def test_api_rooms_retrieve_authenticated():
"id": str(room.id),
"is_administrable": False,
"name": room.name,
+ "pin_code": room.pin_code,
"slug": room.slug,
}
@@ -372,6 +381,7 @@ def test_api_rooms_retrieve_members(mock_token, django_assert_num_queries, setti
"token": "foo",
},
"name": room.name,
+ "pin_code": room.pin_code,
"slug": room.slug,
}
@@ -458,6 +468,7 @@ def test_api_rooms_retrieve_administrators(
"token": "foo",
},
"name": room.name,
+ "pin_code": room.pin_code,
"slug": room.slug,
}
diff --git a/src/frontend/src/features/rooms/api/ApiRoom.ts b/src/frontend/src/features/rooms/api/ApiRoom.ts
index 58d22b1e..554c47bd 100644
--- a/src/frontend/src/features/rooms/api/ApiRoom.ts
+++ b/src/frontend/src/features/rooms/api/ApiRoom.ts
@@ -14,6 +14,7 @@ export type ApiRoom = {
id: string
name: string
slug: string
+ pin_code: string
is_administrable: boolean
access_level: ApiAccessLevel
livekit?: ApiLiveKit