Open source video conferencing app powered by LiveKit. Built with Django and React.
♻️(backend) replace hardcoded file extensions with Python enum
lebaudantoined74dd967af15
diff --git a/src/backend/core/recording/enums.py b/src/backend/core/recording/enums.pynew file mode 100644index 00000000..7bc2c1f4--- /dev/null+++ b/src/backend/core/recording/enums.py@@ -0,0 +1,10 @@+"""Enums related to recordings."""++from enum import Enum+++class FileExtension(Enum):+ """Enum for file extensions used in recordings."""++ OGG = "ogg"+ MP4 = "mp4"diff --git a/src/backend/core/recording/worker/services.py b/src/backend/core/recording/worker/services.pyindex 2fb229e5..548b4d21 100644--- a/src/backend/core/recording/worker/services.py+++ b/src/backend/core/recording/worker/services.py@@ -7,6 +7,7 @@ from asgiref.sync import async_to_syncfrom livekit import api as livekit_apifrom livekit.api.egress_service import EgressService+from ..enums import FileExtensionfrom .exceptions import WorkerConnectionError, WorkerResponseErrorfrom .factories import WorkerServiceConfig@@ -89,7 +90,9 @@ class VideoCompositeEgressService(BaseEgressService):# Save room's recording as a mp4 video file.file_type = livekit_api.EncodedFileType.MP4- filepath = self._get_filepath(filename=recording_id, extension="mp4")+ filepath = self._get_filepath(+ filename=recording_id, extension=FileExtension.MP4.value+ )file_output = livekit_api.EncodedFileOutput(file_type=file_type,@@ -120,7 +123,9 @@ class AudioCompositeEgressService(BaseEgressService):# Save room's recording as an ogg audio file.file_type = livekit_api.EncodedFileType.OGG- filepath = self._get_filepath(filename=recording_id, extension="ogg")+ filepath = self._get_filepath(+ filename=recording_id, extension=FileExtension.OGG.value+ )file_output = livekit_api.EncodedFileOutput(file_type=file_type,